From: "Marcin Juszkiewicz" <marcin.juszkiewicz@linaro.org>
To: devel@edk2.groups.io
Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>,
Leif Lindholm <quic_llindhol@quicinc.com>,
Rebecca Cran <rebecca@bsdio.com>,
Sami Mujawar <sami.mujawar@arm.com>,
Marcin Juszkiewicz <marcin.juszkiewicz@linaro.org>
Subject: [PATCH 4/7] ArmPkg: skip empty system registers in ArmCpuInfo
Date: Thu, 4 May 2023 15:24:37 +0100 [thread overview]
Message-ID: <20230504142440.827531-5-marcin.juszkiewicz@linaro.org> (raw)
In-Reply-To: <20230504142440.827531-1-marcin.juszkiewicz@linaro.org>
If system register is empty (value == 0) then do not display information
from it.
Signed-off-by: Marcin Juszkiewicz <marcin.juszkiewicz@linaro.org>
---
ArmPkg/Application/ArmCpuInfo/ArmCpuInfo.c | 35 +++++++++++++++-------
1 file changed, 25 insertions(+), 10 deletions(-)
diff --git a/ArmPkg/Application/ArmCpuInfo/ArmCpuInfo.c b/ArmPkg/Application/ArmCpuInfo/ArmCpuInfo.c
index 982714ef6ca0..9d0d164774ff 100644
--- a/ArmPkg/Application/ArmCpuInfo/ArmCpuInfo.c
+++ b/ArmPkg/Application/ArmCpuInfo/ArmCpuInfo.c
@@ -2407,23 +2407,38 @@ UefiMain (
HandleAa64Mmfr0 (Aa64Mmfr0);
PrintSpacer ();
- HandleAa64Mmfr1 (Aa64Mmfr1, Aa64Pfr0);
- PrintSpacer ();
- HandleAa64Mmfr2 (Aa64Mmfr2);
- PrintSpacer ();
+ if (Aa64Mmfr1) {
+ HandleAa64Mmfr1 (Aa64Mmfr1, Aa64Pfr0);
+ PrintSpacer ();
+ }
+
+ if (Aa64Mmfr2) {
+ HandleAa64Mmfr2 (Aa64Mmfr2);
+ PrintSpacer ();
+ }
+
HandleAa64Pfr0 (Aa64Pfr0, Aa64Pfr1);
PrintSpacer ();
- HandleAa64Pfr1 (Aa64Pfr1);
- PrintSpacer ();
+ if (Aa64Pfr1) {
+ HandleAa64Pfr1 (Aa64Pfr1);
+ PrintSpacer ();
+ }
+
HandleAa64Isar0 (Aa64Isar0);
PrintSpacer ();
- HandleAa64Isar1 (Aa64Isar1);
- PrintSpacer ();
- HandleAa64Isar2 (Aa64Isar2);
- PrintSpacer ();
+ if (Aa64Isar1) {
+ HandleAa64Isar1 (Aa64Isar1);
+ PrintSpacer ();
+ }
+
+ if (Aa64Isar2) {
+ HandleAa64Isar2 (Aa64Isar2);
+ PrintSpacer ();
+ }
+
HandleAa64Dfr0 (Aa64Dfr0);
return EFI_SUCCESS;
--
2.40.1
next prev parent reply other threads:[~2023-05-04 14:24 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-04 14:24 [PATCH 0/7] ArmCpuInfo improvements Marcin Juszkiewicz
2023-05-04 14:24 ` [PATCH 1/7] ArmPkg: fix reading of first nibbles in ArmCpuInfo Marcin Juszkiewicz
2023-05-04 14:24 ` [PATCH 2/7] ArmPkg: shorten register field " Marcin Juszkiewicz
2023-05-04 14:24 ` [PATCH 3/7] ArmPkg: add functions to read SVE/SME info Marcin Juszkiewicz
2023-05-04 14:24 ` Marcin Juszkiewicz [this message]
2023-05-04 14:24 ` [PATCH 5/7] ArmPkg: format output in one place in ArmCpuInfo Marcin Juszkiewicz
2023-05-04 14:24 ` [PATCH 6/7] ArmPkg: handle SVE/SME " Marcin Juszkiewicz
2023-05-04 14:24 ` [PATCH 7/7] ArmPkg: cleaning output of ArmCpuInfo Marcin Juszkiewicz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230504142440.827531-5-marcin.juszkiewicz@linaro.org \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox