public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: Minh Nguyen <minhnguyen1@os.amperecomputing.com>
To: devel@edk2.groups.io
Cc: patches@amperecomputing.com, abner.chang@amd.com,
	nicklew@nvidia.com, igork@ami.com, nhi@os.amperecomputing.com,
	tinhnguyen@os.amperecomputing.com,
	Vu Nguyen <vunguyen@os.amperecomputing.com>,
	Minh Nguyen <minhnguyen1@os.amperecomputing.com>,
	Nick Ramirez <nramirez@nvidia.com>
Subject: [PATCH V3 1/5] RedfishPkg: Correct variable type to prevent memory corruption
Date: Fri,  5 May 2023 10:58:20 +0700	[thread overview]
Message-ID: <20230505035824.1466954-2-minhnguyen1@os.amperecomputing.com> (raw)
In-Reply-To: <20230505035824.1466954-1-minhnguyen1@os.amperecomputing.com>

From: Vu Nguyen <vunguyen@os.amperecomputing.com>

Id will be casted by CoreOpenProtocol, declare this variable with a
wrong type might result in the corruption of other local variables.

Signed-off-by: Minh Nguyen <minhnguyen1@os.amperecomputing.com>
Cc: Abner Chang <abner.chang@amd.com>
Cc: Igor Kulchytskyy <igork@ami.com>
Cc: Nick Ramirez <nramirez@nvidia.com>
Reviewed-by: Nickle Wang <nicklew@nvidia.com>
---
 RedfishPkg/RedfishRestExDxe/RedfishRestExDriver.h | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/RedfishPkg/RedfishRestExDxe/RedfishRestExDriver.h b/RedfishPkg/RedfishRestExDxe/RedfishRestExDriver.h
index 4a9e9f7b81a4..6b94e5814c43 100644
--- a/RedfishPkg/RedfishRestExDxe/RedfishRestExDriver.h
+++ b/RedfishPkg/RedfishRestExDxe/RedfishRestExDriver.h
@@ -3,6 +3,7 @@
 
   Copyright (c) 2019, Intel Corporation. All rights reserved.<BR>
   (C) Copyright 2020 Hewlett Packard Enterprise Development LP<BR>
+  Copyright (c) 2023, Ampere Computing LLC. All rights reserved.<BR>
 
   SPDX-License-Identifier: BSD-2-Clause-Patent
 
@@ -84,7 +85,7 @@ struct _RESTEX_SERVICE {
   //
   EFI_HANDLE                      HttpChildHandle;
 
-  UINT32                          Id;
+  UINT32                          *Id;
 
   EFI_REST_EX_SERVICE_INFO        RestExServiceInfo;
 };
-- 
2.39.0


  reply	other threads:[~2023-05-05  3:58 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-05-05  3:58 [PATCH V3 0/5] Adding necessary changes for RedfishPkg Minh Nguyen
2023-05-05  3:58 ` Minh Nguyen [this message]
2023-05-05  3:58 ` [PATCH V3 2/5] RedfishPkg: Fix condition checking of error status Minh Nguyen
2023-05-05  3:58 ` [PATCH V3 3/5] RedfishPkg: Create RestEx child on selected interface Minh Nguyen
2023-05-05  3:58 ` [PATCH V3 4/5] RedfishPkg: Add missing newline character Minh Nguyen
2023-05-05  3:58 ` [PATCH V3 5/5] RedfishPkg: Fix compile issue on Linux Minh Nguyen
2023-05-05 22:57   ` [edk2-devel] " Pedro Falcato
2023-05-05 23:32     ` Michael D Kinney
2023-05-07  5:39     ` Minh Nguyen
2023-05-07  6:22       ` Minh Nguyen
2023-05-05  5:03 ` [PATCH V3 0/5] Adding necessary changes for RedfishPkg Chang, Abner
2023-05-05  5:35   ` Minh Nguyen
2023-05-05  5:45     ` Chang, Abner
2023-05-05  6:01       ` Minh Nguyen
2023-05-05  6:50         ` Minh Nguyen
2023-05-08 13:45           ` Chang, Abner
2023-05-09  0:46             ` Minh Nguyen
  -- strict thread matches above, loose matches on Subject: below --
2023-05-05  6:45 minhnampere
2023-05-05  6:45 ` [PATCH V3 1/5] RedfishPkg: Correct variable type to prevent memory corruption minhnampere

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230505035824.1466954-2-minhnguyen1@os.amperecomputing.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox