public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: minhnampere <minhnguyen1@os.amperecomputing.com>
To: devel@edk2.groups.io
Cc: patches@amperecomputing.com, abner.chang@amd.com,
	nicklew@nvidia.com, igork@ami.com, nhi@os.amperecomputing.com,
	tinhnguyen@os.amperecomputing.com,
	Vu Nguyen <vunguyen@os.amperecomputing.com>,
	Minh Nguyen <minhnguyen1@os.amperecomputing.com>,
	Nick Ramirez <nramirez@nvidia.com>
Subject: [PATCH V3 2/5] RedfishPkg: Fix condition checking of error status
Date: Fri,  5 May 2023 13:45:57 +0700	[thread overview]
Message-ID: <20230505064600.1478461-3-minhnguyen1@os.amperecomputing.com> (raw)
In-Reply-To: <20230505064600.1478461-1-minhnguyen1@os.amperecomputing.com>

From: Vu Nguyen <vunguyen@os.amperecomputing.com>

This change fixes condition checking of error status, the condition
should be compared with TRUE status to be identical with an error message.

Signed-off-by: Minh Nguyen <minhnguyen1@os.amperecomputing.com>
Cc: Abner Chang <abner.chang@amd.com>
Cc: Igor Kulchytskyy <igork@ami.com>
Cc: Nick Ramirez <nramirez@nvidia.com>
Reviewed-by: Nickle Wang <nicklew@nvidia.com>
---
 RedfishPkg/RedfishDiscoverDxe/RedfishDiscoverDxe.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/RedfishPkg/RedfishDiscoverDxe/RedfishDiscoverDxe.c b/RedfishPkg/RedfishDiscoverDxe/RedfishDiscoverDxe.c
index 0900a2479e7b..14702748813b 100644
--- a/RedfishPkg/RedfishDiscoverDxe/RedfishDiscoverDxe.c
+++ b/RedfishPkg/RedfishDiscoverDxe/RedfishDiscoverDxe.c
@@ -5,6 +5,7 @@
   (C) Copyright 2021 Hewlett Packard Enterprise Development LP<BR>
   Copyright (c) 2022, AMD Incorporated. All rights reserved.
   Copyright (c) 2023, NVIDIA CORPORATION & AFFILIATES. All rights reserved.
+  Copyright (c) 2023, Ampere Computing LLC. All rights reserved.<BR>
 
   SPDX-License-Identifier: BSD-2-Clause-Patent
 
@@ -926,7 +927,7 @@ AddAndSignalNewRedfishService (
     }
 
     Status = gBS->SignalEvent (Instance->DiscoverToken->Event);
-    if (!EFI_ERROR (Status)) {
+    if (EFI_ERROR (Status)) {
       DEBUG ((DEBUG_ERROR, "%a:No event to signal!\n", __func__));
     }
   }
-- 
2.39.0


  parent reply	other threads:[~2023-05-05  6:46 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-05-05  6:45 [PATCH V3 0/5] Adding necessary changes for RedfishPkg minhnampere
2023-05-05  6:45 ` [PATCH V3 1/5] RedfishPkg: Correct variable type to prevent memory corruption minhnampere
2023-05-05  6:45 ` minhnampere [this message]
2023-05-05  6:45 ` [PATCH V3 3/5] RedfishPkg: Create RestEx child on selected interface minhnampere
2023-05-05  7:36   ` Chang, Abner
2023-05-05  6:45 ` [PATCH V3 4/5] RedfishPkg: Add missing newline character minhnampere
2023-05-05  6:46 ` [PATCH V3 5/5] RedfishPkg: Fix compile issue on Linux minhnampere
2023-05-05  7:38 ` [PATCH V3 0/5] Adding necessary changes for RedfishPkg Chang, Abner
2023-05-05  7:47   ` Minh Nguyen
  -- strict thread matches above, loose matches on Subject: below --
2023-05-05  3:58 Minh Nguyen
2023-05-05  3:58 ` [PATCH V3 2/5] RedfishPkg: Fix condition checking of error status Minh Nguyen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230505064600.1478461-3-minhnguyen1@os.amperecomputing.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox