From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (NAM12-BN8-obe.outbound.protection.outlook.com [40.107.237.135]) by mx.groups.io with SMTP id smtpd.web11.21031.1683269195013177370 for ; Thu, 04 May 2023 23:46:35 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="body hash did not verify" header.i=@os.amperecomputing.com header.s=selector2 header.b=qWfH7wsn; spf=pass (domain: os.amperecomputing.com, ip: 40.107.237.135, mailfrom: minhnguyen1@os.amperecomputing.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Kn9PTwrE4s10RTvLdhrVYKusWP8TvckOIFa+C1lKlofwqMDJA5GgNSa6laDJTPNPCYudPX4D0m4JjcTDsJtx8oJFMMIzaXxsHBeajorhgJmBpVpVEBFXER/nHs8pOa1ZC8O8NISVOfYA0zWr2Wq+xysAtt/Rf448upBWG0iU1rnLCigVjzyaGRyISexPidXQW5TEecrCFQMxSz2YJqHkQc5ZfIOlhCSJF5hXBeO5peWxAyYOjAzZ1Eu2VLgOPscQycAOKLJSAOle0Z3zw5NGcADBJiMa6+0vSR4hPMQu9P6wBxy5ZT7d5ONmcDJQKp4p3olMGeUTXHIJMaeM7AGdJA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ibXkIUL1HAHNsSK5dzTFUmCmEAR2DExKnnrxmlpYwe0=; b=M3xYolzgNzMpml5Pzkh7eUPk2cF++5VRBpalKxdwYf2frIi1hKFMwDVdoO/Z2TgFNsUKRjtrTUZ5Doah0EC2Y+J79hL8l5eXAn7iFurPkBqh+fQZXQPca3hBdA5WfGR6NIFYJFMjq/ny5xkSOCyGp9TseUN/eOq2odZl+dvdSSyyRhWDyHn5X1XR7ijgrAohMvNOwWEdQLm9O1fbZdNKUT4YnBsQORbkVReTi7uT/Yl4mNkXwwZ/jYdZ1fEdb/9Jy14KBrahYG/8XPCX1c/5zgFudGyBWuDQStWiENY+F+//capkESUvLpcULm5AgAkoaECYQ3IMvPmFfsx1IVfg5Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=os.amperecomputing.com; dmarc=pass action=none header.from=os.amperecomputing.com; dkim=pass header.d=os.amperecomputing.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=os.amperecomputing.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ibXkIUL1HAHNsSK5dzTFUmCmEAR2DExKnnrxmlpYwe0=; b=qWfH7wsnd1QYStLZGsnfjW+dNH8qJwdMylE5TBZG0Hiq4LDtySVeb5kNu2lS8a3Ytm4vDxrsW3pXxaT94XyU6nXeFz2zAVDF/BrATn2c8ZuQ9l+K9W5A2G5SQL3xgsAAi/vLYCPqEvVW001sbGp7OGeg9MXWw9oHUuOTGH/bxmU= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=os.amperecomputing.com; Received: from PH0PR01MB8048.prod.exchangelabs.com (2603:10b6:510:280::7) by SN6PR01MB5087.prod.exchangelabs.com (2603:10b6:805:b8::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6363.26; Fri, 5 May 2023 06:46:33 +0000 Received: from PH0PR01MB8048.prod.exchangelabs.com ([fe80::bbdb:b58c:140e:c4e1]) by PH0PR01MB8048.prod.exchangelabs.com ([fe80::bbdb:b58c:140e:c4e1%7]) with mapi id 15.20.6363.026; Fri, 5 May 2023 06:46:33 +0000 From: minhnampere To: devel@edk2.groups.io CC: patches@amperecomputing.com, abner.chang@amd.com, nicklew@nvidia.com, igork@ami.com, nhi@os.amperecomputing.com, tinhnguyen@os.amperecomputing.com, Vu Nguyen , Minh Nguyen , Nick Ramirez Subject: [PATCH V3 2/5] RedfishPkg: Fix condition checking of error status Date: Fri, 5 May 2023 13:45:57 +0700 Message-ID: <20230505064600.1478461-3-minhnguyen1@os.amperecomputing.com> X-Mailer: git-send-email 2.39.0 In-Reply-To: <20230505064600.1478461-1-minhnguyen1@os.amperecomputing.com> References: <20230505064600.1478461-1-minhnguyen1@os.amperecomputing.com> X-ClientProxiedBy: SG3P274CA0005.SGPP274.PROD.OUTLOOK.COM (2603:1096:4:be::17) To PH0PR01MB8048.prod.exchangelabs.com (2603:10b6:510:280::7) Return-Path: minhnguyen1@os.amperecomputing.com MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PH0PR01MB8048:EE_|SN6PR01MB5087:EE_ X-MS-Office365-Filtering-Correlation-Id: 5ca07748-b3d6-4c2d-e44f-08db4d3476a8 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: veiM6mEXc+4b/CCv5YajA4DOs5GAryRdq3sn5R1tVlt339K4fxDdOqxPaPrgW+49PLHnzGtl3Ik42MCq8KkbrLfQcpCGtj4kUdzc/Xb7Atc+a0fWy5PbWq1nIGDyfPcgGnXZETYFPHN/3/UO0cWNCQHAO/FIpgUWZeLZiCFloBaRvUl441qsjPIFp2ZlPAPrZKPW971ZKrkfBj7WXSlUY5vUcCz5qu+hUoKXN3+xhkkQGBxtdor6m3MFdk3hrrWMw5oB809WPE2/S5WvextFEU0cI9Z1ZbEjitnZiY4Nrm35OjEizHXLhe7JTTsA37EAiAYmaDDI6A1Om4pIB4oqc33WrWP5jMRG+itU61gg3xrNRC+CJAOcLB1G4QOqJgQvSgWvbcfCQyDs4q6CZMUsx0SwjjQtDdjOjyyDWtQMoDJk5ex7MRkQskWwmbJqtb7/6t8oj1mNWkEwdNCpFfSS1W778mBXuEzOWrFtfDveGJLazgcBsnirnN3G4Eb/0fVevdj9DURalPX1TDGZvlJxv8zit5t/rq8BMYKHO/lgCLIcLfkOnp81hT8S/vmUjZ/ZCIIMVx155etJz4jteWD9X5k3emaOgnu+cfCa+EqA1K8ypoVQsGAw5jrwoSePx5TTFD1dsRHfTPkNMV/OPVxnXQ== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PH0PR01MB8048.prod.exchangelabs.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(346002)(376002)(366004)(136003)(396003)(39850400004)(451199021)(83380400001)(52116002)(6486002)(1076003)(186003)(478600001)(54906003)(6666004)(2616005)(6506007)(6512007)(26005)(2906002)(38350700002)(5660300002)(38100700002)(66556008)(4326008)(41300700001)(8936002)(66946007)(6916009)(66476007)(8676002)(316002)(86362001)(43062005);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?ytVWC3ndQg5wk36W10wjNgxUj+0xjT23mnjD2J8gWv65+4W8vAXc1/NK6XhK?= =?us-ascii?Q?uqCHFn6CSnjeRModCUYpEVwpxUx0jlA6M/BGwQuqS5XAfUWUXfZeTLanAA+n?= =?us-ascii?Q?qV1/deQWOOwEZEPJ/o0MKUYoUaCE1mHaBNXkAYHykLbYN5yclJmVGfyXdbHq?= =?us-ascii?Q?dPemciiXQNAvUOfRvCPvo/3o+bz0d205x0riwAdvVDQRqr00WiTVr2tA9pQ0?= =?us-ascii?Q?KCNqlBCnx/oKWmfGgSoTHq2n+DE1TneCdrQCZx+NnG3LIp4Q10U2QLotvCIW?= =?us-ascii?Q?1mU3apcNw8zJFlqgN4O8ckGvdM/93PU7IIcS4a6ifdXL/kB/L33pzmEYhyxQ?= =?us-ascii?Q?tOOp+mZcHSgP7254JjbAZGwA7H8itAGZUEBa78ZjQRerH6ixktzjmgQZVnZM?= =?us-ascii?Q?NZ7kJg0n+2HdXJjY35FUBmwWR3d0z9hTuI9kKi5D4GpTOml36lFi4GCW8My/?= =?us-ascii?Q?sdvc3oZaXP7U4+J6wPRFGG6UlZaoYgYpfGA6drNkohm3R7qrHAz1s2QipGSC?= =?us-ascii?Q?LFdf98b4Edob9i9wKcrDm/Io5FGkce1JO9tV3f9TTzhfCPLvMQ1sENwZflFP?= =?us-ascii?Q?kFkL2iXVIJyeUlXILVOavY4Ff7010T9aPCvH9olonGmp9C6heAMQvLxLNOtD?= =?us-ascii?Q?0H0av96wFgqfSRTy2ltCQPc+Bw8AAPT9UlWjeGjs+XTho6b7qmM+jYNFeuGi?= =?us-ascii?Q?EmpsC+mdcTRWBIx4Ptj5RM7j2ng/H6OnJZ+JClFtsFp8KrO64HAoF0oZk+fd?= =?us-ascii?Q?GHntlscNpdMAPrlVqys7KD6yt0OBRUplRVrjDGZpzYAD3kHnTxEkpIXLpVJ/?= =?us-ascii?Q?7CMMso/sFVbpyCwvlG+06S8KmAlT6vAv7Id7qU9y48lg9hBnTxKBtO5LlLAW?= =?us-ascii?Q?QQdZF62RBr6m/JgBFkeWfHHiL4QJINljytNuzEf43mr/P/a9e9lPOFkKdwWz?= =?us-ascii?Q?x+FIupZSNl1I4jKT8RG7E1Acfyr4kcdMkCde2Qvhfb+Ns/4LnQVk+i3tPAT5?= =?us-ascii?Q?3ruz1WzL7zgAOAE3YhxVgM3zgituOS21gXx6qx1oRpMxe7J8dp67/lt0BvbF?= =?us-ascii?Q?Ruu6A044CB8fh5TjH8hEDJCWlb+k0+iU/G07EBum0DYC1v5L1vUDK0qTlILa?= =?us-ascii?Q?prAHUKNV9fOFH7nFFboMDvabqWzo0ceyOumZgrVcEoCVuXhnvNPZsxpv0LW3?= =?us-ascii?Q?2d/fRIZhVce266H+V2g2ksFEtP8Nxyz2ONOaFuSCaiFJPnR9kh6RmPsH/WvJ?= =?us-ascii?Q?mPnz5wdNTe8+VJPb7v3ZGu/38dPiGd00YrrgMUZw4zvSF96E9fGjDLOJBVu1?= =?us-ascii?Q?6cYpCkGxjaOh6n+RTMIU7pBKA9hNyCDSTGfZiAVmY9NreZ5YG4/RCcNtVCUS?= =?us-ascii?Q?SrhmhkqA+nknL3pFuAKgkaxKh4zhxDhHJndZFVOaoOrmkwLyEwjRx077vFzQ?= =?us-ascii?Q?dPqt5wufmgOwk2hrX005iBrshFS+4lwpKe56qP9Sph9zUBkQd+m4eA5KA1Zf?= =?us-ascii?Q?RhvZtcKWCImHdL4B+ctBX4nPUrujxRUzeLpWSTykD2v01DmtmNqvGPPmObEp?= =?us-ascii?Q?TAlOnmf/z55xDaYrhbwCdxjc3t8bydoylPy7Hi8JEgZZ4EZl6thKNXOYaCoI?= =?us-ascii?Q?HdFgdS48NFV3tLBD/4enJu2LL1yJbe/BVeaOhYbBPTv+?= X-OriginatorOrg: os.amperecomputing.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5ca07748-b3d6-4c2d-e44f-08db4d3476a8 X-MS-Exchange-CrossTenant-AuthSource: PH0PR01MB8048.prod.exchangelabs.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 May 2023 06:46:32.9517 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3bc2b170-fd94-476d-b0ce-4229bdc904a7 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Vjl+jHl/OhnRCa5Jb3BTrADzUdhp9oLM2xC85bWoKDNVCWjuhkvAppy68PB8rAzphluxvcytVVLeQ2AsydoOq8luJZ6mijHZGr6PhPTRwuAJr53gWyaTqEhPQLj1qDW+ X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN6PR01MB5087 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain From: Vu Nguyen This change fixes condition checking of error status, the condition should be compared with TRUE status to be identical with an error message. Signed-off-by: Minh Nguyen Cc: Abner Chang Cc: Igor Kulchytskyy Cc: Nick Ramirez Reviewed-by: Nickle Wang --- RedfishPkg/RedfishDiscoverDxe/RedfishDiscoverDxe.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/RedfishPkg/RedfishDiscoverDxe/RedfishDiscoverDxe.c b/RedfishPk= g/RedfishDiscoverDxe/RedfishDiscoverDxe.c index 0900a2479e7b..14702748813b 100644 --- a/RedfishPkg/RedfishDiscoverDxe/RedfishDiscoverDxe.c +++ b/RedfishPkg/RedfishDiscoverDxe/RedfishDiscoverDxe.c @@ -5,6 +5,7 @@ (C) Copyright 2021 Hewlett Packard Enterprise Development LP
Copyright (c) 2022, AMD Incorporated. All rights reserved. Copyright (c) 2023, NVIDIA CORPORATION & AFFILIATES. All rights reserved= . + Copyright (c) 2023, Ampere Computing LLC. All rights reserved.
=20 SPDX-License-Identifier: BSD-2-Clause-Patent =20 @@ -926,7 +927,7 @@ AddAndSignalNewRedfishService ( } =20 Status =3D gBS->SignalEvent (Instance->DiscoverToken->Event); - if (!EFI_ERROR (Status)) { + if (EFI_ERROR (Status)) { DEBUG ((DEBUG_ERROR, "%a:No event to signal!\n", __func__)); } } --=20 2.39.0