From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by mx.groups.io with SMTP id smtpd.web10.15347.1683341215162035856 for ; Fri, 05 May 2023 19:46:55 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=C3/CmGY3; spf=pass (domain: intel.com, ip: 192.55.52.93, mailfrom: michael.d.kinney@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1683341215; x=1714877215; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=Og2r3isjXN7Y2r2GLuV/BGSkceUX5Eu1Cp/V8fcMlpA=; b=C3/CmGY3EkLH+EkrwOxMC88Ho4LyZmdkfY6nCmcUuugfN0YziTL9jWZg EOSpwIP6B+GhiUHg01HuonJDpnuM8iOuGtC7lz3JTe/OnkwZIeVgpqCP3 /iLszI2PRb2xmUwSOGQMEmDeigaNRaMCiTTuxxQUwtVB4t/YfdThLsmxy sDL+P9I+zZhjRAzAI1vMfYd2DzB2n//I2/dnjQU5jFQ4esgs8CvvnnB5e RJxd451j2A6FZkIWX+sRSK7SsnQeQ8cxyk17Z+H3snJCibLg4yuDzrYT/ 2EHG4ZQ5e+j3/z51Mu78qcD6vkKHL8VYP+j3eTlYKNozt+FogzfR8blyL A==; X-IronPort-AV: E=McAfee;i="6600,9927,10701"; a="346803540" X-IronPort-AV: E=Sophos;i="5.99,253,1677571200"; d="scan'208";a="346803540" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 May 2023 19:46:46 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10701"; a="762683175" X-IronPort-AV: E=Sophos;i="5.99,253,1677571200"; d="scan'208";a="762683175" Received: from jrosario-mobl1.amr.corp.intel.com (HELO mdkinney-mobl.amr.corp.intel.com) ([10.209.47.142]) by fmsmga008-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 May 2023 19:46:46 -0700 From: "Michael D Kinney" To: devel@edk2.groups.io Cc: Rebecca Cran , Liming Gao , Bob Feng , Yuwei Chen Subject: [Patch 1/1] BaseTools/Conf: Add quotes to ADDDEBUGFLAG in tools_def.txt Date: Fri, 5 May 2023 19:46:36 -0700 Message-Id: <20230506024636.1245-1-michael.d.kinney@intel.com> X-Mailer: git-send-email 2.40.1.windows.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4448 Update tools_def.txt to add quotes around the file target in OBJCOPY_ADDDEBUGFLAGS for compatibility with GCC like tool chains used on Windows. Cc: Rebecca Cran Cc: Liming Gao Cc: Bob Feng Cc: Yuwei Chen Signed-off-by: Michael D Kinney --- BaseTools/Conf/tools_def.template | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/BaseTools/Conf/tools_def.template b/BaseTools/Conf/tools_def.template index 1b3a9e7a540a..535dda1d5d99 100755 --- a/BaseTools/Conf/tools_def.template +++ b/BaseTools/Conf/tools_def.template @@ -731,9 +731,9 @@ NOOPT_VS2019_AARCH64_DLINK_FLAGS = /NOLOGO /NODEFAULTLIB /IGNORE:4001 /OPT:REF *_*_*_OBJCOPY_FLAGS = objcopy not needed for *_*_*_SYMRENAME_PATH = echo *_*_*_SYMRENAME_FLAGS = Symbol renaming not needed for -DEBUG_*_*_OBJCOPY_ADDDEBUGFLAG = --add-gnu-debuglink=$(DEBUG_DIR)/$(MODULE_NAME).debug +DEBUG_*_*_OBJCOPY_ADDDEBUGFLAG = --add-gnu-debuglink="$(DEBUG_DIR)/$(MODULE_NAME).debug" RELEASE_*_*_OBJCOPY_ADDDEBUGFLAG = -NOOPT_*_*_OBJCOPY_ADDDEBUGFLAG = --add-gnu-debuglink=$(DEBUG_DIR)/$(MODULE_NAME).debug +NOOPT_*_*_OBJCOPY_ADDDEBUGFLAG = --add-gnu-debuglink="$(DEBUG_DIR)/$(MODULE_NAME).debug" *_*_*_OBJCOPY_STRIPFLAG = --strip-unneeded -R .eh_frame *_*_*_DTC_FLAGS = -H epapr *_*_*_DTCPP_PATH = DEF(DTCPP_BIN) -- 2.40.1.windows.1