From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by mx.groups.io with SMTP id smtpd.web11.803.1683576774865909371 for ; Mon, 08 May 2023 13:12:55 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=AIsT3HlS; spf=pass (domain: intel.com, ip: 134.134.136.126, mailfrom: gua.guo@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1683576774; x=1715112774; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=XmFKjl+x/5uB1dQmkzv20mLA+guXXLGOOX3AFhdVzRg=; b=AIsT3HlSyYrbcPVYa7HWEEF1/d81e4/Ff2ln32ELoC7vIIqEgLZZjDKd x1vzma9OukOxyQ6mMUiKDp+G/xcqRhjTcrcL30DoKjeSxlFZJ1tpm/UdZ AkbF+4T59WLeOzY7HiTzCNY7Wlz29WIUNnMyugSSHgBYlitEWjpXa7n78 w8cnYWsjQSSR5A2VyPxEwWJ5DIAd1pePutZprTdd+fIiKH0wdtgX2+lXp hPynKNhI03gLGSitLE104Xkpe7onN9EabCJ1vFZC6PjdBJ5hbrlLCa5Mi doPCi6NWsF471+FMxY8YuwQYhwvpKeyR8w/QDnVARUleQU0tTmKyBJ3fi A==; X-IronPort-AV: E=McAfee;i="6600,9927,10704"; a="334193359" X-IronPort-AV: E=Sophos;i="5.99,259,1677571200"; d="scan'208";a="334193359" Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 May 2023 13:12:53 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10704"; a="698640359" X-IronPort-AV: E=Sophos;i="5.99,259,1677571200"; d="scan'208";a="698640359" Received: from gguo-desk.gar.corp.intel.com ([10.5.215.23]) by orsmga002.jf.intel.com with ESMTP; 08 May 2023 13:12:52 -0700 From: "Guo, Gua" To: devel@edk2.groups.io Cc: Gua Guo , Michael D Kinney , Sean Brogan , Michael Kubacki Subject: [PATCH v2] BaseTools/Plugin: Too many execute file report cmd too long failure Date: Tue, 9 May 2023 04:12:49 +0800 Message-Id: <20230508201249.291-1-gua.guo@intel.com> X-Mailer: git-send-email 2.39.2.windows.1 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable From: Gua Guo Windows command prompt have 8191 characters limitation, enhance it to make command too long can be resloved. Provide an example, if have to many *.cov, it causes to run single command over the 8191 characters limitation. > OpenCppCoverage > --export_type binary:coverage.cov > --working_dir=3D{workspace}Build > --input_coverage=3DAAA.cov > ... > --input_coverage=3DNNN.cov The solution is passing many coverage files in single command line to breaking it up into many command lines with one coverage file per command line in order to prevent single line is over to 8191 characters. - Command Line 1 > OpenCppCoverage > --export_type binary:coverage.cov > --working_dir=3D{workspace}Build > --input_coverage=3DAAA.cov > --input_coverage=3Dcoverage.cov ... - Command Line N > OpenCppCoverage > --export_type binary:coverage.cov > --working_dir=3D{workspace}Build > --input_coverage=3DNNN.cov > --input_coverage=3Dcoverage.cov Cc: Michael D Kinney Cc: Sean Brogan Cc: Michael Kubacki Signed-off-by: Gua Guo --- .../HostBasedUnitTestRunner.py | 31 ++++++++++++++++--- 1 file changed, 27 insertions(+), 4 deletions(-) diff --git a/BaseTools/Plugin/HostBasedUnitTestRunner/HostBasedUnitTestRunn= er.py b/BaseTools/Plugin/HostBasedUnitTestRunner/HostBasedUnitTestRunner.py index d993de9412..05bb6da50a 100644 --- a/BaseTools/Plugin/HostBasedUnitTestRunner/HostBasedUnitTestRunner.py +++ b/BaseTools/Plugin/HostBasedUnitTestRunner/HostBasedUnitTestRunner.py @@ -209,13 +209,25 @@ class HostBasedUnitTestRunner(IUefiBuildPlugin): coverageFile =3D ""=0D for testFile in testList:=0D ret =3D RunCmd("OpenCppCoverage", f"--source {workspace} --exp= ort_type binary:{testFile}.cov -- {testFile}")=0D - coverageFile +=3D " --input_coverage=3D" + testFile + ".cov"=0D + if ret !=3D 0:=0D + logging.error("UnitTest Coverage: Failed to collect covera= ge data.")=0D + return 1=0D +=0D + coverageFile =3D f" --input_coverage=3D{testFile}.cov"=0D + if (os.path.isfile(f"{os.path.join(buildOutputBase, 'coverage.= cov')}")):=0D + coverageFile +=3D f" --input_coverage=3D{os.path.join(buil= dOutputBase, 'coverage.cov')}"=0D + ret =3D RunCmd("OpenCppCoverage", f"--export_type binary:{os.p= ath.join(buildOutputBase, 'coverage.cov')} --working_dir=3D{workspace}Build= {coverageFile}")=0D if ret !=3D 0:=0D logging.error("UnitTest Coverage: Failed to collect covera= ge data.")=0D return 1=0D =0D # Generate and XML file if requested.by each package=0D - ret =3D RunCmd("OpenCppCoverage", f"--export_type cobertura:{os.pa= th.join(buildOutputBase, 'coverage.xml')} --working_dir=3D{workspace}Build = {coverageFile}")=0D + ret =3D RunCmd(=0D + "OpenCppCoverage",=0D + f"--export_type cobertura:{os.path.join(buildOutputBase, 'cove= rage.xml')} " +=0D + f"--working_dir=3D{workspace}Build " +=0D + f"--input_coverage=3D{os.path.join(buildOutputBase, 'coverage.= cov')}"=0D + )=0D if ret !=3D 0:=0D logging.error("UnitTest Coverage: Failed to generate cobertura= format xml in single package.")=0D return 1=0D @@ -224,9 +236,20 @@ class HostBasedUnitTestRunner(IUefiBuildPlugin): testCoverageList =3D glob.glob(os.path.join(workspace, "Build", "*= *","*Test*.exe.cov"), recursive=3DTrue)=0D coverageFile =3D ""=0D for testCoverage in testCoverageList:=0D - coverageFile +=3D " --input_coverage=3D" + testCoverage=0D + coverageFile =3D f" --input_coverage=3D{testCoverage}"=0D + if (os.path.isfile(f"{workspace}Build/coverage.cov")):=0D + coverageFile +=3D f" --input_coverage=3D{workspace}Build/c= overage.cov"=0D + ret =3D RunCmd("OpenCppCoverage", f"--export_type binary:{work= space}Build/coverage.cov --working_dir=3D{workspace}Build {coverageFile}")= =0D + if ret !=3D 0:=0D + logging.error("UnitTest Coverage: Failed to collect covera= ge data.")=0D + return 1=0D =0D - ret =3D RunCmd("OpenCppCoverage", f"--export_type cobertura:{works= pace}Build/coverage.xml --working_dir=3D{workspace}Build {coverageFile}")=0D + ret =3D RunCmd(=0D + "OpenCppCoverage",=0D + f"--export_type cobertura:{workspace}Build/coverage.xml " +=0D + f"--working_dir=3D{workspace}Build " +=0D + f"--input_coverage=3D{workspace}Build/coverage.cov"=0D + )=0D if ret !=3D 0:=0D logging.error("UnitTest Coverage: Failed to generate cobertura= format xml.")=0D return 1=0D --=20 2.39.2.windows.1