From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f47.google.com (mail-wm1-f47.google.com [209.85.128.47]) by mx.groups.io with SMTP id smtpd.web10.3959.1683582802062447003 for ; Mon, 08 May 2023 14:53:22 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="signature has expired" header.i=@gmail.com header.s=20221208 header.b=hj0ChbFM; spf=pass (domain: gmail.com, ip: 209.85.128.47, mailfrom: pedro.falcato@gmail.com) Received: by mail-wm1-f47.google.com with SMTP id 5b1f17b1804b1-3f415a9015bso31064735e9.2 for ; Mon, 08 May 2023 14:53:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1683582800; x=1686174800; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=cERgeHm++bSZdjy2JIamwBqplmcwEsq39aFXHoXYWZ4=; b=hj0ChbFMzDyU+ZVHgUy+bTsJ+ZGTFMcfW26ns8FdPu9a95rwL0St+iCzo2KIyZxchh 6/FmGwyRhohP16RdwORGx/74yyiWHlQiZE9eHKrwJ4iDuwM3LhacHzTGGciNfp05k7SI JpJ8uO7OpGaVOmTBML3duFiG3lqoX1bxmukqrkLodgB8tD1q8ee3+12Ir18yPJBzKoXH KUG25d9vR64g43pp4dj2n2E+5ZRgtlGLCEuC96lXeC+zi+ye4w21YytsiTdEFUSTtHim qqNvmf4tJCQXD7OxyTKJjpcpThxDqIvVhuROkFRhYCco+KfhZAFShF25Wf2tnGQAlf3x nSWQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1683582800; x=1686174800; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=cERgeHm++bSZdjy2JIamwBqplmcwEsq39aFXHoXYWZ4=; b=ZhwG5BMyWQXnEdLhjNvOl4Dr1jJrZQrcQk8cEY5eX5JpUzgR6tPNPVXyKjjpRqQGrh IdePIkz24zNlTVPiOw+OESmaG2CaJTdfU9ZNTzToXM04mj9eJrF29A/tpj4FPeJeKmr/ crFDqt0rdCWTQVT/G5bM97i8o+HFjbEpUbxPJA/voAnBhV0OzSncHMETRvIJuKou6C7N E0YKbIreOZhYeHH1O1lD93d9k46HxRT/G4fwzqNigB5lRKjdDTfyNi1871cgcWdW4Uxp bsS+nTOA9roxdR2hjTVEvvDLoSxNMerVx37Vf4Kuejy7zOn9GFFa1VpVrBfpyJBkll2V wi4A== X-Gm-Message-State: AC+VfDxlHpOXyoF3DjjfZ6Pg0w8c8bmVsFYw4fP6aHXf0I+89rtacpZw atqSudWYwb6PA3ymjBGWB4E1+SfD05ElCOni X-Google-Smtp-Source: ACHHUZ6W0T8Oy9aG+Ws5dMYr3uK8unDalghAUC6rkpllVjSXnrHBwLZDbkbjBMmgkrVzqDA+r4O7tg== X-Received: by 2002:a7b:c051:0:b0:3f1:6ec5:3105 with SMTP id u17-20020a7bc051000000b003f16ec53105mr7929229wmc.20.1683582799885; Mon, 08 May 2023 14:53:19 -0700 (PDT) Return-Path: Received: from PC-PEDRO-ARCH.lan ([2001:8a0:7280:5801:9441:3dce:686c:bfc7]) by smtp.gmail.com with ESMTPSA id u16-20020a05600c00d000b003f428c4155csm2004316wmm.11.2023.05.08.14.53.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 08 May 2023 14:53:19 -0700 (PDT) From: "Pedro Falcato" To: devel@edk2.groups.io Cc: Pedro Falcato , Ard Biesheuvel , Jiewen Yao , Gerd Hoffmann , Erdem Aktas , James Bottomley , Min Xu , Tom Lendacky , Michael Roth , Rebecca Cran , Peter Grehan , =?UTF-8?q?Corvin=20K=C3=B6hne?= , Sebastien Boeuf , Anthony Perard , Julien Grall , Laszlo Ersek Subject: [PATCH 0/2] OvmfPkg: Replace the OVMF-specific SataControllerDxe with the generic one Date: Mon, 8 May 2023 22:52:44 +0100 Message-Id: <20230508215246.217002-1-pedro.falcato@gmail.com> X-Mailer: git-send-email 2.40.1 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit This patch-set replaces the OVMF specific SataControllerDxe with the MdeModulePkg/Bus/Pci one. They were both forked from the same code, and are code-and-functionality similar. As such, there seems to be no need for duplication here. First I manually replayed OvmfPkg/SataControllerDxe's patches on top of the generic one. Only one seemed to make sense. The second patch removes OvmfPkg/SataControllerDxe and replaces it for all platforms under OvmfPkg. Tested by booting in QEMU (Q35 (AHCI) and PC (IDE)). More testing from other, alternative platforms is desired, although breakage seems unlikely. (+CC Laszlo as the author of the original SataControllerDxe patches) Cc: Ard Biesheuvel Cc: Jiewen Yao Cc :Jordan Justen Cc: Gerd Hoffmann Cc: Erdem Aktas Cc: James Bottomley Cc: Min Xu Cc: Tom Lendacky Cc: Michael Roth Cc: Rebecca Cran Cc: Peter Grehan Cc: Corvin Köhne Cc: Sebastien Boeuf Cc: Anthony Perard Cc: Julien Grall Cc: Laszlo Ersek Pedro Falcato (2): MdeModulePkg/SataControllerDxe: Remove useless null check OvmfPkg: Replace the OVMF-specific SataControllerDxe with a generic one .../Pci/SataControllerDxe/SataController.c | 44 +- OvmfPkg/AmdSev/AmdSevX64.dsc | 2 +- OvmfPkg/AmdSev/AmdSevX64.fdf | 2 +- OvmfPkg/Bhyve/BhyveX64.dsc | 2 +- OvmfPkg/Bhyve/BhyveX64.fdf | 2 +- OvmfPkg/CloudHv/CloudHvX64.dsc | 2 +- OvmfPkg/CloudHv/CloudHvX64.fdf | 2 +- OvmfPkg/IntelTdx/IntelTdxX64.dsc | 2 +- OvmfPkg/IntelTdx/IntelTdxX64.fdf | 2 +- OvmfPkg/Microvm/MicrovmX64.dsc | 2 +- OvmfPkg/Microvm/MicrovmX64.fdf | 2 +- OvmfPkg/OvmfPkgIa32.dsc | 2 +- OvmfPkg/OvmfPkgIa32.fdf | 2 +- OvmfPkg/OvmfPkgIa32X64.dsc | 2 +- OvmfPkg/OvmfPkgIa32X64.fdf | 2 +- OvmfPkg/OvmfPkgX64.dsc | 2 +- OvmfPkg/OvmfPkgX64.fdf | 2 +- OvmfPkg/OvmfXen.dsc | 2 +- OvmfPkg/OvmfXen.fdf | 2 +- OvmfPkg/SataControllerDxe/ComponentName.c | 170 --- OvmfPkg/SataControllerDxe/SataController.c | 1112 ----------------- OvmfPkg/SataControllerDxe/SataController.h | 544 -------- .../SataControllerDxe/SataControllerDxe.inf | 43 - 23 files changed, 39 insertions(+), 1910 deletions(-) delete mode 100644 OvmfPkg/SataControllerDxe/ComponentName.c delete mode 100644 OvmfPkg/SataControllerDxe/SataController.c delete mode 100644 OvmfPkg/SataControllerDxe/SataController.h delete mode 100644 OvmfPkg/SataControllerDxe/SataControllerDxe.inf -- 2.40.1