From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f52.google.com (mail-wm1-f52.google.com [209.85.128.52]) by mx.groups.io with SMTP id smtpd.web10.2381.1683592928605536028 for ; Mon, 08 May 2023 17:42:08 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="signature has expired" header.i=@gmail.com header.s=20221208 header.b=mzfLzt29; spf=pass (domain: gmail.com, ip: 209.85.128.52, mailfrom: pedro.falcato@gmail.com) Received: by mail-wm1-f52.google.com with SMTP id 5b1f17b1804b1-3f315735514so188406595e9.1 for ; Mon, 08 May 2023 17:42:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1683592927; x=1686184927; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=BT1s7L5Rm9PFFr2ItUH01oEzMjlUoAAc3PAYprFUiFw=; b=mzfLzt29KzWyPw2NVIz1C81r9Hseb3CgVZWFRDnmNFV7YHXXlLPqtMLGctX3EsVvOx 2qM8+aaRxk/ZJvTJDHjKws2ymUvvnr5F4ZyKeVIDNya34G3f/JOrRiUjx8++UzJlNPC+ p6rjLyuLLxb6MyYehZFU5wJJXkqRc39RUURcIdsoTu63DKKp/xnp9zYIgFNf6Mhr4K92 1PTmlUKi4NJ/PDm2KaaMBX/cjTycevOfy7nWRAHyxAJqwA2uTNKne3ZZIxu9SzRkgVug 3kfg4JSKbmzLjaPldf4PoD/eziaAfO/smlw/3q97HhsR/7nwGChE8NXBlap+QLMmLbO4 XJRA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1683592927; x=1686184927; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=BT1s7L5Rm9PFFr2ItUH01oEzMjlUoAAc3PAYprFUiFw=; b=ILJzxVbn2tdhEEB/3SCIsn6VeAezgkUb0PyzoasVl7A9LkJQmjO5GJAwL43EgRN+wc 49ewlZ1r7VHAqp+SyZ5l1oNJ0CAydCU92M3/nJksOcZsRcomm1p8tPHbXtLaN4RqkkwX a7wFhVW8CnYyLx6qWZdw841/ZZeOJkPoAjb/4bL4yweITadPh2lSFLjYckv+1KJN5QZD ol+jmtiT+Bf17XH6gfXS/nNH2AgYb78ayfyA6NBMfHUPlqVSwbG494WzIPRn9CWsUr7A oiTXH1zvkGiwSmU1DDgxXAfy9zEOKLLrOXAaympwN8uPUjk+uMDhUqetJDd0vY/ROxWb Ms6A== X-Gm-Message-State: AC+VfDz4oOgCboTK/hdsEc5TKihnRZnCfwJg39cQu8CxtQH82eVONGwO VhvIuJimkpRpUqAdgJCGmNtM9XWp73IYoR5y X-Google-Smtp-Source: ACHHUZ4ulrXPVZgrG5E8XfBMCaHfSjaYlG8E6iYugR4aZoEj+wpg67wcs20ja4g0NAOHGCTpcHLkQA== X-Received: by 2002:a5d:4751:0:b0:2fd:c315:bb2c with SMTP id o17-20020a5d4751000000b002fdc315bb2cmr8173202wrs.22.1683592926661; Mon, 08 May 2023 17:42:06 -0700 (PDT) Return-Path: Received: from PC-PEDRO-ARCH.lan ([2001:8a0:7280:5801:9441:3dce:686c:bfc7]) by smtp.gmail.com with ESMTPSA id r15-20020a5d694f000000b00306415ac69asm12612219wrw.15.2023.05.08.17.42.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 08 May 2023 17:42:06 -0700 (PDT) From: "Pedro Falcato" To: devel@edk2.groups.io Cc: Pedro Falcato , =?UTF-8?q?Marvin=20H=C3=A4user?= Subject: [PATCH 2/2] Ext4Pkg: Advertise CSUM_SEED as supported Date: Tue, 9 May 2023 01:42:02 +0100 Message-Id: <20230509004202.243859-2-pedro.falcato@gmail.com> X-Mailer: git-send-email 2.40.1 In-Reply-To: <20230509004202.243859-1-pedro.falcato@gmail.com> References: <20230509004202.243859-1-pedro.falcato@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit We had added support for CSUM_SEED but accidentally forgot to advertise it in gSupportedIncompatFeat. This made it (erroneously) impossible to mount CSUM_SEED filesystems. Detected by attempting to mount a relatively new mkfs.ext4'd filesystem. Cc: Marvin Häuser Signed-off-by: Pedro Falcato --- Features/Ext4Pkg/Ext4Dxe/Superblock.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Features/Ext4Pkg/Ext4Dxe/Superblock.c b/Features/Ext4Pkg/Ext4Dxe/Superblock.c index 3f56de93c105..604925b582c1 100644 --- a/Features/Ext4Pkg/Ext4Dxe/Superblock.c +++ b/Features/Ext4Pkg/Ext4Dxe/Superblock.c @@ -1,7 +1,7 @@ /** @file Superblock managing routines - Copyright (c) 2021 - 2022 Pedro Falcato All rights reserved. + Copyright (c) 2021 - 2023 Pedro Falcato All rights reserved. SPDX-License-Identifier: BSD-2-Clause-Patent **/ @@ -18,7 +18,7 @@ STATIC CONST UINT32 gSupportedIncompatFeat = EXT4_FEATURE_INCOMPAT_64BIT | EXT4_FEATURE_INCOMPAT_DIRDATA | EXT4_FEATURE_INCOMPAT_FLEX_BG | EXT4_FEATURE_INCOMPAT_FILETYPE | EXT4_FEATURE_INCOMPAT_EXTENTS | EXT4_FEATURE_INCOMPAT_LARGEDIR | - EXT4_FEATURE_INCOMPAT_MMP | EXT4_FEATURE_INCOMPAT_RECOVER; + EXT4_FEATURE_INCOMPAT_MMP | EXT4_FEATURE_INCOMPAT_RECOVER | EXT4_FEATURE_INCOMPAT_CSUM_SEED; // Future features that may be nice additions in the future: // 1) Btree support: Required for write support and would speed up lookups in large directories. -- 2.40.1