From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f53.google.com (mail-wr1-f53.google.com [209.85.221.53]) by mx.groups.io with SMTP id smtpd.web10.2660.1683593708791977681 for ; Mon, 08 May 2023 17:55:09 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="signature has expired" header.i=@gmail.com header.s=20221208 header.b=U2wovu4R; spf=pass (domain: gmail.com, ip: 209.85.221.53, mailfrom: pedro.falcato@gmail.com) Received: by mail-wr1-f53.google.com with SMTP id ffacd0b85a97d-30771c68a9eso4500272f8f.2 for ; Mon, 08 May 2023 17:55:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1683593707; x=1686185707; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=BT1s7L5Rm9PFFr2ItUH01oEzMjlUoAAc3PAYprFUiFw=; b=U2wovu4Ryqi9imcx3G8dUuatXWsiac4o1ZEGBcBugDp/yIU/6TB3A339UCerRmHTRe TRZ8tEamWLAZrf6oG2xMH48n99FuYSIoZOCXUx1prIReRI0vUlSo1VUHNoIwvWo1sRov 2X5+x6q2Vh5Q1E0ZV+FQa+J24Z8xs9YV7ZmZxFggrMG7JRApxBEM4BxWkExXbTd3SeCi 9SqqmzNCBwmflWM/5ukoNP/rN/+X5gbc8bV4KExBXC1ZBe3OmGY7dis3zvpczgc1Or8k qQyKuBURw06jXy9qqLTtC9DydbPx/T60tVg+Gscb9zCTKuhTppX5+V8qUe8PpHVYEq0/ DOfA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1683593707; x=1686185707; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=BT1s7L5Rm9PFFr2ItUH01oEzMjlUoAAc3PAYprFUiFw=; b=k46jNcKtxsr1tZURiTnzo4vBjt+VcYu6CWQGK7fxdIWAsnRsmV6ybpJMx/P2OTcxp5 R/y3ow1HpmaWutxYK/O0RnUV6tNqNhwPZjpg/IebPz3PqO4St+nvbWQmYGo2vGv4dA7C 9M6Vj96PjPEgK7JEeht7bQL/Gego9XZCMuIEtSddkuLhSDsIZnQHRJF0Lj00TOeb/g1b nHErRfuqAmcUBl89dZkoGdm9SkDfz60i1MsTp5k8VTX8YI6CU9wfQzsdo4q8v4XyJkwh o0gBlgh3PLC1DLSKJ5IgrfSahH3M8riioIQEq6XipJxXIi3CEc+NGp0CHwiIUPBlt2qw K3tA== X-Gm-Message-State: AC+VfDzS/ZFbu6pADWfb0m4ARxdrLAz1Q1hxSMNLVdDKAxRlg6sNfLsv QflcAQHsOPl790ZFGv3mTa46uIpq9vTvlJOb X-Google-Smtp-Source: ACHHUZ5plPYy79Oscopcos+Or9BX+iSaqIXzRawKw4nUMbNGWoYFsS75343vaU9C8lm4WJI5DYwJJA== X-Received: by 2002:a5d:5946:0:b0:2f5:d3d7:7af4 with SMTP id e6-20020a5d5946000000b002f5d3d77af4mr7957160wri.63.1683593706875; Mon, 08 May 2023 17:55:06 -0700 (PDT) Return-Path: Received: from PC-PEDRO-ARCH.lan ([2001:8a0:7280:5801:9441:3dce:686c:bfc7]) by smtp.gmail.com with ESMTPSA id k15-20020a5d518f000000b003077a19cf75sm12560770wrv.60.2023.05.08.17.55.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 08 May 2023 17:55:06 -0700 (PDT) From: "Pedro Falcato" To: devel@edk2.groups.io Cc: Pedro Falcato , =?UTF-8?q?Marvin=20H=C3=A4user?= Subject: [PATCH v2 2/2] Ext4Pkg: Advertise CSUM_SEED as supported Date: Tue, 9 May 2023 01:54:58 +0100 Message-Id: <20230509005458.245291-2-pedro.falcato@gmail.com> X-Mailer: git-send-email 2.40.1 In-Reply-To: <20230509005458.245291-1-pedro.falcato@gmail.com> References: <20230509005458.245291-1-pedro.falcato@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit We had added support for CSUM_SEED but accidentally forgot to advertise it in gSupportedIncompatFeat. This made it (erroneously) impossible to mount CSUM_SEED filesystems. Detected by attempting to mount a relatively new mkfs.ext4'd filesystem. Cc: Marvin Häuser Signed-off-by: Pedro Falcato --- Features/Ext4Pkg/Ext4Dxe/Superblock.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Features/Ext4Pkg/Ext4Dxe/Superblock.c b/Features/Ext4Pkg/Ext4Dxe/Superblock.c index 3f56de93c105..604925b582c1 100644 --- a/Features/Ext4Pkg/Ext4Dxe/Superblock.c +++ b/Features/Ext4Pkg/Ext4Dxe/Superblock.c @@ -1,7 +1,7 @@ /** @file Superblock managing routines - Copyright (c) 2021 - 2022 Pedro Falcato All rights reserved. + Copyright (c) 2021 - 2023 Pedro Falcato All rights reserved. SPDX-License-Identifier: BSD-2-Clause-Patent **/ @@ -18,7 +18,7 @@ STATIC CONST UINT32 gSupportedIncompatFeat = EXT4_FEATURE_INCOMPAT_64BIT | EXT4_FEATURE_INCOMPAT_DIRDATA | EXT4_FEATURE_INCOMPAT_FLEX_BG | EXT4_FEATURE_INCOMPAT_FILETYPE | EXT4_FEATURE_INCOMPAT_EXTENTS | EXT4_FEATURE_INCOMPAT_LARGEDIR | - EXT4_FEATURE_INCOMPAT_MMP | EXT4_FEATURE_INCOMPAT_RECOVER; + EXT4_FEATURE_INCOMPAT_MMP | EXT4_FEATURE_INCOMPAT_RECOVER | EXT4_FEATURE_INCOMPAT_CSUM_SEED; // Future features that may be nice additions in the future: // 1) Btree support: Required for write support and would speed up lookups in large directories. -- 2.40.1