From: "Rebecca Cran" <rebecca@bsdio.com>
To: devel@edk2.groups.io, Andrew Fish <afish@apple.com>,
Leif Lindholm <quic_llindhol@quicinc.com>,
Michael D Kinney <michael.d.kinney@intel.com>,
Liming Gao <gaoliming@byosoft.com.cn>,
Bob Feng <bob.c.feng@intel.com>,
Yuwei Chen <yuwei.chen@intel.com>
Cc: Rebecca Cran <rebecca@bsdio.com>
Subject: [edk2-stable202305 PATCH 2/3] BaseTools: only print the environment once in toolsetup.bat
Date: Mon, 8 May 2023 22:25:24 -0600 [thread overview]
Message-ID: <20230509042524.612-3-rebecca@bsdio.com> (raw)
In-Reply-To: <20230509042524.612-1-rebecca@bsdio.com>
Avoid printing %PATH% twice: move the printing of the environment down
to print_python_info.
Signed-off-by: Rebecca Cran <rebecca@bsdio.com>
---
BaseTools/toolsetup.bat | 35 +++++++++-----------
1 file changed, 16 insertions(+), 19 deletions(-)
diff --git a/BaseTools/toolsetup.bat b/BaseTools/toolsetup.bat
index 85104aa224da..9521f67c024e 100755
--- a/BaseTools/toolsetup.bat
+++ b/BaseTools/toolsetup.bat
@@ -250,24 +250,6 @@ if NOT exist %CONF_PATH%\build_rule.txt (
if defined RECONFIG copy /Y %EDK_TOOLS_PATH%\Conf\build_rule.template %CONF_PATH%\build_rule.txt > nul
)
-echo PATH = %PATH%
-echo.
-if defined WORKSPACE (
- echo WORKSPACE = %WORKSPACE%
-)
-if defined PACKAGES_PATH (
- echo PACKAGES_PATH = %PACKAGES_PATH%
-)
-echo EDK_TOOLS_PATH = %EDK_TOOLS_PATH%
-if defined BASE_TOOLS_PATH (
- echo BASE_TOOLS_PATH = %BASE_TOOLS_PATH%
-)
-if defined EDK_TOOLS_BIN (
- echo EDK_TOOLS_BIN = %EDK_TOOLS_BIN%
-)
-echo CONF_PATH = %CONF_PATH%
-echo.
-
:skip_reconfig
@REM
@@ -381,7 +363,22 @@ if %ERRORLEVEL% EQU 0 (
goto print_python_info
:print_python_info
- echo PATH = %PATH%
+ echo PATH = %PATH%
+ echo.
+ if defined WORKSPACE (
+ echo WORKSPACE = %WORKSPACE%
+ )
+ if defined PACKAGES_PATH (
+ echo PACKAGES_PATH = %PACKAGES_PATH%
+ )
+ echo EDK_TOOLS_PATH = %EDK_TOOLS_PATH%
+ if defined BASE_TOOLS_PATH (
+ echo BASE_TOOLS_PATH = %BASE_TOOLS_PATH%
+ )
+ if defined EDK_TOOLS_BIN (
+ echo EDK_TOOLS_BIN = %EDK_TOOLS_BIN%
+ )
+ echo CONF_PATH = %CONF_PATH%
echo PYTHON_COMMAND = %PYTHON_COMMAND%
echo PYTHONPATH = %PYTHONPATH%
echo.
--
2.40.0.windows.1
next prev parent reply other threads:[~2023-05-09 4:25 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-09 4:25 [edk2-stable202305 PATCH 0/3] BaseTools: Fix PYTHONPATH on Windows, Tests\TestTools.py and cleanup toolsetup.bat Rebecca Cran
2023-05-09 4:25 ` [edk2-stable202305 PATCH 1/3] BaseTools: Update toolsetup.bat to not use BASETOOLS_PYTHON_SOURCE Rebecca Cran
2023-05-09 4:25 ` Rebecca Cran [this message]
2023-05-10 22:30 ` [edk2-stable202305 PATCH 0/3] BaseTools: Fix PYTHONPATH on Windows, Tests\TestTools.py and cleanup toolsetup.bat Rebecca Cran
2023-05-11 1:37 ` 回复: [edk2-devel] " gaoliming
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230509042524.612-3-rebecca@bsdio.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox