From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f43.google.com (mail-wm1-f43.google.com [209.85.128.43]) by mx.groups.io with SMTP id smtpd.web10.36502.1683647368935514742 for ; Tue, 09 May 2023 08:49:29 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="signature has expired" header.i=@gmail.com header.s=20221208 header.b=j14qKzWm; spf=pass (domain: gmail.com, ip: 209.85.128.43, mailfrom: pedro.falcato@gmail.com) Received: by mail-wm1-f43.google.com with SMTP id 5b1f17b1804b1-3f41dceb9d1so35266335e9.1 for ; Tue, 09 May 2023 08:49:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1683647367; x=1686239367; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=fCYhf/BzVUvcEi3hmHL8rFJxKpXVcy7QV70Ntztutlg=; b=j14qKzWmF0zuYgZfcDhqkKiGGOatjj64ICAB6o5htnVwH4vbD4EQ7SHxxkOUzWtAaw OUpzMts7qgk9Gj0WNjnbmq3gT9TQ3bdvXt8XCpCitdNpl68gJVUnyUQ5idTmODOzYfGn UJ+edByLUI+qsd/zMHgIaloLYO/UZS6VaKHqoJVtkTuBKHlrf1A+x0JYtb3QDMJXdxPO 8wGDVNjPzwDBE5IVPj+/1aewcdTyGuMVCGFqCCUbqvAkIX0AWekm/OJwV4c77ycEyGsj UIECbUYnshwY8/zjX5vdzC3LMBWYpCsGdZoD/GRJV18pLtchnqsifu06L5+0zh88aMep MCqQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1683647367; x=1686239367; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=fCYhf/BzVUvcEi3hmHL8rFJxKpXVcy7QV70Ntztutlg=; b=YOmBJx3mlBuGheqA+OzWszP7R15TWULLa2f8U2OAMlFo3gH2FyYqdPoD+xhv+5dqd6 iPUNTGOi8UwmWkAcYtKNF3JaPLQRvnU0EL1UKigLmwak62HNOLv1UT4NBIMURfTgAX6G bUJ7reevA59HJLTBBsBkQOco+9KpzaUOuIWNH4LpDPRVKlIvuuju8IdQVZHVjatcMHGN IH/FRbd82mlGu1WgDzoXrAuShkXBMdDNE624Xbbd8+lTS7R4KeUZ3mfdkMAPbBHFIAHj oQ7IGgzdSOvFUo+5ssFSU0HYFlcBgE8u+IESy7fSpos8fIwymwZaqPWw0938gffiSVwo hJkw== X-Gm-Message-State: AC+VfDz+QDOoc2REE2Z1xSt1rnh1O1Y6H9pFygdKerwwTVskO0jg6ZNS 3c817VJ2z03B3kZ2zFZSxc0MYt/xuTf74Or2 X-Google-Smtp-Source: ACHHUZ7cmA0sJ9QADWgjwfMzq2kuOMC7XRYig5Jp+pUoXwxZyLkPEtN86QMvK1lpzyEoso+WnqMvtA== X-Received: by 2002:a05:600c:364b:b0:3f1:8af9:55ae with SMTP id y11-20020a05600c364b00b003f18af955aemr10525262wmq.18.1683647366996; Tue, 09 May 2023 08:49:26 -0700 (PDT) Return-Path: Received: from PC-PEDRO-ARCH.lan ([2001:8a0:7280:5801:9441:3dce:686c:bfc7]) by smtp.gmail.com with ESMTPSA id t25-20020a7bc3d9000000b003f42d3111b8sm1295463wmj.30.2023.05.09.08.49.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 09 May 2023 08:49:26 -0700 (PDT) From: "Pedro Falcato" To: devel@edk2.groups.io Cc: Pedro Falcato , =?UTF-8?q?Marvin=20H=C3=A4user?= Subject: [PATCH v3 2/2] Ext4Pkg: Advertise CSUM_SEED as supported Date: Tue, 9 May 2023 16:49:22 +0100 Message-Id: <20230509154922.278200-2-pedro.falcato@gmail.com> X-Mailer: git-send-email 2.40.1 In-Reply-To: <20230509154922.278200-1-pedro.falcato@gmail.com> References: <20230509154922.278200-1-pedro.falcato@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit We had added support for CSUM_SEED but accidentally forgot to advertise it in gSupportedIncompatFeat. This made it (erroneously) impossible to mount CSUM_SEED filesystems. Detected by attempting to mount a relatively new mkfs.ext4'd filesystem. Cc: Marvin Häuser Signed-off-by: Pedro Falcato Reviewed-by: Marvin Häuser --- Features/Ext4Pkg/Ext4Dxe/Superblock.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Features/Ext4Pkg/Ext4Dxe/Superblock.c b/Features/Ext4Pkg/Ext4Dxe/Superblock.c index 3f56de93c105..604925b582c1 100644 --- a/Features/Ext4Pkg/Ext4Dxe/Superblock.c +++ b/Features/Ext4Pkg/Ext4Dxe/Superblock.c @@ -1,7 +1,7 @@ /** @file Superblock managing routines - Copyright (c) 2021 - 2022 Pedro Falcato All rights reserved. + Copyright (c) 2021 - 2023 Pedro Falcato All rights reserved. SPDX-License-Identifier: BSD-2-Clause-Patent **/ @@ -18,7 +18,7 @@ STATIC CONST UINT32 gSupportedIncompatFeat = EXT4_FEATURE_INCOMPAT_64BIT | EXT4_FEATURE_INCOMPAT_DIRDATA | EXT4_FEATURE_INCOMPAT_FLEX_BG | EXT4_FEATURE_INCOMPAT_FILETYPE | EXT4_FEATURE_INCOMPAT_EXTENTS | EXT4_FEATURE_INCOMPAT_LARGEDIR | - EXT4_FEATURE_INCOMPAT_MMP | EXT4_FEATURE_INCOMPAT_RECOVER; + EXT4_FEATURE_INCOMPAT_MMP | EXT4_FEATURE_INCOMPAT_RECOVER | EXT4_FEATURE_INCOMPAT_CSUM_SEED; // Future features that may be nice additions in the future: // 1) Btree support: Required for write support and would speed up lookups in large directories. -- 2.40.1