public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
* [PATCH edk2-platforms 0/4] Remove usage of OvmfPkg/SataControllerDxe
@ 2023-05-09 16:14 Pedro Falcato
  2023-05-09 16:14 ` [PATCH edk2-platforms 1/4] QemuOpenBoardPkg: Use MdeModulePkg's SataControllerDxe Pedro Falcato
                   ` (4 more replies)
  0 siblings, 5 replies; 8+ messages in thread
From: Pedro Falcato @ 2023-05-09 16:14 UTC (permalink / raw)
  To: devel
  Cc: Pedro Falcato, Isaac Oram, Theo Jehl, Ard Biesheuvel,
	Leif Lindholm, Graeme Gregory, Radoslaw Biernacki, Bibo Mao,
	Xianglai li, Chao Li, Marcin Wojtas

As part of an effort undertaken by me (in another patchset) to unify and replace
OvmfPkg/SataControllerDxe with MdeModulePkg's, this patchset replaces all usage
of it with MdeModulePkg/Bus/Pci/SataControllerDxe.

The two drivers were forked from the same code and are mostly code-and-functionality
equivalent.

This patchset should *not* rely on the edk2 patchset, and should be merged before edk2's
(as to not break platforms).

Cc: Isaac Oram <isaac.w.oram@intel.com>
Cc: Theo Jehl <theojehl76@gmail.com>
Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
Cc: Leif Lindholm <quic_llindhol@quicinc.com>
Cc: Graeme Gregory <graeme@xora.org.uk>
Cc: Radoslaw Biernacki <rad@semihalf.com>
Cc: Bibo Mao <maobibo@loongson.cn>
Cc: Xianglai li <lixianglai@loongson.cn>
Cc: Chao Li <lichao@loongson.cn>
Cc: Marcin Wojtas <mw@semihalf.com>

Pedro Falcato (4):
  QemuOpenBoardPkg: Use MdeModulePkg's SataControllerDxe
  SbsaQemu: Use MdeModulePkg's SataControllerDxe
  LoongArchQemuPkg: Use MdeModulePkg's SataControllerDxe
  Silicon/Armada7k8k: Use MdeModulePkg's SataControllerDxe

 Platform/Loongson/LoongArchQemuPkg/Loongson.dsc           | 2 +-
 Platform/Loongson/LoongArchQemuPkg/Loongson.fdf           | 2 +-
 Platform/Qemu/QemuOpenBoardPkg/Include/Dsc/Stage4.dsc.inc | 2 +-
 Platform/Qemu/QemuOpenBoardPkg/QemuOpenBoardPkg.dsc       | 2 +-
 Platform/Qemu/QemuOpenBoardPkg/QemuOpenBoardPkg.fdf       | 2 +-
 Platform/Qemu/SbsaQemu/SbsaQemu.dsc                       | 2 +-
 Platform/Qemu/SbsaQemu/SbsaQemu.fdf                       | 2 +-
 Silicon/Marvell/Armada7k8k/Armada7k8k.dsc.inc             | 2 +-
 Silicon/Marvell/Armada7k8k/Armada7k8k.fdf                 | 2 +-
 9 files changed, 9 insertions(+), 9 deletions(-)

-- 
2.40.1


^ permalink raw reply	[flat|nested] 8+ messages in thread

* [PATCH edk2-platforms 1/4] QemuOpenBoardPkg: Use MdeModulePkg's SataControllerDxe
  2023-05-09 16:14 [PATCH edk2-platforms 0/4] Remove usage of OvmfPkg/SataControllerDxe Pedro Falcato
@ 2023-05-09 16:14 ` Pedro Falcato
  2023-05-09 22:13   ` [edk2-devel] " Isaac Oram
  2023-05-09 16:14 ` [PATCH edk2-platforms 2/4] SbsaQemu: " Pedro Falcato
                   ` (3 subsequent siblings)
  4 siblings, 1 reply; 8+ messages in thread
From: Pedro Falcato @ 2023-05-09 16:14 UTC (permalink / raw)
  To: devel; +Cc: Pedro Falcato, Isaac Oram, Theo Jehl

As part of an effort to remove OvmfPkg/SataControllerDxe, switch to the
generic version in MdeModulePkg.

Tested-by: Pedro Falcato <pedro.falcato@gmail.com>
Cc: Isaac Oram <isaac.w.oram@intel.com>
Cc: Theo Jehl <theojehl76@gmail.com>
Signed-off-by: Pedro Falcato <pedro.falcato@gmail.com>
---
 Platform/Qemu/QemuOpenBoardPkg/Include/Dsc/Stage4.dsc.inc | 2 +-
 Platform/Qemu/QemuOpenBoardPkg/QemuOpenBoardPkg.dsc       | 2 +-
 Platform/Qemu/QemuOpenBoardPkg/QemuOpenBoardPkg.fdf       | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/Platform/Qemu/QemuOpenBoardPkg/Include/Dsc/Stage4.dsc.inc b/Platform/Qemu/QemuOpenBoardPkg/Include/Dsc/Stage4.dsc.inc
index 283c235b44c0..5a63848f26cd 100644
--- a/Platform/Qemu/QemuOpenBoardPkg/Include/Dsc/Stage4.dsc.inc
+++ b/Platform/Qemu/QemuOpenBoardPkg/Include/Dsc/Stage4.dsc.inc
@@ -21,7 +21,7 @@
 [Components.$(DXE_ARCH)]
   OvmfPkg/AcpiPlatformDxe/AcpiPlatformDxe.inf
   MdeModulePkg/Universal/Acpi/AcpiTableDxe/AcpiTableDxe.inf
-  OvmfPkg/SataControllerDxe/SataControllerDxe.inf
+  MdeModulePkg/Bus/Pci/SataControllerDxe/SataControllerDxe.inf
   MdeModulePkg/Bus/Ata/AtaAtapiPassThru/AtaAtapiPassThru.inf
   MdeModulePkg/Bus/Ata/AtaBusDxe/AtaBusDxe.inf
   MdeModulePkg/Bus/Pci/UhciDxe/UhciDxe.inf
diff --git a/Platform/Qemu/QemuOpenBoardPkg/QemuOpenBoardPkg.dsc b/Platform/Qemu/QemuOpenBoardPkg/QemuOpenBoardPkg.dsc
index f5c317c83e6a..b409a6164412 100644
--- a/Platform/Qemu/QemuOpenBoardPkg/QemuOpenBoardPkg.dsc
+++ b/Platform/Qemu/QemuOpenBoardPkg/QemuOpenBoardPkg.dsc
@@ -160,7 +160,7 @@
 [Components.$(DXE_ARCH)]
   MdeModulePkg/Bus/Scsi/ScsiBusDxe/ScsiBusDxe.inf
   MdeModulePkg/Bus/Scsi/ScsiDiskDxe/ScsiDiskDxe.inf
-  OvmfPkg/SataControllerDxe/SataControllerDxe.inf
+  MdeModulePkg/Bus/Pci/SataControllerDxe/SataControllerDxe.inf
   MdeModulePkg/Bus/Ata/AtaAtapiPassThru/AtaAtapiPassThru.inf
   MdeModulePkg/Bus/Ata/AtaBusDxe/AtaBusDxe.inf
   MdeModulePkg/Bus/Pci/NvmExpressDxe/NvmExpressDxe.inf
diff --git a/Platform/Qemu/QemuOpenBoardPkg/QemuOpenBoardPkg.fdf b/Platform/Qemu/QemuOpenBoardPkg/QemuOpenBoardPkg.fdf
index 5af0f0f2faa2..b106828460a9 100644
--- a/Platform/Qemu/QemuOpenBoardPkg/QemuOpenBoardPkg.fdf
+++ b/Platform/Qemu/QemuOpenBoardPkg/QemuOpenBoardPkg.fdf
@@ -266,7 +266,7 @@ SET gMinPlatformPkgTokenSpaceGuid.PcdFlashAreaSize             = 0x800000
   INF MdeModulePkg/Bus/Scsi/ScsiBusDxe/ScsiBusDxe.inf
   INF MdeModulePkg/Bus/Scsi/ScsiDiskDxe/ScsiDiskDxe.inf
 
-  INF OvmfPkg/SataControllerDxe/SataControllerDxe.inf
+  INF MdeModulePkg/Bus/Pci/SataControllerDxe/SataControllerDxe.inf
 
   INF MdeModulePkg/Bus/Ata/AtaAtapiPassThru/AtaAtapiPassThru.inf
   INF MdeModulePkg/Bus/Ata/AtaBusDxe/AtaBusDxe.inf
-- 
2.40.1


^ permalink raw reply related	[flat|nested] 8+ messages in thread

* [PATCH edk2-platforms 2/4] SbsaQemu: Use MdeModulePkg's SataControllerDxe
  2023-05-09 16:14 [PATCH edk2-platforms 0/4] Remove usage of OvmfPkg/SataControllerDxe Pedro Falcato
  2023-05-09 16:14 ` [PATCH edk2-platforms 1/4] QemuOpenBoardPkg: Use MdeModulePkg's SataControllerDxe Pedro Falcato
@ 2023-05-09 16:14 ` Pedro Falcato
  2023-05-09 16:14 ` [PATCH edk2-platforms 3/4] LoongArchQemuPkg: " Pedro Falcato
                   ` (2 subsequent siblings)
  4 siblings, 0 replies; 8+ messages in thread
From: Pedro Falcato @ 2023-05-09 16:14 UTC (permalink / raw)
  To: devel
  Cc: Pedro Falcato, Ard Biesheuvel, Leif Lindholm, Graeme Gregory,
	Radoslaw Biernacki

As part of an effort to remove OvmfPkg/SataControllerDxe, switch to the
generic version in MdeModulePkg.

Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
Cc: Leif Lindholm <quic_llindhol@quicinc.com>
Cc: Graeme Gregory <graeme@xora.org.uk>
Cc: Radoslaw Biernacki <rad@semihalf.com>
Signed-off-by: Pedro Falcato <pedro.falcato@gmail.com>
---
 Platform/Qemu/SbsaQemu/SbsaQemu.dsc | 2 +-
 Platform/Qemu/SbsaQemu/SbsaQemu.fdf | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/Platform/Qemu/SbsaQemu/SbsaQemu.dsc b/Platform/Qemu/SbsaQemu/SbsaQemu.dsc
index 79dd200ca7fc..9ca030cfe9a7 100644
--- a/Platform/Qemu/SbsaQemu/SbsaQemu.dsc
+++ b/Platform/Qemu/SbsaQemu/SbsaQemu.dsc
@@ -705,7 +705,7 @@ DEFINE NETWORK_HTTP_BOOT_ENABLE       = FALSE
   MdeModulePkg/Bus/Pci/NonDiscoverablePciDeviceDxe/NonDiscoverablePciDeviceDxe.inf
 
   # IDE/AHCI Support
-  OvmfPkg/SataControllerDxe/SataControllerDxe.inf
+  MdeModulePkg/Bus/Pci/SataControllerDxe/SataControllerDxe.inf
   MdeModulePkg/Bus/Ata/AtaAtapiPassThru/AtaAtapiPassThru.inf
   MdeModulePkg/Bus/Ata/AtaBusDxe/AtaBusDxe.inf
 
diff --git a/Platform/Qemu/SbsaQemu/SbsaQemu.fdf b/Platform/Qemu/SbsaQemu/SbsaQemu.fdf
index 781215707c3d..677cea6344dc 100644
--- a/Platform/Qemu/SbsaQemu/SbsaQemu.fdf
+++ b/Platform/Qemu/SbsaQemu/SbsaQemu.fdf
@@ -298,7 +298,7 @@ READ_LOCK_STATUS   = TRUE
   INF MdeModulePkg/Core/DxeIplPeim/DxeIpl.inf
 
   # IDE/AHCI Support
-  INF OvmfPkg/SataControllerDxe/SataControllerDxe.inf
+  INF MdeModulePkg/Bus/Pci/SataControllerDxe/SataControllerDxe.inf
   INF MdeModulePkg/Bus/Ata/AtaAtapiPassThru/AtaAtapiPassThru.inf
   INF MdeModulePkg/Bus/Ata/AtaBusDxe/AtaBusDxe.inf
   INF MdeModulePkg/Bus/Scsi/ScsiBusDxe/ScsiBusDxe.inf
-- 
2.40.1


^ permalink raw reply related	[flat|nested] 8+ messages in thread

* [PATCH edk2-platforms 3/4] LoongArchQemuPkg: Use MdeModulePkg's SataControllerDxe
  2023-05-09 16:14 [PATCH edk2-platforms 0/4] Remove usage of OvmfPkg/SataControllerDxe Pedro Falcato
  2023-05-09 16:14 ` [PATCH edk2-platforms 1/4] QemuOpenBoardPkg: Use MdeModulePkg's SataControllerDxe Pedro Falcato
  2023-05-09 16:14 ` [PATCH edk2-platforms 2/4] SbsaQemu: " Pedro Falcato
@ 2023-05-09 16:14 ` Pedro Falcato
  2023-05-10  3:16   ` [edk2-devel] " Chao Li
  2023-05-09 16:14 ` [PATCH edk2-platforms 4/4] Silicon/Armada7k8k: " Pedro Falcato
  2023-05-10  6:16 ` [PATCH edk2-platforms 0/4] Remove usage of OvmfPkg/SataControllerDxe Ard Biesheuvel
  4 siblings, 1 reply; 8+ messages in thread
From: Pedro Falcato @ 2023-05-09 16:14 UTC (permalink / raw)
  To: devel; +Cc: Pedro Falcato, Bibo Mao, Xianglai li, Chao Li

As part of an effort to remove OvmfPkg/SataControllerDxe, switch to the
generic version in MdeModulePkg.

Cc: Bibo Mao <maobibo@loongson.cn>
Cc: Xianglai li <lixianglai@loongson.cn>
Cc: Chao Li <lichao@loongson.cn>
Signed-off-by: Pedro Falcato <pedro.falcato@gmail.com>
---
 Platform/Loongson/LoongArchQemuPkg/Loongson.dsc | 2 +-
 Platform/Loongson/LoongArchQemuPkg/Loongson.fdf | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/Platform/Loongson/LoongArchQemuPkg/Loongson.dsc b/Platform/Loongson/LoongArchQemuPkg/Loongson.dsc
index 465e9229a2c4..6875e39cc604 100644
--- a/Platform/Loongson/LoongArchQemuPkg/Loongson.dsc
+++ b/Platform/Loongson/LoongArchQemuPkg/Loongson.dsc
@@ -550,7 +550,7 @@
   #
   # IDE/SCSI
   #
-  OvmfPkg/SataControllerDxe/SataControllerDxe.inf
+  MdeModulePkg/Bus/Pci/SataControllerDxe/SataControllerDxe.inf
   MdeModulePkg/Bus/Scsi/ScsiBusDxe/ScsiBusDxe.inf
   MdeModulePkg/Bus/Scsi/ScsiDiskDxe/ScsiDiskDxe.inf
 
diff --git a/Platform/Loongson/LoongArchQemuPkg/Loongson.fdf b/Platform/Loongson/LoongArchQemuPkg/Loongson.fdf
index 03cbcf86301b..8a759c0238ee 100644
--- a/Platform/Loongson/LoongArchQemuPkg/Loongson.fdf
+++ b/Platform/Loongson/LoongArchQemuPkg/Loongson.fdf
@@ -178,7 +178,7 @@ INF  OvmfPkg/PlatformDxe/Platform.inf
 #
 # SATA/SCSI
 #
-INF  OvmfPkg/SataControllerDxe/SataControllerDxe.inf
+INF  MdeModulePkg/Bus/Pci/SataControllerDxe/SataControllerDxe.inf
 INF  MdeModulePkg/Bus/Scsi/ScsiBusDxe/ScsiBusDxe.inf
 INF  MdeModulePkg/Bus/Scsi/ScsiDiskDxe/ScsiDiskDxe.inf
 
-- 
2.40.1


^ permalink raw reply related	[flat|nested] 8+ messages in thread

* [PATCH edk2-platforms 4/4] Silicon/Armada7k8k: Use MdeModulePkg's SataControllerDxe
  2023-05-09 16:14 [PATCH edk2-platforms 0/4] Remove usage of OvmfPkg/SataControllerDxe Pedro Falcato
                   ` (2 preceding siblings ...)
  2023-05-09 16:14 ` [PATCH edk2-platforms 3/4] LoongArchQemuPkg: " Pedro Falcato
@ 2023-05-09 16:14 ` Pedro Falcato
  2023-05-10  6:16 ` [PATCH edk2-platforms 0/4] Remove usage of OvmfPkg/SataControllerDxe Ard Biesheuvel
  4 siblings, 0 replies; 8+ messages in thread
From: Pedro Falcato @ 2023-05-09 16:14 UTC (permalink / raw)
  To: devel; +Cc: Pedro Falcato, Leif Lindholm, Marcin Wojtas

As part of an effort to remove OvmfPkg/SataControllerDxe, switch to the
generic version in MdeModulePkg.

Cc: Leif Lindholm <quic_llindhol@quicinc.com>
Cc: Marcin Wojtas <mw@semihalf.com>
Signed-off-by: Pedro Falcato <pedro.falcato@gmail.com>
---
 Silicon/Marvell/Armada7k8k/Armada7k8k.dsc.inc | 2 +-
 Silicon/Marvell/Armada7k8k/Armada7k8k.fdf     | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/Silicon/Marvell/Armada7k8k/Armada7k8k.dsc.inc b/Silicon/Marvell/Armada7k8k/Armada7k8k.dsc.inc
index b64c0ffdeed9..a135cb88b898 100644
--- a/Silicon/Marvell/Armada7k8k/Armada7k8k.dsc.inc
+++ b/Silicon/Marvell/Armada7k8k/Armada7k8k.dsc.inc
@@ -492,7 +492,7 @@
   # SATA
   MdeModulePkg/Bus/Ata/AtaAtapiPassThru/AtaAtapiPassThru.inf
   MdeModulePkg/Bus/Ata/AtaBusDxe/AtaBusDxe.inf
-  OvmfPkg/SataControllerDxe/SataControllerDxe.inf
+  MdeModulePkg/Bus/Pci/SataControllerDxe/SataControllerDxe.inf
 
   # USB
   MdeModulePkg/Bus/Pci/XhciDxe/XhciDxe.inf
diff --git a/Silicon/Marvell/Armada7k8k/Armada7k8k.fdf b/Silicon/Marvell/Armada7k8k/Armada7k8k.fdf
index bc7284652bbd..ffde102dcfc0 100644
--- a/Silicon/Marvell/Armada7k8k/Armada7k8k.fdf
+++ b/Silicon/Marvell/Armada7k8k/Armada7k8k.fdf
@@ -145,7 +145,7 @@ FvNameGuid         = 5eda4200-2c5f-43cb-9da3-0baf74b1b30c
   # SATA
   INF MdeModulePkg/Bus/Ata/AtaAtapiPassThru/AtaAtapiPassThru.inf
   INF MdeModulePkg/Bus/Ata/AtaBusDxe/AtaBusDxe.inf
-  INF OvmfPkg/SataControllerDxe/SataControllerDxe.inf
+  INF MdeModulePkg/Bus/Pci/SataControllerDxe/SataControllerDxe.inf
 
   # USB
   INF MdeModulePkg/Bus/Pci/XhciDxe/XhciDxe.inf
-- 
2.40.1


^ permalink raw reply related	[flat|nested] 8+ messages in thread

* Re: [edk2-devel] [PATCH edk2-platforms 1/4] QemuOpenBoardPkg: Use MdeModulePkg's SataControllerDxe
  2023-05-09 16:14 ` [PATCH edk2-platforms 1/4] QemuOpenBoardPkg: Use MdeModulePkg's SataControllerDxe Pedro Falcato
@ 2023-05-09 22:13   ` Isaac Oram
  0 siblings, 0 replies; 8+ messages in thread
From: Isaac Oram @ 2023-05-09 22:13 UTC (permalink / raw)
  To: devel@edk2.groups.io, pedro.falcato@gmail.com; +Cc: Theo Jehl

Reviewed-by: Isaac Oram <isaac.w.oram@intel.com>

-----Original Message-----
From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Pedro Falcato
Sent: Tuesday, May 9, 2023 9:15 AM
To: devel@edk2.groups.io
Cc: Pedro Falcato <pedro.falcato@gmail.com>; Oram, Isaac W <isaac.w.oram@intel.com>; Theo Jehl <theojehl76@gmail.com>
Subject: [edk2-devel] [PATCH edk2-platforms 1/4] QemuOpenBoardPkg: Use MdeModulePkg's SataControllerDxe

As part of an effort to remove OvmfPkg/SataControllerDxe, switch to the generic version in MdeModulePkg.

Tested-by: Pedro Falcato <pedro.falcato@gmail.com>
Cc: Isaac Oram <isaac.w.oram@intel.com>
Cc: Theo Jehl <theojehl76@gmail.com>
Signed-off-by: Pedro Falcato <pedro.falcato@gmail.com>
---
 Platform/Qemu/QemuOpenBoardPkg/Include/Dsc/Stage4.dsc.inc | 2 +-
 Platform/Qemu/QemuOpenBoardPkg/QemuOpenBoardPkg.dsc       | 2 +-
 Platform/Qemu/QemuOpenBoardPkg/QemuOpenBoardPkg.fdf       | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/Platform/Qemu/QemuOpenBoardPkg/Include/Dsc/Stage4.dsc.inc b/Platform/Qemu/QemuOpenBoardPkg/Include/Dsc/Stage4.dsc.inc
index 283c235b44c0..5a63848f26cd 100644
--- a/Platform/Qemu/QemuOpenBoardPkg/Include/Dsc/Stage4.dsc.inc
+++ b/Platform/Qemu/QemuOpenBoardPkg/Include/Dsc/Stage4.dsc.inc
@@ -21,7 +21,7 @@
 [Components.$(DXE_ARCH)]
   OvmfPkg/AcpiPlatformDxe/AcpiPlatformDxe.inf
   MdeModulePkg/Universal/Acpi/AcpiTableDxe/AcpiTableDxe.inf
-  OvmfPkg/SataControllerDxe/SataControllerDxe.inf
+  MdeModulePkg/Bus/Pci/SataControllerDxe/SataControllerDxe.inf
   MdeModulePkg/Bus/Ata/AtaAtapiPassThru/AtaAtapiPassThru.inf
   MdeModulePkg/Bus/Ata/AtaBusDxe/AtaBusDxe.inf
   MdeModulePkg/Bus/Pci/UhciDxe/UhciDxe.inf
diff --git a/Platform/Qemu/QemuOpenBoardPkg/QemuOpenBoardPkg.dsc b/Platform/Qemu/QemuOpenBoardPkg/QemuOpenBoardPkg.dsc
index f5c317c83e6a..b409a6164412 100644
--- a/Platform/Qemu/QemuOpenBoardPkg/QemuOpenBoardPkg.dsc
+++ b/Platform/Qemu/QemuOpenBoardPkg/QemuOpenBoardPkg.dsc
@@ -160,7 +160,7 @@
 [Components.$(DXE_ARCH)]
   MdeModulePkg/Bus/Scsi/ScsiBusDxe/ScsiBusDxe.inf
   MdeModulePkg/Bus/Scsi/ScsiDiskDxe/ScsiDiskDxe.inf
-  OvmfPkg/SataControllerDxe/SataControllerDxe.inf
+  MdeModulePkg/Bus/Pci/SataControllerDxe/SataControllerDxe.inf
   MdeModulePkg/Bus/Ata/AtaAtapiPassThru/AtaAtapiPassThru.inf
   MdeModulePkg/Bus/Ata/AtaBusDxe/AtaBusDxe.inf
   MdeModulePkg/Bus/Pci/NvmExpressDxe/NvmExpressDxe.inf
diff --git a/Platform/Qemu/QemuOpenBoardPkg/QemuOpenBoardPkg.fdf b/Platform/Qemu/QemuOpenBoardPkg/QemuOpenBoardPkg.fdf
index 5af0f0f2faa2..b106828460a9 100644
--- a/Platform/Qemu/QemuOpenBoardPkg/QemuOpenBoardPkg.fdf
+++ b/Platform/Qemu/QemuOpenBoardPkg/QemuOpenBoardPkg.fdf
@@ -266,7 +266,7 @@ SET gMinPlatformPkgTokenSpaceGuid.PcdFlashAreaSize             = 0x800000
   INF MdeModulePkg/Bus/Scsi/ScsiBusDxe/ScsiBusDxe.inf
   INF MdeModulePkg/Bus/Scsi/ScsiDiskDxe/ScsiDiskDxe.inf
 
-  INF OvmfPkg/SataControllerDxe/SataControllerDxe.inf
+  INF MdeModulePkg/Bus/Pci/SataControllerDxe/SataControllerDxe.inf
 
   INF MdeModulePkg/Bus/Ata/AtaAtapiPassThru/AtaAtapiPassThru.inf
   INF MdeModulePkg/Bus/Ata/AtaBusDxe/AtaBusDxe.inf
--
2.40.1







^ permalink raw reply related	[flat|nested] 8+ messages in thread

* Re: [edk2-devel] [PATCH edk2-platforms 3/4] LoongArchQemuPkg: Use MdeModulePkg's SataControllerDxe
  2023-05-09 16:14 ` [PATCH edk2-platforms 3/4] LoongArchQemuPkg: " Pedro Falcato
@ 2023-05-10  3:16   ` Chao Li
  0 siblings, 0 replies; 8+ messages in thread
From: Chao Li @ 2023-05-10  3:16 UTC (permalink / raw)
  To: devel, pedro.falcato; +Cc: Bibo Mao, Xianglai li

[-- Attachment #1: Type: text/plain, Size: 1779 bytes --]

If ther driver is ok in the MdeModulePkg version, that's fine.

Reviewed-by: Chao Li <lichao@loongson.cn>


Thanks,
Chao
在 2023/5/10 00:14, Pedro Falcato 写道:
> As part of an effort to remove OvmfPkg/SataControllerDxe, switch to the
> generic version in MdeModulePkg.
>
> Cc: Bibo Mao<maobibo@loongson.cn>
> Cc: Xianglai li<lixianglai@loongson.cn>
> Cc: Chao Li<lichao@loongson.cn>
> Signed-off-by: Pedro Falcato<pedro.falcato@gmail.com>
> ---
>   Platform/Loongson/LoongArchQemuPkg/Loongson.dsc | 2 +-
>   Platform/Loongson/LoongArchQemuPkg/Loongson.fdf | 2 +-
>   2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/Platform/Loongson/LoongArchQemuPkg/Loongson.dsc b/Platform/Loongson/LoongArchQemuPkg/Loongson.dsc
> index 465e9229a2c4..6875e39cc604 100644
> --- a/Platform/Loongson/LoongArchQemuPkg/Loongson.dsc
> +++ b/Platform/Loongson/LoongArchQemuPkg/Loongson.dsc
> @@ -550,7 +550,7 @@
>     #
>     # IDE/SCSI
>     #
> -  OvmfPkg/SataControllerDxe/SataControllerDxe.inf
> +  MdeModulePkg/Bus/Pci/SataControllerDxe/SataControllerDxe.inf
>     MdeModulePkg/Bus/Scsi/ScsiBusDxe/ScsiBusDxe.inf
>     MdeModulePkg/Bus/Scsi/ScsiDiskDxe/ScsiDiskDxe.inf
>   
> diff --git a/Platform/Loongson/LoongArchQemuPkg/Loongson.fdf b/Platform/Loongson/LoongArchQemuPkg/Loongson.fdf
> index 03cbcf86301b..8a759c0238ee 100644
> --- a/Platform/Loongson/LoongArchQemuPkg/Loongson.fdf
> +++ b/Platform/Loongson/LoongArchQemuPkg/Loongson.fdf
> @@ -178,7 +178,7 @@ INF  OvmfPkg/PlatformDxe/Platform.inf
>   #
>   # SATA/SCSI
>   #
> -INF  OvmfPkg/SataControllerDxe/SataControllerDxe.inf
> +INF  MdeModulePkg/Bus/Pci/SataControllerDxe/SataControllerDxe.inf
>   INF  MdeModulePkg/Bus/Scsi/ScsiBusDxe/ScsiBusDxe.inf
>   INF  MdeModulePkg/Bus/Scsi/ScsiDiskDxe/ScsiDiskDxe.inf
>   

[-- Attachment #2: Type: text/html, Size: 2782 bytes --]

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH edk2-platforms 0/4] Remove usage of OvmfPkg/SataControllerDxe
  2023-05-09 16:14 [PATCH edk2-platforms 0/4] Remove usage of OvmfPkg/SataControllerDxe Pedro Falcato
                   ` (3 preceding siblings ...)
  2023-05-09 16:14 ` [PATCH edk2-platforms 4/4] Silicon/Armada7k8k: " Pedro Falcato
@ 2023-05-10  6:16 ` Ard Biesheuvel
  4 siblings, 0 replies; 8+ messages in thread
From: Ard Biesheuvel @ 2023-05-10  6:16 UTC (permalink / raw)
  To: Pedro Falcato
  Cc: devel, Isaac Oram, Theo Jehl, Ard Biesheuvel, Leif Lindholm,
	Graeme Gregory, Radoslaw Biernacki, Bibo Mao, Xianglai li,
	Chao Li, Marcin Wojtas

On Tue, 9 May 2023 at 18:14, Pedro Falcato <pedro.falcato@gmail.com> wrote:
>
> As part of an effort undertaken by me (in another patchset) to unify and replace
> OvmfPkg/SataControllerDxe with MdeModulePkg's, this patchset replaces all usage
> of it with MdeModulePkg/Bus/Pci/SataControllerDxe.
>
> The two drivers were forked from the same code and are mostly code-and-functionality
> equivalent.
>
> This patchset should *not* rely on the edk2 patchset, and should be merged before edk2's
> (as to not break platforms).
>
> Cc: Isaac Oram <isaac.w.oram@intel.com>
> Cc: Theo Jehl <theojehl76@gmail.com>
> Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
> Cc: Leif Lindholm <quic_llindhol@quicinc.com>
> Cc: Graeme Gregory <graeme@xora.org.uk>
> Cc: Radoslaw Biernacki <rad@semihalf.com>
> Cc: Bibo Mao <maobibo@loongson.cn>
> Cc: Xianglai li <lixianglai@loongson.cn>
> Cc: Chao Li <lichao@loongson.cn>
> Cc: Marcin Wojtas <mw@semihalf.com>
>
> Pedro Falcato (4):
>   QemuOpenBoardPkg: Use MdeModulePkg's SataControllerDxe
>   SbsaQemu: Use MdeModulePkg's SataControllerDxe
>   LoongArchQemuPkg: Use MdeModulePkg's SataControllerDxe
>   Silicon/Armada7k8k: Use MdeModulePkg's SataControllerDxe
>

Series pushed as c91f8862ae87..42a677e992d2

Thanks,

^ permalink raw reply	[flat|nested] 8+ messages in thread

end of thread, other threads:[~2023-05-10  6:16 UTC | newest]

Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-05-09 16:14 [PATCH edk2-platforms 0/4] Remove usage of OvmfPkg/SataControllerDxe Pedro Falcato
2023-05-09 16:14 ` [PATCH edk2-platforms 1/4] QemuOpenBoardPkg: Use MdeModulePkg's SataControllerDxe Pedro Falcato
2023-05-09 22:13   ` [edk2-devel] " Isaac Oram
2023-05-09 16:14 ` [PATCH edk2-platforms 2/4] SbsaQemu: " Pedro Falcato
2023-05-09 16:14 ` [PATCH edk2-platforms 3/4] LoongArchQemuPkg: " Pedro Falcato
2023-05-10  3:16   ` [edk2-devel] " Chao Li
2023-05-09 16:14 ` [PATCH edk2-platforms 4/4] Silicon/Armada7k8k: " Pedro Falcato
2023-05-10  6:16 ` [PATCH edk2-platforms 0/4] Remove usage of OvmfPkg/SataControllerDxe Ard Biesheuvel

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox