From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f43.google.com (mail-wm1-f43.google.com [209.85.128.43]) by mx.groups.io with SMTP id smtpd.web11.37798.1683649945555927799 for ; Tue, 09 May 2023 09:32:25 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="signature has expired" header.i=@gmail.com header.s=20221208 header.b=qm1reh6F; spf=pass (domain: gmail.com, ip: 209.85.128.43, mailfrom: pedro.falcato@gmail.com) Received: by mail-wm1-f43.google.com with SMTP id 5b1f17b1804b1-3f42ba32e24so7178975e9.3 for ; Tue, 09 May 2023 09:32:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1683649944; x=1686241944; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=l8FOV5ze78gvcgEeCwPqbvm8lui2b+1GU4GYakZ1IK0=; b=qm1reh6F84HTlNMJtH7h3HCa49orPKsZu84ilNzkvcZ5RK+REdlHSwtM77oZcZgclk OEsT9cnK2ILdi/z//YuGSMtqJg1fN6gIa5glwMLlYPC/AnCBzxWhR1HkM92oyb9mHa/R BZu3XHOVG13z2kCsZ1RrJ28gZuz5FZEgfE0SCLESiMVM6amxcZFrnfhveS24BySzwnWm eBP4uQdET4xrDiODAD3+z1zSroySERBGBb3yImmqCAD+SBp6L+D2pSUezDANUu70bfPy eAhFxLa+LpQIQTmGskZvbznjrkVx6rlK73wDIlhtRAlPzjUGyrFzZ9HS3heHL5DuiROG qA9Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1683649944; x=1686241944; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=l8FOV5ze78gvcgEeCwPqbvm8lui2b+1GU4GYakZ1IK0=; b=jNY0ATpMw/t7JqZRIIA+Ju+UbqoRIeXvHoMjCCRDBHCdfjV+m8mlmkq5szIzE0jrRb IvRKh4HeDWBaLVSQeSf/g9eNFzyWsbtqaFmMpnKV0v/p1RZlHClYq0qSHIWkz/UcVe5R JqxryVauxuw1rGHr7iv4Lq+Jn66bi+NhL1uCQ3ANYYOWaHHIXIwAL9qtZZnmf7vaECo2 O7UASuysUSP5X3gXKEYcPnBmXRm5uOvEdq495dFrpN09lhIyKQRkPbI/yyqZYHeathKR V3CMcEf45JW+uF8MsU8wys9+w3I810bHfb5HYPdMiZoSOwNgtiTxuYzH2QCbmtO7jHwu T0lg== X-Gm-Message-State: AC+VfDz0LCJ+Z7F7VqdsKulbcaUv9jFO2GTdM8+dycsXV10t3AA/7KnU 6dAFC//hUs59yo0pZFcEpep8BiiiO7ab4jcj X-Google-Smtp-Source: ACHHUZ7pRDKw5Opsf9WRQZWDS6zgysC7kdYG9jbhqm9s0B2AeB1wf11pdm2nVvVQNrcRvsqNGCS31w== X-Received: by 2002:a1c:721a:0:b0:3f1:7277:eaa with SMTP id n26-20020a1c721a000000b003f172770eaamr10549904wmc.31.1683649943763; Tue, 09 May 2023 09:32:23 -0700 (PDT) Return-Path: Received: from PC-PEDRO-ARCH.lan ([2001:8a0:7280:5801:9441:3dce:686c:bfc7]) by smtp.gmail.com with ESMTPSA id p1-20020a05600c204100b003f0a6a1f969sm20363938wmg.46.2023.05.09.09.32.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 09 May 2023 09:32:23 -0700 (PDT) From: "Pedro Falcato" To: devel@edk2.groups.io Cc: Laszlo Ersek , Pedro Falcato , Ard Biesheuvel , Jiewen Yao , Gerd Hoffmann , Erdem Aktas , James Bottomley , Min Xu , Tom Lendacky , Michael Roth , Rebecca Cran , Peter Grehan , =?UTF-8?q?Corvin=20K=C3=B6hne?= , Sebastien Boeuf , Anthony Perard , Julien Grall Subject: [PATCH v2 00/12] OvmfPkg: Replace the OVMF-specific SataControllerDxe with the generic one Date: Tue, 9 May 2023 17:32:00 +0100 Message-Id: <20230509163212.291333-1-pedro.falcato@gmail.com> X-Mailer: git-send-email 2.40.1 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit This patch-set replaces the OVMF specific SataControllerDxe with the MdeModulePkg/Bus/Pci one. They were both forked from the same code, and are code-and-functionality similar. As such, there seems to be no need for duplication here. The first four pages both replay OvmfPkg/SataControllerDxe commits and fix up a couple of details. The rest of the patches (minus the last) replace OvmfPkg/SataControllerDxe with the MdeModulePkg variant. The last patch, finally, removes the thing. Tested by booting in QEMU (Q35 (AHCI) and PC (IDE)). More testing from other, alternative platforms is desired, although breakage seems unlikely. This patchset (or at least, the last patch) depends on the edk2-platforms patch series to get merged. (+CC Laszlo as the author of the original SataControllerDxe patches) Cc: Ard Biesheuvel Cc: Jiewen Yao Cc :Jordan Justen Cc: Gerd Hoffmann Cc: Erdem Aktas Cc: James Bottomley Cc: Min Xu Cc: Tom Lendacky Cc: Michael Roth Cc: Rebecca Cran Cc: Peter Grehan Cc: Corvin Köhne Cc: Sebastien Boeuf Cc: Anthony Perard Cc: Julien Grall Cc: Laszlo Ersek Changes: v2: - Address Laszlo's feedback wrt commit to port into MdeModulePkg - Address Laszlo's feedback wrt how to split the removal of the driver and the patches for each sub-platform maintainer - Address Mike Maslenkin's feedback on the preexisting ASSERTs (Private != NULL) - Add Gerd's ACK and Tested-by (conservatively) to patches 6 and 12 (since they are remotely QEMU related) Pedro Falcato (12): MdeModulePkg/SataControllerDxe: Clean up error handling in Start() MdeModulePkg/SataControllerDxe: Log expected errors at DEBUG_INFO level MdeModulePkg/SataControllerDxe: Remove useless null check MdeModulePkg/SataControllerDxe: Fix up ASSERTS (Private != NULL) OvmfPkg: Replace the OVMF-specific SataControllerDxe OvmfPkg/Microvm: Replace the OVMF-specific SataControllerDxe OvmfPkg/Bhyve: Replace the OVMF-specific SataControllerDxe OvmfPkg/CloudHv: Replace the OVMF-specific SataControllerDxe OvmfPkg/IntelTdx: Replace the OVMF-specific SataControllerDxe OvmfPkg/AmdSev: Replace the OVMF-specific SataControllerDxe OvmfPkg/Xen: Replace the OVMF-specific SataControllerDxe OvmfPkg: Remove SataControllerDxe .../Pci/SataControllerDxe/SataController.c | 146 ++- OvmfPkg/AmdSev/AmdSevX64.dsc | 2 +- OvmfPkg/AmdSev/AmdSevX64.fdf | 2 +- OvmfPkg/Bhyve/BhyveX64.dsc | 2 +- OvmfPkg/Bhyve/BhyveX64.fdf | 2 +- OvmfPkg/CloudHv/CloudHvX64.dsc | 2 +- OvmfPkg/CloudHv/CloudHvX64.fdf | 2 +- OvmfPkg/IntelTdx/IntelTdxX64.dsc | 2 +- OvmfPkg/IntelTdx/IntelTdxX64.fdf | 2 +- OvmfPkg/Microvm/MicrovmX64.dsc | 2 +- OvmfPkg/Microvm/MicrovmX64.fdf | 2 +- OvmfPkg/OvmfPkgIa32.dsc | 2 +- OvmfPkg/OvmfPkgIa32.fdf | 2 +- OvmfPkg/OvmfPkgIa32X64.dsc | 2 +- OvmfPkg/OvmfPkgIa32X64.fdf | 2 +- OvmfPkg/OvmfPkgX64.dsc | 2 +- OvmfPkg/OvmfPkgX64.fdf | 2 +- OvmfPkg/OvmfXen.dsc | 2 +- OvmfPkg/OvmfXen.fdf | 2 +- OvmfPkg/SataControllerDxe/ComponentName.c | 170 --- OvmfPkg/SataControllerDxe/SataController.c | 1112 ----------------- OvmfPkg/SataControllerDxe/SataController.h | 544 -------- .../SataControllerDxe/SataControllerDxe.inf | 43 - 23 files changed, 90 insertions(+), 1961 deletions(-) delete mode 100644 OvmfPkg/SataControllerDxe/ComponentName.c delete mode 100644 OvmfPkg/SataControllerDxe/SataController.c delete mode 100644 OvmfPkg/SataControllerDxe/SataController.h delete mode 100644 OvmfPkg/SataControllerDxe/SataControllerDxe.inf -- 2.40.1