From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by mx.groups.io with SMTP id smtpd.web11.9406.1683695701564861887 for ; Tue, 09 May 2023 22:15:01 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=oCnv2jSx; spf=pass (domain: intel.com, ip: 192.55.52.136, mailfrom: gua.guo@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1683695701; x=1715231701; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=pvR6dX1bBKhgdOIK5d6E6TrrTExJ/yrj7Ltd9UUAXBk=; b=oCnv2jSxKhGqTbxEp7i2JSS9YdriwGrNog3w1XWXFg1jqCMeezjzx+Pk +YghpookIxPO+VQd84W4rIujV2ld78Fq4KyPSpQYdMVukFUvBINAJLoXs kuyzv9VMQfwoqbiMfEn4PT6vF+cLHYd4TAZE5FxITk+8IQhtblQ2H5JAr JfaxxNZYqKgGwwcQBLFQ9O1B6R6HF1XkgEHAklA6aF4ooeoAj75QqwtdS QRo9FwpL0BZrBDORJwUZwPHi1/u4VysELP/WNGbpElcg8BeuIkO5lipfa knUYiW9G8UXoj5nNq0GXs6sO/4r/A4UlHX9o61yEK/gAh9iCzff/z4gww Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10705"; a="329746715" X-IronPort-AV: E=Sophos;i="5.99,263,1677571200"; d="scan'208";a="329746715" Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 May 2023 22:15:00 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10705"; a="699157266" X-IronPort-AV: E=Sophos;i="5.99,263,1677571200"; d="scan'208";a="699157266" Received: from gguo-desk.gar.corp.intel.com ([10.5.215.23]) by orsmga002.jf.intel.com with ESMTP; 09 May 2023 22:14:59 -0700 From: "Guo, Gua" To: devel@edk2.groups.io Cc: gua.guo@intel.com Subject: [PATCH v4 0/1] BaseTools/Plugin: Too many execute files cause "cmd too long" failure Date: Wed, 10 May 2023 13:14:56 +0800 Message-Id: <20230510051457.1063-1-gua.guo@intel.com> X-Mailer: git-send-email 2.39.2.windows.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Gua Guo V3: Michael Kubacki Open1: I understand it was common in some parts of the code base at one point to wrap all expressions in parentheses, but can it be avoided in newly added code? And the parentheses are unnecessary in this case and don't follow typical Python style. Solution: Fixed, I will record it in my personal guideline to prevent happen again in next time that I change python code on Edk2. Open2: Due to the number of references, it would be easier to follow if this path were assigned to a variable: os.path.join(buildOutputBase, 'coverage.cov') Solution: Fixed, Use variable to reduce repetitive data. Open3: Solution: my local test, performance time increase 1.4% each build. I'm not sure whether the data is reasonable or not. But if won't fix it, I think one day unittest implement more and more on Edk2 part. It will break azurepipe line build in the future. V2/V1: Mike Kinney: Open1: Make commit message more clearly. Solution: Change commit message to use real case to describe the issue I encounter. Gua Guo (1): BaseTools/Plugin: Too many execute files cause "cmd too long" failure .../HostBasedUnitTestRunner.py | 46 +++++++++++++++++-- 1 file changed, 41 insertions(+), 5 deletions(-) -- 2.39.2.windows.1