From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by mx.groups.io with SMTP id smtpd.web11.9604.1683696934710100433 for ; Tue, 09 May 2023 22:35:34 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=Ejhlr41Q; spf=pass (domain: intel.com, ip: 134.134.136.24, mailfrom: gua.guo@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1683696934; x=1715232934; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=LpCBKA0jOglqpL6TMv3oTYSRxbkpva1ddnAYV1rSj1k=; b=Ejhlr41QYq/w89+Zcv7A/NOiqzxmG54DkDVYz/62GGo+py8Ogv8LvRZX Zjk6gbAp5cdrmbNwC7/jUqb0hjzcOWCYkVfSXPbBim2R4mGmFb4Yqqp1+ L8AX6fhIUN6EqJ7MP8w1asIwQBXQ5BRws+zzZDzhKNhvV1xakOSRHCu/M FmAluUEXbe7XTrjs2UGFleCTEzEKh6LekTeWn5xrAh9JPSL2IQcu8UTYQ EtEdYI6sgK3yHFZs3r6/+WMHHblSswAZcmebgyy9zL9S49yJO5TtVfOKu 3apL56BscqfeXivqgjciV16W6sjYKU9RTRk5ssUO+w8SSPcDqwA8I7tRc g==; X-IronPort-AV: E=McAfee;i="6600,9927,10705"; a="352319318" X-IronPort-AV: E=Sophos;i="5.99,263,1677571200"; d="scan'208";a="352319318" Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 May 2023 22:35:33 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10705"; a="702127454" X-IronPort-AV: E=Sophos;i="5.99,263,1677571200"; d="scan'208";a="702127454" Received: from gguo-desk.gar.corp.intel.com ([10.5.215.23]) by fmsmga007.fm.intel.com with ESMTP; 09 May 2023 22:35:32 -0700 From: "Guo, Gua" To: devel@edk2.groups.io Cc: gua.guo@intel.com Subject: [PATCH v4 0/4] Trace Hub debug library support Date: Wed, 10 May 2023 13:34:49 +0800 Message-Id: <20230510053453.1652-1-gua.guo@intel.com> X-Mailer: git-send-email 2.39.2.windows.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Gua Guo V4 - https://github.com/tianocore/edk2/pull/3901 - OnGoing Enhance SwapBytesGuid to use CopyGuid instead of CopyMem, to make implement code more simple. V3 - https://github.com/tianocore/edk2/pull/3901 - OnGoing - Open: MdeModulePkg/Include/Guid/TraceHubDebugInfoHob.h: why MAX_TRACE_HUB_DEBUG_INSTANCE hardcoded to 5? Solution: Remove this macro, use Library Constructor to allocate it dynamiclly. - Open: MdeModulePkg/Library/TraceHubDebugSysTLib/InternalTraceHubApiCommon.c: SwapBytesGuid () algorithm wrong. Solution: Follow correct algorithm to implement it. VOID EFIAPI SwapBytesGuid ( IN GUID *Guid, <----------- In PreMem, guid is global data so region is readonly, add output data to support it. OUT GUID *ConvertedGuid ); - Open: Merge MSFT and GCC CC_FLAGS as they both supports -D Solution: use *_*_*_CC_FLAGS = -DMIPI_SYST_STATIC to unified both. V2 - https://github.com/tianocore/edk2/pull/3901 - Open: MdeModulePkg/Include/Guid/TraceHubDebugInfoHob.h: why MAX_TRACE_HUB_DEBUG_INSTANCE hardcoded to 5? - Open: MdeModulePkg/Library/TraceHubDebugSysTLib/InternalTraceHubApiCommon.c: SwapBytesGuid () algorithm wrong. - Open: Merge MSFT and GCC CC_FLAGS as they both supports -D V1 Previous PR: - https://github.com/tianocore/edk2/pull/3613 - TraceHubDebugLib without submodule - Reject - https://github.com/tianocore/edk2/pull/3793 - TraceHubDebugLib with submodule and without seperate into MipiSysTLib and TraceHubDebugLib - Reject Gua Guo (4): MdePkg: Add MipiSysTLib library MdePkg: Add NULL library of TraceHubDebugSysTLib MdeModulePkg: Add TraceHubDebugSysTLib library Maintainers.txt: Update reviewers and maintainers for TraceHubDebugLib. .gitmodules | 11 +- .pytool/CISettings.py | 2 + Maintainers.txt | 18 + .../Include/Guid/TraceHubDebugInfoHob.h | 24 + .../BaseTraceHubDebugSysTLib.c | 245 ++++++ .../BaseTraceHubDebugSysTLib.inf | 44 + .../DxeSmmTraceHubDebugSysTLib.c | 263 ++++++ .../DxeSmmTraceHubDebugSysTLib.inf | 51 ++ .../InternalTraceHubApi.c | 74 ++ .../InternalTraceHubApi.h | 37 + .../InternalTraceHubApiCommon.c | 200 +++++ .../InternalTraceHubApiCommon.h | 119 +++ .../PeiTraceHubDebugSysTLib.c | 282 +++++++ .../PeiTraceHubDebugSysTLib.inf | 50 ++ .../Library/TraceHubDebugSysTLib/Readme.md | 26 + MdeModulePkg/MdeModulePkg.dec | 21 + MdeModulePkg/MdeModulePkg.dsc | 3 + MdeModulePkg/MdeModulePkg.uni | 18 + MdePkg/Include/Library/MipiSysTLib.h | 66 ++ MdePkg/Include/Library/TraceHubDebugSysTLib.h | 81 ++ MdePkg/Library/MipiSysTLib/GenMipiSystH.py | 132 +++ MdePkg/Library/MipiSysTLib/MipiSysTLib.c | 123 +++ MdePkg/Library/MipiSysTLib/MipiSysTLib.inf | 52 ++ MdePkg/Library/MipiSysTLib/Platform.c | 164 ++++ MdePkg/Library/MipiSysTLib/Platform.h | 138 +++ MdePkg/Library/MipiSysTLib/Readme.md | 25 + MdePkg/Library/MipiSysTLib/mipi_syst.h | 789 ++++++++++++++++++ MdePkg/Library/MipiSysTLib/mipisyst | 1 + .../TraceHubDebugSysTLibNull.c | 76 ++ .../TraceHubDebugSysTLibNull.inf | 29 + MdePkg/MdePkg.ci.yaml | 12 +- MdePkg/MdePkg.dec | 9 + MdePkg/MdePkg.dsc | 2 + ReadMe.rst | 1 + 34 files changed, 3181 insertions(+), 7 deletions(-) create mode 100644 MdeModulePkg/Include/Guid/TraceHubDebugInfoHob.h create mode 100644 MdeModulePkg/Library/TraceHubDebugSysTLib/BaseTraceHubDebugSysTLib.c create mode 100644 MdeModulePkg/Library/TraceHubDebugSysTLib/BaseTraceHubDebugSysTLib.inf create mode 100644 MdeModulePkg/Library/TraceHubDebugSysTLib/DxeSmmTraceHubDebugSysTLib.c create mode 100644 MdeModulePkg/Library/TraceHubDebugSysTLib/DxeSmmTraceHubDebugSysTLib.inf create mode 100644 MdeModulePkg/Library/TraceHubDebugSysTLib/InternalTraceHubApi.c create mode 100644 MdeModulePkg/Library/TraceHubDebugSysTLib/InternalTraceHubApi.h create mode 100644 MdeModulePkg/Library/TraceHubDebugSysTLib/InternalTraceHubApiCommon.c create mode 100644 MdeModulePkg/Library/TraceHubDebugSysTLib/InternalTraceHubApiCommon.h create mode 100644 MdeModulePkg/Library/TraceHubDebugSysTLib/PeiTraceHubDebugSysTLib.c create mode 100644 MdeModulePkg/Library/TraceHubDebugSysTLib/PeiTraceHubDebugSysTLib.inf create mode 100644 MdeModulePkg/Library/TraceHubDebugSysTLib/Readme.md create mode 100644 MdePkg/Include/Library/MipiSysTLib.h create mode 100644 MdePkg/Include/Library/TraceHubDebugSysTLib.h create mode 100644 MdePkg/Library/MipiSysTLib/GenMipiSystH.py create mode 100644 MdePkg/Library/MipiSysTLib/MipiSysTLib.c create mode 100644 MdePkg/Library/MipiSysTLib/MipiSysTLib.inf create mode 100644 MdePkg/Library/MipiSysTLib/Platform.c create mode 100644 MdePkg/Library/MipiSysTLib/Platform.h create mode 100644 MdePkg/Library/MipiSysTLib/Readme.md create mode 100644 MdePkg/Library/MipiSysTLib/mipi_syst.h create mode 160000 MdePkg/Library/MipiSysTLib/mipisyst create mode 100644 MdePkg/Library/TraceHubDebugSysTLibNull/TraceHubDebugSysTLibNull.c create mode 100644 MdePkg/Library/TraceHubDebugSysTLibNull/TraceHubDebugSysTLibNull.inf -- 2.39.2.windows.1