From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (NAM10-MW2-obe.outbound.protection.outlook.com [40.107.94.41]) by mx.groups.io with SMTP id smtpd.web10.11469.1683707025730776243 for ; Wed, 10 May 2023 01:23:45 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="body hash did not verify" header.i=@nvidia.com header.s=selector2 header.b=bKg6shD4; spf=permerror, err=parse error for token &{10 18 %{i}._ip.%{h}._ehlo.%{d}._spf.vali.email}: invalid domain name (domain: nvidia.com, ip: 40.107.94.41, mailfrom: nicklew@nvidia.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=mRd3hRGTHYPkNAg2OIbBMvyfERQGDurv08XJF+ffxhgFZPAUkUgadr90MurnVcxw23cDqn+ZaBKktrwp3+Xt/zXTF01qPFnLXHgQzjVVCYvsF61PgwUYw1PcE09u8r+YVsG1GpGOSk1VPMI1mF1O7uKaT+5C/hlH4nL3KRmk13BywqPNwlcVOrJl8Hcrh5WhPJq5vrkDI04iSXibHPYNAPWo9S+smWTzMLA6OqezKypNJQYHKZ4RS3GGF26J+EdSf0YOex8g8ggNgqhpVIPsQB3MP2YA4Cm4MYdUGze5Eo50IT13Ryo+hXMsqzv8sBRTc7Sy0QyZOMdYzt3ThGh8Nw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=rXGNqyPTqsPmyNQNV+NzpuFgEMCWmcYeKobh5IUFuR4=; b=Y0YwIH3JCfq3MwkdPL1ODS4GSzdIFVC4H3G+sSWt3s4qsm2vU2t5ARSvibUoKF5jaBE0HnTg4JsfHr7IsZ2tcebN4KTLUcsPv+f17WyLRSQN2OzCNEGvUwkwBcbYhPCKUoltNtlenWxz4Auv7fVcYQZTkcXmbqkrLf/Es9bqxG2P97MgcjdYbdBfg7w0TqJp6CbzrbmppfkaJy1ddF5vLFK2fnvUrn1hHjRJ/HRUE+j0rBaRrC5e87rsKaR6DYNrYTSSHIzO9wPHUN2u2eFr5rYB3NU3rfteYPzE/pacthJ9MOnh9j2SJI5oZg+Q7N4p5XihvHqpRj21u8+0GNJzxA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.118.233) smtp.rcpttodomain=edk2.groups.io smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=rXGNqyPTqsPmyNQNV+NzpuFgEMCWmcYeKobh5IUFuR4=; b=bKg6shD4meOaB0itNYfst5rhWrvKabw2UIDqDQ2t4XNZlYIXwBdEp2lKy6EV4JHYTqjCqduBJ2GCKXKyDdFWB/1oSHaG69raPHYszsFmE3Q4XlRbpLPckuV2lY0oDoxrBuri+S0IHnIe4Fuc02E2Dkqe8AJy5IMzGQzyaOA8noRL+psb8Xg9zqSiSSjjfc38dlAiQtQsSepLwYOMbJtQOO0be2kI98JBwedvi8t6/p0lGN7Ae1l+S+XOqKOGYoFFtB+QO3RjfvnTIg8icLA0D/gbwPYzu2P+q+cqfo0d3jKdxGTK+zq0EkQvoBi3sYe7dCutx8mxBgt6ja3coqwGOQ== Received: from MW4PR04CA0239.namprd04.prod.outlook.com (2603:10b6:303:87::34) by SN7PR12MB7299.namprd12.prod.outlook.com (2603:10b6:806:2af::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6363.32; Wed, 10 May 2023 08:23:42 +0000 Received: from CO1NAM11FT054.eop-nam11.prod.protection.outlook.com (2603:10b6:303:87:cafe::49) by MW4PR04CA0239.outlook.office365.com (2603:10b6:303:87::34) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6363.33 via Frontend Transport; Wed, 10 May 2023 08:23:42 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.118.233) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.118.233 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.118.233; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.118.233) by CO1NAM11FT054.mail.protection.outlook.com (10.13.174.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6387.20 via Frontend Transport; Wed, 10 May 2023 08:23:42 +0000 Received: from drhqmail202.nvidia.com (10.126.190.181) by mail.nvidia.com (10.127.129.6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.5; Wed, 10 May 2023 01:23:31 -0700 Received: from drhqmail201.nvidia.com (10.126.190.180) by drhqmail202.nvidia.com (10.126.190.181) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.37; Wed, 10 May 2023 01:23:31 -0700 Received: from NV-CL38DL3.nvidia.com (10.127.8.14) by mail.nvidia.com (10.126.190.180) with Microsoft SMTP Server id 15.2.986.37 via Frontend Transport; Wed, 10 May 2023 01:23:30 -0700 From: "Nickle Wang" To: CC: Abner Chang , Igor Kulchytskyy Subject: [edk2-redfish-client][PATCH 1/4] RedfishClientPkg: Update ETag driver Date: Wed, 10 May 2023 16:23:30 +0800 Message-ID: <20230510082330.12199-1-nicklew@nvidia.com> X-Mailer: git-send-email 2.17.1 MIME-Version: 1.0 Return-Path: nicklew@nvidia.com X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CO1NAM11FT054:EE_|SN7PR12MB7299:EE_ X-MS-Office365-Filtering-Correlation-Id: 6e24d20a-9fa0-4cbf-2fa4-08db512fdd6f X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: YNCNdxpMqQolS2WtB7PQhs1zt1AXzHuKss88XT2+SMVXUb/3WAbCNga95ixhTFDEJiUMQ33houyvHTwr4/WJ9RPogDv/iWq/pPq4wa85dsB0Ib49ZZ/5nK+5sP8H5DkSVJJ40W4lWecKcShpytlawMKyKJRqaJXWJpjqQT0A3pf1ct8qml4QJC2SsjnGWFGlZf/xgFC3TwaSN0MVQAAJPoahCFCZCU1rwjybL0YkUKV7rhflA+s2H+CGjrL9j9zh04omFQ8rtqjK0b19jPQFroK5Q6KKPIbz4rQrz24ep+a/j9BSlGCU/8xR18HAsI29SI7FpQ+w9LIDOZpZO3NUtJUbmoUEQMMB+6WSd6pOeiGEGD/gTWilNTBGiThpIxCctr1VdqokSiiBORH41d/IBDCxfDgsOqVFzAMAJYWJm+wiCxXZLUamy6wVqNuyPS+J7YBAVnJFKqnOsWw6fRyFHZES7aeC6CAmiDqOEexVsvB+u8uOAwydrHSpP67WMalVbpogFo/sL6gOaaJBCaXpHiBsVFXBOrJZ/1lRZ/Bzu3dIEz5KaVQI1TD/Mfw8sXM1PEAxKsCf85Wi3QvtR/nbCe3VBSBl2dYAaEsQ0w9WEDGy1RCs1ppMvEbyV4JrfLdcIk5ufxHxdw/MfO9PqMLg+RiC56DVYuInq3uZCtxqcE8Dy7hJYv+W9f9oFo6+twDAvyj2U/s0SgG3S3TdvMRf/g== X-Forefront-Antispam-Report: CIP:216.228.118.233;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:mail.nvidia.com;PTR:dc7edge2.nvidia.com;CAT:NONE;SFS:(13230028)(4636009)(136003)(39860400002)(396003)(376002)(346002)(451199021)(46966006)(40470700004)(36840700001)(36756003)(86362001)(4326008)(6916009)(316002)(54906003)(70586007)(70206006)(478600001)(7696005)(8936002)(82310400005)(8676002)(5660300002)(2906002)(15650500001)(82740400003)(83380400001)(7636003)(40480700001)(186003)(356005)(26005)(1076003)(41300700001)(2616005)(47076005)(36860700001)(336012)(426003)(40460700003);DIR:OUT;SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 May 2023 08:23:42.2483 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 6e24d20a-9fa0-4cbf-2fa4-08db512fdd6f X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a;Ip=[216.228.118.233];Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: CO1NAM11FT054.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR12MB7299 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain Update ETag driver and use specific variable GUID. Also fix the typo in comment. Signed-off-by: Nickle Wang Cc: Abner Chang Cc: Igor Kulchytskyy --- RedfishClientPkg/RedfishClientPkg.dec | 2 +- RedfishClientPkg/RedfishETagDxe/RedfishETagDxe.h | 4 ++-- RedfishClientPkg/RedfishETagDxe/RedfishETagDxe.c | 10 +++++----- 3 files changed, 8 insertions(+), 8 deletions(-) diff --git a/RedfishClientPkg/RedfishClientPkg.dec b/RedfishClientPkg/Redfi= shClientPkg.dec index 7bdab5be..67929341 100644 --- a/RedfishClientPkg/RedfishClientPkg.dec +++ b/RedfishClientPkg/RedfishClientPkg.dec @@ -36,7 +36,7 @@ gEdkIIRedfishFeatureProtocolGuid =3D { 0x785CC694, 0x4930, 0xEFBF= , { 0x2A, 0xCB, 0xA4, 0xB6, 0xA1, 0xCC, 0xAA, 0x34 } } ## Include/Protocol/EdkIIRedfishResourceConfigProtocol.h gEdkIIRedfishResourceConfigProtocolGuid =3D { 0x6f164c68, 0xfb09, 0x4646= , { 0xa8, 0xd3, 0x24, 0x11, 0x5d, 0xab, 0x3e, 0xe7 } } - ## Include/Protocol/EdkiiRedfishETagProtocol.h + ## Include/Protocol/EdkIIRedfishETagProtocol.h gEdkIIRedfishETagProtocolGuid =3D { 0x5706d368, 0xaf66, 0x48f5= , { 0x89, 0xfc, 0xa6, 0x61, 0xce, 0xb5, 0xa6, 0xa9 } } ## Include/Protocol/EdkIIRedfishConfigLangMapProtocol.h gEdkIIRedfishConfigLangMapProtocolGuid =3D { 0x1d9ba9fe, 0x5d5a, 0x4b= 66, {0x83, 0x5b, 0xe2, 0x5d, 0x13, 0x93, 0x4a, 0x9c } } diff --git a/RedfishClientPkg/RedfishETagDxe/RedfishETagDxe.h b/RedfishClie= ntPkg/RedfishETagDxe/RedfishETagDxe.h index 6dffa9d7..3542f289 100644 --- a/RedfishClientPkg/RedfishETagDxe/RedfishETagDxe.h +++ b/RedfishClientPkg/RedfishETagDxe/RedfishETagDxe.h @@ -1,7 +1,7 @@ /** @file Common header file for RedfishETagDxe driver. =20 - (C) Copyright 2021 Hewlett Packard Enterprise Development LP
+ (C) Copyright 2021-2022 Hewlett Packard Enterprise Development LP
=20 SPDX-License-Identifier: BSD-2-Clause-Patent =20 @@ -11,6 +11,7 @@ #define REDFISH_ETAG_DXE_H_ =20 #include +#include =20 // // Libraries @@ -30,7 +31,6 @@ #include =20 #define ETAG_VARIABLE_NAME L"RedfishETag" -#define IS_EMPTY_STRING(a) ((a) =3D=3D NULL || (a)[0] =3D=3D '\0') #define ETAG_DEBUG_ENABLED 0x00 =20 // diff --git a/RedfishClientPkg/RedfishETagDxe/RedfishETagDxe.c b/RedfishClie= ntPkg/RedfishETagDxe/RedfishETagDxe.c index af920afc..a4233a64 100644 --- a/RedfishClientPkg/RedfishETagDxe/RedfishETagDxe.c +++ b/RedfishClientPkg/RedfishETagDxe/RedfishETagDxe.c @@ -1,6 +1,6 @@ /** @file =20 - (C) Copyright 2021 Hewlett Packard Enterprise Development LP
+ (C) Copyright 2021-2022 Hewlett Packard Enterprise Development LP
=20 SPDX-License-Identifier: BSD-2-Clause-Patent =20 @@ -401,16 +401,16 @@ SaveETagList ( // Status =3D GetVariable2 ( VariableName, - &gEfiCallerIdGuid, + &mRedfishVariableGuid, (VOID *)&Data, NULL ); if (!EFI_ERROR (Status)) { FreePool (Data); - gRT->SetVariable (VariableName, &gEfiCallerIdGuid, VARIABLE_ATTRIBUTE_= NV_BS, 0, NULL); + gRT->SetVariable (VariableName, &mRedfishVariableGuid, VARIABLE_ATTRIB= UTE_NV_BS, 0, NULL); } =20 - return gRT->SetVariable (VariableName, &gEfiCallerIdGuid, VARIABLE_ATTRI= BUTE_NV_BS, VarSize, (VOID *)VarData); + return gRT->SetVariable (VariableName, &mRedfishVariableGuid, VARIABLE_A= TTRIBUTE_NV_BS, VarSize, (VOID *)VarData); } =20 /** @@ -446,7 +446,7 @@ InitialETagList ( // Status =3D GetVariable2 ( VariableName, - &gEfiCallerIdGuid, + &mRedfishVariableGuid, (VOID *)&VarData, &VariableSize ); --=20 2.17.1