From: "Guo, Gua" <gua.guo@intel.com>
To: devel@edk2.groups.io
Cc: gua.guo@intel.com
Subject: [PATCH v5 0/1] BaseTools/Plugin: Too many execute files cause "cmd too long" failure
Date: Thu, 11 May 2023 08:51:35 +0800 [thread overview]
Message-ID: <20230511005136.1465-1-gua.guo@intel.com> (raw)
From: Gua Guo <gua.guo@intel.com>
V4:
Add Reviewed-by Info from Michael Kubacki
Add more people into Cc List
> BaseTools
> F: BaseTools/
> M: Rebecca Cran <rebecca@bsdio.com> [bcran]
> M: Liming Gao <gaoliming@byosoft.com.cn> [lgao4]
> R: Bob Feng <bob.c.feng@intel.com> [BobCF]
> R: Yuwei Chen <yuwei.chen@intel.com> [YuweiChen1110]
V3:
Michael Kubacki
Open1:
I understand it was common in some parts of the code base at one point to wrap all expressions in parentheses, but can it be avoided in newly added code?
And the parentheses are unnecessary in this case and don't follow typical Python style.
Solution: Fixed, I will record it in my personal guideline to prevent happen again in next time that I change python code on Edk2.
Open2:
Due to the number of references, it would be easier to follow if this path were assigned to a variable:
os.path.join(buildOutputBase, 'coverage.cov')
Solution: Fixed, Use variable to reduce repetitive data.
Open3:
Solution: my local test, performance time increase 1.4% each build. I'm not sure whether the data is reasonable or not. But if won't fix it, I think one day unittest implement more and more on Edk2 part.
It will break azurepipe line build in the future.
V2/V1:
Mike Kinney:
Open1: Make commit message more clearly.
Solution: Change commit message to use real case to describe the issue I encounter.
Gua Guo (1):
BaseTools/Plugin: Too many execute files cause "cmd too long" failure
.../HostBasedUnitTestRunner.py | 46 +++++++++++++++++--
1 file changed, 41 insertions(+), 5 deletions(-)
--
2.39.2.windows.1
next reply other threads:[~2023-05-11 0:53 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-11 0:51 Guo, Gua [this message]
2023-05-11 0:51 ` [PATCH v5 1/1] BaseTools/Plugin: Too many execute files cause "cmd too long" failure Guo, Gua
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230511005136.1465-1-gua.guo@intel.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox