From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by mx.groups.io with SMTP id smtpd.web10.34629.1683766403622375645 for ; Wed, 10 May 2023 17:53:24 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=Pil0DlXq; spf=pass (domain: intel.com, ip: 192.55.52.120, mailfrom: gua.guo@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1683766403; x=1715302403; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=FTQE86S50R2jskewU3cMUhz9gjCHn+Gr6GURzHACmRk=; b=Pil0DlXqk/BvtEbNZLpxw0RE87qujEjSBQQVOsMKOKvTcKUEwZMq7Y5w zeEchAnloujPouRYSUhrE6XsXdtkQ6pgk5XvhpKl87SIpMESMXNxr2QBS StFkZRbkklobvn5J1hlf/DRl5r2gjLmHmblqeUYGaFIJlp2zmAVGRRFcj 9K8VImNAiKDoUM2UPcO/1XpJiwruYWKFPlaLfP76Lpt8O8lxMXsOsoqez rqp+2naHKO6EvwIgkusN6SRjnr2VadJbf/aLXQ27l6DBi20uzJjzuABcO 6gmYq1vymZPdg2gV7JCUy7THlMkpasGwTCQQ2mN4DBVNRIwwc2etWqt3X Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10706"; a="349196867" X-IronPort-AV: E=Sophos;i="5.99,265,1677571200"; d="scan'208";a="349196867" Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 May 2023 17:51:45 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10706"; a="702503628" X-IronPort-AV: E=Sophos;i="5.99,265,1677571200"; d="scan'208";a="702503628" Received: from gguo-desk.gar.corp.intel.com ([10.5.215.23]) by fmsmga007.fm.intel.com with ESMTP; 10 May 2023 17:51:44 -0700 From: "Guo, Gua" To: devel@edk2.groups.io Cc: gua.guo@intel.com Subject: [PATCH v5 0/1] BaseTools/Plugin: Too many execute files cause "cmd too long" failure Date: Thu, 11 May 2023 08:51:35 +0800 Message-Id: <20230511005136.1465-1-gua.guo@intel.com> X-Mailer: git-send-email 2.39.2.windows.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Gua Guo V4: Add Reviewed-by Info from Michael Kubacki Add more people into Cc List > BaseTools > F: BaseTools/ > M: Rebecca Cran [bcran] > M: Liming Gao [lgao4] > R: Bob Feng [BobCF] > R: Yuwei Chen [YuweiChen1110] V3: Michael Kubacki Open1: I understand it was common in some parts of the code base at one point to wrap all expressions in parentheses, but can it be avoided in newly added code? And the parentheses are unnecessary in this case and don't follow typical Python style. Solution: Fixed, I will record it in my personal guideline to prevent happen again in next time that I change python code on Edk2. Open2: Due to the number of references, it would be easier to follow if this path were assigned to a variable: os.path.join(buildOutputBase, 'coverage.cov') Solution: Fixed, Use variable to reduce repetitive data. Open3: Solution: my local test, performance time increase 1.4% each build. I'm not sure whether the data is reasonable or not. But if won't fix it, I think one day unittest implement more and more on Edk2 part. It will break azurepipe line build in the future. V2/V1: Mike Kinney: Open1: Make commit message more clearly. Solution: Change commit message to use real case to describe the issue I encounter. Gua Guo (1): BaseTools/Plugin: Too many execute files cause "cmd too long" failure .../HostBasedUnitTestRunner.py | 46 +++++++++++++++++-- 1 file changed, 41 insertions(+), 5 deletions(-) -- 2.39.2.windows.1