From: Minh Nguyen <minhnguyen1@os.amperecomputing.com>
To: devel@edk2.groups.io
Cc: patches@amperecomputing.com, quic_llindhol@quicinc.com,
ardb+tianocore@kernel.org, nhi@os.amperecomputing.com,
tinhnguyen@os.amperecomputing.com,
Minh Nguyen <minhnguyen1@os.amperecomputing.com>
Subject: [edk2-platforms][PATCH 3/6] AmpereAltraPkg: Change PCIe Amba Link Timeout value
Date: Thu, 11 May 2023 15:10:08 +0700 [thread overview]
Message-ID: <20230511081011.2692963-4-minhnguyen1@os.amperecomputing.com> (raw)
In-Reply-To: <20230511081011.2692963-1-minhnguyen1@os.amperecomputing.com>
As AMBA_LINK_TIMEOUT_OFF spec, it impacts OS Hot Plug removal delay.
The greater value the longer delay it is. Per experiments, set it 2
from beginning of Root Port initialization for stable operation.
Signed-off-by: Minh Nguyen <minhnguyen1@os.amperecomputing.com>
---
Silicon/Ampere/AmpereAltraPkg/Library/Ac01PcieLib/PcieCore.c | 8 ++++++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/Silicon/Ampere/AmpereAltraPkg/Library/Ac01PcieLib/PcieCore.c b/Silicon/Ampere/AmpereAltraPkg/Library/Ac01PcieLib/PcieCore.c
index c5a299cca6c5..d71f56d5fcf1 100644
--- a/Silicon/Ampere/AmpereAltraPkg/Library/Ac01PcieLib/PcieCore.c
+++ b/Silicon/Ampere/AmpereAltraPkg/Library/Ac01PcieLib/PcieCore.c
@@ -1159,8 +1159,12 @@ Ac01PcieCoreSetupRC (
}
}
- // Link timeout after 1ms
- SetLinkTimeout (RootComplex, PcieIndex, 1);
+ //
+ // As AMBA_LINK_TIMEOUT_OFF spec, it impacts OS HP removal delay.
+ // The greater value the longer delay it is. Per discussion,
+ // set it 2 from beginning of RP initialization.
+ //
+ SetLinkTimeout (RootComplex, PcieIndex, 2);
DisableCompletionTimeOut (RootComplex, PcieIndex, TRUE);
--
2.39.0
next prev parent reply other threads:[~2023-05-11 8:10 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-11 8:10 [edk2-platforms][PATCH 0/6] Support NVMe Hot Plug feature for Ampere Altra and Ampere Altra Max Minh Nguyen
2023-05-11 8:10 ` [edk2-platforms][PATCH 1/6] AmpereAltraPkg: Add PCIe Hot Plug library Minh Nguyen
2023-05-11 8:10 ` [edk2-platforms][PATCH 2/6] AmpereAltraPkg: Add Hot Plug Slot Capable during PCIe port initialization Minh Nguyen
2023-05-11 8:10 ` Minh Nguyen [this message]
2023-05-11 8:10 ` [edk2-platforms][PATCH 4/6] JadePkg: Support ACPI tables for Hot Plug of Ampere Altra Minh Nguyen
2023-05-11 8:10 ` [edk2-platforms][PATCH 5/6] JadePkg: Support ACPI tables for Hot Plug of Ampere Altra Max Minh Nguyen
2023-05-11 8:10 ` [edk2-platforms][PATCH 6/6] AmpereAltraPkg: Enable NVMe Hot Plug feature Minh Nguyen
2023-06-02 12:37 ` [edk2-platforms][PATCH 0/6] Support NVMe Hot Plug feature for Ampere Altra and Ampere Altra Max Ard Biesheuvel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230511081011.2692963-4-minhnguyen1@os.amperecomputing.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox