From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (NAM10-BN7-obe.outbound.protection.outlook.com [40.107.92.138]) by mx.groups.io with SMTP id smtpd.web11.53795.1683792648081336523 for ; Thu, 11 May 2023 01:10:48 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="body hash did not verify" header.i=@os.amperecomputing.com header.s=selector2 header.b=KD6n0IL/; spf=pass (domain: os.amperecomputing.com, ip: 40.107.92.138, mailfrom: minhnguyen1@os.amperecomputing.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=EGBl7TQ3gzjU6+fOlVhEfvnqqcdE0NxpOD2LX2kegXYYJkg1tA2igSQNaJPcvTaEthFQJO5K3WOG+q4sYlfACWeIHp8dX0VhLD2dcCwMwYoCdq/i7BjHwajwGTZjU/yRAISoaih01eg50fJQW/DWNHChQVRKG+MDzrA+XU0c/cH2R2ALKef5XbAMYTNY+U27dtyJxVzGcy0/nqid9xHnkLZhs+lIrHaiOtRSlDLK+3mUwG7kkgplB/nvNdjOwb1tl0eO3EXjD2dyqgteRqkLmxbQHbqiBqb2gh9D6fSzUasDa5AJaEO0StQvDhAYiv6gZWzuy8vCqCRkRMDZo+DJhw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=XFj3rEkwriYe/4lRLCQXuuxm/K1LPDZ85s8shr7ZsMk=; b=bTnHSQCA/IWrOwWoW8/Vek7N+HCnyEEnEsYBdFXG/XxWFUWEY6Brf3UjqsmgBTXXtueMqlrJj2EMdW6Wf9mMttvHYTx117j+0XyQKGpZTX2Kxd05gjCm45eW1IT/sI05XhW0QetoyrecjMCxvqKjCNLkD47zuWZUK6Os7tO+GgObqzLno/6KRC4DRoosJipzo5w2rscWU9U9Qvev86HUQqYYhwMD8EG59tGyA193khg0Gubsy48WVIcrijadCQnep2X/0u9Nz2UGyrAMof5MyOMtNQUyYuJmRSVI3Li2hUVSNiFEmOX7XsVf/btgjxHTNTt2DMPiAWRwNlP8GRtVGw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=os.amperecomputing.com; dmarc=pass action=none header.from=os.amperecomputing.com; dkim=pass header.d=os.amperecomputing.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=os.amperecomputing.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=XFj3rEkwriYe/4lRLCQXuuxm/K1LPDZ85s8shr7ZsMk=; b=KD6n0IL/cvUYz285o46o+orz+DMIgrCdbrBhDeNoFb3bzpJH5f0JWy5NH6tmaryGPPD8AcQnLGRiwdCZtNsDMd7yD/ACD0J/qEsZieqCzkQ0Llf/zNpFA1SzDFwm2hnqjs9r5FJe3ulOUN4s46H3HAvBIYA11NJcXC6puH70OfE= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=os.amperecomputing.com; Received: from PH0PR01MB8048.prod.exchangelabs.com (2603:10b6:510:280::7) by CY4PR0101MB3144.prod.exchangelabs.com (2603:10b6:910:49::35) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6340.19; Thu, 11 May 2023 08:10:45 +0000 Received: from PH0PR01MB8048.prod.exchangelabs.com ([fe80::bbdb:b58c:140e:c4e1]) by PH0PR01MB8048.prod.exchangelabs.com ([fe80::bbdb:b58c:140e:c4e1%6]) with mapi id 15.20.6387.019; Thu, 11 May 2023 08:10:45 +0000 From: Minh Nguyen To: devel@edk2.groups.io CC: patches@amperecomputing.com, quic_llindhol@quicinc.com, ardb+tianocore@kernel.org, nhi@os.amperecomputing.com, tinhnguyen@os.amperecomputing.com, Minh Nguyen Subject: [edk2-platforms][PATCH 3/6] AmpereAltraPkg: Change PCIe Amba Link Timeout value Date: Thu, 11 May 2023 15:10:08 +0700 Message-ID: <20230511081011.2692963-4-minhnguyen1@os.amperecomputing.com> X-Mailer: git-send-email 2.39.0 In-Reply-To: <20230511081011.2692963-1-minhnguyen1@os.amperecomputing.com> References: <20230511081011.2692963-1-minhnguyen1@os.amperecomputing.com> X-ClientProxiedBy: SI2P153CA0033.APCP153.PROD.OUTLOOK.COM (2603:1096:4:190::21) To PH0PR01MB8048.prod.exchangelabs.com (2603:10b6:510:280::7) Return-Path: minhnguyen1@os.amperecomputing.com MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PH0PR01MB8048:EE_|CY4PR0101MB3144:EE_ X-MS-Office365-Filtering-Correlation-Id: 4aba050f-248a-4b1e-c5e5-08db51f738c0 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: /zv7wLcyWHzRgj8Slxd2t/2FH5aBslhzDH+NJFcirxiFzbU01NbM3UbPZFbIl/0ccwph9TDPPxUgrCHLxIEYrYTn+bZMEOIUQKFzjvRemKC38/fNkK6AnHTI4Lru1nIaPZx/3Cl0HQGcbFYIu4AzNSLGHf61nVhabHVRgMdHAhEEDZ+kRW8Lv95GIsvS5yWKmeh95mqcmQDFOb1Y+oMwFc2sBL6nbcHpqRssIAfw8WxbTlU5lA0Xwed14WeGvKK4Zi7tenj2wmfo1P2RIdrxOtrx/b7WKPSVnI1an87Tg6MIhHQfolOubZlicK/drx2cJ2sMPJk7QIhQ8lnmjrtxOoGzg4v6bJ93XPTj4LwWhqeRq6Pt3VfsSnqTGjbwnXqMePWmxo463h/TbI+ZHneLy2h5u0Yd6ojqK8E/vDjBEm6rn4CXG6DwWK1G4LBwclSXtydYTAhQTtAEDz3hZLRlI5GsFmmd+//adQ/WmlFaI8/V9IrrNOq0uuQVZ7CXGyU1LMUvnFI052WBSqp3S0LiYwOetwDeMNHAcmQGYiqy+aruBoqKj3XhtrNJkKBna8HWZxQ6b9zdEzxu2zUlkjpmtD+yPklRc0XzzwDCIebfWMezItJ25f03sXFF7LazcH3n X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PH0PR01MB8048.prod.exchangelabs.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(136003)(376002)(39860400002)(366004)(346002)(396003)(451199021)(6666004)(478600001)(66556008)(19627235002)(316002)(6486002)(66946007)(52116002)(6916009)(66476007)(86362001)(26005)(83380400001)(6512007)(107886003)(6506007)(4326008)(1076003)(8936002)(186003)(2906002)(8676002)(41300700001)(5660300002)(38350700002)(38100700002)(2616005);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?UwfXWkW/q6gP7y0O8k8VaN6M2Eq0qAFHya+57BwP+wuVH6Jhq47YIrZzsLfT?= =?us-ascii?Q?t1slE17i4506vQrwz1mceBM/wHKmT40iFth/XggJ4TGMrVWNbLFtqy3wgCdS?= =?us-ascii?Q?VZqCD2rhQBU6QqDKHb8RGvIkHCLSIgIzUpSTlH51VpZcuHLAfQknbcNAVfjA?= =?us-ascii?Q?MDzvkfGj3R8Zghk2miBKv80TmuWmiDQQj6QKJeUrhWLxDpsQf5LPt3nmkjo/?= =?us-ascii?Q?npJ3Sw6lE+u8bRKs9acG/IKq7UvDvGJAWo+U0zERyM1/CQaiO5hdHhi/3pj6?= =?us-ascii?Q?IQhMUdCFaJuTYZS6m4ZCA34GZyG2eeuQI2T8udCl8Tz0KpGsk23kl1IBx09r?= =?us-ascii?Q?V1GiLk5FsgljXKvFw2AmhKGod/crNLcxbmSt9+7ujhy2fHxpC3AxkuRCFwN9?= =?us-ascii?Q?Z/82Bbn77Ruk+1p7CJt0Ci92mynr5/6O7mJMiBHGoPU6yWWMHYNk63YZI7bg?= =?us-ascii?Q?gKCSWKUrBcZ//CniPMPxwj3VqNPYuVAK4E7UJU060GedDC9QvcZbsw/clG71?= =?us-ascii?Q?9nrkc17MbM+2smYLVorDLitS3+50hEaiigKbiI/qi5N01DDzCuPBSfhgSp6O?= =?us-ascii?Q?FsBn/ohDhSu5LXgFIg4AdbN0Onj43QG7ZEqoDdidn1IOD0AqDY04RzuB28Xn?= =?us-ascii?Q?UcAvtW0lfMaaDtWAXaTQyzH+EezTn9ZMEi/PWNiWQ61VltPye9+bEfIQ0S5n?= =?us-ascii?Q?mhaU9Qs9DY95fZ72wn4DX/OmeUQZiQRbcZmzK8Gl+tlRjrVrozX/ZshiJZ1t?= =?us-ascii?Q?d0rNjhCFW56LytmlKso9XVpI7Oxe3gdDH4n6xxTu7ayFpeXrSEaT3Danu6TM?= =?us-ascii?Q?9PJULKd5pupoTPgaesmgR0nLJ/O6LlvJheRrtpjKzAFIOuu7outCtiaUvQYY?= =?us-ascii?Q?JNJMgB/LK5Qv54ge6cdWB2eprbHuVBARLbpklxV0PowJDrEER02TFE9VFeAX?= =?us-ascii?Q?1cDHLRw0ZkNzL0Z62uSUTJjH35aUCiTxjBI2M2VkgwYKhfaa3mEbXjjCeiB8?= =?us-ascii?Q?VjUikboIbijiWby6fRwK6ULZGBpsdcTapONRolfhPCnS4WzduaaeQQlrAj2t?= =?us-ascii?Q?WahFueD1USV4CAnvPf8H4fLVOIkUOwh2IZXOS9+hAfLXxXHlHBTFIzrqjp0D?= =?us-ascii?Q?o2Kt/IHPE2VJ1aHV5VIbMIDbenoZIVJtuCJ0kgtxs7e+uHzjdK+LoZ8+DSqx?= =?us-ascii?Q?ueGJ2It/kI372jjEYQYzsxSf0D2wgapDpUKEntBMEvgWOkXl9h2pX1rxDXR1?= =?us-ascii?Q?OAzYDs2LJE0exLbzXrClT3Tzo/nGS7lhtp8b5tyCWi8inRwGNi7CM1hKAecr?= =?us-ascii?Q?GC98NJQS9j6hOAS/ouaY2+8Wy/M2xz6o2sFn+QS+Vni/q5ODo/hFsodWc63w?= =?us-ascii?Q?f2/Elz/uDiyEUDuUM1gXJwX6rFLGN8t0kDq3Qqgp8yx+ElufekoIglkQ488B?= =?us-ascii?Q?1F2lVWtF7hoptUB1XRWGUV3YZfS+4hWpZOW/9eeAWhqU+QOo6j8Xg96NrafR?= =?us-ascii?Q?4uN6S00ir7W/WCnMOIPHmaUKWJsXbnQ4lJP3scqufwrdqUehVHtwVcqTtc4S?= =?us-ascii?Q?04zPrpNbCzxu6Xr5xPiZR19tFEAPURSNmhx1gktU9+ZxX5gl5GdBoC7Z2T1c?= =?us-ascii?Q?++wUxYeE58u0E67D3xQj4s4zP+Q2rZlNlQCrKGqFvQln?= X-OriginatorOrg: os.amperecomputing.com X-MS-Exchange-CrossTenant-Network-Message-Id: 4aba050f-248a-4b1e-c5e5-08db51f738c0 X-MS-Exchange-CrossTenant-AuthSource: PH0PR01MB8048.prod.exchangelabs.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 May 2023 08:10:45.8084 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3bc2b170-fd94-476d-b0ce-4229bdc904a7 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: dC3trXGZC4piOwyGs+5BJTTMcwC5KvtcxUl+7YyiDOkB92oLTThQbjbR+uIv8Lzm6LG3cQJtZSbiK5N3kGihh57lumk5C1oKXg/DW6tXv7+f1GyFf7cFw4Wk9k6isj34 X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR0101MB3144 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain As AMBA_LINK_TIMEOUT_OFF spec, it impacts OS Hot Plug removal delay. The greater value the longer delay it is. Per experiments, set it 2 from beginning of Root Port initialization for stable operation. Signed-off-by: Minh Nguyen --- Silicon/Ampere/AmpereAltraPkg/Library/Ac01PcieLib/PcieCore.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/Silicon/Ampere/AmpereAltraPkg/Library/Ac01PcieLib/PcieCore.c b= /Silicon/Ampere/AmpereAltraPkg/Library/Ac01PcieLib/PcieCore.c index c5a299cca6c5..d71f56d5fcf1 100644 --- a/Silicon/Ampere/AmpereAltraPkg/Library/Ac01PcieLib/PcieCore.c +++ b/Silicon/Ampere/AmpereAltraPkg/Library/Ac01PcieLib/PcieCore.c @@ -1159,8 +1159,12 @@ Ac01PcieCoreSetupRC ( } } =20 - // Link timeout after 1ms - SetLinkTimeout (RootComplex, PcieIndex, 1); + // + // As AMBA_LINK_TIMEOUT_OFF spec, it impacts OS HP removal delay. + // The greater value the longer delay it is. Per discussion, + // set it 2 from beginning of RP initialization. + // + SetLinkTimeout (RootComplex, PcieIndex, 2); =20 DisableCompletionTimeOut (RootComplex, PcieIndex, TRUE); =20 --=20 2.39.0