public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Rebecca Cran" <rebecca@bsdio.com>
To: devel@edk2.groups.io, Eric Dong <eric.dong@intel.com>,
	Isaac Oram <isaac.w.oram@intel.com>,
	Liming Gao <gaoliming@byosoft.com.cn>,
	Sai Chaganty <rangasai.v.chaganty@intel.com>,
	Nate DeSimone <nathaniel.l.desimone@intel.com>
Cc: Rebecca Cran <rebecca@bsdio.com>
Subject: [PATCH edk2-platforms 1/1] Platform/Intel: Fix type mismatches from prototypes in BoardBdsHookLib.c
Date: Sun, 14 May 2023 23:54:21 -0600	[thread overview]
Message-ID: <20230515055421.3241932-1-rebecca@bsdio.com> (raw)

Add EFIAPI to the implementations of:

BdsBeforeConsoleAfterTrustedConsoleCallback
BdsBeforeConsoleBeforeEndOfDxeGuidCallback
BdsAfterConsoleReadyBeforeBootOptionCallback

This makes them match the prototypes, and avoids an -Wlto-type-mismatch
warning.

Signed-off-by: Rebecca Cran <rebecca@bsdio.com>
---
 Platform/Intel/BoardModulePkg/Library/BoardBdsHookLib/BoardBdsHookLib.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/Platform/Intel/BoardModulePkg/Library/BoardBdsHookLib/BoardBdsHookLib.c b/Platform/Intel/BoardModulePkg/Library/BoardBdsHookLib/BoardBdsHookLib.c
index e866f70bc336..bc80badb3e01 100644
--- a/Platform/Intel/BoardModulePkg/Library/BoardBdsHookLib/BoardBdsHookLib.c
+++ b/Platform/Intel/BoardModulePkg/Library/BoardBdsHookLib/BoardBdsHookLib.c
@@ -1273,6 +1273,7 @@ BdsReadyToBootCallback (
   @param[in] Context    Pointer to the context data registered to the Event.
 **/
 VOID
+EFIAPI
 BdsBeforeConsoleAfterTrustedConsoleCallback (
   IN EFI_EVENT          Event,
   IN VOID               *Context
@@ -1294,6 +1295,7 @@ BdsBeforeConsoleAfterTrustedConsoleCallback (
   @param[in] Context    Pointer to the context data registered to the Event.
 **/
 VOID
+EFIAPI
 BdsBeforeConsoleBeforeEndOfDxeGuidCallback (
   IN EFI_EVENT          Event,
   IN VOID               *Context
@@ -1311,6 +1313,7 @@ BdsBeforeConsoleBeforeEndOfDxeGuidCallback (
   @param[in] Context    Pointer to the context data registered to the Event.
 **/
 VOID
+EFIAPI
 BdsAfterConsoleReadyBeforeBootOptionCallback (
   IN EFI_EVENT          Event,
   IN VOID               *Context
-- 
2.39.2


             reply	other threads:[~2023-05-15  5:54 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-05-15  5:54 Rebecca Cran [this message]
2023-05-15 21:22 ` [edk2-devel] [PATCH edk2-platforms 1/1] Platform/Intel: Fix type mismatches from prototypes in BoardBdsHookLib.c Isaac Oram
     [not found] ` <175F6E02C829A330.20583@groups.io>
2023-05-16 19:54   ` Isaac Oram

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230515055421.3241932-1-rebecca@bsdio.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox