From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from wout4-smtp.messagingengine.com (wout4-smtp.messagingengine.com [64.147.123.20]) by mx.groups.io with SMTP id smtpd.web10.89371.1684159172108751923 for ; Mon, 15 May 2023 06:59:32 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="signature has expired" header.i=@bsdio.com header.s=fm2 header.b=Yk0hUj77; spf=pass (domain: bsdio.com, ip: 64.147.123.20, mailfrom: rebecca@bsdio.com) Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailout.west.internal (Postfix) with ESMTP id 3370A32008FA; Mon, 15 May 2023 09:59:31 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute2.internal (MEProxy); Mon, 15 May 2023 09:59:31 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdio.com; h=cc :cc:content-transfer-encoding:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm2; t=1684159170; x= 1684245570; bh=P+iVDMUkscIPwd2prSInIrvshEGu7pq7XzfUcyYzuxw=; b=Y k0hUj77hyfF3RD5Uixej9NwyukfUtql73DsKep55RZ7tNocWCvGHEkzOekSzRKaM /d7AGTxy1FVD1ezFM+vvnsE6ikqc0QTLSAU5VqcVb4IGF07qSOgX9jAI/+HE3gXl jdMmhVqssk6vAAdQDp/opKNgbOuf3s9Nh0Yll2CY4tfuCJcseRRTe0/dp6dC1hJV bv8ibhnD5boJ1Dg6fZP46vdbE2NBcXLbghapHyZv9rtdmBueGodavpw1YuyoJ1c8 PvwkKmJxhB0+BT4j9765rkgJrwV1hFp1tqmyqbjjbU49h1A1goIzQ6keIDTxL7HT gtQoONrWsQlkQaGYwkhFg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t=1684159170; x= 1684245570; bh=P+iVDMUkscIPwd2prSInIrvshEGu7pq7XzfUcyYzuxw=; b=D 5hk85rWjemgVQ2hoN+6E4bFAYDA4omorJWRnuJFpREbKXZT9DZmf84C+wvnJ0YEN SsDLGlYvYALCdGBd0YNS+93h6JWFLR+b6wgfCR+R5aYWX9FcmBBzimeWnsYzhQfT 5Au71UwwZnVOKHVglpsErxR91W7kyvMwluOEEbYsqIFRLpL2GtqLzvu66I3/Szk1 jtaCOu4Pqix4gPN36CfU/7YjTJVZAg8/KeuqV2KGc7Q8rMyhAdDPMUOC3XESERAa 8XZYCdbmOAGgniMe4KFpkje0uK1Rh2vM3cRssyCkX5px3iraIk9bCUUThIZmn0ry Uy9lYH0yTqdd8F+edzFrQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrfeehjedgjeduucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvvefufffkofgjfhgggfestdekredtredttdenucfhrhhomheptfgvsggv tggtrgcuvehrrghnuceorhgvsggvtggtrgessghsughiohdrtghomheqnecuggftrfgrth htvghrnhepgeffueeuledvgefgvddvgfetvdduhfefkedukeeikedtudekfeetteeifedv leefnecuvehluhhsthgvrhfuihiivgepudenucfrrghrrghmpehmrghilhhfrhhomheprh gvsggvtggtrgessghsughiohdrtghomh X-ME-Proxy: Feedback-ID: i5b994698:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 15 May 2023 09:59:29 -0400 (EDT) From: "Rebecca Cran" To: devel@edk2.groups.io, Chasel Chiu , Nate DeSimone , Sai Chaganty , Isaac Oram Cc: Rebecca Cran Subject: [PATCH edk2-platforms v2 2/2] Platform/Intel/WhiskeylakeOpenBoardPkg: Delete unused include files Date: Mon, 15 May 2023 07:59:21 -0600 Message-Id: <20230515135921.3299706-3-rebecca@bsdio.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230515135921.3299706-1-rebecca@bsdio.com> References: <20230515135921.3299706-1-rebecca@bsdio.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The following include files appear to be unused, since the build system uses the corresponding files under WhiskeylakeOpenBoardPkg/Include instead: WhiskeylakeOpenBoardPkg/UpXtreme/Include/Library/PeiPlatformHookLib.h WhiskeylakeOpenBoardPkg/UpXtreme/Include/Library/PeiPlatformLib.h WhiskeylakeOpenBoardPkg/UpXtreme/Include/PlatformBoardConfig.h WhiskeylakeOpenBoardPkg/UpXtreme/Include/PlatformInfo.h Since they're unused and could cause confusion, delete them. Signed-off-by: Rebecca Cran --- Platform/Intel/WhiskeylakeOpenBoardPkg/UpXtreme/Include/Library/PeiPlatformHookLib.h | 131 -------------------- Platform/Intel/WhiskeylakeOpenBoardPkg/UpXtreme/Include/Library/PeiPlatformLib.h | 38 ------ Platform/Intel/WhiskeylakeOpenBoardPkg/UpXtreme/Include/PlatformBoardConfig.h | 103 --------------- Platform/Intel/WhiskeylakeOpenBoardPkg/UpXtreme/Include/PlatformInfo.h | 42 ------- 4 files changed, 314 deletions(-) diff --git a/Platform/Intel/WhiskeylakeOpenBoardPkg/UpXtreme/Include/Library/PeiPlatformHookLib.h b/Platform/Intel/WhiskeylakeOpenBoardPkg/UpXtreme/Include/Library/PeiPlatformHookLib.h deleted file mode 100644 index febccdf48282..000000000000 --- a/Platform/Intel/WhiskeylakeOpenBoardPkg/UpXtreme/Include/Library/PeiPlatformHookLib.h +++ /dev/null @@ -1,131 +0,0 @@ -/** @file - UP Xtreme Platform Hook library. - - Copyright (c) 2020, Intel Corporation. All rights reserved.
- SPDX-License-Identifier: BSD-2-Clause-Patent -**/ - -#ifndef _PEI_PLATFORM_HOOK_LIB_H_ -#define _PEI_PLATFORM_HOOK_LIB_H_ - -#include -#include -#include - -// EC Command to provide one byte of debug indication -#define BSSB_DEBUG_INDICATION 0xAE -/** - Configure EC for specific devices - - @param[in] PchLan - The PchLan of PCH_SETUP variable. - @param[in] BootMode - The current boot mode. -**/ -VOID -EcInit ( - IN UINT8 PchLan, - IN EFI_BOOT_MODE BootMode - ); - -/** - Checks if Premium PMIC present - - @retval TRUE if present - @retval FALSE it discrete/other PMIC -**/ -BOOLEAN -IsPremiumPmicPresent ( - VOID - ); - -/** - Pmic Programming to supprort LPAL Feature - - @retval NONE -**/ -VOID -PremiumPmicDisableSlpS0Voltage ( - VOID - ); - -/** -Pmic Programming to supprort LPAL Feature - @retval NONE -**/ -VOID -PremiumPmicEnableSlpS0Voltage( - VOID - ); - -/** - Do platform specific programming pre-memory. For example, EC init, Chipset programming - - @retval Status -**/ -EFI_STATUS -PlatformSpecificInitPreMem ( - VOID - ); - -/** - Do platform specific programming post-memory. - - @retval Status -**/ -EFI_STATUS -PlatformSpecificInit ( - VOID - ); - -/** - Configure GPIO and SIO Before Memory is ready. - - @retval EFI_SUCCESS Operation success. -**/ -EFI_STATUS -BoardInitPreMem ( - VOID - ); - -/** - Configure GPIO and SIO - - @retval EFI_SUCCESS Operation success. -**/ -EFI_STATUS -BoardInit ( - VOID - ); - -/** -Voltage Margining Routine - -@retval EFI_SUCCESS Operation success -**/ -EFI_STATUS -VoltageMarginingRoutine( - VOID - ); - -/** - Detect recovery mode - - @retval EFI_SUCCESS System in Recovery Mode - @retval EFI_UNSUPPORTED System doesn't support Recovery Mode - @retval EFI_NOT_FOUND System is not in Recovery Mode -**/ -EFI_STATUS -IsRecoveryMode ( - VOID - ); - -/** - Early board Configuration before Memory is ready. - - @retval EFI_SUCCESS Operation success. -**/ -EFI_STATUS -BoardInitEarlyPreMem ( - VOID - ); - -#endif diff --git a/Platform/Intel/WhiskeylakeOpenBoardPkg/UpXtreme/Include/Library/PeiPlatformLib.h b/Platform/Intel/WhiskeylakeOpenBoardPkg/UpXtreme/Include/Library/PeiPlatformLib.h deleted file mode 100644 index 2514d2ec444b..000000000000 --- a/Platform/Intel/WhiskeylakeOpenBoardPkg/UpXtreme/Include/Library/PeiPlatformLib.h +++ /dev/null @@ -1,38 +0,0 @@ -/** @file - UP Xtreme platform library. - - Copyright (c) 2020, Intel Corporation. All rights reserved.
- SPDX-License-Identifier: BSD-2-Clause-Patent -**/ - -#ifndef _PEI_PLATFORM_LIB_H_ -#define _PEI_PLATFORM_LIB_H_ - -#define PEI_DEVICE_DISABLED 0 -#define PEI_DEVICE_ENABLED 1 - -typedef struct { - UINT8 Register; - UINT32 Value; -} PCH_GPIO_DEV; - -// -// GPIO Initialization Data Structure -// -typedef struct{ - PCH_GPIO_DEV Use_Sel; - PCH_GPIO_DEV Use_Sel2; - PCH_GPIO_DEV Use_Sel3; - PCH_GPIO_DEV Io_Sel; - PCH_GPIO_DEV Io_Sel2; - PCH_GPIO_DEV Io_Sel3; - PCH_GPIO_DEV Lvl; - PCH_GPIO_DEV Lvl2; - PCH_GPIO_DEV Lvl3; - PCH_GPIO_DEV Inv; - PCH_GPIO_DEV Blink; - PCH_GPIO_DEV Rst_Sel; - PCH_GPIO_DEV Rst_Sel2; -} GPIO_INIT_STRUCT; - -#endif diff --git a/Platform/Intel/WhiskeylakeOpenBoardPkg/UpXtreme/Include/PlatformBoardConfig.h b/Platform/Intel/WhiskeylakeOpenBoardPkg/UpXtreme/Include/PlatformBoardConfig.h deleted file mode 100644 index db6024a1e49d..000000000000 --- a/Platform/Intel/WhiskeylakeOpenBoardPkg/UpXtreme/Include/PlatformBoardConfig.h +++ /dev/null @@ -1,103 +0,0 @@ -/** @file - Header file for UP Xtreme platform board configuration. - - Copyright (c) 2020, Intel Corporation. All rights reserved.
- SPDX-License-Identifier: BSD-2-Clause-Patent -**/ - -#ifndef _PLATFORM_BOARD_CONFIG_H -#define _PLATFORM_BOARD_CONFIG_H - -#include -#include -#include -#include -#include - -#define IS_ALIGNED(addr, size) (((addr) & (size - 1)) ? 0 : 1) -#define ALIGN16(size) (IS_ALIGNED(size, 16) ? size : ((size + 16) & 0xFFF0)) - -#define BOARD_CONFIG_BLOCK_PEI_PREMEM_VERSION 0x00000001 -#define BOARD_CONFIG_BLOCK_PEI_POSTMEM_VERSION 0x00000001 -#define BOARD_CONFIG_BLOCK_DXE_VERSION 0x00000001 -#define BOARD_NO_BATTERY_SUPPORT 0 -#define BOARD_REAL_BATTERY_SUPPORTED BIT0 -#define BOARD_VIRTUAL_BATTERY_SUPPORTED BIT1 - -#pragma pack(1) - -typedef struct { - CONFIG_BLOCK_HEADER Header; ///< Offset 0-27 Config Block Header -} BOARD_CONFIG_BLOCK; - -typedef struct { - UINT8 GpioSupport; - UINT32 WakeGpioNo; - UINT8 HoldRstExpanderNo; - UINT32 HoldRstGpioNo; - BOOLEAN HoldRstActive; - UINT8 PwrEnableExpanderNo; - UINT32 PwrEnableGpioNo; - BOOLEAN PwrEnableActive; -} SWITCH_GRAPHIC_GPIO; - -typedef struct { - UINT8 ClkReqNumber : 4; - UINT8 ClkReqSupported : 1; - UINT8 DeviceResetPadActiveHigh : 1; - UINT32 DeviceResetPad; -} ROOT_PORT_CLK_INFO; - -typedef struct { - UINT8 Section; - UINT8 Pin; -} EXPANDER_GPIO_CONFIG; - -typedef enum { - BoardGpioTypePch, - BoardGpioTypeExpander, - BoardGpioTypeNotSupported = 0xFF -} BOARD_GPIO_TYPE; - -typedef struct { - UINT8 Type; - UINT8 Reserved[3]; // alignment for COMMON_GPIO_CONFIG - union { - UINT32 Pin; - EXPANDER_GPIO_CONFIG Expander; - } u; -} BOARD_GPIO_CONFIG; - -// Do not change the encoding. It must correspond with PCH_PCIE_CLOCK_USAGE from PCH RC. -#define NOT_USED 0xFF -#define FREE_RUNNING 0x80 -#define LAN_CLOCK 0x70 -#define PCIE_PEG 0x40 -#define PCIE_PCH 0x00 - -typedef struct { - UINT32 ClockUsage; - UINT32 ClkReqSupported; -} PCIE_CLOCK_CONFIG; - -typedef union { - UINT64 Blob; - BOARD_GPIO_CONFIG BoardGpioConfig; - ROOT_PORT_CLK_INFO Info; - PCIE_CLOCK_CONFIG PcieClock; -} PCD64_BLOB; - -typedef union { - UINT32 Blob; - USB20_AFE Info; -} PCD32_BLOB; - -#ifndef IO_EXPANDER_DISABLED -#define IO_EXPANDER_DISABLED 0xFF -#endif - -#define SPD_DATA_SIZE 512 - -#pragma pack() - -#endif // _PLATFORM_BOARD_CONFIG_H diff --git a/Platform/Intel/WhiskeylakeOpenBoardPkg/UpXtreme/Include/PlatformInfo.h b/Platform/Intel/WhiskeylakeOpenBoardPkg/UpXtreme/Include/PlatformInfo.h deleted file mode 100644 index 88564e37338d..000000000000 --- a/Platform/Intel/WhiskeylakeOpenBoardPkg/UpXtreme/Include/PlatformInfo.h +++ /dev/null @@ -1,42 +0,0 @@ -/** @file - GUID used for Platform Info Data entries in the HOB list. - - Copyright (c) 2020, Intel Corporation. All rights reserved.
- SPDX-License-Identifier: BSD-2-Clause-Patent -**/ - -#ifndef _PLATFORM_INFO_H_ -#define _PLATFORM_INFO_H_ - -#pragma pack(1) - -/// -/// PCH_GPIO_PAD is equivalent to GPIO_PAD which is defined in GpioConfig.h -/// -typedef UINT32 PCH_GPIO_PAD; //Copied from GpioConfig.h (need to change it based on include) - -typedef struct { -UINT8 Expander; -UINT8 Pin; -UINT16 Reserved; // Reserved for future use -} IO_EXPANDER_PAD; - -typedef union { -PCH_GPIO_PAD PchGpio; -IO_EXPANDER_PAD IoExpGpio; -} GPIO_PAD_CONFIG; - -typedef struct { -UINT8 GpioType; // 0: Disabled (no GPIO support), 1: PCH, 2: I/O Expander -UINT8 Reserved[3]; // Reserved for future use -GPIO_PAD_CONFIG GpioData; -} PACKED_GPIO_CONFIG; - -typedef union { -PACKED_GPIO_CONFIG PackedGpio; -UINT64 Data64; -} COMMON_GPIO_CONFIG; - -#pragma pack() - -#endif -- 2.39.2