From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from NAM02-SN1-obe.outbound.protection.outlook.com (NAM02-SN1-obe.outbound.protection.outlook.com [40.107.96.68]) by mx.groups.io with SMTP id smtpd.web10.36083.1684275396140417297 for ; Tue, 16 May 2023 15:16:36 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="body hash did not verify" header.i=@amd.com header.s=selector1 header.b=v2L9PX/e; spf=permerror, err=parse error for token &{10 18 %{i}._ip.%{h}._ehlo.%{d}._spf.vali.email}: invalid domain name (domain: amd.com, ip: 40.107.96.68, mailfrom: brit.chesley@amd.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ispW84hea8spVzZgqNAawy8x+8aNDS5hw7I49GQ9g0b035xjf4n1I9xMFq9M94NjiSJ6mGyhqc6NEB+UPDX3s4lSpabKGfBJaK5f8ToQU61Yke0mRwiia4x89+17wUQ6mIJgktfH1vLNvuqzsQPqB2SG98MKxSCJzPXA94Ou2Et1xjrhQr8aXqYhMQqsV+RWjskgJZfCAXGYrFdrVjYI62k+B+8Ge1AKDyIOVlUFl9zURDEQrDKG9LMmDXVjdjZyCxfYdqVVvwJW7BiT9MP+gjAxqjdEa0LaXcfLB8q/GWsx96dRiMtfrzitDPjlOe9DxESOhAIu5XXiNoc+9tV+NA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=BWXzS0q8xhf1HfpCnzsZ586CUD1L8iIWP5o/cqAo98k=; b=VXLOlFwxchzmVZu1YOclz6z5R8SKCe3ENbcB3kdqNt5rBNxj1FcJFhHlRhEB8yl00VGTuedW97q6W6x3uAcmmhuSPj2xDqXuL12SqpPW0Hq9QIZPzCgfoMK6lX2b6f2VByVvX+2xEAZMsxbfMpLeQ5nWrw060eZHJ/HDV/QZJEWdQGVgS6GZhCqe4wpXzVOJiSfzaO8nsEipmBlWy0GwcoHoEABANTPd/jmPCKe/QMAdGAq4hahRVqTs8DeIVbMKYX4lwzj46J7BZ0jdrUaXKl0rw2nsIWxKZbykerrWRLhMBh5JxPC3R1ZFTX+IMMoq+E8ZHBbXgD0us2XQM0wCpA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=edk2.groups.io smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=BWXzS0q8xhf1HfpCnzsZ586CUD1L8iIWP5o/cqAo98k=; b=v2L9PX/eKk2wnCKr3SWR1GkqTjpwClOzspVC1RSJOvA4kSWg0+wrhKTTeJLWY8KoO3KIWltIiC6+J5vGJj9CF/5wR97ueDinA8SsFtlJLDosqmC0aagjfBzziOJdoAw9WVEEMcU7cqvNWxnbWRGJyMTebk22q9T0YgbVa/wAlX0= Received: from BN9PR03CA0957.namprd03.prod.outlook.com (2603:10b6:408:108::32) by DS0PR12MB8414.namprd12.prod.outlook.com (2603:10b6:8:fb::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6387.30; Tue, 16 May 2023 22:16:34 +0000 Received: from BN8NAM11FT030.eop-nam11.prod.protection.outlook.com (2603:10b6:408:108:cafe::df) by BN9PR03CA0957.outlook.office365.com (2603:10b6:408:108::32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6387.33 via Frontend Transport; Tue, 16 May 2023 22:16:33 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Received: from SATLEXMB04.amd.com (165.204.84.17) by BN8NAM11FT030.mail.protection.outlook.com (10.13.177.146) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.6411.15 via Frontend Transport; Tue, 16 May 2023 22:16:33 +0000 Received: from aus-g8-bchesley.amd.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Tue, 16 May 2023 17:16:32 -0500 From: brit.chesley@amd.com To: CC: Jian J Wang , Liming Gao , Hao A Wu , Ray Ni Subject: [PATCH v1 1/1] MdeModulePkg: UsbBusDxe: Build Descriptor table after resetting port Date: Tue, 16 May 2023 17:15:57 -0500 Message-ID: <20230516221557.471-1-brit.chesley@amd.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Return-Path: Brit.Chesley@amd.com X-Originating-IP: [10.180.168.240] X-ClientProxiedBy: SATLEXMB03.amd.com (10.181.40.144) To SATLEXMB04.amd.com (10.181.40.145) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BN8NAM11FT030:EE_|DS0PR12MB8414:EE_ X-MS-Office365-Filtering-Correlation-Id: f1667bbd-56d5-492f-cb8e-08db565b3547 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: lTEZLHxIHCNQTanoezB2w/hue3YSdWBP3hQXGgCpy+fgzk0NXf+cL95jZO66csODDpk2QAvHVkDHnyhqEst+LMWCaCn28Wtd3tO8zsemo6Uq5zNikiYV4u4Pm5PT3qdcX9vQm60fwHfKbgZ/r/rTJxpaG0HjiYCBzCfD/Pc4RpkYmfOzwAG7kNuIBOtEe3BZ2JhC+vjeUBE3JadJ22Kdb1RwYS7sUeLoEVqwJaYFi10if4p6xYCN+eCs0jJci0+RW3AkBhbv1p7OF/BRFYJHjV3eRzJ6AlOvImlGeUDmvMX1LQDmUier4AT+MW7LjLFUTsxQk9sL2KcQwDOr2LTkFaQ7CMNueMRLiAKnFCHYh6da3Tmbg2RR6IRsgsvSJGWWbL4wgsfXMfKV8wH0RHN3KAiD1b1dk+CLAet7PEd27wo7l3ddqX/HNfS+5zlvln+IVF9Iw/nVhdeTL6jlls08uQ+98IKuCCPM6NmYhSMBKneAfsyWykvynWzZdiqyFYLWYAr9VLg+evSjQ5umOTEnwZbLsL25ASg8mHUCOYdLYIenO/v0U7wKAO9gwHzV0csmqtOuADsxZj+p//OTZQynZl3bFcHq+KBmYgrJd3Lej1ys4KUlgKgSZ04tjJXPDoxzW9Hwa0X1axf/BJsN1lspIgY3H2sATpf43LmCBVYh4+pVb7h40EW3PsZ2FDPOyO1jq1/OWf9Xpvp0nnXF1X5j9DdL8rR9doYxv/Pb6fzH+/0B8LvPLIloX3oL45RFj68yk1toqPRLedMBseuGTO8Anw== X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230028)(4636009)(376002)(396003)(39860400002)(346002)(136003)(451199021)(40470700004)(36840700001)(46966006)(70206006)(54906003)(6916009)(4326008)(478600001)(70586007)(7696005)(6666004)(8676002)(8936002)(40480700001)(41300700001)(316002)(2906002)(2876002)(5660300002)(1076003)(26005)(82740400003)(81166007)(356005)(82310400005)(86362001)(336012)(2616005)(426003)(40460700003)(186003)(16526019)(36860700001)(47076005)(36756003)(36900700001);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 May 2023 22:16:33.8498 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: f1667bbd-56d5-492f-cb8e-08db565b3547 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: BN8NAM11FT030.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR12MB8414 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain From: Britton Chesley Fixed a bug which led to an ASSERT due to the USB device context being maintained after a port reset, but the underlying XHCI context was uninitialized. Added build descriptor table call in UsbIoPortReset Cc: Jian J Wang Cc: Liming Gao Cc: Hao A Wu Cc: Ray Ni Signed-off-by: Britton Chesley --- MdeModulePkg/Bus/Usb/UsbBusDxe/UsbBus.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/MdeModulePkg/Bus/Usb/UsbBusDxe/UsbBus.c b/MdeModulePkg/Bus/Usb= /UsbBusDxe/UsbBus.c index c25f3cc2f279..55e0e1f16cdb 100644 --- a/MdeModulePkg/Bus/Usb/UsbBusDxe/UsbBus.c +++ b/MdeModulePkg/Bus/Usb/UsbBusDxe/UsbBus.c @@ -882,6 +882,12 @@ UsbIoPortReset ( // is in CONFIGURED state. // if (Dev->ActiveConfig !=3D NULL) { + Status =3D UsbBuildDescTable (Dev); + + if (EFI_ERROR (Status)) { + DEBUG ((DEBUG_ERROR, "UsbIoPortReset: failed to build descriptor tab= le - %r\n", Status)); + } + Status =3D UsbSetConfig (Dev, Dev->ActiveConfig->Desc.ConfigurationVal= ue); =20 if (EFI_ERROR (Status)) { --=20 2.36.1