From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from EUR04-DB3-obe.outbound.protection.outlook.com (EUR04-DB3-obe.outbound.protection.outlook.com [40.107.6.61]) by mx.groups.io with SMTP id smtpd.web10.21866.1684847088044692149 for ; Tue, 23 May 2023 06:04:48 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@armh.onmicrosoft.com header.s=selector2-armh-onmicrosoft-com header.b=hZQRCDh8; spf=pass (domain: arm.com, ip: 40.107.6.61, mailfrom: sami.mujawar@arm.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=y8aJhuAl6ETi1Bx9hOwiSyXNzSbktUpFXHM0N6PVZlo=; b=hZQRCDh8iJ4Nt2cej6lhyxL1026cDtlxW3I3pWCpfQ53pCUqsQaj771p/VXx11nOM+fyUVydkWcrk75uj4AqPFec7Bl2Nz8H2VCDXY1n1KgQLKWJNgfx7S0QE00qgNxzFFIp4AkCcBsHu4mlWxne7dJ0w5P4OQxjP55dJ2ZeIVk= Received: from DUZPR01CA0281.eurprd01.prod.exchangelabs.com (2603:10a6:10:4b9::9) by AS8PR08MB9244.eurprd08.prod.outlook.com (2603:10a6:20b:5a3::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6411.29; Tue, 23 May 2023 13:04:44 +0000 Received: from DBAEUR03FT028.eop-EUR03.prod.protection.outlook.com (2603:10a6:10:4b9:cafe::93) by DUZPR01CA0281.outlook.office365.com (2603:10a6:10:4b9::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6411.29 via Frontend Transport; Tue, 23 May 2023 13:04:44 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DBAEUR03FT028.mail.protection.outlook.com (100.127.142.236) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6433.14 via Frontend Transport; Tue, 23 May 2023 13:04:44 +0000 Received: ("Tessian outbound 5154e9d36775:v136"); Tue, 23 May 2023 13:04:44 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: e701691b83968c72 X-CR-MTA-TID: 64aa7808 Received: from d82ada020686.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id F8CA9E3E-B876-48A8-ADB2-9307DD521391.1; Tue, 23 May 2023 13:04:33 +0000 Received: from EUR01-VE1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id d82ada020686.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Tue, 23 May 2023 13:04:33 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=hnneqsJBzdNyuf2uxOlPFctCJsiPa76AxHD3qSyq6nUL3VhjHiL42RATXQk9RITS4qAFfP0lQUdeFfU17/gDRmSWYOlb2HXzWePHJIQVBOWbDr4ZFX+kNvAoJ5BEOh8XrV2fHr6ZiOVxwXQpJwkVgxTd1MYTLwYwKrxooEzU8QC9qJpV6XBsLU2HYtx04iI2jHqTqZ4sozBPPUlFhCzVAbZW9rDfDOkWLVtoH1eJNLZJvas7L0cLG8M3ErCv3I57FKA9XQBVkq1ALTBGbCmIxJ06uXJgxqYC8pjbBE3AHZlhr1UWUNPiO0ywY4ptKP4SaVSqMulOxgPeIgDgLUUAxg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=y8aJhuAl6ETi1Bx9hOwiSyXNzSbktUpFXHM0N6PVZlo=; b=ExkLxsZvtj2hAAvFDWQSyPPM5MoH9bO+C0bpxCQn1Dg9PqZvogk8U8FuYlMXscd47h7G1cEqDI46nuzJCprR+3OENNESYIsYSJsHglz0fpSmExThDfe/cFDnRc9dOEVostvCml3VvGaps11zD3Ep4dXfEdo7DB5vC5B2d8M0FTPY4lAKCiEqu6P0siWQwp+5z0Ix/4KbY9Yf+1/ySTQbB3a5BwN/khbVIAMq2K0DuLpAR7PibY/iy98qSgURuJW9Ed+rYWbMAYSouPXgp5ezJ9mMY5Tc9k+552aDz0EciRJ3pvv2QOVW7gYm4INMhMLvKcpG8a/lZzdiJDVsYXzBFg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 40.67.248.234) smtp.rcpttodomain=edk2.groups.io smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=y8aJhuAl6ETi1Bx9hOwiSyXNzSbktUpFXHM0N6PVZlo=; b=hZQRCDh8iJ4Nt2cej6lhyxL1026cDtlxW3I3pWCpfQ53pCUqsQaj771p/VXx11nOM+fyUVydkWcrk75uj4AqPFec7Bl2Nz8H2VCDXY1n1KgQLKWJNgfx7S0QE00qgNxzFFIp4AkCcBsHu4mlWxne7dJ0w5P4OQxjP55dJ2ZeIVk= Received: from AS8PR04CA0206.eurprd04.prod.outlook.com (2603:10a6:20b:2f3::31) by DB8PR08MB5497.eurprd08.prod.outlook.com (2603:10a6:10:11a::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6411.28; Tue, 23 May 2023 13:04:28 +0000 Received: from AM7EUR03FT004.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:2f3:cafe::65) by AS8PR04CA0206.outlook.office365.com (2603:10a6:20b:2f3::31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6411.29 via Frontend Transport; Tue, 23 May 2023 13:04:28 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 40.67.248.234) smtp.mailfrom=arm.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 40.67.248.234 as permitted sender) receiver=protection.outlook.com; client-ip=40.67.248.234; helo=nebula.arm.com; pr=C Received: from nebula.arm.com (40.67.248.234) by AM7EUR03FT004.mail.protection.outlook.com (100.127.140.210) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.6433.14 via Frontend Transport; Tue, 23 May 2023 13:04:28 +0000 Received: from AZ-NEU-EX04.Arm.com (10.251.24.32) by AZ-NEU-EX04.Arm.com (10.251.24.32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23; Tue, 23 May 2023 13:04:23 +0000 Received: from E114225.Arm.com (10.1.196.36) by mail.arm.com (10.251.24.32) with Microsoft SMTP Server id 15.1.2507.23 via Frontend Transport; Tue, 23 May 2023 13:04:23 +0000 From: "Sami Mujawar" To: CC: Sami Mujawar , , , , , , , , , , Subject: [PATCH v1 02/12] ArmPkg: Fix data type used for GicInterruptInterfaceBase Date: Tue, 23 May 2023 14:04:11 +0100 Message-ID: <20230523130421.10804-3-sami.mujawar@arm.com> X-Mailer: git-send-email 2.16.2.windows.1 In-Reply-To: <20230523130421.10804-1-sami.mujawar@arm.com> References: <20230523130421.10804-1-sami.mujawar@arm.com> MIME-Version: 1.0 X-EOPAttributedMessage: 1 X-MS-TrafficTypeDiagnostic: AM7EUR03FT004:EE_|DB8PR08MB5497:EE_|DBAEUR03FT028:EE_|AS8PR08MB9244:EE_ X-MS-Office365-Filtering-Correlation-Id: fe800745-caf2-4d06-c03c-08db5b8e4774 x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: H43/tnG4bOo3BQutsJ1tUkfS0KJx9FCwM4cTPRtebraPjIaY//M7hepkNKUMsHpOQug+w71BCj0fdLmd5/coPZf87r2JcDgWYckveGjwlU6dAqWbhn93i4N6qj5UGCLjbpnlR75NnvvM2dOpWk2t7orgA7vr/xnOMnSL9ZArrDC6W6HMr9iOowViIArd3VI8W0dw16qM2NjlXvOFACpq8aUFMX15HsUB5exwHz1PhGsUuKWHRxw06L7ZPHi4Vl8XFXqOlUZm56u5x14tJVcKQ7F3d/1+6k1YN+04vKNEUCgANQp99sIaIUNKywOuW+gz2niWGhoz+rChDGmqlZTqgV05VvB2c7IZ/jKk7xCPcPdmbhGVWzCK4N40euYaLVQxHM3CJLcGUDJsLJLxa2htgJY6LzBGwcA+khzpvEmtY4Kfa6Fav+Qf6+xKRJ3HqONZS28sUyhNJ6fCnJ6GMUccTeSj0HUaA7QaO7zReU953AGr7obaJuWrBv1PKoNCaBkRxIUWRhBhUF//Jvm15pPkD+fvf4SJaniGocJ6rEnRdNorFRxGb0sWlUq7GBUQ5w5KcGIQGbGENxDiRdtcXwtCKqfAjUQ++zLzQakHUbag9b2d60LY6m/AUlp7rfpt32GlPBpRFfSoQ6ODwepKquXZ5Gu7XFKYnKu5sILlkG0BS9gikppqa61B2njdKrchsMZYyrytA2r3KfLL4eFAyzMqPWAviumGgDoe1UHbKi+/FLUVvOXaZc+sqXijLG9wWp8y7eDdFqBjtDxxDYPjYL+jsw== X-Forefront-Antispam-Report-Untrusted: CIP:40.67.248.234;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:nebula.arm.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230028)(4636009)(39860400002)(136003)(346002)(396003)(376002)(451199021)(40470700004)(36840700001)(46966006)(54906003)(41300700001)(7696005)(82310400005)(316002)(6916009)(4326008)(356005)(6666004)(70586007)(81166007)(70206006)(82740400003)(5660300002)(8676002)(8936002)(86362001)(19627235002)(478600001)(44832011)(47076005)(83380400001)(1076003)(26005)(2906002)(40460700003)(186003)(36860700001)(36756003)(2616005)(40480700001)(336012)(426003)(36900700001);DIR:OUT;SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB8PR08MB5497 Return-Path: Sami.Mujawar@arm.com X-MS-Exchange-Transport-CrossTenantHeadersStripped: DBAEUR03FT028.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: e6539ff9-27c4-49e1-6eb4-08db5b8e3e0f X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: fIPrpH1G4bOIPh/mp/Ag3IdyHbjMuJ0TcUWFuptX0E0BrJGAJGZd/BkwhOa1RTfWHwBbKOLWgtKUQNMrDcgL9Mo8NIiO+dd69tZVsSMxg3sMrhhqqg0hvzJJB7K1qi5liOJnt8ugnUTYKbuKGNG05C/AaJldWLtfOColHvJNJQuE6PscAwQkkAKLeHMioSTVtCWwpoc5wDl4I0Tkd8vx165eXSWPYPz49/CeePyswGMwXZLxr0kcpl03R9ocbHjPsKIw7jGb8wUE4Qt0bCjzIgxq2M20NJFONZohk5jWA6hNRCk/eO2XeY9o1wpxQex0vLNzsIUUKb9Xj1PqbuX62c10U5p0l73n1arXtisOicbQzOZiX+RSJIjJ1lPmhYRr1Qg2DMRxmXto56CjWqgcWA/101gtDHaR0WnLy6h0cgB2XTYQkVV9eEiRdosroRXXU2odcBN2/r7kt3Z6QYl8xravMrUhnEd0KqrvZ5tlwuZOocZSJuGu7LsATK/bxXUnA+taGujaabcH0cBagdEkxxG9+T/V+tl6jF53l+CAUrD4qJRoUnPDxDIybpye809cSnSKYzS3VyEZszJfqRZav/Co5s8oYAoCxRd82eL4vgTH9rCabqrJDnHNm0+zjg6qrqapygAAV4rom685r3xy6hIdZhytl83YqQ3N7xGT5Yujc63JhTSZ55xZaT8B2Qk8aHd4z0sBV0OtT7/Nst3rKGsPhthjFvHlB+QvxLsW9QdvfsX5jTyteg0YZwPevWTy X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230028)(4636009)(39860400002)(346002)(136003)(396003)(376002)(451199021)(36840700001)(46966006)(40470700004)(316002)(4326008)(6916009)(70206006)(70586007)(426003)(336012)(478600001)(19627235002)(82310400005)(54906003)(8676002)(8936002)(7696005)(86362001)(6666004)(41300700001)(5660300002)(26005)(44832011)(36756003)(36860700001)(82740400003)(83380400001)(1076003)(81166007)(47076005)(186003)(40460700003)(2906002)(2616005)(40480700001);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 May 2023 13:04:44.5374 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: fe800745-caf2-4d06-c03c-08db5b8e4774 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DBAEUR03FT028.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB9244 Content-Type: text/plain The data type used by variables representing the GicInterruptInterfaceBase has been inconsistently used in the ArmGic driver and the library. The PCD defined for the GIC Interrupt interface base address is UINT64. However, the data types for the variables used is UINTN, INTN, and at some places UINT32. Therefore, update the data types to use UINTN and add necessary typecasts when reading values from the PCD. This should then be consistent across AArch32 and AArch64 builds. Signed-off-by: Sami Mujawar --- ArmPkg/Drivers/ArmGic/ArmGicLib.c | 13 ++++++++++--- ArmPkg/Drivers/ArmGic/GicV2/ArmGicV2Dxe.c | 2 +- ArmPkg/Drivers/ArmGic/GicV2/ArmGicV2NonSecLib.c | 6 +++--- ArmPkg/Include/Library/ArmGicLib.h | 18 +++++++++--------- 4 files changed, 23 insertions(+), 16 deletions(-) diff --git a/ArmPkg/Drivers/ArmGic/ArmGicLib.c b/ArmPkg/Drivers/ArmGic/ArmGicLib.c index 6e44e89390fcdaa89302d6505f75c43c84ce3535..78edc7e76a087caa5b91d896f9bd316d6530a668 100644 --- a/ArmPkg/Drivers/ArmGic/ArmGicLib.c +++ b/ArmPkg/Drivers/ArmGic/ArmGicLib.c @@ -104,10 +104,17 @@ GicGetCpuRedistributorBase ( return 0; } +/** + Return the GIC CPU Interrupt Interface ID. + + @param GicInterruptInterfaceBase Base address of the GIC Interrupt Interface. + + @retval CPU Interface Identification information. +**/ UINTN EFIAPI ArmGicGetInterfaceIdentification ( - IN INTN GicInterruptInterfaceBase + IN UINTN GicInterruptInterfaceBase ) { // Read the GIC Identification Register @@ -400,7 +407,7 @@ ArmGicDisableDistributor ( VOID EFIAPI ArmGicEnableInterruptInterface ( - IN INTN GicInterruptInterfaceBase + IN UINTN GicInterruptInterfaceBase ) { ARM_GIC_ARCH_REVISION Revision; @@ -418,7 +425,7 @@ ArmGicEnableInterruptInterface ( VOID EFIAPI ArmGicDisableInterruptInterface ( - IN INTN GicInterruptInterfaceBase + IN UINTN GicInterruptInterfaceBase ) { ARM_GIC_ARCH_REVISION Revision; diff --git a/ArmPkg/Drivers/ArmGic/GicV2/ArmGicV2Dxe.c b/ArmPkg/Drivers/ArmGic/GicV2/ArmGicV2Dxe.c index b7d67d830e46b663e4054990e7456660fb22cda9..b952c3ae31c060ecbb43c0800d34e57664a8262a 100644 --- a/ArmPkg/Drivers/ArmGic/GicV2/ArmGicV2Dxe.c +++ b/ArmPkg/Drivers/ArmGic/GicV2/ArmGicV2Dxe.c @@ -400,7 +400,7 @@ GicV2DxeInitialize ( // the system. ASSERT_PROTOCOL_ALREADY_INSTALLED (NULL, &gHardwareInterruptProtocolGuid); - mGicInterruptInterfaceBase = PcdGet64 (PcdGicInterruptInterfaceBase); + mGicInterruptInterfaceBase = (UINTN)PcdGet64 (PcdGicInterruptInterfaceBase); mGicDistributorBase = (UINTN)PcdGet64 (PcdGicDistributorBase); mGicNumInterrupts = ArmGicGetMaxNumInterrupts (mGicDistributorBase); diff --git a/ArmPkg/Drivers/ArmGic/GicV2/ArmGicV2NonSecLib.c b/ArmPkg/Drivers/ArmGic/GicV2/ArmGicV2NonSecLib.c index 85c2a920a54a1acaccb98a94b5591ce36d20697c..832f21644233655ef2f359f1e175071d2a493b7c 100644 --- a/ArmPkg/Drivers/ArmGic/GicV2/ArmGicV2NonSecLib.c +++ b/ArmPkg/Drivers/ArmGic/GicV2/ArmGicV2NonSecLib.c @@ -1,6 +1,6 @@ /** @file * -* Copyright (c) 2011-2014, ARM Limited. All rights reserved. +* Copyright (c) 2011-2021, Arm Limited. All rights reserved. * * SPDX-License-Identifier: BSD-2-Clause-Patent * @@ -13,7 +13,7 @@ VOID EFIAPI ArmGicV2EnableInterruptInterface ( - IN INTN GicInterruptInterfaceBase + IN UINTN GicInterruptInterfaceBase ) { /* @@ -26,7 +26,7 @@ ArmGicV2EnableInterruptInterface ( VOID EFIAPI ArmGicV2DisableInterruptInterface ( - IN INTN GicInterruptInterfaceBase + IN UINTN GicInterruptInterfaceBase ) { // Disable Gic Interface diff --git a/ArmPkg/Include/Library/ArmGicLib.h b/ArmPkg/Include/Library/ArmGicLib.h index 72dbd1ca8d626c69d9bb8727d77fd34b4ab3af28..41bbf1da6a6cbb683df4bb30c4b1a1762dc7814f 100644 --- a/ArmPkg/Include/Library/ArmGicLib.h +++ b/ArmPkg/Include/Library/ArmGicLib.h @@ -113,7 +113,7 @@ UINTN EFIAPI ArmGicGetInterfaceIdentification ( - IN INTN GicInterruptInterfaceBase + IN UINTN GicInterruptInterfaceBase ); // GIC Secure interfaces @@ -122,7 +122,7 @@ EFIAPI ArmGicSetupNonSecure ( IN UINTN MpId, IN UINTN GicDistributorBase, - IN INTN GicInterruptInterfaceBase + IN UINTN GicInterruptInterfaceBase ); VOID @@ -136,13 +136,13 @@ ArmGicSetSecureInterrupts ( VOID EFIAPI ArmGicEnableInterruptInterface ( - IN INTN GicInterruptInterfaceBase + IN UINTN GicInterruptInterfaceBase ); VOID EFIAPI ArmGicDisableInterruptInterface ( - IN INTN GicInterruptInterfaceBase + IN UINTN GicInterruptInterfaceBase ); VOID @@ -203,8 +203,8 @@ ArmGicEndOfInterrupt ( UINTN EFIAPI ArmGicSetPriorityMask ( - IN INTN GicInterruptInterfaceBase, - IN INTN PriorityMask + IN UINTN GicInterruptInterfaceBase, + IN INTN PriorityMask ); VOID @@ -252,19 +252,19 @@ EFIAPI ArmGicV2SetupNonSecure ( IN UINTN MpId, IN UINTN GicDistributorBase, - IN INTN GicInterruptInterfaceBase + IN UINTN GicInterruptInterfaceBase ); VOID EFIAPI ArmGicV2EnableInterruptInterface ( - IN INTN GicInterruptInterfaceBase + IN UINTN GicInterruptInterfaceBase ); VOID EFIAPI ArmGicV2DisableInterruptInterface ( - IN INTN GicInterruptInterfaceBase + IN UINTN GicInterruptInterfaceBase ); UINTN -- 'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)'