From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from EUR04-HE1-obe.outbound.protection.outlook.com (EUR04-HE1-obe.outbound.protection.outlook.com [40.107.7.51]) by mx.groups.io with SMTP id smtpd.web10.9082.1684935550665196480 for ; Wed, 24 May 2023 06:39:11 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@armh.onmicrosoft.com header.s=selector2-armh-onmicrosoft-com header.b=g5qhrbYM; spf=pass (domain: arm.com, ip: 40.107.7.51, mailfrom: sami.mujawar@arm.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=hn7xhGhgegZB4dkBiZZWTyeRUiBVuY9xPNbIPE6vbWo=; b=g5qhrbYM9GIq0quYqUi310yRwECzgzsw3ct4OHZLetJXhTZGmCsFNU+KZR+tmmil/JQbqcPFZycbXIRVqFOftnsFGxwvLrPGBejr4MQfm7TaO5FGcXikqG0G/uPcxKnZmqFDV8E4E/VUdGyKOwjd9+9HeW9FOieD79wUDrtbLMY= Received: from AM6PR01CA0064.eurprd01.prod.exchangelabs.com (2603:10a6:20b:e0::41) by PAVPR08MB9746.eurprd08.prod.outlook.com (2603:10a6:102:31d::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6411.29; Wed, 24 May 2023 13:39:02 +0000 Received: from AM7EUR03FT053.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:e0:cafe::7) by AM6PR01CA0064.outlook.office365.com (2603:10a6:20b:e0::41) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6433.15 via Frontend Transport; Wed, 24 May 2023 13:39:02 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM7EUR03FT053.mail.protection.outlook.com (100.127.140.202) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6433.15 via Frontend Transport; Wed, 24 May 2023 13:39:02 +0000 Received: ("Tessian outbound 99a3040377ca:v136"); Wed, 24 May 2023 13:39:02 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: c258d0f7f664c26c X-CR-MTA-TID: 64aa7808 Received: from ead3a07d0422.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 6D46B453-0B31-4EC6-BE0F-738AEFE2CD4B.1; Wed, 24 May 2023 13:38:51 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id ead3a07d0422.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Wed, 24 May 2023 13:38:51 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=bt8eXNG4tCH4hN06Uw10JAaVnbzKbal1QMgC74q4+g4djaJIUjWtBUA427JtpEq7HEBDqB5YwOBMwvdrgnu/nwvdxIfGlH32pLUonR9sttCgmivCEaf0idwNjGirXqPQgKBDsL4rnmfZc7mNE3V5Og5Gzx8v0nOFaf40FsRYdkJO41pu8pLBI6FzkLyo56Qr2RAyMhyF7F9RkOKoj0eHVyjS6OqrZE1X4T+CmZCRz+d5kcDAUTYoaoVJU5MHLxMa/E2HIfM6jrRnrHpYsZMfIu0InK3bZsyW93otootyJpl2+d7XSVjo1KIrFHJj+mXY3JWO/ZpM4k/xsKhAoOJl6Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=hn7xhGhgegZB4dkBiZZWTyeRUiBVuY9xPNbIPE6vbWo=; b=FF5PsWe2cVX2UL7CuD+myUq1RYKLtfxmSjB7Xol2Qbb5cyGDg8fjGEG6oqOFXHMFQgYlM3Pa/Gk+Ibzf/GRZTn5AKvA4MA0x81EPMjgNgaSSLEbWmapab08RcEQVcxw/N1YDVrpyXAkFHaj/yLopPH/eha24cCfiokQ8Hxd+mtdtGygfJPuA01hJNmzpENKHPZGKhFMpdP+EcG8QwiXmRFw1+CMCpxEPkU3/YCcx9eagfthiwUN3OubswH/4LsZFyKDp3Rq0Z78tdJzvLrDyvl+0Ew0L8RASDBy1WEsGPr0ydpCafKUckU8Ms+c2On4rx03AoGnMyWaLVOiFcqqTbg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 40.67.248.234) smtp.rcpttodomain=edk2.groups.io smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=hn7xhGhgegZB4dkBiZZWTyeRUiBVuY9xPNbIPE6vbWo=; b=g5qhrbYM9GIq0quYqUi310yRwECzgzsw3ct4OHZLetJXhTZGmCsFNU+KZR+tmmil/JQbqcPFZycbXIRVqFOftnsFGxwvLrPGBejr4MQfm7TaO5FGcXikqG0G/uPcxKnZmqFDV8E4E/VUdGyKOwjd9+9HeW9FOieD79wUDrtbLMY= Received: from AS9PR05CA0052.eurprd05.prod.outlook.com (2603:10a6:20b:489::10) by DU0PR08MB9774.eurprd08.prod.outlook.com (2603:10a6:10:445::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6411.29; Wed, 24 May 2023 13:38:48 +0000 Received: from AM7EUR03FT051.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:489:cafe::3e) by AS9PR05CA0052.outlook.office365.com (2603:10a6:20b:489::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6411.29 via Frontend Transport; Wed, 24 May 2023 13:38:47 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 40.67.248.234) smtp.mailfrom=arm.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 40.67.248.234 as permitted sender) receiver=protection.outlook.com; client-ip=40.67.248.234; helo=nebula.arm.com; pr=C Received: from nebula.arm.com (40.67.248.234) by AM7EUR03FT051.mail.protection.outlook.com (100.127.140.64) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.6433.16 via Frontend Transport; Wed, 24 May 2023 13:38:47 +0000 Received: from AZ-NEU-EX04.Arm.com (10.251.24.32) by AZ-NEU-EX03.Arm.com (10.251.24.31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23; Wed, 24 May 2023 13:38:44 +0000 Received: from E114225.Arm.com (10.1.196.36) by mail.arm.com (10.251.24.32) with Microsoft SMTP Server id 15.1.2507.23 via Frontend Transport; Wed, 24 May 2023 13:38:44 +0000 From: "Sami Mujawar" To: CC: Sami Mujawar , , , , , , , , , , Subject: [PATCH v2 07/11] ArmPkg: Typecast IntID to UINT32 in ArmGicV2EndOfInterrupt Date: Wed, 24 May 2023 14:38:36 +0100 Message-ID: <20230524133840.28612-8-sami.mujawar@arm.com> X-Mailer: git-send-email 2.16.2.windows.1 In-Reply-To: <20230524133840.28612-1-sami.mujawar@arm.com> References: <20230524133840.28612-1-sami.mujawar@arm.com> MIME-Version: 1.0 X-EOPAttributedMessage: 1 X-MS-TrafficTypeDiagnostic: AM7EUR03FT051:EE_|DU0PR08MB9774:EE_|AM7EUR03FT053:EE_|PAVPR08MB9746:EE_ X-MS-Office365-Filtering-Correlation-Id: 77fa3973-81b7-47c9-b5ee-08db5c5c3c87 x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: 0sDjHEY6/1pK8A5pvvKUcsFrx6UjV7hcYYGfCwHlJvZOeqaEaRM+QUKdBl50zZQa1mwXuFUvs/qZAjde82JggEqrpqE0M2sdMs8KWG7SasGlKW5ZftN2bQ3fyXYOwhISN4bZnj8DtYAXQprq33f1RseXoDmHjljA3oitbfQRJ06dGGOEi4VyodX135Z7XMppff7K5Uw84gTLCNtqj9CrIp9FmRkCAno2asHy8vlsADs6vr9c0Pmv3kMobqtK1tobteEiDNO0q5Bx3xNxkQhQEb3MkcrKqL2pqAaIEAIRYm9IeLi2n0QFKkVX8i2kvrgPf629xKGj0pxOTF7VhkrWv5CDLerq3Z71xkCaD1LGbJQbGwdsyxItSdFVLh1gOXYwg9H1xTTQcCyWAxVwdp2Bgd6pBez98208QN74DJMko0ncrbJrqCmtEvsUsWMh+r8DNFyUidBRub//KvJqdJ3+zSjbMqfmEiTtHOZ414fL7xYN7tAsXUKLG6iPHVZaermmoPlJofM1NrEKRoioXu9P5ws+VXpBaa3YWyCg/jUrQmWVgy7hpos9vwVT7tVLEDXmCQGyXCTQqDf+XTTdt5fxxJF6EirhiKd6pVXOCHnxHHT2rNdQo+hivYAZIOHcLcbRRa4Bta4ifk3PrN0EN/3uPlxehY6+OvNr86VliKRjm9i539umdnzdwNiJcj8ASSlmekfzeD+Ne2E9drX/rTZWZKWYicEXFg26fThWxIJ+mLw= X-Forefront-Antispam-Report-Untrusted: CIP:40.67.248.234;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:nebula.arm.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230028)(6029001)(4636009)(346002)(39860400002)(136003)(376002)(396003)(451199021)(36840700001)(46966006)(70586007)(4326008)(966005)(70206006)(478600001)(316002)(6916009)(19627235002)(54906003)(36756003)(83380400001)(47076005)(5660300002)(26005)(426003)(2616005)(336012)(1076003)(186003)(36860700001)(41300700001)(8676002)(8936002)(44832011)(2906002)(6666004)(7696005)(82310400005)(40480700001)(86362001)(81166007)(82740400003)(356005)(36900700001);DIR:OUT;SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU0PR08MB9774 Return-Path: Sami.Mujawar@arm.com X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM7EUR03FT053.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 5a29a1b9-57d9-4ca8-7e17-08db5c5c33ac X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: xWpky5pROb5cmsuALHyHoHqEXh31eWFB+Q4bVEgxobriypKAsBOTdem9uDBTqcUBiwgD2odV9zVSj76UQWtoZ2Ls29eGfwxT2GMW70wJiE8DIKojQ4TFtGECfBm9GOZia6CglNXw2QWgykMqKTids7it2FrOrxghf+OaOpAUzP7w6hBi/JBatjB7qaKXP9qv8QLOSG7TP5mXYiw8SoSOKr3EGBTOWs7l/+vpJfMXi/vjEftmodW1sCNVU0mf6hCK591saCr9n1otSuHoNfIfhV986/wP32Ls2HaP0fIHvAiYloRmGf8wNUqdh3HZZzhhMsUoDI3/+UM7Ll2bDiAWUF9wsT2+NRFw6gRGcZoZVm09gvTc27U5GmJptPDx207vBGj97A8MpJzzQLai6xOaBEkelqkN0OtoHHK79s7egQoKjWegacDLQA64dak3euI+IzzELiOJWC6wW339HYLKIE16jeHXEVLcYwjXmCzmeY+qo0ZIc0KBtp2Vhz4GsZ7y6QTVfP7x5Q+OKf+JP9KyjnijAIhpfrvE/tCj85zGc5v8zn1vSWeNybD1pSN/TpxbuWwEWSl8mlEfCAMYs7zJR1FB0qaZG8appwTMgtfyQD9Njdf8DdFWUJAp7Jh8aW9zCcLB1cFuLAaXDEZIbJJy7lRRAeY50bHGj9GcHftQkEWEyNb+rZQrLEm1ISycVZvirADpczqbiQW8Vxh/z3+cDUYPQYzWr3ZDqzcLFYHJyKY= X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230028)(6029001)(4636009)(396003)(39860400002)(136003)(376002)(346002)(451199021)(36840700001)(46966006)(40470700004)(83380400001)(47076005)(54906003)(336012)(426003)(19627235002)(2616005)(86362001)(478600001)(36860700001)(8936002)(6916009)(70206006)(8676002)(4326008)(70586007)(2906002)(81166007)(6666004)(316002)(186003)(1076003)(26005)(82740400003)(7696005)(36756003)(82310400005)(40480700001)(40460700003)(5660300002)(44832011)(41300700001)(966005);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 May 2023 13:39:02.3768 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 77fa3973-81b7-47c9-b5ee-08db5c5c3c87 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM7EUR03FT053.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAVPR08MB9746 Content-Type: text/plain The EIOR register of the Gic CPU interface is a 32 bit register. However, the HARDWARE_INTERRUPT_SOURCE used to represent the interrupt source (Interrupt ID) is typedefed as UINTN, see EmbeddedPkg\Include\Protocol\HardwareInterrupt.h Therfore, typecast the interrupt ID (Source) value to UINT32 before setting the EOIR register. Also, add an assert to check that the value does not exceed 32 bits. Signed-off-by: Sami Mujawar --- Notes: v2: - Assert condition should be <= [Ard] - Fixed assert condition as per feedback and [Sami] also updated copyright year. - Ref: https://edk2.groups.io/g/devel/message/105187 ArmPkg/Drivers/ArmGic/GicV2/ArmGicV2Lib.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/ArmPkg/Drivers/ArmGic/GicV2/ArmGicV2Lib.c b/ArmPkg/Drivers/ArmGic/GicV2/ArmGicV2Lib.c index f403bec367b5254c248e620e56471904e520f9f2..d21caa90e5def04ff9666939c879de4aa772f97e 100644 --- a/ArmPkg/Drivers/ArmGic/GicV2/ArmGicV2Lib.c +++ b/ArmPkg/Drivers/ArmGic/GicV2/ArmGicV2Lib.c @@ -1,12 +1,13 @@ /** @file * -* Copyright (c) 2013-2014, ARM Limited. All rights reserved. +* Copyright (c) 2013-2023, ARM Limited. All rights reserved. * * SPDX-License-Identifier: BSD-2-Clause-Patent * **/ #include +#include #include UINTN @@ -26,5 +27,6 @@ ArmGicV2EndOfInterrupt ( IN UINTN Source ) { - MmioWrite32 (GicInterruptInterfaceBase + ARM_GIC_ICCEIOR, Source); + ASSERT (Source <= MAX_UINT32); + MmioWrite32 (GicInterruptInterfaceBase + ARM_GIC_ICCEIOR, (UINT32)Source); } -- 'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)'