From: "Gerd Hoffmann" <kraxel@redhat.com>
To: devel@edk2.groups.io
Cc: "Daniel Schaefer" <git@danielschaefer.me>,
"Marvin Häuser" <mhaeuser@posteo.de>,
"Rebecca Cran" <rebecca@bsdio.com>,
"Oliver Steffen" <osteffen@redhat.com>,
"Liming Gao" <gaoliming@byosoft.com.cn>,
"Pawel Polawski" <ppolawsk@redhat.com>,
"Chao Li" <lichao@loongson.cn>,
"Ard Biesheuvel" <ardb+tianocore@kernel.org>,
"Bob Feng" <bob.c.feng@intel.com>,
"Sunil V L" <sunilvl@ventanamicro.com>,
"Michael D Kinney" <michael.d.kinney@intel.com>,
"Leif Lindholm" <quic_llindhol@quicinc.com>,
"Dongyan Qian" <qiandongyan@loongson.cn>,
"Yuwei Chen" <yuwei.chen@intel.com>,
"Baoqi Zhang" <zhangbaoqi@loongson.cn>,
"Zhiguang Liu" <zhiguang.liu@intel.com>,
"Gerd Hoffmann" <kraxel@redhat.com>,
"Ard Biesheuvel" <ardb@kernel.org>
Subject: [PATCH v6 01/11] BaseTools: make sure the got is empty
Date: Wed, 24 May 2023 16:05:50 +0200 [thread overview]
Message-ID: <20230524140600.1432056-2-kraxel@redhat.com> (raw)
In-Reply-To: <20230524140600.1432056-1-kraxel@redhat.com>
Add ASSERT()s that .got and .got.plt sections are empty
to linker scripts for gcc and clang.
Suggested-by: Ard Biesheuvel <ardb@kernel.org>
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
Reviewed-by: Liming Gao <gaoliming@byosoft.com.cn>
Reviewed-by: Rebecca Cran <rebecca@bsdio.com>
---
BaseTools/Scripts/ClangBase.lds | 10 ++++++++++
BaseTools/Scripts/GccBase.lds | 10 ++++++++++
2 files changed, 20 insertions(+)
diff --git a/BaseTools/Scripts/ClangBase.lds b/BaseTools/Scripts/ClangBase.lds
index 61452ddd9506..c7dcd2024ac8 100644
--- a/BaseTools/Scripts/ClangBase.lds
+++ b/BaseTools/Scripts/ClangBase.lds
@@ -59,6 +59,16 @@ SECTIONS {
KEEP (*(.hii))
}
+ .got : {
+ *(.got)
+ }
+ ASSERT(SIZEOF(.got) == 0, "Unexpected GOT entries detected!")
+
+ .got.plt (INFO) : {
+ *(.got.plt)
+ }
+ ASSERT(SIZEOF(.got.plt) == 0 || SIZEOF(.got.plt) == 0xc || SIZEOF(.got.plt) == 0x18, "Unexpected GOT/PLT entries detected!")
+
/*
* Retain the GNU build id but in a non-allocatable section so GenFw
* does not copy it into the PE/COFF image.
diff --git a/BaseTools/Scripts/GccBase.lds b/BaseTools/Scripts/GccBase.lds
index 83cebd29d599..9f27e83bb0fc 100644
--- a/BaseTools/Scripts/GccBase.lds
+++ b/BaseTools/Scripts/GccBase.lds
@@ -59,6 +59,16 @@ SECTIONS {
KEEP (*(.hii))
}
+ .got : {
+ *(.got)
+ }
+ ASSERT(SIZEOF(.got) == 0, "Unexpected GOT entries detected!")
+
+ .got.plt (INFO) : {
+ *(.got.plt)
+ }
+ ASSERT(SIZEOF(.got.plt) == 0 || SIZEOF(.got.plt) == 0xc || SIZEOF(.got.plt) == 0x18, "Unexpected GOT/PLT entries detected!")
+
/*
* Retain the GNU build id but in a non-allocatable section so GenFw
* does not copy it into the PE/COFF image.
--
2.40.1
next prev parent reply other threads:[~2023-05-24 14:06 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-24 14:05 [PATCH v6 00/11] BaseTools: remove duplicate includes Gerd Hoffmann
2023-05-24 14:05 ` Gerd Hoffmann [this message]
2023-05-24 14:05 ` [PATCH v6 02/11] BaseTools: add -fdirect-access-external-data to clang pie builds Gerd Hoffmann
2023-06-01 8:00 ` 回复: " gaoliming
2023-06-01 8:38 ` [edk2-devel] " Ard Biesheuvel
2023-06-01 8:59 ` 回复: " gaoliming
2023-08-23 11:08 ` [edk2-devel] " Leif Lindholm
2023-08-23 14:59 ` Ard Biesheuvel
2023-05-24 14:05 ` [PATCH v6 03/11] MdePkg: don't set visibility to hidden Gerd Hoffmann
2023-05-24 14:05 ` [PATCH v6 04/11] BaseTools: remove WinNtInclude.h Gerd Hoffmann
2023-05-24 14:05 ` [PATCH v6 05/11] BaseTools: remove duplicate includes: <arch>/ProcessorBind.h Gerd Hoffmann
2023-05-24 14:05 ` [PATCH v6 06/11] BaseTools: remove duplicate includes: IndustryStandard/Acpi*.h Gerd Hoffmann
2023-05-24 14:05 ` [PATCH v6 07/11] MdePkg/PeImage.h: add bits from BaseTools version Gerd Hoffmann
2023-05-24 14:05 ` [PATCH v6 08/11] BaseTools: drop IMAGE_FILE_MACHINE_ARM hacks Gerd Hoffmann
2023-05-24 14:05 ` [PATCH v6 09/11] BaseTools: switch from EFI_IMAGE_MACHINE_* to IMAGE_FILE_MACHINE_* Gerd Hoffmann
2023-05-24 14:05 ` [PATCH v6 10/11] BaseTools: remove duplicate includes: IndustryStandard/PeImage.h Gerd Hoffmann
2023-05-24 14:06 ` [PATCH v6 11/11] BaseTools: remove duplicate includes: IndustryStandard/*.h Gerd Hoffmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230524140600.1432056-2-kraxel@redhat.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox