From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (NAM12-DM6-obe.outbound.protection.outlook.com [40.107.243.82]) by mx.groups.io with SMTP id smtpd.web10.3906.1685428421120372516 for ; Mon, 29 May 2023 23:33:41 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="body hash did not verify" header.i=@amd.com header.s=selector1 header.b=e53kr9pV; spf=permerror, err=parse error for token &{10 18 %{i}._ip.%{h}._ehlo.%{d}._spf.vali.email}: invalid domain name (domain: amd.com, ip: 40.107.243.82, mailfrom: abner.chang@amd.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=liz3X2HHpNJ/Vd0UjdNJuMi259MuBnxorl95MyyKCQ3WnWgOocM8Gw8oSncZwK2XHPZRSkkONotCgL8ee8sd8zTod7x5pndO0qRBl/fv+Xsrzo1rXNe4ZyOk79x75hQ2AxHAfbJSC8EabSUKKlo6A5FDjfis9FSw2B18BOHK08ccbRHrteld6710wO4cXnfzUvfxhdOKdmQaeazumfJU11JEKH/m1YPw+35kEy3/OY8rvdwcgmbHzjmrxblLTn9R5l7uGHjfXUFPpRBQ66Yl/AWOK9JaUi0h1dJBF0PyAy/JNeXV5+CkqbstEHnuWAqIZKUN4Q8Nv8LLpeHDO7LN+w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=XpmNWv5+HCYR+R9houXcz4YXvpbIzBiQjctwujdYHqU=; b=JQZtyQ9aPCt0WO5RxD3TDCykG5ZUBvUQCaqg2gc37ebGcEIEYLJYv13k4PK48sFrxnH21AAXaOhlpo3Wd9fhzzgbEi5J4gZ++oc1bN5DJTgk5fs5ew6niqtto0ZxMwEVOhmkoEY/MKu9x8grVi76Y+LqMtQqmwIRw8hIgETP2YNwNCWXx9fSKoxfLXKIqDSjFPOYLsHIMUR5TdeRgeuH2K1uJplimv1VIBKPXjBACWbSsq4gvJxkyI/zxUFonH3j3i5xj71ilkFJ1FIJ1tWqND+uClhMbNHuNQ1CXVzCCMmPZ9TIZqyUsl16VHJAOEFYnYQfFZHL9o3h9QCqTYssFQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=edk2.groups.io smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=XpmNWv5+HCYR+R9houXcz4YXvpbIzBiQjctwujdYHqU=; b=e53kr9pVHBJmhOEgU+HpiI/tAxSX3XZxADKjON8fFpCTo/v1RjL00cHPCKwFBjZszv0cennVKumJgO44IYd8ihN+3Qz+eaVH1fnNV9ILMFAeiT0ilPKK9Z68TUiVMHjTs3sisJke6Zs0QeW0Ei7JrwxS9Bvyw9g+yPHQGcGHSlk= Received: from BN8PR15CA0061.namprd15.prod.outlook.com (2603:10b6:408:80::38) by CH3PR12MB7498.namprd12.prod.outlook.com (2603:10b6:610:143::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6433.23; Tue, 30 May 2023 06:33:37 +0000 Received: from BN8NAM11FT018.eop-nam11.prod.protection.outlook.com (2603:10b6:408:80:cafe::8) by BN8PR15CA0061.outlook.office365.com (2603:10b6:408:80::38) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6433.23 via Frontend Transport; Tue, 30 May 2023 06:33:37 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Received: from SATLEXMB04.amd.com (165.204.84.17) by BN8NAM11FT018.mail.protection.outlook.com (10.13.176.89) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.6455.21 via Frontend Transport; Tue, 30 May 2023 06:33:37 +0000 Received: from TPE-L1-ABNCHANG.amd.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Tue, 30 May 2023 01:33:35 -0500 From: "Chang, Abner" To: CC: Isaac Oram , Abdul Lateef Attar , Nickle Wang , Tinh Nguyen Subject: [edk2-platforms][PATCH 2/2] ManageabilityPkg: Use DEBUG_MANAGEABILITY Date: Tue, 30 May 2023 14:33:16 +0800 Message-ID: <20230530063316.46-2-abner.chang@amd.com> X-Mailer: git-send-email 2.37.1.windows.1 In-Reply-To: <20230530063316.46-1-abner.chang@amd.com> References: <20230530063316.46-1-abner.chang@amd.com> MIME-Version: 1.0 Return-Path: Abner.Chang@amd.com X-Originating-IP: [10.180.168.240] X-ClientProxiedBy: SATLEXMB04.amd.com (10.181.40.145) To SATLEXMB04.amd.com (10.181.40.145) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BN8NAM11FT018:EE_|CH3PR12MB7498:EE_ X-MS-Office365-Filtering-Correlation-Id: 57ed9316-7751-4799-c1e0-08db60d7ccbc X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: ZFCOL1cIwVzXo1009/wG/kDALNXlHJO0O0n389bBu241Uu9UbgeM5wjGKXK5K7+qDtTh4TZ6NBlstoQXcHhRI7IZzsFkqeOdzpm2gTYSrTWwuTWcEXdvi+8nbND4nte+o3fkd7TJoOJysIc77No7yHn3XeWSr07xOhYJCx2T747K6kx78Smo33KLQ37TDUfO9o8zl6QvX0A+zzMjOgoneUVC0hIHQtOWW/148W0OYl16JyWu8QkJOz2zvBtMy9M74PggIV9eTtt1kXvcKwrEdzJG/LHTDus1Mk6anJ+MJEcpqtbvizpPkvxqzne8ta7nfZLl1NTn+X4keC5zdRAsgOYs5WdjQ1hmB8z/TpQBSHVM4CwlsqLq1teb9iyAzKvEszAAUdt5QCmskpUkpwkEnF80Mx/qJsawL4E/GGiq3sf26TeAwu2NpWRMpOqORg0f7idURPikcMQXAy/AeOTMs3rH5ky8VL/xI9FMmZV4RFtZLx/ycCuh6ptaHmj6KHsOapiYM/acMCp0fbUFeJy+o+LP9WT7tY8Bj0sA2iEnVcRPZhtLeIoZGihsIAGDc2//+K9ZBpEt3Bpm2fz9jKxabHrfdwDRxGN3qWUiyFAZvHZCozx/Jrd6B53oYr+7HOgG6VgHzul10zK8zYiqAzqD+H7WuRYq2/M/H5db7NqMfBq6zFimwsYbIHCzbRt4YhwSB2HSUZ5OGl5UTeQ7/PDVit6u0dpBpuRU5gFzKmYx9Kz1avaa4VA2NPIr9K8qx+wesUOcCtplOSC8tKp05mrdgg== X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230028)(4636009)(396003)(39860400002)(346002)(136003)(376002)(451199021)(46966006)(36840700001)(40470700004)(186003)(16526019)(2616005)(41300700001)(426003)(336012)(83380400001)(26005)(1076003)(36860700001)(7696005)(6666004)(47076005)(478600001)(40460700003)(54906003)(356005)(4326008)(6916009)(82740400003)(70206006)(70586007)(40480700001)(316002)(81166007)(5660300002)(8936002)(8676002)(2906002)(86362001)(82310400005)(2876002)(36756003)(36900700001);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 May 2023 06:33:37.1746 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 57ed9316-7751-4799-c1e0-08db60d7ccbc X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: BN8NAM11FT018.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH3PR12MB7498 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain From: Abner Chang Use debug print level DEBUG_MANAGEABILITY in ManageabilityPkg. Signed-off-by: Abner Chang Cc: Isaac Oram Cc: Abdul Lateef Attar Cc: Nickle Wang Cc: Tinh Nguyen --- .../Library/ManageabilityTransportHelperLib.h | 2 +- .../BaseManageabilityTransportHelper.c | 2 +- .../Universal/IpmiBmcAcpi/BmcAcpi.c | 6 ++++-- .../Universal/IpmiBmcElog/BmcElog.c | 4 +++- .../ManageabilityPkg/Universal/IpmiFrb/FrbDxe.c | 8 +++++--- .../PldmSmbiosTransferDxe/PldmSmbiosTransferDxe.c | 14 +++++++------- 6 files changed, 21 insertions(+), 15 deletions(-) diff --git a/Features/ManageabilityPkg/Include/Library/ManageabilityTranspo= rtHelperLib.h b/Features/ManageabilityPkg/Include/Library/ManageabilityTran= sportHelperLib.h index 11a1bd0521..dfe32189ad 100644 --- a/Features/ManageabilityPkg/Include/Library/ManageabilityTransportHelpe= rLib.h +++ b/Features/ManageabilityPkg/Include/Library/ManageabilityTransportHelpe= rLib.h @@ -11,7 +11,7 @@ =20 #include =20 -#define DEBUG_MANAGEABILITY_INFO DEBUG_INFO +#define DEBUG_MANAGEABILITY_INFO DEBUG_MANAGEABILITY =20 typedef struct _MANAGEABILITY_PROTOCOL_NAME MANAGEABILITY_PROTOCOL_NAME; =20 diff --git a/Features/ManageabilityPkg/Library/BaseManageabilityTransportHe= lperLib/BaseManageabilityTransportHelper.c b/Features/ManageabilityPkg/Libr= ary/BaseManageabilityTransportHelperLib/BaseManageabilityTransportHelper.c index f72957ea7f..27bc5eaddf 100644 --- a/Features/ManageabilityPkg/Library/BaseManageabilityTransportHelperLib= /BaseManageabilityTransportHelper.c +++ b/Features/ManageabilityPkg/Library/BaseManageabilityTransportHelperLib= /BaseManageabilityTransportHelper.c @@ -163,7 +163,7 @@ HelperAcquireManageabilityTransport ( CHAR16 *ManageabilityProtocolName; CHAR16 *ManageabilityTransportName; =20 - DEBUG ((DEBUG_INFO, "%a: Entry\n", __func__)); + DEBUG ((DEBUG_MANAGEABILITY_INFO, "%a: Entry\n", __func__)); if ((TransportToken =3D=3D NULL) || (ManageabilityProtocolSpec =3D=3D NU= LL)) { DEBUG ((DEBUG_ERROR, "%a: One of the required input parameters is NULL= .\n", __func__)); return EFI_INVALID_PARAMETER; diff --git a/Features/ManageabilityPkg/Universal/IpmiBmcAcpi/BmcAcpi.c b/Fe= atures/ManageabilityPkg/Universal/IpmiBmcAcpi/BmcAcpi.c index cf066dd095..d04623ecad 100644 --- a/Features/ManageabilityPkg/Universal/IpmiBmcAcpi/BmcAcpi.c +++ b/Features/ManageabilityPkg/Universal/IpmiBmcAcpi/BmcAcpi.c @@ -24,6 +24,8 @@ #include #include =20 +#include + #ifndef EFI_ACPI_CREATOR_ID #define EFI_ACPI_CREATOR_ID SIGNATURE_32 ('M', 'S', 'F', 'T') #endif @@ -140,7 +142,7 @@ UpdateDeviceSsdtTable ( // // Update IO(Decode16, 0xCA2, 0xCA2, 0, 2) // - DEBUG ((DEBUG_INFO, "UpdateDeviceSsdtTable - IPMI\n")); + DEBUG ((DEBUG_MANAGEABILITY_INFO, "UpdateDeviceSsdtTable - IPMI\n")); for (DataPtr =3D (UINT8 *)(Table + 1); DataPtr < (UINT8 *)((UINT8 *)Table + Table->Length - 4); DataPtr++) @@ -158,7 +160,7 @@ UpdateDeviceSsdtTable ( ASSERT (IoRsc->Header.Bits.Type =3D=3D ACPI_SMALL_ITEM_FLAG); ASSERT (IoRsc->Header.Bits.Name =3D=3D ACPI_SMALL_IO_PORT_DESCRIPTOR= _NAME); ASSERT (IoRsc->Header.Bits.Length =3D=3D sizeof (EFI_ACPI_IO_PORT_DE= SCRIPTOR) - sizeof (ACPI_SMALL_RESOURCE_HEADER)); - DEBUG ((DEBUG_INFO, "IPMI IO Base in ASL update - 0x%04x <=3D 0x%04x= \n", IoRsc->BaseAddressMin, PcdGet16 (PcdIpmiKcsIoBaseAddress))); + DEBUG ((DEBUG_MANAGEABILITY_INFO, "IPMI IO Base in ASL update - 0x%0= 4x <=3D 0x%04x\n", IoRsc->BaseAddressMin, PcdGet16 (PcdIpmiKcsIoBaseAddress= ))); IoRsc->BaseAddressMin =3D PcdGet16 (PcdIpmiKcsIoBaseAddress); IoRsc->BaseAddressMax =3D PcdGet16 (PcdIpmiKcsIoBaseAddress); } diff --git a/Features/ManageabilityPkg/Universal/IpmiBmcElog/BmcElog.c b/Fe= atures/ManageabilityPkg/Universal/IpmiBmcElog/BmcElog.c index 02873fc4c6..8b34b2d2d5 100644 --- a/Features/ManageabilityPkg/Universal/IpmiBmcElog/BmcElog.c +++ b/Features/ManageabilityPkg/Universal/IpmiBmcElog/BmcElog.c @@ -15,6 +15,8 @@ SPDX-License-Identifier: BSD-2-Clause-Patent #include #include =20 +#include + EFI_STATUS EFIAPI CheckIfSelIsFull ( @@ -186,7 +188,7 @@ CheckIfSelIsFull ( // Check the Bit7 of the OperationByte if SEL is OverFlow. // SelIsFull =3D (SelInfo.OperationSupport & 0x80); - DEBUG ((DEBUG_INFO, "SelIsFull - 0x%x\n", SelIsFull)); + DEBUG ((DEBUG_MANAGEABILITY_INFO, "SelIsFull - 0x%x\n", SelIsFull)); =20 return EFI_SUCCESS; } diff --git a/Features/ManageabilityPkg/Universal/IpmiFrb/FrbDxe.c b/Feature= s/ManageabilityPkg/Universal/IpmiFrb/FrbDxe.c index 46f741eed1..40ae0c3ecc 100644 --- a/Features/ManageabilityPkg/Universal/IpmiFrb/FrbDxe.c +++ b/Features/ManageabilityPkg/Universal/IpmiFrb/FrbDxe.c @@ -16,6 +16,8 @@ SPDX-License-Identifier: BSD-2-Clause-Patent #include #include =20 +#include + /** This routine disables the specified FRB timer. =20 @@ -159,7 +161,7 @@ ReportFrb2Status ( // Status =3D IpmiGetWatchdogTimer (&GetWatchdogTimer); if (EFI_ERROR (Status)) { - DEBUG ((DEBUG_INFO, "Failed to get Watchdog Timer info from BMC.\n")); + DEBUG ((DEBUG_ERROR, "Failed to get Watchdog Timer info from BMC.\n"))= ; return Status; } =20 @@ -167,9 +169,9 @@ ReportFrb2Status ( // Check if timer is running, report status to DEBUG_MODE output. // if (GetWatchdogTimer.TimerUse.Bits.TimerRunning =3D=3D 1) { - DEBUG ((DEBUG_INFO, "FRB2 Timer is running.\n")); + DEBUG ((DEBUG_MANAGEABILITY_INFO, "FRB2 Timer is running.\n")); } else { - DEBUG ((DEBUG_INFO, "FRB2 Timer is not running.\n")); + DEBUG ((DEBUG_MANAGEABILITY_INFO, "FRB2 Timer is not running.\n")); } =20 return EFI_SUCCESS; diff --git a/Features/ManageabilityPkg/Universal/PldmSmbiosTransferDxe/Pldm= SmbiosTransferDxe.c b/Features/ManageabilityPkg/Universal/PldmSmbiosTransfe= rDxe/PldmSmbiosTransferDxe.c index f897162bb5..fdf033f0b1 100644 --- a/Features/ManageabilityPkg/Universal/PldmSmbiosTransferDxe/PldmSmbiosT= ransferDxe.c +++ b/Features/ManageabilityPkg/Universal/PldmSmbiosTransferDxe/PldmSmbiosT= ransferDxe.c @@ -147,7 +147,7 @@ GetSmbiosStructureTableMetaData ( EFI_STATUS Status; UINT32 ResponseSize; =20 - DEBUG ((DEBUG_INFO, "%a: Set SMBIOS structure table metafile.\n", __func= __)); + DEBUG ((DEBUG_MANAGEABILITY_INFO, "%a: Set SMBIOS structure table metafi= le.\n", __func__)); =20 ResponseSize =3D sizeof (PLDM_SMBIOS_STRUCTURE_TABLE_METADATA); Status =3D PldmSubmitCommand ( @@ -194,7 +194,7 @@ SetSmbiosStructureTableMetaData ( UINT32 ResponseSize; UINT32 RequestSize; =20 - DEBUG ((DEBUG_INFO, "%a: Get SMBIOS structure table metafile.\n", __func= __)); + DEBUG ((DEBUG_MANAGEABILITY_INFO, "%a: Get SMBIOS structure table metafi= le.\n", __func__)); =20 RequestSize =3D sizeof (PLDM_SMBIOS_STRUCTURE_TABLE_METADATA); ResponseSize =3D 0; @@ -236,7 +236,7 @@ GetSmbiosStructureTable ( OUT UINT32 *BufferSize ) { - DEBUG ((DEBUG_INFO, "%a: Unsupported.\n", __func__)); + DEBUG ((DEBUG_MANAGEABILITY_INFO, "%a: Unsupported.\n", __func__)); // Only support PLDM SMBIOS Transfer push mode. return EFI_UNSUPPORTED; } @@ -272,7 +272,7 @@ SetSmbiosStructureTable ( EFI_SMBIOS_TABLE_HEADER *Record; PLDM_SET_SMBIOS_STRUCTURE_TABLE_REQUEST *PldmSetSmbiosStructureTable; =20 - DEBUG ((DEBUG_INFO, "%a: Set SMBIOS structure table.\n", __func__)); + DEBUG ((DEBUG_MANAGEABILITY_INFO, "%a: Set SMBIOS structure table.\n", _= _func__)); =20 Status =3D gBS->LocateProtocol ( &gEfiSmbiosProtocolGuid, @@ -422,7 +422,7 @@ GetSmbiosStructureByType ( OUT UINT32 *BufferSize ) { - DEBUG ((DEBUG_INFO, "%a: Unsupported.\n", __func__)); + DEBUG ((DEBUG_MANAGEABILITY_INFO, "%a: Unsupported.\n", __func__)); // Only support PLDM SMBIOS Transfer push mode. return EFI_UNSUPPORTED; } @@ -451,7 +451,7 @@ GetSmbiosStructureByHandle ( OUT UINT32 *BufferSize ) { - DEBUG ((DEBUG_INFO, "%a: Unsupported.\n", __func__)); + DEBUG ((DEBUG_MANAGEABILITY_INFO, "%a: Unsupported.\n", __func__)); // Only support PLDM SMBIOS Transfer push mode. return EFI_UNSUPPORTED; } @@ -486,7 +486,7 @@ DxePldmSmbiosTransferEntry ( EFI_HANDLE Handle; EFI_STATUS Status; =20 - DEBUG ((DEBUG_INFO, "%a: Entry.\n", __func__)); + DEBUG ((DEBUG_MANAGEABILITY_INFO, "%a: Entry.\n", __func__)); =20 SetSmbiosStructureTableHandle =3D 0; =20 --=20 2.37.1.windows.1