From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from NAM04-BN8-obe.outbound.protection.outlook.com (NAM04-BN8-obe.outbound.protection.outlook.com [40.107.100.53]) by mx.groups.io with SMTP id smtpd.web11.4365.1685430571456055180 for ; Tue, 30 May 2023 00:09:32 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="body hash did not verify" header.i=@amd.com header.s=selector1 header.b=wIpavxGI; spf=permerror, err=parse error for token &{10 18 %{i}._ip.%{h}._ehlo.%{d}._spf.vali.email}: invalid domain name (domain: amd.com, ip: 40.107.100.53, mailfrom: abner.chang@amd.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=n2NGcmn9pE98dYQ8R8VKxhkFQuF6hS6rB0NyLD/BSA4pGEJSwJADpWtlZAo57iw9DQd7ehgjPAj0ZoMW4Vd8cvSkTZ9OrkG+LUrZ4rJ5umBzSSp7tWrt0GXwyNoF+u3lgHuBt8/8wKSJBQdud2H3brmaatqdxXQdClLSsN+Fy/7GLu1Vb4SOETlI8VH9uweEZ7tOBDkeBoZwc/DZaWLbowq8H8pi/YVeUSbWcUFHc1Y9bqM29+7o+OzoHRDZFWR1/qbEFEu8crld+b2nVtYYqmcAKk4eraDruNElKHNJt5gy6pEGbleEOKIU7w1DjOXt84/b/kVTDvFbjvtrZOIo8Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=TqPQsh0r7Ez9W5K6I1A7tB9mkIFdnqWHD3kD07jT1F4=; b=n8xjp/VAbi59TNfWMd1WjN0IE91cATw/sfgV8zQmrWK2qaraUvgWtJLUzdIUOaX+remNZFZMN5Ve6dY9dS2bn84y/P001Zv1OpxOkuQt6hfTBBYNwhcHlUCz7BmyOGqV48rb1NV9AaUF2piesaLcp9mbCUbyG3D0UKjDqMubze9UOVA4n5+OvG40ycTOpGFQziad6pBduNPdNOfFY5zdKPrEhRRu6/lqK1XfvRrJ9Xe7WMjYGCjXjZ3mREebCIShtMm3udT09EzBnZb0UfsZuyT7tN8Z+GABbSm8SrGaWrx3fh1wpGi+jEDbUGKgXiSMuEI5Ni3tZl2TBv88FsVvbw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=edk2.groups.io smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=TqPQsh0r7Ez9W5K6I1A7tB9mkIFdnqWHD3kD07jT1F4=; b=wIpavxGIIQSjUR34Jq8PUvBcB11dv+HfIQaweEDDAAyZ1Ruly3WVlhiKdWkJPrsJy8AZUB70Kpcrr2CCOWC9WcDCo6bjjXo/JP3quPHz/VULjeaUaLSbicmrZsVPzIEl+LhCoYCzXICy3vEVtU/O4p6gW8OZCcFs1wXumN8SwuU= Received: from MW4PR03CA0134.namprd03.prod.outlook.com (2603:10b6:303:8c::19) by MW4PR12MB6974.namprd12.prod.outlook.com (2603:10b6:303:207::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6433.23; Tue, 30 May 2023 07:09:28 +0000 Received: from CO1NAM11FT086.eop-nam11.prod.protection.outlook.com (2603:10b6:303:8c:cafe::d1) by MW4PR03CA0134.outlook.office365.com (2603:10b6:303:8c::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6433.23 via Frontend Transport; Tue, 30 May 2023 07:09:28 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Received: from SATLEXMB04.amd.com (165.204.84.17) by CO1NAM11FT086.mail.protection.outlook.com (10.13.175.73) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.6455.21 via Frontend Transport; Tue, 30 May 2023 07:09:27 +0000 Received: from TPE-L1-ABNCHANG.amd.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Tue, 30 May 2023 02:09:25 -0500 From: "Chang, Abner" To: CC: Nickle Wang , Igor Kulchytskyy Subject: [PATCH] RedfishPkg: Use DEBUG_MANAGEABILITY Date: Tue, 30 May 2023 15:09:15 +0800 Message-ID: <20230530070915.731-1-abner.chang@amd.com> X-Mailer: git-send-email 2.37.1.windows.1 MIME-Version: 1.0 Return-Path: Abner.Chang@amd.com X-Originating-IP: [10.180.168.240] X-ClientProxiedBy: SATLEXMB04.amd.com (10.181.40.145) To SATLEXMB04.amd.com (10.181.40.145) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CO1NAM11FT086:EE_|MW4PR12MB6974:EE_ X-MS-Office365-Filtering-Correlation-Id: f75676f8-2278-433b-0003-08db60dccea7 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: uW6jePAoL0CI9AiZ2JlCGLysun0AT7Lao0W4IMZg5ACcH+DGOwSJrSBX3UNz+7xogM+aKxKEDX9ssAY3fkSkVEoDuxMS4V/ozoGYJ61L0ItuaLob0oDiuz7V6IQhFyZdXsI6nrBLWO12gfeLKqtBzJ1wa8xN0vVaq/4JgBjklr1iZcQSS0liJ4KAlupz0dUap/BOr/Rkpi1xMGpNEhWUSMqdqq4U/jgKKj1JEWwywy1oiuVZclo2fiR5dVjKuZbDCpMYOUefzAa8jf8Inpyl3/tiYii4howc9vTd0AvmZLd9uCa2CV5PRlivQXhIramUxdKvE8XC0v/SiAMCdKkTjzLOEeBdDTc0Dh3fvCS5G53OzmXA5H5+r/HF+yX+DeYw8+pkk7guz//fSy6Tk3mJo4nWawSjZ4YRj8GUfOCKGOuGvV0t+ERdAG/nwKTBzVphXuDcVwAaO9ajde+AKEJw4ZLeBkE25jEC/zi36wxh1WdpgMq0yzyMrVkDS1u1CqSU7CWHlz8ip2p3xH4FGfr1SfXZG6X3owDvAEQxPsZmT7f6iatXTVIWQQYpwcEn6oZpjWxZMrSEJT+G3Od4xT+Ud8yAvV58jOOiBkqyZcvKU3ic6su0ZGNspFjjIlE8mMCWFd7NuFhSqxncR7F5e5iEmPN2/+/1nMMQ2/je/rfQOCP5i+w19xDFNZGAcO5vp8wA2SZvV4AxzZyEtbE8+PZPUnk8p5hpBQOa8CbozIqzrbW40y62W7aCHWFW4sm9d7Dz/sMRnEvJSqIZZrA21fiXWw== X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230028)(4636009)(136003)(376002)(346002)(396003)(39860400002)(451199021)(40470700004)(46966006)(36840700001)(478600001)(19627235002)(8676002)(8936002)(54906003)(41300700001)(7696005)(5660300002)(86362001)(6666004)(316002)(4326008)(6916009)(70586007)(70206006)(1076003)(82310400005)(26005)(2876002)(186003)(83380400001)(2616005)(336012)(426003)(47076005)(40460700003)(16526019)(30864003)(2906002)(36860700001)(40480700001)(36756003)(81166007)(82740400003)(356005)(36900700001);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 May 2023 07:09:27.7773 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: f75676f8-2278-433b-0003-08db60dccea7 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: CO1NAM11FT086.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR12MB6974 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain From: Abner Chang Use debug print level DEBUG_MANAGEABILITY in RedfishPkg. Signed-off-by: Abner Chang Cc: Nickle Wang Cc: Igor Kulchytskyy --- RedfishPkg/Include/Library/RedfishDebugLib.h | 4 +- .../PlatformHostInterfaceBmcUsbNicLib.c | 22 +++++----- .../RedfishPlatformCredentialIpmiLib.c | 8 ++-- .../RedfishCrtLib/RedfishCrtLib.c | 2 +- .../PrivateLibrary/RedfishLib/RedfishLib.c | 8 ++-- .../RedfishLib/edk2libredfish/src/service.c | 10 ++--- .../RedfishConfigHandlerCommon.c | 2 +- .../RedfishConfigHandlerDriver.c | 2 +- .../RedfishDiscoverDxe/RedfishDiscoverDxe.c | 44 +++++++++---------- .../RedfishHostInterfaceDxe.c | 10 ++--- .../RedfishRestExDxe/RedfishRestExImpl.c | 2 +- .../RedfishRestExDxe/RedfishRestExProtocol.c | 8 ++-- 12 files changed, 61 insertions(+), 61 deletions(-) diff --git a/RedfishPkg/Include/Library/RedfishDebugLib.h b/RedfishPkg/Incl= ude/Library/RedfishDebugLib.h index 913f2b2f358..73f1469ac62 100644 --- a/RedfishPkg/Include/Library/RedfishDebugLib.h +++ b/RedfishPkg/Include/Library/RedfishDebugLib.h @@ -14,8 +14,8 @@ #include #include =20 -#define DEBUG_REDFISH_NETWORK DEBUG_INFO ///< Debug error level = for Redfish networking function -#define DEBUG_REDFISH_HOST_INTERFACE DEBUG_INFO ///< Debug error level = for Redfish networking function +#define DEBUG_REDFISH_NETWORK DEBUG_MANAGEABILITY ///< Debug err= or level for Redfish networking function +#define DEBUG_REDFISH_HOST_INTERFACE DEBUG_MANAGEABILITY ///< Debug err= or level for Redfish networking function =20 /** =20 diff --git a/RedfishPkg/Library/PlatformHostInterfaceBmcUsbNicLib/PlatformH= ostInterfaceBmcUsbNicLib.c b/RedfishPkg/Library/PlatformHostInterfaceBmcUsb= NicLib/PlatformHostInterfaceBmcUsbNicLib.c index 4bd01850af9..d18d83b9380 100644 --- a/RedfishPkg/Library/PlatformHostInterfaceBmcUsbNicLib/PlatformHostInte= rfaceBmcUsbNicLib.c +++ b/RedfishPkg/Library/PlatformHostInterfaceBmcUsbNicLib/PlatformHostInte= rfaceBmcUsbNicLib.c @@ -37,7 +37,7 @@ ProbeRedfishCredentialBootstrap ( UINT32 ResponseSize; BOOLEAN ReturnBool; =20 - DEBUG ((DEBUG_INFO, "%a: Entry\n", __func__)); + DEBUG ((DEBUG_MANAGEABILITY, "%a: Entry\n", __func__)); =20 // // IPMI callout to NetFn 2C, command 02 @@ -94,7 +94,7 @@ RedfishPlatformHostInterfaceDeviceDescriptor ( HOST_INTERFACE_BMC_USB_NIC_INFO *ThisInstance; REDFISH_INTERFACE_DATA *InterfaceData; =20 - DEBUG ((DEBUG_INFO, "%a: Entry\n", __func__)); + DEBUG ((DEBUG_MANAGEABILITY, "%a: Entry\n", __func__)); =20 if (IsListEmpty (&mBmcUsbNic)) { return EFI_NOT_FOUND; @@ -166,7 +166,7 @@ RedfishPlatformHostInterfaceProtocolData ( UINT8 HostNameLength; CHAR8 *HostNameString; =20 - DEBUG ((DEBUG_INFO, "%a: Entry\n", __func__)); + DEBUG ((DEBUG_MANAGEABILITY, "%a: Entry\n", __func__)); =20 if (IsListEmpty (&mBmcUsbNic) || (IndexOfProtocolData > 0)) { return EFI_NOT_FOUND; @@ -300,7 +300,7 @@ RetrievedBmcUsbNicInfo ( IPMI_LAN_VLAN_ID *LanVlanId; EFI_USB_DEVICE_DESCRIPTOR UsbDeviceDescriptor; =20 - DEBUG ((DEBUG_INFO, "%a: Entry\n", __func__)); + DEBUG ((DEBUG_MANAGEABILITY, "%a: Entry\n", __func__)); =20 if (IsListEmpty (&mBmcUsbNic)) { return EFI_NOT_FOUND; @@ -605,7 +605,7 @@ HostInterfaceIpmiCheckMacAddress ( EFI_MAC_ADDRESS IpmiLanChannelMacAddress= ; BOOLEAN AlreadyCached; =20 - DEBUG ((DEBUG_INFO, "%a: Entry.\n", __func__)); + DEBUG ((DEBUG_MANAGEABILITY, "%a: Entry.\n", __func__)); =20 GetLanConfigReps =3D NULL; AlreadyCached =3D FALSE; @@ -823,7 +823,7 @@ UsbNicSearchUsbIo ( EFI_DEVICE_PATH_PROTOCOL *ThisUsbDevicePath; EFI_DEVICE_PATH_PROTOCOL *ThisUsbDevicePathEnd; =20 - DEBUG ((DEBUG_INFO, "%a: Entry.\n", __func__)); + DEBUG ((DEBUG_MANAGEABILITY, "%a: Entry.\n", __func__)); DEBUG ((DEBUG_REDFISH_HOST_INTERFACE, "Device path on the EFI handle whi= ch has UsbIo and SNP instaleld on it.\n")); DevicePathStr =3D ConvertDevicePathToText (UsbDevicePath, FALSE, FALSE); if (DevicePathStr !=3D NULL) { @@ -987,7 +987,7 @@ IdentifyUsbNicBmcChannel ( EFI_USB_IO_PROTOCOL *UsbIo; HOST_INTERFACE_BMC_USB_NIC_INFO *BmcUsbNic; =20 - DEBUG ((DEBUG_INFO, "%a: Entry.\n", __func__)); + DEBUG ((DEBUG_MANAGEABILITY, "%a: Entry.\n", __func__)); Status =3D gBS->HandleProtocol ( Handle, &gEfiSimpleNetworkProtocolGuid, @@ -1074,7 +1074,7 @@ CheckBmcUsbNicOnHandles ( return EFI_INVALID_PARAMETER; } =20 - DEBUG ((DEBUG_INFO, "%a: Entry, #%d SNP handle\n", __func__, HandleNumer= )); + DEBUG ((DEBUG_MANAGEABILITY, "%a: Entry, #%d SNP handle\n", __func__, Ha= ndleNumer)); =20 GotOneUsbNIc =3D FALSE; for (Index =3D 0; Index < HandleNumer; Index++) { @@ -1137,7 +1137,7 @@ CheckBmcUsbNic ( UINTN BufferSize; EFI_HANDLE *HandleBuffer; =20 - DEBUG ((DEBUG_INFO, "%a: Entry, the registration key - 0x%08x.\n", __fun= c__, Registration)); + DEBUG ((DEBUG_MANAGEABILITY, "%a: Entry, the registration key - 0x%08x.\= n", __func__, Registration)); =20 Handle =3D NULL; Status =3D EFI_SUCCESS; @@ -1213,7 +1213,7 @@ PlatformHostInterfaceSnpCallback ( IN VOID *Context ) { - DEBUG ((DEBUG_INFO, "%a: Entry.\n", __func__)); + DEBUG ((DEBUG_MANAGEABILITY, "%a: Entry.\n", __func__)); =20 CheckBmcUsbNic (mPlatformHostInterfaceSnpRegistration); return; @@ -1241,7 +1241,7 @@ RedfishPlatformHostInterfaceNotification ( { EFI_STATUS Status; =20 - DEBUG ((DEBUG_INFO, "%a: Entry\n", __func__)); + DEBUG ((DEBUG_MANAGEABILITY, "%a: Entry\n", __func__)); =20 *InformationReadinessGuid =3D NULL; InitializeListHead (&mBmcUsbNic); diff --git a/RedfishPkg/Library/RedfishPlatformCredentialIpmiLib/RedfishPla= tformCredentialIpmiLib.c b/RedfishPkg/Library/RedfishPlatformCredentialIpmi= Lib/RedfishPlatformCredentialIpmiLib.c index 3b34dafbaf6..47a40d9c464 100644 --- a/RedfishPkg/Library/RedfishPlatformCredentialIpmiLib/RedfishPlatformCr= edentialIpmiLib.c +++ b/RedfishPkg/Library/RedfishPlatformCredentialIpmiLib/RedfishPlatformCr= edentialIpmiLib.c @@ -66,7 +66,7 @@ LibStopRedfishService ( DEBUG ((DEBUG_ERROR, "%a: fail to remove bootstrap credential: %r\n", = __func__, Status)); } =20 - DEBUG ((DEBUG_INFO, "%a: bootstrap credential service stopped\n", __func= __)); + DEBUG ((DEBUG_MANAGEABILITY, "%a: bootstrap credential service stopped\n= ", __func__)); =20 return EFI_SUCCESS; } @@ -216,7 +216,7 @@ GetBootstrapAccountCredentials ( } } =20 - DEBUG ((DEBUG_INFO, "%a: get bootstrap credential via IPMI: %r\n", __fun= c__, Status)); + DEBUG ((DEBUG_MANAGEABILITY, "%a: get bootstrap credential via IPMI: %r\= n", __func__, Status)); =20 return Status; } @@ -284,7 +284,7 @@ GetBootstrapAccountCredentialsFromVariable ( =20 FreePool (Data); =20 - DEBUG ((DEBUG_INFO, "%a: get bootstrap credential from variable\n", __fu= nc__)); + DEBUG ((DEBUG_MANAGEABILITY, "%a: get bootstrap credential from variable= \n", __func__)); =20 return EFI_SUCCESS; } @@ -446,7 +446,7 @@ LibCredentialGetAuthInfo ( } =20 if (DisableCredentialService) { - DEBUG ((DEBUG_INFO, "%a: credential bootstrapping control disabled\n",= __func__)); + DEBUG ((DEBUG_MANAGEABILITY, "%a: credential bootstrapping control dis= abled\n", __func__)); } =20 Status =3D SetBootstrapAccountCredentialsToVariable (*UserId, *Password,= FALSE); diff --git a/RedfishPkg/PrivateLibrary/RedfishCrtLib/RedfishCrtLib.c b/Redf= ishPkg/PrivateLibrary/RedfishCrtLib/RedfishCrtLib.c index f240dfba131..57a997f351f 100644 --- a/RedfishPkg/PrivateLibrary/RedfishCrtLib/RedfishCrtLib.c +++ b/RedfishPkg/PrivateLibrary/RedfishCrtLib/RedfishCrtLib.c @@ -548,7 +548,7 @@ strtod ( char **__restrict endptr ) { - DEBUG ((DEBUG_INFO, "We don't supprot double type on edk2 yet!")); + DEBUG ((DEBUG_ERROR, "We don't supprot double type on edk2 yet!")); ASSERT (FALSE); return (double)0; } diff --git a/RedfishPkg/PrivateLibrary/RedfishLib/RedfishLib.c b/RedfishPkg= /PrivateLibrary/RedfishLib/RedfishLib.c index 0a0a4e64587..cca0ea77489 100644 --- a/RedfishPkg/PrivateLibrary/RedfishLib/RedfishLib.c +++ b/RedfishPkg/PrivateLibrary/RedfishLib/RedfishLib.c @@ -946,7 +946,7 @@ RedfishDumpJsonStringFractions ( return; } =20 - DEBUG ((DEBUG_INFO, "JSON text:\n")); + DEBUG ((DEBUG_MANAGEABILITY, "JSON text:\n")); NextFraction =3D String; StrLen =3D AsciiStrLen (String); if (StrLen =3D=3D 0) { @@ -956,13 +956,13 @@ RedfishDumpJsonStringFractions ( for (Count =3D 0; Count < (StrLen / StringFractionSize); Count++) { BackupChar =3D *(NextFraction + StringFracti= onSize); *(NextFraction + StringFractionSize) =3D 0; - DEBUG ((DEBUG_INFO, "%a", NextFraction)); + DEBUG ((DEBUG_MANAGEABILITY, "%a", NextFraction)); *(NextFraction + StringFractionSize) =3D BackupChar; NextFraction +=3D StringFractionSize; } =20 if ((StrLen % StringFractionSize) !=3D 0) { - DEBUG ((DEBUG_INFO, "%a\n\n", NextFraction)); + DEBUG ((DEBUG_MANAGEABILITY, "%a\n\n", NextFraction)); } } =20 @@ -1101,7 +1101,7 @@ RedfishIsValidOdataType ( } } =20 - DEBUG ((DEBUG_INFO, "%a: This Odata type is not in the list.\n", __func_= _)); + DEBUG ((DEBUG_MANAGEABILITY, "%a: This Odata type is not in the list.\n"= , __func__)); return FALSE; } =20 diff --git a/RedfishPkg/PrivateLibrary/RedfishLib/edk2libredfish/src/servic= e.c b/RedfishPkg/PrivateLibrary/RedfishLib/edk2libredfish/src/service.c index 206094d87d0..286f298e6a3 100644 --- a/RedfishPkg/PrivateLibrary/RedfishLib/edk2libredfish/src/service.c +++ b/RedfishPkg/PrivateLibrary/RedfishLib/edk2libredfish/src/service.c @@ -428,7 +428,7 @@ getUriFromService ( return NULL; } =20 - DEBUG ((DEBUG_INFO, "libredfish: getUriFromService(): %a\n", url)); + DEBUG ((DEBUG_MANAGEABILITY, "libredfish: getUriFromService(): %a\n", ur= l)); =20 // // Step 1: Create HTTP request message with 4 headers: @@ -587,7 +587,7 @@ patchUriFromService ( return NULL; } =20 - DEBUG ((DEBUG_INFO, "libredfish: patchUriFromService(): %a\n", url)); + DEBUG ((DEBUG_MANAGEABILITY, "libredfish: patchUriFromService(): %a\n", = url)); =20 // // Step 1: Create HTTP request message with 4 headers: @@ -660,7 +660,7 @@ patchUriFromService ( ret =3D NULL; goto ON_EXIT; } else if (Status =3D=3D EFI_UNSUPPORTED) { - DEBUG ((DEBUG_INFO, "No content coding for %a! Use raw data instead.\n= ", HTTP_CONTENT_ENCODING_GZIP)); + DEBUG ((DEBUG_MANAGEABILITY, "No content coding for %a! Use raw data i= nstead.\n", HTTP_CONTENT_ENCODING_GZIP)); Status =3D HttpIoSetHeader (HttpIoHeader, "Content-Encoding", HTTP_CON= TENT_ENCODING_IDENTITY); ASSERT_EFI_ERROR (Status); } else { @@ -769,7 +769,7 @@ postUriFromService ( return NULL; } =20 - DEBUG ((DEBUG_INFO, "libredfish: postUriFromService(): %a\n", url)); + DEBUG ((DEBUG_MANAGEABILITY, "libredfish: postUriFromService(): %a\n", u= rl)); =20 if (contentLength =3D=3D 0) { contentLength =3D strlen (content); @@ -954,7 +954,7 @@ deleteUriFromServiceEx ( return NULL; } =20 - DEBUG ((DEBUG_INFO, "libredfish: deleteUriFromService(): %a\n", url)); + DEBUG ((DEBUG_MANAGEABILITY, "libredfish: deleteUriFromService(): %a\n",= url)); =20 // // Step 1: Create HTTP request message with 4 headers: diff --git a/RedfishPkg/RedfishConfigHandler/RedfishConfigHandlerCommon.c b= /RedfishPkg/RedfishConfigHandler/RedfishConfigHandlerCommon.c index b51b558a487..bc1ba598359 100644 --- a/RedfishPkg/RedfishConfigHandler/RedfishConfigHandlerCommon.c +++ b/RedfishPkg/RedfishConfigHandler/RedfishConfigHandlerCommon.c @@ -122,7 +122,7 @@ RedfishConfigCommonInit ( // Status =3D gBS->LocateProtocol (&gEdkIIRedfishCredentialProtocolGuid, NU= LL, (VOID **)&gCredential); if (EFI_ERROR (Status)) { - DEBUG ((DEBUG_INFO, "%a: No Redfish Credential Protocol is installed o= n system.", __func__)); + DEBUG ((DEBUG_ERROR, "%a: No Redfish Credential Protocol is installed = on system.", __func__)); return Status; } =20 diff --git a/RedfishPkg/RedfishConfigHandler/RedfishConfigHandlerDriver.c b= /RedfishPkg/RedfishConfigHandler/RedfishConfigHandlerDriver.c index 161731b2113..f987cc67a69 100644 --- a/RedfishPkg/RedfishConfigHandler/RedfishConfigHandlerDriver.c +++ b/RedfishPkg/RedfishConfigHandler/RedfishConfigHandlerDriver.c @@ -362,7 +362,7 @@ RedfishDiscoverProtocolInstalled ( EFI_REDFISH_DISCOVERED_TOKEN *ThisRedfishDiscoveredToken; UINTN NumberOfNetworkInterfaces; =20 - DEBUG ((DEBUG_INFO, "%a: New network interface is installed on system by= EFI Redfish discover driver.\n", __func__)); + DEBUG ((DEBUG_MANAGEABILITY, "%a: New network interface is installed on = system by EFI Redfish discover driver.\n", __func__)); =20 BufferSize =3D sizeof (EFI_HANDLE); Status =3D gBS->LocateHandle ( diff --git a/RedfishPkg/RedfishDiscoverDxe/RedfishDiscoverDxe.c b/RedfishPk= g/RedfishDiscoverDxe/RedfishDiscoverDxe.c index 0b86a7b5cc4..470b4c9e006 100644 --- a/RedfishPkg/RedfishDiscoverDxe/RedfishDiscoverDxe.c +++ b/RedfishPkg/RedfishDiscoverDxe/RedfishDiscoverDxe.c @@ -272,7 +272,7 @@ Tcp6GetSubnetInfo ( } =20 if (IpModedata.AddressCount =3D=3D 0) { - DEBUG ((DEBUG_INFO, "%a: No IPv6 address configured.\n", __func__)); + DEBUG ((DEBUG_MANAGEABILITY, "%a: No IPv6 address configured.\n", __fu= nc__)); Instance->SubnetAddrInfoIPv6Number =3D 0; return EFI_SUCCESS; } @@ -684,7 +684,7 @@ AddAndSignalNewRedfishService ( RestExOpened =3D FALSE; DeleteRestEx =3D FALSE; =20 - DEBUG ((DEBUG_INFO, "%a:Add this instance to Redfish instance list.\n", = __func__)); + DEBUG ((DEBUG_MANAGEABILITY, "%a:Add this instance to Redfish instance l= ist.\n", __func__)); =20 if (Uuid !=3D NULL) { Char16Uuid =3D (CHAR16 *)AllocateZeroPool (AsciiStrSize ((const CHAR8 = *)Uuid) * sizeof (CHAR16)); @@ -720,7 +720,7 @@ AddAndSignalNewRedfishService ( { InfoRefresh =3D TRUE; DiscoveredInstance =3D DiscoveredList->Instance; - DEBUG ((DEBUG_INFO, "*** This Redfish Service information re= fresh ***\n")); + DEBUG ((DEBUG_MANAGEABILITY, "*** This Redfish Service infor= mation refresh ***\n")); } =20 break; @@ -770,30 +770,30 @@ AddAndSignalNewRedfishService ( } } =20 - DEBUG ((DEBUG_INFO, "*** Redfish Service Information ***\n")); + DEBUG ((DEBUG_MANAGEABILITY, "*** Redfish Service Information ***\n"))= ; =20 DiscoveredInstance->Information.UseHttps =3D UseHttps; if (RedfishVersion !=3D NULL) { DiscoveredInstance->Information.RedfishVersion =3D *RedfishVersion; - DEBUG ((DEBUG_INFO, "Redfish service version: %d.\n", DiscoveredInst= ance->Information.RedfishVersion)); + DEBUG ((DEBUG_MANAGEABILITY, "Redfish service version: %d.\n", Disco= veredInstance->Information.RedfishVersion)); } =20 if (RedfishLocation !=3D NULL) { DiscoveredInstance->Information.Location =3D (CHAR16 *)AllocatePool = (AsciiStrSize ((const CHAR8 *)RedfishLocation) * sizeof (CHAR16)); AsciiStrToUnicodeStrS ((const CHAR8 *)RedfishLocation, DiscoveredIns= tance->Information.Location, AsciiStrSize ((const CHAR8 *)RedfishLocation) = * sizeof (CHAR16)); - DEBUG ((DEBUG_INFO, "Redfish service location: %s.\n", DiscoveredIns= tance->Information.Location)); + DEBUG ((DEBUG_MANAGEABILITY, "Redfish service location: %s.\n", Disc= overedInstance->Information.Location)); } =20 if (Uuid !=3D NULL) { DiscoveredInstance->Information.Uuid =3D (CHAR16 *)AllocatePool (Asc= iiStrSize ((const CHAR8 *)Uuid) * sizeof (CHAR16)); AsciiStrToUnicodeStrS ((const CHAR8 *)Uuid, DiscoveredInstance->Info= rmation.Uuid, AsciiStrSize ((const CHAR8 *)Uuid) * sizeof (CHAR16)); - DEBUG ((DEBUG_INFO, "Service UUID: %s.\n", DiscoveredInstance->Infor= mation.Uuid)); + DEBUG ((DEBUG_MANAGEABILITY, "Service UUID: %s.\n", DiscoveredInstan= ce->Information.Uuid)); } =20 if (Os !=3D NULL) { DiscoveredInstance->Information.Os =3D (CHAR16 *)AllocatePool (Ascii= StrSize ((const CHAR8 *)Os) * sizeof (CHAR16)); AsciiStrToUnicodeStrS ((const CHAR8 *)Os, DiscoveredInstance->Inform= ation.Os, AsciiStrSize ((const CHAR8 *)Os) * sizeof (CHAR16)); - DEBUG ((DEBUG_INFO, "Redfish service OS: %s, Version:%s.\n", Discove= redInstance->Information.Os, DiscoveredInstance->Information.OsVersion)); + DEBUG ((DEBUG_MANAGEABILITY, "Redfish service OS: %s, Version:%s.\n"= , DiscoveredInstance->Information.Os, DiscoveredInstance->Information.OsVer= sion)); } =20 if (OsVer !=3D NULL) { @@ -806,7 +806,7 @@ AddAndSignalNewRedfishService ( AsciiStrToUnicodeStrS ((const CHAR8 *)Product, DiscoveredInstance->I= nformation.Product, AsciiStrSize ((const CHAR8 *)Product) * sizeof (CHAR16)= ); DiscoveredInstance->Information.ProductVer =3D (CHAR16 *)AllocatePoo= l (AsciiStrSize ((const CHAR8 *)ProductVer) * sizeof (CHAR16)); AsciiStrToUnicodeStrS ((const CHAR8 *)ProductVer, DiscoveredInstance= ->Information.ProductVer, AsciiStrSize ((const CHAR8 *)ProductVer) * sizeof= (CHAR16)); - DEBUG ((DEBUG_INFO, "Redfish service product: %s, Version:%s.\n", Di= scoveredInstance->Information.Product, DiscoveredInstance->Information.Prod= uctVer)); + DEBUG ((DEBUG_MANAGEABILITY, "Redfish service product: %s, Version:%= s.\n", DiscoveredInstance->Information.Product, DiscoveredInstance->Informa= tion.ProductVer)); } =20 if (RedfishLocation =3D=3D NULL) { @@ -824,11 +824,11 @@ AddAndSignalNewRedfishService ( DiscoveredInstance->Status =3D EFI_SUCCESS; } else { if (DiscoveredList !=3D NULL) { - DEBUG ((DEBUG_INFO, "*** This Redfish Service was already found ***\= n")); + DEBUG ((DEBUG_MANAGEABILITY, "*** This Redfish Service was already f= ound ***\n")); if (DiscoveredInstance->Information.Uuid !=3D NULL) { - DEBUG ((DEBUG_INFO, "Service UUID: %s.\n", DiscoveredInstance->Inf= ormation.Uuid)); + DEBUG ((DEBUG_MANAGEABILITY, "Service UUID: %s.\n", DiscoveredInst= ance->Information.Uuid)); } else { - DEBUG ((DEBUG_INFO, "Service UUID: unknown.\n")); + DEBUG ((DEBUG_MANAGEABILITY, "Service UUID: unknown.\n")); } } } @@ -1002,7 +1002,7 @@ NetworkInterfaceGetSubnetInfo ( DEBUG ((DEBUG_ERROR, "%a:Failed to get Subnet infomation.\n", __func= __)); return Status; } else { - DEBUG ((DEBUG_INFO, "%a:MAC address: %s\n", __func__, Instance->StrM= acAddr)); + DEBUG ((DEBUG_MANAGEABILITY, "%a:MAC address: %s\n", __func__, Insta= nce->StrMacAddr)); if (CheckIsIpVersion6 (Instance)) { if (Instance->SubnetAddrInfoIPv6Number =3D=3D 0) { DEBUG ((DEBUG_ERROR, "%a: There is no Subnet infomation for IPv6= network interface.\n", __func__)); @@ -1013,7 +1013,7 @@ NetworkInterfaceGetSubnetInfo ( IP6_COPY_ADDRESS (&Instance->SubnetAddr.v6, &ThisSubnetAddrInfoIPv= 6->Address); Instance->SubnetPrefixLength =3D ThisSubnetAddrInfoIPv6->PrefixLen= gth; DEBUG (( - DEBUG_INFO, + DEBUG_MANAGEABILITY, " IPv6 Subnet ID:%d, Prefix length: %d.\n", ThisSubnetAddrInfoIPv6->Address.Addr[7] + (UINT16)ThisSubnetAddr= InfoIPv6->Address.Addr[6] * 256, ThisSubnetAddrInfoIPv6->PrefixLength @@ -1038,7 +1038,7 @@ NetworkInterfaceGetSubnetInfo ( ThisSubnetAddrInfoIPv6++; mNumNetworkInterface++; DEBUG (( - DEBUG_INFO, + DEBUG_MANAGEABILITY, " IPv6 Subnet ID:%d, Prefix length: %d.\n", ThisSubnetAddrInfoIPv6->Address.Addr[7] + (UINT16)ThisSubnet= AddrInfoIPv6->Address.Addr[6] * 256, ThisSubnetAddrInfoIPv6->PrefixLength @@ -1050,7 +1050,7 @@ NetworkInterfaceGetSubnetInfo ( } } else { DEBUG (( - DEBUG_INFO, + DEBUG_MANAGEABILITY, " IPv4 Subnet:%d.%d.%d.%d Subnet mask: %d.%d.%d.%d.\n", Instance->SubnetAddr.v4.Addr[0], Instance->SubnetAddr.v4.Addr[1], @@ -1204,7 +1204,7 @@ RedfishServiceAcquireService ( UINTN NetworkInterfacesIndex; EFI_REDFISH_DISCOVER_NETWORK_INTERFACE_INTERNAL *TargetNetworkInterface= Internal; =20 - DEBUG ((DEBUG_INFO, "%a:Entry.\n", __func__)); + DEBUG ((DEBUG_MANAGEABILITY, "%a:Entry.\n", __func__)); =20 // // Validate parameters. @@ -1238,7 +1238,7 @@ RedfishServiceAcquireService ( NewInstance =3D FALSE; Instance =3D GetInstanceByOwner (ImageHandle, TargetNetworkInterfac= eInternal, Flags & ~EFI_REDFISH_DISCOVER_VALIDATION); // Check if we can re= -use previous instance. if (Instance =3D=3D NULL) { - DEBUG ((DEBUG_INFO, "%a:Create new EFI_REDFISH_DISCOVERED_INTERNAL_I= NSTANCE.\n", __func__)); + DEBUG ((DEBUG_MANAGEABILITY, "%a:Create new EFI_REDFISH_DISCOVERED_I= NTERNAL_INSTANCE.\n", __func__)); Instance =3D (EFI_REDFISH_DISCOVERED_INTERNAL_INSTANCE *)AllocateZer= oPool (sizeof (EFI_REDFISH_DISCOVERED_INTERNAL_INSTANCE)); if (Instance =3D=3D NULL) { DEBUG ((DEBUG_ERROR, "%a:Memory allocation fail.\n", __func__)); @@ -1258,14 +1258,14 @@ RedfishServiceAcquireService ( } =20 if (TargetNetworkInterfaceInternal->StrMacAddr !=3D NULL) { - DEBUG ((DEBUG_INFO, "%a:Acquire Redfish service on network interface= MAC address:%s.\n", __func__, TargetNetworkInterfaceInternal->StrMacAddr))= ; + DEBUG ((DEBUG_MANAGEABILITY, "%a:Acquire Redfish service on network = interface MAC address:%s.\n", __func__, TargetNetworkInterfaceInternal->Str= MacAddr)); } else { - DEBUG ((DEBUG_INFO, "%a:WARNING: No MAC address on this network inte= rface.\n", __func__)); + DEBUG ((DEBUG_MANAGEABILITY, "%a:WARNING: No MAC address on this net= work interface.\n", __func__)); } =20 Instance->DiscoverToken =3D Token; // Always use the latest Token pass= ed by caller. if ((Flags & EFI_REDFISH_DISCOVER_HOST_INTERFACE) !=3D 0) { - DEBUG ((DEBUG_INFO, "%a:Redfish HOST interface discovery.\n", __func= __)); + DEBUG ((DEBUG_MANAGEABILITY, "%a:Redfish HOST interface discovery.\n= ", __func__)); Instance->HostIntfValidation =3D FALSE; if ((Flags & EFI_REDFISH_DISCOVER_VALIDATION) !=3D 0) { Instance->HostIntfValidation =3D TRUE; @@ -1747,7 +1747,7 @@ BuildupNetworkInterface ( DEBUG ((DEBUG_ERROR, "%a: Fail to install EFI_REDFISH_DISCOVER= _PROTOCOL\n", __func__)); } } else { - DEBUG ((DEBUG_INFO, "%a: Not REST EX, continue with next\n", __f= unc__)); + DEBUG ((DEBUG_MANAGEABILITY, "%a: Not REST EX, continue with nex= t\n", __func__)); Index++; if (Index =3D=3D (sizeof (gRequiredProtocol) / sizeof (REDFISH_D= ISCOVER_REQUIRED_PROTOCOL))) { break; diff --git a/RedfishPkg/RedfishHostInterfaceDxe/RedfishHostInterfaceDxe.c b= /RedfishPkg/RedfishHostInterfaceDxe/RedfishHostInterfaceDxe.c index c4fa59193a2..55a66decfc8 100644 --- a/RedfishPkg/RedfishHostInterfaceDxe/RedfishHostInterfaceDxe.c +++ b/RedfishPkg/RedfishHostInterfaceDxe/RedfishHostInterfaceDxe.c @@ -221,7 +221,7 @@ RedfishCreateSmbiosTable42 ( &MemArrayMappedAddrSmbiosHand= le, (EFI_SMBIOS_TABLE_HEADER *)Ty= pe42Record ); - DEBUG ((DEBUG_INFO, "RedfishPlatformDxe: Smbios->Add() - %r\n", Status))= ; + DEBUG ((DEBUG_MANAGEABILITY, "RedfishPlatformDxe: Smbios->Add() - %r\n",= Status)); if (EFI_ERROR (Status)) { goto ON_EXIT; } @@ -259,7 +259,7 @@ PlatformHostInterfaceInformationReady ( IN VOID *Context ) { - DEBUG ((DEBUG_INFO, "%a: Platform Redfish Host Interface informtion is r= eady\n", __func__)); + DEBUG ((DEBUG_MANAGEABILITY, "%a: Platform Redfish Host Interface inform= tion is ready\n", __func__)); =20 RedfishCreateSmbiosTable42 (); =20 @@ -291,7 +291,7 @@ RedfishHostInterfaceDxeEntryPoint ( EFI_STATUS Status; EFI_GUID *ReadyGuid; =20 - DEBUG ((DEBUG_INFO, "%a: Entry\n.", __func__)); + DEBUG ((DEBUG_MANAGEABILITY, "%a: Entry\n.", __func__)); =20 // // Check if the Redfish Host Interface depends on @@ -299,8 +299,8 @@ RedfishHostInterfaceDxeEntryPoint ( // Status =3D RedfishPlatformHostInterfaceNotification (&ReadyGuid); if (Status =3D=3D EFI_SUCCESS) { - DEBUG ((DEBUG_INFO, " Create protocol install notification to know = the installation of platform Redfish host interface readiness\n")); - DEBUG ((DEBUG_INFO, " Protocol GUID: %g\n", ReadyGuid)); + DEBUG ((DEBUG_MANAGEABILITY, " Create protocol install notification= to know the installation of platform Redfish host interface readiness\n"))= ; + DEBUG ((DEBUG_MANAGEABILITY, " Protocol GUID: %g\n", ReadyGuid)); // // Register event for ReadyGuid protocol installed by // platform Redfish host interface library. diff --git a/RedfishPkg/RedfishRestExDxe/RedfishRestExImpl.c b/RedfishPkg/R= edfishRestExDxe/RedfishRestExImpl.c index 41f2b29c83b..838e24f7e7e 100644 --- a/RedfishPkg/RedfishRestExDxe/RedfishRestExImpl.c +++ b/RedfishPkg/RedfishRestExDxe/RedfishRestExImpl.c @@ -28,7 +28,7 @@ ResetHttpTslSession ( { EFI_STATUS Status; =20 - DEBUG ((DEBUG_INFO, "%a: TCP connection is finished. Could be TSL sessio= n closure, reset HTTP instance for the new TLS session.\n", __func__)); + DEBUG ((DEBUG_MANAGEABILITY, "%a: TCP connection is finished. Could be T= SL session closure, reset HTTP instance for the new TLS session.\n", __func= __)); =20 Status =3D Instance->HttpIo.Http->Configure (Instance->HttpIo.Http, NULL= ); if (EFI_ERROR (Status)) { diff --git a/RedfishPkg/RedfishRestExDxe/RedfishRestExProtocol.c b/RedfishP= kg/RedfishRestExDxe/RedfishRestExProtocol.c index 3722e1f7956..d8f2c73f8ef 100644 --- a/RedfishPkg/RedfishRestExDxe/RedfishRestExProtocol.c +++ b/RedfishPkg/RedfishRestExDxe/RedfishRestExProtocol.c @@ -250,17 +250,17 @@ ReSendRequest:; goto ReSendRequest; } } else if (ResponseData->Response.StatusCode =3D=3D HTTP_STATUS_204_NO_C= ONTENT) { - DEBUG ((DEBUG_INFO, "HTTP_STATUS_204_NO_CONTENT\n")); + DEBUG ((DEBUG_MANAGEABILITY, "HTTP_STATUS_204_NO_CONTENT\n")); =20 if (FixedPcdGetBool (PcdRedfishRestExChunkRequestMode) && (SendChunkPr= ocess =3D=3D HttpIoSendChunkHeaderZeroContent)) { - DEBUG ((DEBUG_INFO, "This is chunk transfer, start to send all chunk= s - %d.", ResponseData->Response.StatusCode)); + DEBUG ((DEBUG_MANAGEABILITY, "This is chunk transfer, start to send = all chunks - %d.", ResponseData->Response.StatusCode)); SendChunkProcess++; goto ReSendRequest; } } else if (ResponseData->Response.StatusCode =3D=3D HTTP_STATUS_201_CREA= TED) { - DEBUG ((DEBUG_INFO, "HTTP_STATUS_201_CREATED\n")); + DEBUG ((DEBUG_MANAGEABILITY, "HTTP_STATUS_201_CREATED\n")); } else if (ResponseData->Response.StatusCode =3D=3D HTTP_STATUS_202_ACCE= PTED) { - DEBUG ((DEBUG_INFO, "HTTP_STATUS_202_ACCEPTED\n")); + DEBUG ((DEBUG_MANAGEABILITY, "HTTP_STATUS_202_ACCEPTED\n")); } else if (ResponseData->Response.StatusCode =3D=3D HTTP_STATUS_413_REQU= EST_ENTITY_TOO_LARGE) { DEBUG ((DEBUG_REDFISH_NETWORK, "HTTP_STATUS_413_REQUEST_ENTITY_TOO_LAR= GE\n")); =20 --=20 2.37.1.windows.1