public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
* [PATCH 1/1] ArmPkg: add SMC defines for SiP service calls
@ 2023-06-01 12:58 Marcin Juszkiewicz
  2023-06-01 16:00 ` [edk2-devel] " Leif Lindholm
  0 siblings, 1 reply; 2+ messages in thread
From: Marcin Juszkiewicz @ 2023-06-01 12:58 UTC (permalink / raw)
  To: devel; +Cc: Leif Lindholm, Ard Biesheuvel, Sami Mujawar, Marcin Juszkiewicz

They are useful for those platforms where SMC SiP calls exist.
---
 ArmPkg/Include/IndustryStandard/ArmStdSmc.h | 9 +++++++++
 1 file changed, 9 insertions(+)

diff --git a/ArmPkg/Include/IndustryStandard/ArmStdSmc.h b/ArmPkg/Include/IndustryStandard/ArmStdSmc.h
index 374b9ded7f5f..616c650d07c8 100644
--- a/ArmPkg/Include/IndustryStandard/ArmStdSmc.h
+++ b/ArmPkg/Include/IndustryStandard/ArmStdSmc.h
@@ -244,4 +244,13 @@
 #define TRNG_STATUS_INVALID_PARAMETER  (INT32)(-2)
 #define TRNG_STATUS_NO_ENTROPY         (INT32)(-3)
 
+/*
+ *  SMC64 SiP Service Calls
+ */
+
+#define SMC_FASTCALL           0x80000000
+#define SMC64_FUNCTION         (SMC_FASTCALL     | 0x40000000)
+#define SMC_SIP_FUNCTION       (SMC64_FUNCTION   | 0x02000000)
+#define SMC_SIP_FUNCTION_ID(n) (SMC_SIP_FUNCTION | (n))
+
 #endif // ARM_STD_SMC_H_
-- 
2.40.1


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [edk2-devel] [PATCH 1/1] ArmPkg: add SMC defines for SiP service calls
  2023-06-01 12:58 [PATCH 1/1] ArmPkg: add SMC defines for SiP service calls Marcin Juszkiewicz
@ 2023-06-01 16:00 ` Leif Lindholm
  0 siblings, 0 replies; 2+ messages in thread
From: Leif Lindholm @ 2023-06-01 16:00 UTC (permalink / raw)
  To: devel, marcin.juszkiewicz; +Cc: Ard Biesheuvel, Sami Mujawar

On Thu, Jun 01, 2023 at 14:58:27 +0200, Marcin Juszkiewicz wrote:
> They are useful for those platforms where SMC SiP calls exist.

Thanks for this
Reviewed-by: Leif Lindholm <quic_llindhol@quicinc.com>

However, I'm missing your S-o-b, can you provide it?

/
    Leif

> ---
>  ArmPkg/Include/IndustryStandard/ArmStdSmc.h | 9 +++++++++
>  1 file changed, 9 insertions(+)
> 
> diff --git a/ArmPkg/Include/IndustryStandard/ArmStdSmc.h b/ArmPkg/Include/IndustryStandard/ArmStdSmc.h
> index 374b9ded7f5f..616c650d07c8 100644
> --- a/ArmPkg/Include/IndustryStandard/ArmStdSmc.h
> +++ b/ArmPkg/Include/IndustryStandard/ArmStdSmc.h
> @@ -244,4 +244,13 @@
>  #define TRNG_STATUS_INVALID_PARAMETER  (INT32)(-2)
>  #define TRNG_STATUS_NO_ENTROPY         (INT32)(-3)
>  
> +/*
> + *  SMC64 SiP Service Calls
> + */
> +
> +#define SMC_FASTCALL           0x80000000
> +#define SMC64_FUNCTION         (SMC_FASTCALL     | 0x40000000)
> +#define SMC_SIP_FUNCTION       (SMC64_FUNCTION   | 0x02000000)
> +#define SMC_SIP_FUNCTION_ID(n) (SMC_SIP_FUNCTION | (n))
> +
>  #endif // ARM_STD_SMC_H_
> -- 
> 2.40.1
> 
> 
> 
> 
> 
> 
> 

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2023-06-01 16:00 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-06-01 12:58 [PATCH 1/1] ArmPkg: add SMC defines for SiP service calls Marcin Juszkiewicz
2023-06-01 16:00 ` [edk2-devel] " Leif Lindholm

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox