From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f50.google.com (mail-wm1-f50.google.com [209.85.128.50]) by mx.groups.io with SMTP id smtpd.web11.643.1685640483408223484 for ; Thu, 01 Jun 2023 10:28:03 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="signature has expired" header.i=@gmail.com header.s=20221208 header.b=XCKVB0+9; spf=pass (domain: gmail.com, ip: 209.85.128.50, mailfrom: pedro.falcato@gmail.com) Received: by mail-wm1-f50.google.com with SMTP id 5b1f17b1804b1-3f6da07ff00so11819575e9.3 for ; Thu, 01 Jun 2023 10:28:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1685640481; x=1688232481; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=Lm+LXYIyWOh5VrtNAqR6UenmrW9iQ7wpZ9Iga+8EP7c=; b=XCKVB0+92CNl1gWjfjRoOCc5ZdOH8ikNbueG9GiTL5IpO2dz8EcoFfOtWNpzmPhXsQ KgZzP/DpNie1YYSNOvYdWDOUf3ZZ8BpVVt6JdPRYbuLvdEnGqz4W+4SyX48TV4I6Pnpq x7IU7JGjpSV2Vrava0m7SSWEspe3rxIrRAmoUhCRwZlEGlmpVFboDnCTGPeuRS3qrB6P rJ25EiqoqiqfFVU+gUCwAHzDUaBCkU6I03Qh2klh0HHoofEo8Ta+W/sTytEG+B23Wbcc l0kuF79//HtXaPpUIo/k0rRyTBUpaW5LjG+XfBaL/Hct7GvTvRs9NjYi9rlpK0AYZNJY 4qGA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1685640481; x=1688232481; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=Lm+LXYIyWOh5VrtNAqR6UenmrW9iQ7wpZ9Iga+8EP7c=; b=Um6Q5rsvufEHAsZpo0bv7AmLNCNsmqDhGMYNr6q8lpLCgeBZoK7+7OyI2OVMC4RY+y AJSe/S14e+PP9a7mmRAQGwP2yIRnd9a27rYdlpAu7+V38c9/SoH5t59YTb6qRdBLBgMr fxhzdLWvsCGDvtPweAFo8cj8MB8zJRSj2MdJM2en/0YHuNQqQkIZt0sbYLaGuBqo+CTq Qk/mlGE9/jGDe9/gn9Mt5+abxuESu6z0Ld+tG+g1NX2npB0/waI5XoJaCsSj/IVLc6EP Cmb9CA9nF2cI1eoHA+QyD5p6WSx4HM57CqFvYXnae5BxEMPnL3cPryJ80INU8S+Szaht Oudg== X-Gm-Message-State: AC+VfDyOpm92JpOZDlJ7AOC1dUbZ4+5et3C1LrVMiP5brYmIV/c0lq3m WjI9gCdts4/dtbkwmPb38vD3nmkQ8DMWyQ== X-Google-Smtp-Source: ACHHUZ4qpERlc3rIQYoy75vxNDkqPAmtxnq+FWOlXTZCaWaDZ487EGkwzGyrxnZcwy6iUSEEcuVzEg== X-Received: by 2002:a7b:cbd7:0:b0:3f6:3b9:eaeb with SMTP id n23-20020a7bcbd7000000b003f603b9eaebmr96880wmi.6.1685640481125; Thu, 01 Jun 2023 10:28:01 -0700 (PDT) Return-Path: Received: from PC-PEDRO-ARCH.lan ([2001:8a0:7280:5801:9441:3dce:686c:bfc7]) by smtp.gmail.com with ESMTPSA id n11-20020a7bcbcb000000b003f60d0eef36sm2970511wmi.48.2023.06.01.10.27.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 01 Jun 2023 10:28:00 -0700 (PDT) From: "Pedro Falcato" To: devel@edk2.groups.io Cc: Pedro Falcato , Ard Biesheuvel , Jiewen Yao , Gerd Hoffmann , Erdem Aktas , James Bottomley , Min Xu , Tom Lendacky , Michael Roth , Rebecca Cran , Peter Grehan , =?UTF-8?q?Corvin=20K=C3=B6hne?= , Sebastien Boeuf , Anthony Perard , Julien Grall , Laszlo Ersek Subject: [PATCH v3 00/12] OvmfPkg: Replace the OVMF-specific SataControllerDxe with the generic one Date: Thu, 1 Jun 2023 18:27:28 +0100 Message-Id: <20230601172740.9165-1-pedro.falcato@gmail.com> X-Mailer: git-send-email 2.40.1 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit This patch-set replaces the OVMF specific SataControllerDxe with the MdeModulePkg/Bus/Pci one. They were both forked from the same code, and are code-and-functionality similar. As such, there seems to be no need for duplication here. The first four pages both replay OvmfPkg/SataControllerDxe commits and fix up a couple of details. The rest of the patches (minus the last) replace OvmfPkg/SataControllerDxe with the MdeModulePkg variant. The last patch, finally, removes the thing. Tested by booting in QEMU (Q35 (AHCI) and PC (IDE)). More testing from other, alternative platforms is desired, although breakage seems unlikely. This patchset (or at least, the last patch) depends on the edk2-platforms patch series to get merged. (+CC Laszlo as the author of the original SataControllerDxe patches) PR: https://github.com/tianocore/edk2/pull/4370 Cc: Ard Biesheuvel Cc: Jiewen Yao Cc :Jordan Justen Cc: Gerd Hoffmann Cc: Erdem Aktas Cc: James Bottomley Cc: Min Xu Cc: Tom Lendacky Cc: Michael Roth Cc: Rebecca Cran Cc: Peter Grehan Cc: Corvin Köhne Cc: Sebastien Boeuf Cc: Anthony Perard Cc: Julien Grall Cc: Laszlo Ersek Changes: v3: - Pick up Reviewed-by and Acked-by tags v2: - Address Laszlo's feedback wrt commit to port into MdeModulePkg - Address Laszlo's feedback wrt how to split the removal of the driver and the patches for each sub-platform maintainer - Address Mike Maslenkin's feedback on the preexisting ASSERTs (Private != NULL) - Add Gerd's ACK and Tested-by (conservatively) to patches 6 and 12 (since they are remotely QEMU related) Pedro Falcato (12): MdeModulePkg/SataControllerDxe: Clean up error handling in Start() MdeModulePkg/SataControllerDxe: Log expected errors at DEBUG_INFO level MdeModulePkg/SataControllerDxe: Remove useless null check MdeModulePkg/SataControllerDxe: Fix up ASSERTS (Private != NULL) OvmfPkg: Replace the OVMF-specific SataControllerDxe OvmfPkg/Microvm: Replace the OVMF-specific SataControllerDxe OvmfPkg/Bhyve: Replace the OVMF-specific SataControllerDxe OvmfPkg/CloudHv: Replace the OVMF-specific SataControllerDxe OvmfPkg/IntelTdx: Replace the OVMF-specific SataControllerDxe OvmfPkg/AmdSev: Replace the OVMF-specific SataControllerDxe OvmfPkg/Xen: Replace the OVMF-specific SataControllerDxe OvmfPkg: Remove SataControllerDxe .../Pci/SataControllerDxe/SataController.c | 146 ++- OvmfPkg/AmdSev/AmdSevX64.dsc | 2 +- OvmfPkg/AmdSev/AmdSevX64.fdf | 2 +- OvmfPkg/Bhyve/BhyveX64.dsc | 2 +- OvmfPkg/Bhyve/BhyveX64.fdf | 2 +- OvmfPkg/CloudHv/CloudHvX64.dsc | 2 +- OvmfPkg/CloudHv/CloudHvX64.fdf | 2 +- OvmfPkg/IntelTdx/IntelTdxX64.dsc | 2 +- OvmfPkg/IntelTdx/IntelTdxX64.fdf | 2 +- OvmfPkg/Microvm/MicrovmX64.dsc | 2 +- OvmfPkg/Microvm/MicrovmX64.fdf | 2 +- OvmfPkg/OvmfPkgIa32.dsc | 2 +- OvmfPkg/OvmfPkgIa32.fdf | 2 +- OvmfPkg/OvmfPkgIa32X64.dsc | 2 +- OvmfPkg/OvmfPkgIa32X64.fdf | 2 +- OvmfPkg/OvmfPkgX64.dsc | 2 +- OvmfPkg/OvmfPkgX64.fdf | 2 +- OvmfPkg/OvmfXen.dsc | 2 +- OvmfPkg/OvmfXen.fdf | 2 +- OvmfPkg/SataControllerDxe/ComponentName.c | 170 --- OvmfPkg/SataControllerDxe/SataController.c | 1112 ----------------- OvmfPkg/SataControllerDxe/SataController.h | 544 -------- .../SataControllerDxe/SataControllerDxe.inf | 43 - 23 files changed, 90 insertions(+), 1961 deletions(-) delete mode 100644 OvmfPkg/SataControllerDxe/ComponentName.c delete mode 100644 OvmfPkg/SataControllerDxe/SataController.c delete mode 100644 OvmfPkg/SataControllerDxe/SataController.h delete mode 100644 OvmfPkg/SataControllerDxe/SataControllerDxe.inf -- 2.40.1