From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-oa1-f66.google.com (mail-oa1-f66.google.com [209.85.160.66]) by mx.groups.io with SMTP id smtpd.web11.6870.1685689795873903193 for ; Fri, 02 Jun 2023 00:09:56 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@ventanamicro.com header.s=google header.b=LCkpD48S; spf=pass (domain: ventanamicro.com, ip: 209.85.160.66, mailfrom: rsingh@ventanamicro.com) Received: by mail-oa1-f66.google.com with SMTP id 586e51a60fabf-1a28817f70bso1194013fac.2 for ; Fri, 02 Jun 2023 00:09:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ventanamicro.com; s=google; t=1685689795; x=1688281795; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=yeyk0cfuLi5CywNQ06UidKbQf6KT7IjDfUuYGRfC2jI=; b=LCkpD48SoNEDf9ROo5h50wEix8YMzwFZA6Wk204mpUaPSoXDMkCYgibqpbHQX6pd2Q p4rSijJHChe95KVqLOK16p3QFpTMHYQvlDEIu9ESeMGXNR5/ZqAsCu5H05fUzafpa/56 y3pE1pAZsuAUI7379fVTk+vkiBvUIWoan2XgAiRpPvkXQ5xGTJov4dDpMqpIkbBFtszY c/wHHTeRE1rqyyGvT7VnU0yD/sIYCi/yNl98WiadZEpQu6yn0LAQ9DZxjjW0iWtlOaTp 3Q3FXKUXS1DhJk45NoIHBFLUUDjPE1JZZ50hXkgkDa8emkB3En+Uq6auda8v0Hx0YOF5 1kaQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1685689795; x=1688281795; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=yeyk0cfuLi5CywNQ06UidKbQf6KT7IjDfUuYGRfC2jI=; b=Yp7Fy9FqGIsRNVsWFKe8ZrcCDKP/GyseIYcrt3PQvhxtnIUlEO0xR0fclHsxR8S/HL 7dJgPmAIIqdixdkQjh99EcPQzBCEGTtHgXpKBWHyYXWyWtNlM+MhERCq5ZMmx9A0UDXr pqHbiU2XYUOd992ankn/SBhxvlBFY5YkfK5Aiffkgq+OFVXAiGiuh4piCdVTeusPSK7p exPvG67Q+ZlPo3PqTYTnEAYBH2mVOtpnjXq/tMz8ub7jf1d6RJnJJMvYBN62qJ9/OC1M bfCqhLvfHp22sXFtFp2nP+M8De7UmhTEl2VNSNw/jE3FGrIlZxFrvwJQa8KXhK2GSYkT veMQ== X-Gm-Message-State: AC+VfDxK5JrcCHBELekD86NFo9RGAxY4KgmC1X1mp1ML9f2uiTpCYKu6 8GL5CwkPwBuJSo/CpF6i2gat/XSDQ44qdD5mpRsAnZCG X-Google-Smtp-Source: ACHHUZ7O9+kz/R0dpBe9t745vS8kusqg3QdfLdkxS4VHDIhGfJTtXgPrKodwDIqRWE99E+5j72icHw== X-Received: by 2002:a05:6871:4c1:b0:187:85b1:1258 with SMTP id n1-20020a05687104c100b0018785b11258mr1205547oai.23.1685689795059; Fri, 02 Jun 2023 00:09:55 -0700 (PDT) Return-Path: Received: from user-Latitude-5420.dc1.ventanamicro.com ([2401:4900:1cbd:cf0a:3d37:338a:2fdd:c49e]) by smtp.gmail.com with ESMTPSA id u17-20020a05687004d100b0019f4f5c8298sm342390oam.56.2023.06.02.00.09.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 02 Jun 2023 00:09:54 -0700 (PDT) From: Ranbir Singh To: devel@edk2.groups.io Cc: Hao A Wu , Ray Ni Subject: [PATCH 2/2] MdeModulePkg/Bus/Ata/AtaAtapiPassThru: Fix UNUSED_VALUE Coverity issue Date: Fri, 2 Jun 2023 12:39:46 +0530 Message-Id: <20230602070946.83730-2-rsingh@ventanamicro.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230602070946.83730-1-rsingh@ventanamicro.com> References: <20230602070946.83730-1-rsingh@ventanamicro.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable From: Ranbir Singh The return value stored in Status after call to SetDriveParameters is not made of any use thereafter and hence it remains as UNUSED. Assuming, this non-usage is deliberate, the storage in Status can be done away with. Cc: Hao A Wu Cc: Ray Ni REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D4204 Signed-off-by: Ranbir Singh --- MdeModulePkg/Bus/Ata/AtaAtapiPassThru/IdeMode.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/MdeModulePkg/Bus/Ata/AtaAtapiPassThru/IdeMode.c b/MdeModulePkg= /Bus/Ata/AtaAtapiPassThru/IdeMode.c index 75403886e44a..c6d637afa989 100644 --- a/MdeModulePkg/Bus/Ata/AtaAtapiPassThru/IdeMode.c +++ b/MdeModulePkg/Bus/Ata/AtaAtapiPassThru/IdeMode.c @@ -2555,7 +2555,7 @@ DetectAndConfigIdeDevice ( DriveParameters.Heads =3D (UINT8)(((ATA5_IDENTIFY_DATA *)(&= Buffer.AtaData))->heads - 1);=0D DriveParameters.MultipleSector =3D (UINT8)((ATA5_IDENTIFY_DATA *)(&B= uffer.AtaData))->multi_sector_cmd_max_sct_cnt;=0D =0D - Status =3D SetDriveParameters (Instance, IdeChannel, IdeDevice, &Dri= veParameters, NULL);=0D + SetDriveParameters (Instance, IdeChannel, IdeDevice, &DriveParameter= s, NULL);=0D }=0D =0D //=0D --=20 2.34.1