From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by mx.groups.io with SMTP id smtpd.web11.8114.1685695906132912119 for ; Fri, 02 Jun 2023 01:51:46 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=Mbh5yFlJ; spf=pass (domain: kernel.org, ip: 139.178.84.217, mailfrom: ardb@kernel.org) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id A826A64D72; Fri, 2 Jun 2023 08:51:45 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id CEA85C4339B; Fri, 2 Jun 2023 08:51:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1685695905; bh=he5IBthLioSaEyasvATY+jPsoHCgWd20G2EOQZ0sxs0=; h=From:To:Cc:Subject:Date:From; b=Mbh5yFlJp8iUM3q4lxBYJwCgbg9SVRtnM3Sw5UeeNidXoadRXZt2Kjrqd/f5lZP+g nM2ZQ6cuJsZt0QgXOsEyJ+A/3n3nurhHaXPfHYMTTjcI2UCSG3yKr53lKE/WLtu4pv oCMbXwrBionb9cDxZPPDSp4G+NBYe4RUYyjODZEpzTSxzFmq9M8hsHjZOt1azmUxSu kFN52FEzXRNqarPEL7ABiJL1ezc28+Kn7icBtn4l00fBJvL9G809z5Ohwdz8Ws4VzI ysgm0FiMPv5/AclFDq9Bv32PT8f9f01rWlxN4fprOYYjrJptU+Qd6rwNW6eyOVo4Ek cnw3gTN/LfQQw== From: "Ard Biesheuvel" To: devel@edk2.groups.io Cc: Ard Biesheuvel , Leif Lindholm , "Kinney, Michael D" , Michael Kubacki Subject: [RFC PATCH] ArmPkg: Enable AuditMode for Uncrustify CI checks Date: Fri, 2 Jun 2023 10:51:36 +0200 Message-Id: <20230602085136.3552790-1-ardb@kernel.org> X-Mailer: git-send-email 2.39.2 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Uncrustify checks are too rigid, making them counter-productive: - it leads to code that is arguably harder to parse visually (e.g., the changes to ArmPkg/Include/Chipset/AArch64Mmu.h in commit 429309e0c6b74792) - it forces indentation-only changes to code in the vicinity of actual changes, making the code history more bloated than necessary (see commit 7f198321eec0f520373 for an example) - finding out from the web UI what exactly Uncrustify objected to is not straight-forward. So let's enable AuditMode for ArmPkg, so that interested parties can see the uncrustify recommendations if desired, but without preventing the changes from being merged. This leaves it at the discretion of the ArmPkg maintainers to decide which level of conformance is required. Cc: Leif Lindholm Cc: "Kinney, Michael D" Cc: Michael Kubacki Signed-off-by: Ard Biesheuvel --- ArmPkg/ArmPkg.ci.yaml | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/ArmPkg/ArmPkg.ci.yaml b/ArmPkg/ArmPkg.ci.yaml index 24db7425051388cf..d3124816118944cb 100644 --- a/ArmPkg/ArmPkg.ci.yaml +++ b/ArmPkg/ArmPkg.ci.yaml @@ -239,5 +239,10 @@ ],=0D "AdditionalIncludePaths": [] # Additional paths to spell check=0D # (wildcards supported)=0D + },=0D +=0D + # options defined in .pytool/Plugin/UncrustifyCheck=0D + "UncrustifyCheck": {=0D + "AuditOnly": True=0D }=0D }=0D --=20 2.39.2