From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by mx.groups.io with SMTP id smtpd.web11.6332.1685738710534682214 for ; Fri, 02 Jun 2023 13:45:10 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="body hash did not verify" header.i=@linux.microsoft.com header.s=default header.b=gDTF1hHM; spf=pass (domain: linux.microsoft.com, ip: 13.77.154.182, mailfrom: osde@linux.microsoft.com) Received: from OSD-Desktop.redmond.corp.microsoft.com (unknown [131.107.1.171]) by linux.microsoft.com (Postfix) with ESMTPSA id C4AFB20520BA; Fri, 2 Jun 2023 13:45:09 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com C4AFB20520BA DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1685738709; bh=vo5437hGJb7Mbn+fJcSBLuNcvQzSx6or4k3ra+YGGLA=; h=From:To:Cc:Subject:Date:From; b=gDTF1hHMnDKinRzRulxKZlMuGXKyeSqnU12acaZ2+mEhkJz5S1d5dGmkM1My0JW4s egWDxjSl8QJhT6nwjgw2Yexd8bYek9ZvvnF8V2RHs63NNSDdrh2r4tptE5g7VcfZO/ ZsOTAMlINmt1GdutYkziDFnUaQ+floik+yMuFl+Q= From: "Oliver Smith-Denny" To: devel@edk2.groups.io Cc: Sean Brogan , Michael Kubacki , Michael D Kinney , Liming Gao Subject: [edk2-devel][PATCH v1 1/1] CharEncodingCheckPlugin: Remove Noisy Print Date: Fri, 2 Jun 2023 13:45:04 -0700 Message-Id: <20230602204504.1455-1-osde@linux.microsoft.com> X-Mailer: git-send-email 2.40.1 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Currently, CharEncodingCheckPlugin prints a message for every file that passes the test, which for some platforms can cause most of the CI build log to be filled with this print. It does not add any value, so this patch removes the noisy print and only prints if the encoding check fails. Github PR: https://github.com/tianocore/edk2/pull/4472 Cc: Sean Brogan Cc: Michael Kubacki Cc: Michael D Kinney Cc: Liming Gao Signed-off-by: Oliver Smith-Denny --- .pytool/Plugin/CharEncodingCheck/CharEncodingCheck.py | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/.pytool/Plugin/CharEncodingCheck/CharEncodingCheck.py b/.pyt= ool/Plugin/CharEncodingCheck/CharEncodingCheck.py index b09fb1704087..07d9e9ce223e 100644 --- a/.pytool/Plugin/CharEncodingCheck/CharEncodingCheck.py +++ b/.pytool/Plugin/CharEncodingCheck/CharEncodingCheck.py @@ -93,9 +93,7 @@ class CharEncodingCheck(ICiBuildPlugin): files =3D [Edk2pathObj.GetAbsolutePathOnThisSystemFromEdk2Re= lativePath(x) for x in files] for a in files: files_tested +=3D 1 - if(self.TestEncodingOk(a, enc)): - logging.debug("File {0} Passed Encoding Check {1}".f= ormat(a, enc)) - else: + if not self.TestEncodingOk(a, enc): tc.LogStdError("Encoding Failure in {0}. Not {1}".f= ormat(a, enc)) overall_status +=3D 1 =20 --=20 2.40.1