From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from NAM04-DM6-obe.outbound.protection.outlook.com (NAM04-DM6-obe.outbound.protection.outlook.com [40.107.102.41]) by mx.groups.io with SMTP id smtpd.web10.8231.1685973044400906391 for ; Mon, 05 Jun 2023 06:50:44 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="body hash did not verify" header.i=@nvidia.com header.s=selector2 header.b=oXRCIXlG; spf=permerror, err=parse error for token &{10 18 %{i}._ip.%{h}._ehlo.%{d}._spf.vali.email}: invalid domain name (domain: nvidia.com, ip: 40.107.102.41, mailfrom: nicklew@nvidia.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=iblsqUqL7JWObZo+Os70EbwHD6ZYHcNPqed3n6jENKzpjvKQ+D9rMJ0Fztp6YjczGjwPR+9IkW8co1U/XyCJojNwSqb9PqvWT7pfRxtEUcQB/cL4JW9M01RWI89mVMPd2YKEypeACmy1cct61fHvFnJ+VRwg4Nx3gJDqrxoFAJ3hVgCpw79+UPmLfS18Dx78jnONsloPkV3FYQNKapH8AJjhnQkBdQTOl8b8Gw6pVzDTptWcc2JSuH1Gz3PeJKDKs0GHF9vWt7NAZda78yKzfBF4Wl9WudU03BNnzBtY5oSdYQ9nT4a61eHT6Kv+Ha9nIV2MUNE4j8/odC+tBf+Dew== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=t2G2eyVwXqFJTjHo2vpWaECbZGROWAca4/jpG+MXLJY=; b=TjTTwrVbQFFR+MplbFvCGXutNIlAswrXj7RftFS36RUwhYHAkIbk/0cQDVtOAZ+LBPAe45kJqcbvWUKulsvtYC8WUimK9BXQKek0uPgR6RUXTt2jy/sUH01dFIXdHTKMg1NQkNrACQrXRUH4Ov6zwHpWhYA3NfdtOx0QJceKe71y2mghYwYrhEyI1+ehd/4i2VEYm2lehGQx8zqq+/ddS2Jy8PDcFwFsFBCPTjWSJ0gqXT1rdNnFLwKOeronRpOxHwPEf5MbnJihmldgt1fsXG3jbWNjV3dimkEZLPodNd5MsNMAG/JW95gEZRadA3euOaFEPdC9Wi4xlha5QapUkw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.118.232) smtp.rcpttodomain=edk2.groups.io smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=t2G2eyVwXqFJTjHo2vpWaECbZGROWAca4/jpG+MXLJY=; b=oXRCIXlGpDzPTjT4hjjdfOPvHlqDUcEcS/EOSKWa9jKXPnrrCJZG3MFH5RZ8OZVtthPdQSDxNQGbURe+nkl7pvP9zeKCjwmq9M1vbSR8lZimboKQNzpeZo4GqyZQf1HQWsccitp3v39ABYSq+cVRr4+6/m9fQYmPcZGcUMBDtu5HIGzjMUUQVjIJH/69RhpAXHKskUQlu9RIaeCB5WSL3FXQtnNwP4DjmNxzgCCdLhHxCtADk4T96FE7QGrksPjzFobIIbVB/Q08pX9gxi3x8TBrZKZ8spEZathyZ0z3DSmAMSRMK68hUd08emX2BEZEQqRiUdS5Y9AopLEo3hpL5A== Received: from CY5PR15CA0016.namprd15.prod.outlook.com (2603:10b6:930:14::11) by BL1PR12MB5048.namprd12.prod.outlook.com (2603:10b6:208:30a::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6455.33; Mon, 5 Jun 2023 13:50:42 +0000 Received: from CY4PEPF0000E9D4.namprd03.prod.outlook.com (2603:10b6:930:14:cafe::94) by CY5PR15CA0016.outlook.office365.com (2603:10b6:930:14::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6455.33 via Frontend Transport; Mon, 5 Jun 2023 13:50:41 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.118.232) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.118.232 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.118.232; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.118.232) by CY4PEPF0000E9D4.mail.protection.outlook.com (10.167.241.147) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6477.13 via Frontend Transport; Mon, 5 Jun 2023 13:50:41 +0000 Received: from drhqmail202.nvidia.com (10.126.190.181) by mail.nvidia.com (10.127.129.5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.5; Mon, 5 Jun 2023 06:50:30 -0700 Received: from drhqmail201.nvidia.com (10.126.190.180) by drhqmail202.nvidia.com (10.126.190.181) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.37; Mon, 5 Jun 2023 06:50:30 -0700 Received: from NV-CL38DL3.nvidia.com (10.127.8.13) by mail.nvidia.com (10.126.190.180) with Microsoft SMTP Server id 15.2.986.37 via Frontend Transport; Mon, 5 Jun 2023 06:50:29 -0700 From: "Nickle Wang" To: CC: Abner Chang , Igor Kulchytskyy Subject: [edk2-redfish-client][PATCH 7/9] RedfishClientPkg/BiosDxe: Fix build error Date: Mon, 5 Jun 2023 21:50:28 +0800 Message-ID: <20230605135028.25765-1-nicklew@nvidia.com> X-Mailer: git-send-email 2.17.1 MIME-Version: 1.0 Return-Path: nicklew@nvidia.com X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CY4PEPF0000E9D4:EE_|BL1PR12MB5048:EE_ X-MS-Office365-Filtering-Correlation-Id: 6f9a30d4-c09a-43e0-0e26-08db65cbda3b X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: rBFeNpHVHykN1Ta7Sb2BzK6CfAtXRoi4sDNYDIckWFAxxv6zENCWQn8/oqkBO4qEHSR3iEUx2T8Zim4xWnm4yTRtyeY1h22ALZ4H2rDKMG72SdrXk+j6UD1da9+t7orT4Rr5WZ5Y/TNOe+xQ9oPHctrOT0I+fB2WWsv45r7F2BHzDtVllkvix1Fh8PoYAkVI6/HrqhEByznPKnJPCtdLOT39wuSgLs1HMhrL9u4UHjxx+9YU/omR3PHp0UYzJGm7mdB4hN4kZWahmZsi5OPwYpLOoTXVNaV8mFXXhgMln6JxsbtzvFWXig6ID5tfowXAq5PrCBiR8totWGDQyhpaEKYKTAomE5rp5UAKzQrpz/hT10cr/N6PSqYWAgnqGCuJPIiYbWPB2qEOtC4wmsy6ORcHfJyHivLwKejQ+i94EIGjNElK/VCrpFi/+JUgMFOwYjXB6RBhycd/xDD8sLxt9UfpxTpc+BGNWHG4tDqOYwRFN63H3x6WCnRkAlsRMP3PbUQqEiSBlZa5eQhz5hYHNyezOEvjb4cDXyvVo5ilXwIFLrKpPsKxI6CDQpuQdkyD4JPxtu4pcpqgAEZZ59PDQahhitm3kdlVJG/TF4AYFHNGQQsPkWmqEK4bLBprB72BVDxUfBN2dhdL0gbWxwAP4ujnT8o4UB5WEjzRfUr9xUAiHHa6BC2kABwQrg9WVVuJpeyVdfGikZxgTOgavwuatetTSMqOYRS/BJBiNhzkQXP83x1ziNSNxE4n0lKA+LL2 X-Forefront-Antispam-Report: CIP:216.228.118.232;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:mail.nvidia.com;PTR:dc7edge1.nvidia.com;CAT:NONE;SFS:(13230028)(4636009)(376002)(396003)(39860400002)(136003)(346002)(451199021)(46966006)(40470700004)(36840700001)(1076003)(26005)(186003)(2616005)(336012)(426003)(83380400001)(47076005)(36756003)(36860700001)(82310400005)(7696005)(2906002)(8676002)(8936002)(19627235002)(40480700001)(82740400003)(54906003)(478600001)(5660300002)(6916009)(4326008)(40460700003)(86362001)(316002)(41300700001)(356005)(7636003)(70206006)(70586007);DIR:OUT;SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Jun 2023 13:50:41.6033 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 6f9a30d4-c09a-43e0-0e26-08db65cbda3b X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a;Ip=[216.228.118.232];Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: CY4PEPF0000E9D4.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL1PR12MB5048 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain - Fix "variable set but not used" error. - Fix missing "EFIAPI" error. - Fix typos. Signed-off-by: Nickle Wang Cc: Abner Chang Cc: Igor Kulchytskyy --- .../Features/Bios/v1_0_9/Dxe/BiosDxe.c | 20 ++++++++++--------- 1 file changed, 11 insertions(+), 9 deletions(-) diff --git a/RedfishClientPkg/Features/Bios/v1_0_9/Dxe/BiosDxe.c b/RedfishC= lientPkg/Features/Bios/v1_0_9/Dxe/BiosDxe.c index c65e2f51..e7ac8779 100644 --- a/RedfishClientPkg/Features/Bios/v1_0_9/Dxe/BiosDxe.c +++ b/RedfishClientPkg/Features/Bios/v1_0_9/Dxe/BiosDxe.c @@ -2,7 +2,7 @@ Redfish feature driver implementation - Bios =20 (C) Copyright 2020-2022 Hewlett Packard Enterprise Development LP
- Copyright (c) 2022, NVIDIA CORPORATION. All rights reserved. + Copyright (c) 2022-2023, NVIDIA CORPORATION. All rights reserved. =20 SPDX-License-Identifier: BSD-2-Clause-Patent =20 @@ -18,10 +18,10 @@ HandleResource ( IN EFI_STRING Uri ); =20 -EFI_HANDLE medfishResourceConfigProtocolHandle; +EFI_HANDLE mRedfishResourceConfigProtocolHandle; =20 /** - Provising redfish resource by given URI. + Provisioning redfish resource by given URI. =20 @param[in] This Pointer to EFI_HP_REDFISH_HII_PROTOCOL = instance. @param[in] Uri Target URI to create resource. @@ -33,6 +33,7 @@ EFI_HANDLE medfishResourceConfigProtocolHandle; =20 **/ EFI_STATUS +EFIAPI RedfishResourceProvisioningResource ( IN EDKII_REDFISH_RESOURCE_CONFIG_PROTOCOL *This, IN EFI_STRING Uri, @@ -94,6 +95,7 @@ RedfishResourceProvisioningResource ( =20 **/ EFI_STATUS +EFIAPI RedfishResourceConsumeResource ( IN EDKII_REDFISH_RESOURCE_CONFIG_PROTOCOL *This, IN EFI_STRING Uri @@ -233,19 +235,16 @@ RedfishResourceConsumeResource ( =20 **/ EFI_STATUS +EFIAPI RedfishResourceGetInfo ( IN EDKII_REDFISH_RESOURCE_CONFIG_PROTOCOL *This, OUT REDFISH_SCHEMA_INFO *Info ) { - REDFISH_RESOURCE_COMMON_PRIVATE *Private; - if ((This =3D=3D NULL) || (Info =3D=3D NULL)) { return EFI_INVALID_PARAMETER; } =20 - Private =3D REDFISH_RESOURCE_COMMON_PRIVATE_DATA_FROM_RESOURCE_PROTOCOL = (This); - AsciiStrCpyS (Info->Schema, REDFISH_SCHEMA_STRING_SIZE, RESOURCE_SCHEMA)= ; AsciiStrCpyS (Info->Major, REDFISH_SCHEMA_VERSION_SIZE, RESOURCE_SCHEMA_= MAJOR); AsciiStrCpyS (Info->Minor, REDFISH_SCHEMA_VERSION_SIZE, RESOURCE_SCHEMA_= MINOR); @@ -265,6 +264,7 @@ RedfishResourceGetInfo ( =20 **/ EFI_STATUS +EFIAPI RedfishResourceUpdate ( IN EDKII_REDFISH_RESOURCE_CONFIG_PROTOCOL *This, IN EFI_STRING Uri @@ -334,6 +334,7 @@ RedfishResourceUpdate ( =20 **/ EFI_STATUS +EFIAPI RedfishResourceCheck ( IN EDKII_REDFISH_RESOURCE_CONFIG_PROTOCOL *This, IN EFI_STRING Uri @@ -404,6 +405,7 @@ RedfishResourceCheck ( =20 **/ EFI_STATUS +EFIAPI RedfishResourceIdentify ( IN EDKII_REDFISH_RESOURCE_CONFIG_PROTOCOL *This, IN EFI_STRING Uri @@ -478,7 +480,7 @@ EDKII_REDFISH_RESOURCE_CONFIG_PROTOCOL mRedfishResourc= eConfig =3D { handler. =20 @param[in] This Pointer to EDKII_REDFISH_CONFIG_HA= NDLER_PROTOCOL instance. - @param[in] RedfishConfigServiceInfo Redfish service informaion. + @param[in] RedfishConfigServiceInfo Redfish service information. =20 @retval EFI_SUCCESS The handler has been initialized su= ccessfully. @retval EFI_DEVICE_ERROR Failed to create or configure the R= EST EX protocol instance. @@ -799,7 +801,7 @@ RedfishResourceEntryPoint ( return EFI_ALREADY_STARTED; } =20 - medfishResourceConfigProtocolHandle =3D ImageHandle; + mRedfishResourceConfigProtocolHandle =3D ImageHandle; =20 mRedfishResourcePrivate =3D AllocateZeroPool (sizeof (REDFISH_RESOURCE_C= OMMON_PRIVATE)); CopyMem (&mRedfishResourcePrivate->ConfigHandler, &mRedfishConfigHandler= , sizeof (EDKII_REDFISH_CONFIG_HANDLER_PROTOCOL)); --=20 2.17.1