* [edk2-redfish-client][PATCH 8/9] RedfishClientPkg/MemoryDxe: Fix build error
@ 2023-06-05 13:50 Nickle Wang
0 siblings, 0 replies; only message in thread
From: Nickle Wang @ 2023-06-05 13:50 UTC (permalink / raw)
To: devel; +Cc: Abner Chang, Igor Kulchytskyy
- Fix "variable set but not used" error.
- Fix missing "EFIAPI" error.
- Fix typos.
Signed-off-by: Nickle Wang <nicklew@nvidia.com>
Cc: Abner Chang <abner.chang@amd.com>
Cc: Igor Kulchytskyy <igork@ami.com>
---
.../Features/Memory/V1_7_1/Dxe/MemoryDxe.c | 19 +++++++++++--------
1 file changed, 11 insertions(+), 8 deletions(-)
diff --git a/RedfishClientPkg/Features/Memory/V1_7_1/Dxe/MemoryDxe.c b/RedfishClientPkg/Features/Memory/V1_7_1/Dxe/MemoryDxe.c
index 78784118..c55a6848 100644
--- a/RedfishClientPkg/Features/Memory/V1_7_1/Dxe/MemoryDxe.c
+++ b/RedfishClientPkg/Features/Memory/V1_7_1/Dxe/MemoryDxe.c
@@ -2,6 +2,7 @@
Redfish feature driver implementation - Memory
(C) Copyright 2020-2022 Hewlett Packard Enterprise Development LP<BR>
+ Copyright (c) 2023, NVIDIA CORPORATION & AFFILIATES. All rights reserved.
SPDX-License-Identifier: BSD-2-Clause-Patent
@@ -11,10 +12,10 @@
extern REDFISH_RESOURCE_COMMON_PRIVATE *mRedfishResourcePrivate;
-EFI_HANDLE medfishResourceConfigProtocolHandle;
+EFI_HANDLE mRedfishResourceConfigProtocolHandle;
/**
- Provising redfish resource by given URI.
+ Provisioning redfish resource by given URI.
@param[in] This Pointer to EFI_HP_REDFISH_HII_PROTOCOL instance.
@param[in] Uri Target URI to create resource.
@@ -26,6 +27,7 @@ EFI_HANDLE medfishResourceConfigProtocolHandle;
**/
EFI_STATUS
+EFIAPI
RedfishResourceProvisioningResource (
IN EDKII_REDFISH_RESOURCE_CONFIG_PROTOCOL *This,
IN EFI_STRING Uri,
@@ -87,6 +89,7 @@ RedfishResourceProvisioningResource (
**/
EFI_STATUS
+EFIAPI
RedfishResourceConsumeResource (
IN EDKII_REDFISH_RESOURCE_CONFIG_PROTOCOL *This,
IN EFI_STRING Uri
@@ -178,19 +181,16 @@ RedfishResourceConsumeResource (
**/
EFI_STATUS
+EFIAPI
RedfishResourceGetInfo (
IN EDKII_REDFISH_RESOURCE_CONFIG_PROTOCOL *This,
OUT REDFISH_SCHEMA_INFO *Info
)
{
- REDFISH_RESOURCE_COMMON_PRIVATE *Private;
-
if ((This == NULL) || (Info == NULL)) {
return EFI_INVALID_PARAMETER;
}
- Private = REDFISH_RESOURCE_COMMON_PRIVATE_DATA_FROM_RESOURCE_PROTOCOL (This);
-
AsciiStrCpyS (Info->Schema, REDFISH_SCHEMA_STRING_SIZE, RESOURCE_SCHEMA);
AsciiStrCpyS (Info->Major, REDFISH_SCHEMA_VERSION_SIZE, RESOURCE_SCHEMA_MAJOR);
AsciiStrCpyS (Info->Minor, REDFISH_SCHEMA_VERSION_SIZE, RESOURCE_SCHEMA_MINOR);
@@ -210,6 +210,7 @@ RedfishResourceGetInfo (
**/
EFI_STATUS
+EFIAPI
RedfishResourceUpdate (
IN EDKII_REDFISH_RESOURCE_CONFIG_PROTOCOL *This,
IN EFI_STRING Uri
@@ -279,6 +280,7 @@ RedfishResourceUpdate (
**/
EFI_STATUS
+EFIAPI
RedfishResourceCheck (
IN EDKII_REDFISH_RESOURCE_CONFIG_PROTOCOL *This,
IN EFI_STRING Uri
@@ -349,6 +351,7 @@ RedfishResourceCheck (
**/
EFI_STATUS
+EFIAPI
RedfishResourceIdentify (
IN EDKII_REDFISH_RESOURCE_CONFIG_PROTOCOL *This,
IN EFI_STRING Uri
@@ -423,7 +426,7 @@ EDKII_REDFISH_RESOURCE_CONFIG_PROTOCOL mRedfishResourceConfig = {
handler.
@param[in] This Pointer to EDKII_REDFISH_CONFIG_HANDLER_PROTOCOL instance.
- @param[in] RedfishConfigServiceInfo Redfish service informaion.
+ @param[in] RedfishConfigServiceInfo Redfish service information.
@retval EFI_SUCCESS The handler has been initialized successfully.
@retval EFI_DEVICE_ERROR Failed to create or configure the REST EX protocol instance.
@@ -613,7 +616,7 @@ RedfishResourceEntryPoint (
return EFI_ALREADY_STARTED;
}
- medfishResourceConfigProtocolHandle = ImageHandle;
+ mRedfishResourceConfigProtocolHandle = ImageHandle;
mRedfishResourcePrivate = AllocateZeroPool (sizeof (REDFISH_RESOURCE_COMMON_PRIVATE));
CopyMem (&mRedfishResourcePrivate->ConfigHandler, &mRedfishConfigHandler, sizeof (EDKII_REDFISH_CONFIG_HANDLER_PROTOCOL));
--
2.17.1
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2023-06-05 13:50 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-06-05 13:50 [edk2-redfish-client][PATCH 8/9] RedfishClientPkg/MemoryDxe: Fix build error Nickle Wang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox