From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from NAM04-DM6-obe.outbound.protection.outlook.com (NAM04-DM6-obe.outbound.protection.outlook.com [40.107.102.78]) by mx.groups.io with SMTP id smtpd.web11.8248.1685973057588671798 for ; Mon, 05 Jun 2023 06:50:57 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="body hash did not verify" header.i=@nvidia.com header.s=selector2 header.b=QOKIN8pO; spf=permerror, err=parse error for token &{10 18 %{i}._ip.%{h}._ehlo.%{d}._spf.vali.email}: invalid domain name (domain: nvidia.com, ip: 40.107.102.78, mailfrom: nicklew@nvidia.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=TbtTZb0m0KP0+ygvRzu4KSHKWhborLlS+Bhtdbb8mE6wouACzxEzAl9AjX3bqFOn1rdZ+wOSVY+hYqc3pOocsrOkqReXHasxnNuPS6QHrhovOvTKPAUx8dhPy11ieHtxcZwfCU1JlzKNqbhBeQrbrMgxRjST2h7Lq4dwrNk+KhR+wUBiWvqjyBbJHkbr9WKAOCVs9/uwc+lePjygWMN6EOvxGOeXfToDkLIc7O7+vzVW7JlcXVA2OueZBIBc29sRTTzlCbKzyeMeVB9IGeFxwI1Wa/RFsTmN/X4+KNg9195gz7MMKPUM4IyG4kC8ak0Jb4bUrIkdAanp5JQRMa1RZQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=pNgAfswSn9CFyJk2Fr5Cz0V7bVq6xx3cdYCNcMCIIIQ=; b=HLuhm2PnIWJVnJ1CWGCN+VV9OMOiBklllN5eHGXkuCPuGfqLNlUePFHmBK1lvIowYQOfYv51YZZR5UXYh/oVCapAeEUQuxyFIQTsfa62gYHx9z9BjzfFjjCGgudjduY7enl+Jcz6eE4rlGoHSytRbyETaWnWO+lj+dlNBeAbu+rOcKEFOg4UDToPZNaWTHT5akDoPjwtYULwehmgKPa+mYUSzZSh3orxqbRF4SLu2Wnug56CeaCiE41RVWJcAOz63/fvVRgBcm/Tcm2bQ16aKYygKlLWFJIZx6nHs9Yrq/3fn2IAl32m9axjEwo8xicX3S78kNoRd/yRPnH5w70qXQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.160) smtp.rcpttodomain=edk2.groups.io smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=pNgAfswSn9CFyJk2Fr5Cz0V7bVq6xx3cdYCNcMCIIIQ=; b=QOKIN8pOK6sQrbGOTputV6+2lO7ztbVs4GVfnzhSiFt2JCCST8bxAo34C7eOHZYQ6Zqv5c0k/vMc+k7voN5W4fSoH1fHLc20iMwRMZlL/NpmVdbOZHyqH7CNGdAJWzw5exejlSh34wa6GSeJsSimlaf5VnnEPy/j8HaxN8Yrlz75P6ii3Rau46GNKOYYBUWZf2DpfBk25wHSMU+zZb1OvKsmwBLoWRiVD1YrsvY7EL2VIso+UrlM6FLSOOTpbgkQpiKIy7WknNAJMPxpro4hhc+gHj14Ve/otNnxSvJwJkITXZdUEtSdrFOtmbYlNN+nlsbALTq+CXtETNb0LS+u1Q== Received: from MW2PR16CA0029.namprd16.prod.outlook.com (2603:10b6:907::42) by BL3PR12MB6547.namprd12.prod.outlook.com (2603:10b6:208:38e::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6455.33; Mon, 5 Jun 2023 13:50:55 +0000 Received: from CO1NAM11FT078.eop-nam11.prod.protection.outlook.com (2603:10b6:907:0:cafe::7f) by MW2PR16CA0029.outlook.office365.com (2603:10b6:907::42) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6455.33 via Frontend Transport; Mon, 5 Jun 2023 13:50:55 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.160) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.160 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.160; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.160) by CO1NAM11FT078.mail.protection.outlook.com (10.13.175.177) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6455.23 via Frontend Transport; Mon, 5 Jun 2023 13:50:54 +0000 Received: from rnnvmail203.nvidia.com (10.129.68.9) by mail.nvidia.com (10.129.200.66) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.5; Mon, 5 Jun 2023 06:50:37 -0700 Received: from rnnvmail201.nvidia.com (10.129.68.8) by rnnvmail203.nvidia.com (10.129.68.9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.37; Mon, 5 Jun 2023 06:50:36 -0700 Received: from NV-CL38DL3.nvidia.com (10.127.8.13) by mail.nvidia.com (10.129.68.8) with Microsoft SMTP Server id 15.2.986.37 via Frontend Transport; Mon, 5 Jun 2023 06:50:35 -0700 From: "Nickle Wang" To: CC: Abner Chang , Igor Kulchytskyy Subject: [edk2-redfish-client][PATCH 8/9] RedfishClientPkg/MemoryDxe: Fix build error Date: Mon, 5 Jun 2023 21:50:35 +0800 Message-ID: <20230605135035.25854-1-nicklew@nvidia.com> X-Mailer: git-send-email 2.17.1 MIME-Version: 1.0 Return-Path: nicklew@nvidia.com X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CO1NAM11FT078:EE_|BL3PR12MB6547:EE_ X-MS-Office365-Filtering-Correlation-Id: e24f97c0-ca2d-4e4b-f87a-08db65cbe212 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: aN9Qz9IidaNHAp+V65yC/6WnIrqV1a2XVPL1cFMXksWFyhBVWFcQq0QCT3pIzYIikCsiMwBvjC3PEERCbRi8YLjJHWpiHbs391NpR+7KEqcz/psUmoEQfVLFYur0tHLaYAvHx9HWWhbue/cjFTrDudtxb4O1fvzYBghdXkZYb1ij9fjTeIZy4d8Ez+Hl8szwtA9+HLNa+UygJRIhUKNE52XTTJMxK3ywjkKWROQDtyXODuzG7DZffEFSmYznLQJKU3aA0Xf2dDVyYzBKx2mov75qI4AVl0I920sK+oYHqtioJsIkt8V5lWJWoKQkrYH8Ua09GXF/wrpgFqzkNDiQhueK+gbm+cm8vQBEH+aHqZZ4JI0WE2bjhUU3Xi8O3u+QhPP42vkzwmKbrX2FS1bKXcF6M5DEwB5WTdPGkB1dYMz85ZJoMyasOOLz3PpLhJfhfISRpIoGkP4Dk0Nd6qu8kLcJSpGkRcKKSB7NtYFeouoJuX5eWuoKZx9viNSQpnF9crVnq1OYWlJBvmaZK8QxJ5pUO5lLazTlsspgYeo29m3hThslqGk9vmpcf23bi2oHp/c6DSP2OzB8B3xrO4N+JngIwjw/MkkLYdaPWXiaRCieHD6/rA/xAp0elqqB+9mGTRRE9AVXGuxNRxRmUfPLdRdQa47Y2tldnVSYTmrLl0bAULe16l3zLWE70BgZ1jxcjZVtID1WH642mYHu/dCiSiHpJU02j6xK+L8KJVPxy+ByOdfdE0Fo/11Uv68C0Ybe X-Forefront-Antispam-Report: CIP:216.228.117.160;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:mail.nvidia.com;PTR:dc6edge1.nvidia.com;CAT:NONE;SFS:(13230028)(4636009)(396003)(136003)(376002)(346002)(39850400004)(451199021)(40470700004)(46966006)(36840700001)(36756003)(2906002)(86362001)(82310400005)(5660300002)(40480700001)(47076005)(83380400001)(7696005)(426003)(336012)(186003)(36860700001)(1076003)(26005)(356005)(7636003)(478600001)(19627235002)(82740400003)(40460700003)(54906003)(6916009)(70586007)(70206006)(316002)(4326008)(2616005)(41300700001)(8936002)(8676002);DIR:OUT;SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Jun 2023 13:50:54.7780 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: e24f97c0-ca2d-4e4b-f87a-08db65cbe212 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a;Ip=[216.228.117.160];Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: CO1NAM11FT078.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL3PR12MB6547 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain - Fix "variable set but not used" error. - Fix missing "EFIAPI" error. - Fix typos. Signed-off-by: Nickle Wang Cc: Abner Chang Cc: Igor Kulchytskyy --- .../Features/Memory/V1_7_1/Dxe/MemoryDxe.c | 19 +++++++++++-------- 1 file changed, 11 insertions(+), 8 deletions(-) diff --git a/RedfishClientPkg/Features/Memory/V1_7_1/Dxe/MemoryDxe.c b/Redf= ishClientPkg/Features/Memory/V1_7_1/Dxe/MemoryDxe.c index 78784118..c55a6848 100644 --- a/RedfishClientPkg/Features/Memory/V1_7_1/Dxe/MemoryDxe.c +++ b/RedfishClientPkg/Features/Memory/V1_7_1/Dxe/MemoryDxe.c @@ -2,6 +2,7 @@ Redfish feature driver implementation - Memory =20 (C) Copyright 2020-2022 Hewlett Packard Enterprise Development LP
+ Copyright (c) 2023, NVIDIA CORPORATION & AFFILIATES. All rights reserved= . =20 SPDX-License-Identifier: BSD-2-Clause-Patent =20 @@ -11,10 +12,10 @@ =20 extern REDFISH_RESOURCE_COMMON_PRIVATE *mRedfishResourcePrivate; =20 -EFI_HANDLE medfishResourceConfigProtocolHandle; +EFI_HANDLE mRedfishResourceConfigProtocolHandle; =20 /** - Provising redfish resource by given URI. + Provisioning redfish resource by given URI. =20 @param[in] This Pointer to EFI_HP_REDFISH_HII_PROTOCOL = instance. @param[in] Uri Target URI to create resource. @@ -26,6 +27,7 @@ EFI_HANDLE medfishResourceConfigProtocolHandle; =20 **/ EFI_STATUS +EFIAPI RedfishResourceProvisioningResource ( IN EDKII_REDFISH_RESOURCE_CONFIG_PROTOCOL *This, IN EFI_STRING Uri, @@ -87,6 +89,7 @@ RedfishResourceProvisioningResource ( =20 **/ EFI_STATUS +EFIAPI RedfishResourceConsumeResource ( IN EDKII_REDFISH_RESOURCE_CONFIG_PROTOCOL *This, IN EFI_STRING Uri @@ -178,19 +181,16 @@ RedfishResourceConsumeResource ( =20 **/ EFI_STATUS +EFIAPI RedfishResourceGetInfo ( IN EDKII_REDFISH_RESOURCE_CONFIG_PROTOCOL *This, OUT REDFISH_SCHEMA_INFO *Info ) { - REDFISH_RESOURCE_COMMON_PRIVATE *Private; - if ((This =3D=3D NULL) || (Info =3D=3D NULL)) { return EFI_INVALID_PARAMETER; } =20 - Private =3D REDFISH_RESOURCE_COMMON_PRIVATE_DATA_FROM_RESOURCE_PROTOCOL = (This); - AsciiStrCpyS (Info->Schema, REDFISH_SCHEMA_STRING_SIZE, RESOURCE_SCHEMA)= ; AsciiStrCpyS (Info->Major, REDFISH_SCHEMA_VERSION_SIZE, RESOURCE_SCHEMA_= MAJOR); AsciiStrCpyS (Info->Minor, REDFISH_SCHEMA_VERSION_SIZE, RESOURCE_SCHEMA_= MINOR); @@ -210,6 +210,7 @@ RedfishResourceGetInfo ( =20 **/ EFI_STATUS +EFIAPI RedfishResourceUpdate ( IN EDKII_REDFISH_RESOURCE_CONFIG_PROTOCOL *This, IN EFI_STRING Uri @@ -279,6 +280,7 @@ RedfishResourceUpdate ( =20 **/ EFI_STATUS +EFIAPI RedfishResourceCheck ( IN EDKII_REDFISH_RESOURCE_CONFIG_PROTOCOL *This, IN EFI_STRING Uri @@ -349,6 +351,7 @@ RedfishResourceCheck ( =20 **/ EFI_STATUS +EFIAPI RedfishResourceIdentify ( IN EDKII_REDFISH_RESOURCE_CONFIG_PROTOCOL *This, IN EFI_STRING Uri @@ -423,7 +426,7 @@ EDKII_REDFISH_RESOURCE_CONFIG_PROTOCOL mRedfishResourc= eConfig =3D { handler. =20 @param[in] This Pointer to EDKII_REDFISH_CONFIG_HA= NDLER_PROTOCOL instance. - @param[in] RedfishConfigServiceInfo Redfish service informaion. + @param[in] RedfishConfigServiceInfo Redfish service information. =20 @retval EFI_SUCCESS The handler has been initialized su= ccessfully. @retval EFI_DEVICE_ERROR Failed to create or configure the R= EST EX protocol instance. @@ -613,7 +616,7 @@ RedfishResourceEntryPoint ( return EFI_ALREADY_STARTED; } =20 - medfishResourceConfigProtocolHandle =3D ImageHandle; + mRedfishResourceConfigProtocolHandle =3D ImageHandle; =20 mRedfishResourcePrivate =3D AllocateZeroPool (sizeof (REDFISH_RESOURCE_C= OMMON_PRIVATE)); CopyMem (&mRedfishResourcePrivate->ConfigHandler, &mRedfishConfigHandler= , sizeof (EDKII_REDFISH_CONFIG_HANDLER_PROTOCOL)); --=20 2.17.1