From: "Nickle Wang" <nicklew@nvidia.com>
To: <devel@edk2.groups.io>
Cc: Abner Chang <abner.chang@amd.com>, Igor Kulchytskyy <igork@ami.com>
Subject: [edk2-redfish-client][PATCH v2 5/9] RedfishClientPkg/RedfishETagDxe: Fix build error
Date: Tue, 6 Jun 2023 20:33:01 +0800 [thread overview]
Message-ID: <20230606123301.17597-1-nicklew@nvidia.com> (raw)
- Fix missing "EFIAPI" build error.
- Fix typos.
Signed-off-by: Nickle Wang <nicklew@nvidia.com>
Cc: Abner Chang <abner.chang@amd.com>
Cc: Igor Kulchytskyy <igork@ami.com>
---
.../Include/Protocol/EdkIIRedfishETagProtocol.h | 2 +-
RedfishClientPkg/RedfishETagDxe/RedfishETagDxe.c | 13 ++++++++-----
2 files changed, 9 insertions(+), 6 deletions(-)
diff --git a/RedfishClientPkg/Include/Protocol/EdkIIRedfishETagProtocol.h b/RedfishClientPkg/Include/Protocol/EdkIIRedfishETagProtocol.h
index 4e10965a..42853860 100644
--- a/RedfishClientPkg/Include/Protocol/EdkIIRedfishETagProtocol.h
+++ b/RedfishClientPkg/Include/Protocol/EdkIIRedfishETagProtocol.h
@@ -36,7 +36,7 @@ EFI_STATUS
@param[in] This Pointer to EDKII_REDFISH_ETAG_PROTOCOL instance.
@param[in] Uri The target Uri which related to ETag.
- @param[in] ETag The ETag to add. If ETag is NULL, the record of correspoonding URI will be removed.
+ @param[in] ETag The ETag to add. If ETag is NULL, the record of corresponding URI will be removed.
@retval EFI_SUCCESS This handler has been stoped successfully.
@retval Others Some error happened.
diff --git a/RedfishClientPkg/RedfishETagDxe/RedfishETagDxe.c b/RedfishClientPkg/RedfishETagDxe/RedfishETagDxe.c
index 60b05e8b..7ac6e885 100644
--- a/RedfishClientPkg/RedfishETagDxe/RedfishETagDxe.c
+++ b/RedfishClientPkg/RedfishETagDxe/RedfishETagDxe.c
@@ -102,7 +102,7 @@ ON_ERROR:
@param[in] Uri The URI string matching to this ETAG.
@param[in] ETag ETAG string.
- @retval EFI_SUCCESS ETAG recourd is added.
+ @retval EFI_SUCCESS ETAG record is added.
@retval Others Fail to add ETAG.
**/
@@ -137,7 +137,7 @@ AddETagRecord (
@param[in] List Target ETAG list to be removed.
@param[in] Record Pointer to the instance to be deleted.
- @retval EFI_SUCCESS ETAG recourd is removed.
+ @retval EFI_SUCCESS ETAG record is removed.
@retval Others Fail to add ETAG.
**/
@@ -357,7 +357,7 @@ SaveETagList (
}
//
- // Caculate the total size we need to keep ETag list.
+ // Calculate the total size we need to keep ETag list.
//
VarSize = ETagList->TotalSize + 1; // terminator character
VarData = AllocateZeroPool (VarSize);
@@ -514,6 +514,7 @@ ON_ERROR:
**/
EFI_STATUS
+EFIAPI
RedfishETagGet (
IN EDKII_REDFISH_ETAG_PROTOCOL *This,
IN CHAR8 *Uri,
@@ -546,13 +547,14 @@ RedfishETagGet (
@param[in] This Pointer to EDKII_REDFISH_ETAG_PROTOCOL instance.
@param[in] Uri The target Uri which related to ETag.
- @param[in] ETag The ETag to add. If ETag is NULL, the record of correspoonding URI will be removed.
+ @param[in] ETag The ETag to add. If ETag is NULL, the record of corresponding URI will be removed.
@retval EFI_SUCCESS This handler has been stoped successfully.
@retval Others Some error happened.
**/
EFI_STATUS
+EFIAPI
RedfishETagSet (
IN EDKII_REDFISH_ETAG_PROTOCOL *This,
IN CHAR8 *Uri,
@@ -579,7 +581,7 @@ RedfishETagSet (
}
//
- // When ETag is NULL, it means that we want to remov this record.
+ // When ETag is NULL, it means that we want to remove this record.
//
if (ETag == NULL) {
return Status;
@@ -598,6 +600,7 @@ RedfishETagSet (
**/
EFI_STATUS
+EFIAPI
RedfishETagFlush (
IN EDKII_REDFISH_ETAG_PROTOCOL *This
)
--
2.17.1
reply other threads:[~2023-06-06 12:33 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230606123301.17597-1-nicklew@nvidia.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox