From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (NAM12-BN8-obe.outbound.protection.outlook.com [40.107.237.59]) by mx.groups.io with SMTP id smtpd.web11.7639.1686054811587956463 for ; Tue, 06 Jun 2023 05:33:31 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="body hash did not verify" header.i=@nvidia.com header.s=selector2 header.b=AMGEwrrl; spf=permerror, err=parse error for token &{10 18 %{i}._ip.%{h}._ehlo.%{d}._spf.vali.email}: invalid domain name (domain: nvidia.com, ip: 40.107.237.59, mailfrom: nicklew@nvidia.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Y1u31ZH0xyAtVe4PSVI5z8LDhYIp6XefXwC/QzMkNIqvzHWh3S/+YSWGIUnidze8Jct404I7CMHOmTc5cpThTVvOMcMsttG4BYwaJ7RtUkdZNhpB0MSqRtS9+iK/MjpgYUD0a8aFcoREm0jdc4jAV5qw/jMUnKGQEqAoHa8SCtD1dyMbk0TEcGBQf9ISlFdcSpiheoEWDQWZ/h5Aqc3ACblQ3b3yeLXHqBn2fOaSSgRMakjaGjn0pMJgvxyr7zv/nElJPhtrvtvCL4HINMah9y1f0JktqLeNYSAYVy0B5NJidldruurekrPS54iR2nTz+QwdlMFM3iYy4rwYAArGVg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=t2G2eyVwXqFJTjHo2vpWaECbZGROWAca4/jpG+MXLJY=; b=SfIm1qB+sCzbEZM9Jz5yiv01i0XGkCPZAoSHkVem37WPwiNOWuXluUhTqG/+qjHRwUtuomaMLYsG8bwPWrpNel6S07+MWnUOyHlrAB6M/AoqENB/V5kuYFQ/4/BEyyhSoKIxYxxAU9WS2MYBn+o8fBgHlkxiht/FiPAYMWh132ztUDV2f5BF0VvfF/qYKIJirH7VftDbEVwkXEmbTj/+scK3yxT8+CJeR7cSg0IAOnKZ8w9fPA3/6hJFMODvdIk4V5g/2ieWEG0Hv0oc4gOedm6qWR179W5btEba/sO13PNw1xmvU/pB7KClGs5Ke7ipi89Ydas67La/Zar96w/38g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.118.233) smtp.rcpttodomain=edk2.groups.io smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=t2G2eyVwXqFJTjHo2vpWaECbZGROWAca4/jpG+MXLJY=; b=AMGEwrrl603K8+EH1TVQtE6cn5UhR/DO/o9d8HomOltepl7Vg4z0JWCqxTvOJy8WrNxydWagVcPYgBFFgNQ/xC+RuXy8WZwwJI4zuiuYY26aWVv9Iv5s4qH/HwNpQFCrD7yIpdvJ7PYnQTFyP5fIt7H1S8KNvS9gvlFLbWEzO/IVW0SGj71GtraOfaktMo0cgZapbi8CyGJVJ5TWWfQYw1zd5kUPx67z3ynziOG7PJt6G6a0dVxbfhymLaVy4aWsPoJYPem41GfR/Lkl/LPG6CMkDjakGZu41RvjzAgUgBpPvyos1QGzqdbom+LRz3N4hhDbePQm8j4yXxYxa97bsA== Received: from MW4PR03CA0300.namprd03.prod.outlook.com (2603:10b6:303:b5::35) by MW4PR12MB6828.namprd12.prod.outlook.com (2603:10b6:303:209::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6455.32; Tue, 6 Jun 2023 12:33:28 +0000 Received: from CO1NAM11FT007.eop-nam11.prod.protection.outlook.com (2603:10b6:303:b5:cafe::5e) by MW4PR03CA0300.outlook.office365.com (2603:10b6:303:b5::35) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6455.33 via Frontend Transport; Tue, 6 Jun 2023 12:33:28 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.118.233) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.118.233 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.118.233; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.118.233) by CO1NAM11FT007.mail.protection.outlook.com (10.13.174.131) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6455.33 via Frontend Transport; Tue, 6 Jun 2023 12:33:28 +0000 Received: from drhqmail202.nvidia.com (10.126.190.181) by mail.nvidia.com (10.127.129.6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.5; Tue, 6 Jun 2023 05:33:18 -0700 Received: from drhqmail202.nvidia.com (10.126.190.181) by drhqmail202.nvidia.com (10.126.190.181) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.37; Tue, 6 Jun 2023 05:33:17 -0700 Received: from NV-CL38DL3.nvidia.com (10.127.8.12) by mail.nvidia.com (10.126.190.181) with Microsoft SMTP Server id 15.2.986.37 via Frontend Transport; Tue, 6 Jun 2023 05:33:17 -0700 From: "Nickle Wang" To: CC: Abner Chang , Igor Kulchytskyy Subject: [edk2-redfish-client][PATCH v2 7/9] RedfishClientPkg/BiosDxe: Fix build error Date: Tue, 6 Jun 2023 20:33:16 +0800 Message-ID: <20230606123316.17775-1-nicklew@nvidia.com> X-Mailer: git-send-email 2.17.1 MIME-Version: 1.0 Return-Path: nicklew@nvidia.com X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CO1NAM11FT007:EE_|MW4PR12MB6828:EE_ X-MS-Office365-Filtering-Correlation-Id: 74ea3caf-ef58-4749-cb56-08db668a3b0b X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 7bdRJNECf8dH8Q3UypKCW0l0JQ9+KooVlX+9gnAzHrM7RYIb/dGiOwK+5IRucNp+v/kf95SVxHzC09gQHnfDH5hhCXPLwlpcrA6OAGt57HuQr3LO9boXAyBQVyyIKnU7NNFQ75VQe2MTVp5yn9pEP7RtybPLaw+ios8/+XSqjf6q9B+Bhg4aE9XxoEoB/ePGsqEY6JMbC92rj1cG2l2zGaQdW60uc5TzlUvyl6jrtT4WYBsv5x6ErX4N6KWOyamVNCfUhooRn9D4cp0S7k40u/gcZPmVw03PafKjNvUIEQlrhguCOax7y9wvrftqgsY6N8ndjYlWfYSY3AG2El3iZjsisYwiC67QPSGhtzxGTBynnUo9gelCYrsjotqiGTmYouDf/vrJBxcq3MWEisAtcLuVx7fdEg7QBlevqE7fV3Xn3opW8Ft+S1qALyP7HFh1NGA9wmTcomf70tTSpN119FiBMi0a8ylxKdM3KmgBi12eR7zMITVPg1TGvnZT8yaS7Bo3nGXRyhjm4OLarldNg2VvQDOaJrhDa70PfxG4KspGEDoViuqcMdAR5Ctl+4zOy10D2iiXEzIKlEB4OXCMrayPAZCuvgQb7bfcdC5mpdeE8Q7EDlAiokMcCGbgy4rAuEJPoytgaFbge7u70vsbsYfFZ/7NG5+038K2h8xmyoUgCj/ApVoz6zlVNZSOC768oJcWcJHgDXmj1NEo6NJ6OAcuIEMoOQ9XVviz0/TwZ+330drzxe4TDeiFdeISJLTJ X-Forefront-Antispam-Report: CIP:216.228.118.233;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:mail.nvidia.com;PTR:dc7edge2.nvidia.com;CAT:NONE;SFS:(13230028)(4636009)(376002)(39860400002)(136003)(396003)(346002)(451199021)(40470700004)(46966006)(36840700001)(70206006)(70586007)(2906002)(478600001)(4326008)(316002)(8936002)(6916009)(8676002)(41300700001)(19627235002)(54906003)(5660300002)(7696005)(1076003)(26005)(40460700003)(82310400005)(356005)(82740400003)(186003)(2616005)(7636003)(40480700001)(336012)(426003)(47076005)(83380400001)(36860700001)(36756003)(86362001);DIR:OUT;SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Jun 2023 12:33:28.4268 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 74ea3caf-ef58-4749-cb56-08db668a3b0b X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a;Ip=[216.228.118.233];Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: CO1NAM11FT007.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR12MB6828 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain - Fix "variable set but not used" error. - Fix missing "EFIAPI" error. - Fix typos. Signed-off-by: Nickle Wang Cc: Abner Chang Cc: Igor Kulchytskyy --- .../Features/Bios/v1_0_9/Dxe/BiosDxe.c | 20 ++++++++++--------- 1 file changed, 11 insertions(+), 9 deletions(-) diff --git a/RedfishClientPkg/Features/Bios/v1_0_9/Dxe/BiosDxe.c b/RedfishC= lientPkg/Features/Bios/v1_0_9/Dxe/BiosDxe.c index c65e2f51..e7ac8779 100644 --- a/RedfishClientPkg/Features/Bios/v1_0_9/Dxe/BiosDxe.c +++ b/RedfishClientPkg/Features/Bios/v1_0_9/Dxe/BiosDxe.c @@ -2,7 +2,7 @@ Redfish feature driver implementation - Bios =20 (C) Copyright 2020-2022 Hewlett Packard Enterprise Development LP
- Copyright (c) 2022, NVIDIA CORPORATION. All rights reserved. + Copyright (c) 2022-2023, NVIDIA CORPORATION. All rights reserved. =20 SPDX-License-Identifier: BSD-2-Clause-Patent =20 @@ -18,10 +18,10 @@ HandleResource ( IN EFI_STRING Uri ); =20 -EFI_HANDLE medfishResourceConfigProtocolHandle; +EFI_HANDLE mRedfishResourceConfigProtocolHandle; =20 /** - Provising redfish resource by given URI. + Provisioning redfish resource by given URI. =20 @param[in] This Pointer to EFI_HP_REDFISH_HII_PROTOCOL = instance. @param[in] Uri Target URI to create resource. @@ -33,6 +33,7 @@ EFI_HANDLE medfishResourceConfigProtocolHandle; =20 **/ EFI_STATUS +EFIAPI RedfishResourceProvisioningResource ( IN EDKII_REDFISH_RESOURCE_CONFIG_PROTOCOL *This, IN EFI_STRING Uri, @@ -94,6 +95,7 @@ RedfishResourceProvisioningResource ( =20 **/ EFI_STATUS +EFIAPI RedfishResourceConsumeResource ( IN EDKII_REDFISH_RESOURCE_CONFIG_PROTOCOL *This, IN EFI_STRING Uri @@ -233,19 +235,16 @@ RedfishResourceConsumeResource ( =20 **/ EFI_STATUS +EFIAPI RedfishResourceGetInfo ( IN EDKII_REDFISH_RESOURCE_CONFIG_PROTOCOL *This, OUT REDFISH_SCHEMA_INFO *Info ) { - REDFISH_RESOURCE_COMMON_PRIVATE *Private; - if ((This =3D=3D NULL) || (Info =3D=3D NULL)) { return EFI_INVALID_PARAMETER; } =20 - Private =3D REDFISH_RESOURCE_COMMON_PRIVATE_DATA_FROM_RESOURCE_PROTOCOL = (This); - AsciiStrCpyS (Info->Schema, REDFISH_SCHEMA_STRING_SIZE, RESOURCE_SCHEMA)= ; AsciiStrCpyS (Info->Major, REDFISH_SCHEMA_VERSION_SIZE, RESOURCE_SCHEMA_= MAJOR); AsciiStrCpyS (Info->Minor, REDFISH_SCHEMA_VERSION_SIZE, RESOURCE_SCHEMA_= MINOR); @@ -265,6 +264,7 @@ RedfishResourceGetInfo ( =20 **/ EFI_STATUS +EFIAPI RedfishResourceUpdate ( IN EDKII_REDFISH_RESOURCE_CONFIG_PROTOCOL *This, IN EFI_STRING Uri @@ -334,6 +334,7 @@ RedfishResourceUpdate ( =20 **/ EFI_STATUS +EFIAPI RedfishResourceCheck ( IN EDKII_REDFISH_RESOURCE_CONFIG_PROTOCOL *This, IN EFI_STRING Uri @@ -404,6 +405,7 @@ RedfishResourceCheck ( =20 **/ EFI_STATUS +EFIAPI RedfishResourceIdentify ( IN EDKII_REDFISH_RESOURCE_CONFIG_PROTOCOL *This, IN EFI_STRING Uri @@ -478,7 +480,7 @@ EDKII_REDFISH_RESOURCE_CONFIG_PROTOCOL mRedfishResourc= eConfig =3D { handler. =20 @param[in] This Pointer to EDKII_REDFISH_CONFIG_HA= NDLER_PROTOCOL instance. - @param[in] RedfishConfigServiceInfo Redfish service informaion. + @param[in] RedfishConfigServiceInfo Redfish service information. =20 @retval EFI_SUCCESS The handler has been initialized su= ccessfully. @retval EFI_DEVICE_ERROR Failed to create or configure the R= EST EX protocol instance. @@ -799,7 +801,7 @@ RedfishResourceEntryPoint ( return EFI_ALREADY_STARTED; } =20 - medfishResourceConfigProtocolHandle =3D ImageHandle; + mRedfishResourceConfigProtocolHandle =3D ImageHandle; =20 mRedfishResourcePrivate =3D AllocateZeroPool (sizeof (REDFISH_RESOURCE_C= OMMON_PRIVATE)); CopyMem (&mRedfishResourcePrivate->ConfigHandler, &mRedfishConfigHandler= , sizeof (EDKII_REDFISH_CONFIG_HANDLER_PROTOCOL)); --=20 2.17.1