From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (NAM11-CO1-obe.outbound.protection.outlook.com [40.107.220.46]) by mx.groups.io with SMTP id smtpd.web10.7515.1686054822053736763 for ; Tue, 06 Jun 2023 05:33:42 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="body hash did not verify" header.i=@nvidia.com header.s=selector2 header.b=M6aZaMJy; spf=permerror, err=parse error for token &{10 18 %{i}._ip.%{h}._ehlo.%{d}._spf.vali.email}: invalid domain name (domain: nvidia.com, ip: 40.107.220.46, mailfrom: nicklew@nvidia.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Pevxy7qvNEU2xUfQs2zDvDpH0Yo3LwiZoO0nk8hF52TX2AWvwswjMXGo47OWNHq5wfkLVT7t1u4avUxsUjsl9LZWav3v06BhI32Q7zKTDBFt9irgwwWCAguwSc/5RJ0eqLLOUV3bnUStye0Yrm9i8EEwX6hgpa4C7osZkiOitz6Nk6X5WhZvGWimQhJIuio3Ah8mQ2g0jNhh0rchYFTS1gZEk70GrG1MFBBrymTsRID3+s95R4p5DJKDefyIF9hpvCab1fWhMK4ujYV/p1RI55dD0WKDVg5KiPW5hp1cKFHy/n/SISljEI0crUwqD9AuhmvXDqFRj2H1TYa1aq7Tcg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=pNgAfswSn9CFyJk2Fr5Cz0V7bVq6xx3cdYCNcMCIIIQ=; b=KHfeBFLijc/kSbm6kKnkacM4BfsK0B398PqH80AkAMMgAgq0w37JHfCVe+zm2XJYgNpnTGgtq/Hg4xzjeVvYUVXDBoUCs+mHvt0qX3ku5qkUnV4zzBD/kJ59yhOYIb9diNlxlBwAyhUwZzXVmTJ6F0JCReGG5bpp6OdiBAbpWeXa6+0GY/eM3uJb6dExSN4DJr49COuSJ1jiG4P5gFYOap2Xob7JU0KN4f6H/ugjjxgjiWvm9bgdpk7r2yXpUumsF+lzJbAHSmQbrYtD1dwAWRSZYwrhKaSxWj63RD9NrDE92/6YJQVWCP0rX5NxfsPkNSFLVlP49a8Bh9RZFduFLg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.160) smtp.rcpttodomain=edk2.groups.io smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=pNgAfswSn9CFyJk2Fr5Cz0V7bVq6xx3cdYCNcMCIIIQ=; b=M6aZaMJysRnmoMLVkDWadb/nEyyUbx4HhscGkAqFWOE/oTheHAslCOjGXNwrhwvrMhiUJPDPIeubYrX9NxMapiPXITRVynt2oI8soeK4GM9k0lBBkstXS+rmqYEr+iy6T2C2crDkk8H8Ns6sFf+5PWW9ItWKXFRObkhY1dwqt5fJAKtoWG0QmdfgYHI11KbvfTV1JpMJyHfeZPuRm8cnj71P/Q213Rp1e4TP5UKGEyEOwJyvOLMUVPfFJvyu4+tTb3zGpg7XNTVATZKc9Bq9iIMmXaphdaQbYdI2gLCKjmyjZTEedMDFQVOscLkuDp8lofs1KV8/MyUSht03aKZEXQ== Received: from SN7PR04CA0010.namprd04.prod.outlook.com (2603:10b6:806:f2::15) by CH3PR12MB7763.namprd12.prod.outlook.com (2603:10b6:610:145::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6455.33; Tue, 6 Jun 2023 12:33:38 +0000 Received: from SN1PEPF000252A4.namprd05.prod.outlook.com (2603:10b6:806:f2:cafe::c6) by SN7PR04CA0010.outlook.office365.com (2603:10b6:806:f2::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6455.33 via Frontend Transport; Tue, 6 Jun 2023 12:33:37 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.160) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.160 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.160; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.160) by SN1PEPF000252A4.mail.protection.outlook.com (10.167.242.11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6477.13 via Frontend Transport; Tue, 6 Jun 2023 12:33:37 +0000 Received: from rnnvmail203.nvidia.com (10.129.68.9) by mail.nvidia.com (10.129.200.66) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.5; Tue, 6 Jun 2023 05:33:25 -0700 Received: from rnnvmail203.nvidia.com (10.129.68.9) by rnnvmail203.nvidia.com (10.129.68.9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.37; Tue, 6 Jun 2023 05:33:25 -0700 Received: from NV-CL38DL3.nvidia.com (10.127.8.12) by mail.nvidia.com (10.129.68.9) with Microsoft SMTP Server id 15.2.986.37 via Frontend Transport; Tue, 6 Jun 2023 05:33:24 -0700 From: "Nickle Wang" To: CC: Abner Chang , Igor Kulchytskyy Subject: [edk2-redfish-client][PATCH v2 8/9] RedfishClientPkg/MemoryDxe: Fix build error Date: Tue, 6 Jun 2023 20:33:23 +0800 Message-ID: <20230606123323.17864-1-nicklew@nvidia.com> X-Mailer: git-send-email 2.17.1 MIME-Version: 1.0 Return-Path: nicklew@nvidia.com X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SN1PEPF000252A4:EE_|CH3PR12MB7763:EE_ X-MS-Office365-Filtering-Correlation-Id: cc584c7e-f1b5-4835-d9e7-08db668a409e X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: yLRfk/PAElA+lo1Eai9Y6BTPo25NBAZiuZMEcia61iGh7g6YYmulTz8UVmso4KymvirdNGCuhkiYwojmMDSL3Xk/CcvSI5xEsenugsI4E1hQjqfbA/9J8tqgiZ4Lqz4pAD0Usuw6J/P+3YVciNboaj3ccXv7UPV13wpjFwwGEz6+mFHERP8ZCml+XM59JTj0jVk1m3wsA3ClKDmGPk3HI/X5pHnGqNfjL5pDOUF1OLhr+8ZebfgWH0TkyM30cWKRXONWNkd0h9A/6DZLLjfemINrHzLVPTPlzU0jYe0IH5OR5rNdfq0VXZ+IryQe/GqPXQ1FOSUL8436zPgNxJHpMEv4T3hdXxy0gWjOJR27xNTzyoS2TEqo4/VYb0tDW0yKsViPJPkPsfp/BCqF3RW1OQoeRL71HpklPhG4JLo8u8UlHbhR6huTWpmWpqAzQCGKYvlp3XBWnX5oswgokCQlzSX9Q3wyoZzrNtbOdTU/uJkR6njt9NPsFDRi7BDl6grB7+FHcB0YDw+RmaftfuTGpIBX1YusCU2aJtt/5pw7nmAiMe2V1xc3Bc1ynTq8cpgIaUjIKr63pVwn/TQhuzG4EiU6MpwXvxjp4UFh1FMEtq7mBqn6jYnv2R4ud6xe512y8jHOZ+HQffByD2XAIYvvtMbMGNZu9fudIz5k1sYrMVJHZ8o9t5cNzwYaR73CjzbP6NDABAOCJn9BpJXqekW9qwqkqKNU5AWme6f1FlrppD/1Nr8xMOEcXN8aunfAD+2N X-Forefront-Antispam-Report: CIP:216.228.117.160;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:mail.nvidia.com;PTR:dc6edge1.nvidia.com;CAT:NONE;SFS:(13230028)(4636009)(396003)(136003)(39860400002)(376002)(346002)(451199021)(46966006)(40470700004)(36840700001)(19627235002)(54906003)(40460700003)(40480700001)(478600001)(6916009)(8936002)(8676002)(2906002)(36756003)(86362001)(5660300002)(82310400005)(4326008)(316002)(70206006)(70586007)(7636003)(356005)(82740400003)(1076003)(2616005)(41300700001)(26005)(47076005)(36860700001)(83380400001)(186003)(7696005)(336012)(426003);DIR:OUT;SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Jun 2023 12:33:37.7323 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: cc584c7e-f1b5-4835-d9e7-08db668a409e X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a;Ip=[216.228.117.160];Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: SN1PEPF000252A4.namprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH3PR12MB7763 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain - Fix "variable set but not used" error. - Fix missing "EFIAPI" error. - Fix typos. Signed-off-by: Nickle Wang Cc: Abner Chang Cc: Igor Kulchytskyy --- .../Features/Memory/V1_7_1/Dxe/MemoryDxe.c | 19 +++++++++++-------- 1 file changed, 11 insertions(+), 8 deletions(-) diff --git a/RedfishClientPkg/Features/Memory/V1_7_1/Dxe/MemoryDxe.c b/Redf= ishClientPkg/Features/Memory/V1_7_1/Dxe/MemoryDxe.c index 78784118..c55a6848 100644 --- a/RedfishClientPkg/Features/Memory/V1_7_1/Dxe/MemoryDxe.c +++ b/RedfishClientPkg/Features/Memory/V1_7_1/Dxe/MemoryDxe.c @@ -2,6 +2,7 @@ Redfish feature driver implementation - Memory =20 (C) Copyright 2020-2022 Hewlett Packard Enterprise Development LP
+ Copyright (c) 2023, NVIDIA CORPORATION & AFFILIATES. All rights reserved= . =20 SPDX-License-Identifier: BSD-2-Clause-Patent =20 @@ -11,10 +12,10 @@ =20 extern REDFISH_RESOURCE_COMMON_PRIVATE *mRedfishResourcePrivate; =20 -EFI_HANDLE medfishResourceConfigProtocolHandle; +EFI_HANDLE mRedfishResourceConfigProtocolHandle; =20 /** - Provising redfish resource by given URI. + Provisioning redfish resource by given URI. =20 @param[in] This Pointer to EFI_HP_REDFISH_HII_PROTOCOL = instance. @param[in] Uri Target URI to create resource. @@ -26,6 +27,7 @@ EFI_HANDLE medfishResourceConfigProtocolHandle; =20 **/ EFI_STATUS +EFIAPI RedfishResourceProvisioningResource ( IN EDKII_REDFISH_RESOURCE_CONFIG_PROTOCOL *This, IN EFI_STRING Uri, @@ -87,6 +89,7 @@ RedfishResourceProvisioningResource ( =20 **/ EFI_STATUS +EFIAPI RedfishResourceConsumeResource ( IN EDKII_REDFISH_RESOURCE_CONFIG_PROTOCOL *This, IN EFI_STRING Uri @@ -178,19 +181,16 @@ RedfishResourceConsumeResource ( =20 **/ EFI_STATUS +EFIAPI RedfishResourceGetInfo ( IN EDKII_REDFISH_RESOURCE_CONFIG_PROTOCOL *This, OUT REDFISH_SCHEMA_INFO *Info ) { - REDFISH_RESOURCE_COMMON_PRIVATE *Private; - if ((This =3D=3D NULL) || (Info =3D=3D NULL)) { return EFI_INVALID_PARAMETER; } =20 - Private =3D REDFISH_RESOURCE_COMMON_PRIVATE_DATA_FROM_RESOURCE_PROTOCOL = (This); - AsciiStrCpyS (Info->Schema, REDFISH_SCHEMA_STRING_SIZE, RESOURCE_SCHEMA)= ; AsciiStrCpyS (Info->Major, REDFISH_SCHEMA_VERSION_SIZE, RESOURCE_SCHEMA_= MAJOR); AsciiStrCpyS (Info->Minor, REDFISH_SCHEMA_VERSION_SIZE, RESOURCE_SCHEMA_= MINOR); @@ -210,6 +210,7 @@ RedfishResourceGetInfo ( =20 **/ EFI_STATUS +EFIAPI RedfishResourceUpdate ( IN EDKII_REDFISH_RESOURCE_CONFIG_PROTOCOL *This, IN EFI_STRING Uri @@ -279,6 +280,7 @@ RedfishResourceUpdate ( =20 **/ EFI_STATUS +EFIAPI RedfishResourceCheck ( IN EDKII_REDFISH_RESOURCE_CONFIG_PROTOCOL *This, IN EFI_STRING Uri @@ -349,6 +351,7 @@ RedfishResourceCheck ( =20 **/ EFI_STATUS +EFIAPI RedfishResourceIdentify ( IN EDKII_REDFISH_RESOURCE_CONFIG_PROTOCOL *This, IN EFI_STRING Uri @@ -423,7 +426,7 @@ EDKII_REDFISH_RESOURCE_CONFIG_PROTOCOL mRedfishResourc= eConfig =3D { handler. =20 @param[in] This Pointer to EDKII_REDFISH_CONFIG_HA= NDLER_PROTOCOL instance. - @param[in] RedfishConfigServiceInfo Redfish service informaion. + @param[in] RedfishConfigServiceInfo Redfish service information. =20 @retval EFI_SUCCESS The handler has been initialized su= ccessfully. @retval EFI_DEVICE_ERROR Failed to create or configure the R= EST EX protocol instance. @@ -613,7 +616,7 @@ RedfishResourceEntryPoint ( return EFI_ALREADY_STARTED; } =20 - medfishResourceConfigProtocolHandle =3D ImageHandle; + mRedfishResourceConfigProtocolHandle =3D ImageHandle; =20 mRedfishResourcePrivate =3D AllocateZeroPool (sizeof (REDFISH_RESOURCE_C= OMMON_PRIVATE)); CopyMem (&mRedfishResourcePrivate->ConfigHandler, &mRedfishConfigHandler= , sizeof (EDKII_REDFISH_CONFIG_HANDLER_PROTOCOL)); --=20 2.17.1