From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (NAM12-BN8-obe.outbound.protection.outlook.com [40.107.237.68]) by mx.groups.io with SMTP id smtpd.web11.7660.1686054855804906660 for ; Tue, 06 Jun 2023 05:34:15 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="body hash did not verify" header.i=@nvidia.com header.s=selector2 header.b=jtYwuJFh; spf=permerror, err=parse error for token &{10 18 %{i}._ip.%{h}._ehlo.%{d}._spf.vali.email}: invalid domain name (domain: nvidia.com, ip: 40.107.237.68, mailfrom: nicklew@nvidia.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=UxQ7kQCuX8+4DjM8VE1lMIclWPB1XjMMl5JMRxwnY32ElBGQ/q2GvJYKF8gzlayE7Tnl16Bqgci3fAJ5IubHYWJBnEe5zZJOFeipLCFxVfz1wQDwuhO1uPOl4rrUvexKTo0YIdSR4wYlGIbpYoQnvklVwJaTiJM9C0qP/mgpOuR+T68N6Wudi+8B9isyliZKeoybQQc16ArJys6KBIGxySs0wZkfeTb5BV9dHo3d4CXnbzae/zkHjTlOaE3STT6Yket/rTw0n4VKJTTx9DsK9CZk1WRSa2iO7p3ttGasAwCvZ3SfFPowx88wJnph+UTNDHDZ8Nfe+TCwEL5y3Y0ykg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=8ZMdHe0O7nowfhEJHGJyWzyB/DslHITiGROS7ZfbZhk=; b=InhGLtEX5uJIzMMiBxqcZsn2s1egBvkFlota7NiGurlFWloSirETtaQBIpuxumJmZg79Huc0+48tV7JouB+GDJ+Z2106uPXBc4/HvdSePebgNjUpkNnbhF77dwZGs9bJBg4bupipbk1Ov7zv0bpSzF8OCot2SSCsb+RGf5rgIe3/+ct4XEncQTFURSRHTcSQlreC+D9c7hTQ+OpMgybDejvRgolMBYDyc/XIU1PlScImCNA+haSoufZ1NAtk83VhSiMBHtUEizo/M+4tfCJwL/colKaT5uRuGYkN6k++e4io3Q/q9XlC0f/dhCAjZ0JhYKlDADzPwpw2yy7DDePF/g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.118.233) smtp.rcpttodomain=edk2.groups.io smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=8ZMdHe0O7nowfhEJHGJyWzyB/DslHITiGROS7ZfbZhk=; b=jtYwuJFhmrjl/yPI+WUElxIQaNpbkYot3iL6N9w/Bp/PI1mPNPXo9ks5cV2QJ689RDojhJk2778tLXFTHIfsr/p1sEV1/sbURofqEMTcnHcSJWkHqr5IMHdtUDpJVA6HWAB5DPBmJAyo/XnpRytxUjJbExFFCJ+0WfN9EySMZV3WDj/Vn3UOkMIquEaSyOpd+dkI1I5928RDnw5pqytzz2ls6bleJfaktjR10Je/6HBABVk+1gNSOlIIew0h28B+pczlNbcbhm+Mp1PV6zy3TfOZ7ihB5EfM+/5h8RrgkL4nepnzrTlYVloX6fTwey0NRbJgjJeW2wDrf6K31h6H9Q== Received: from BYAPR01CA0021.prod.exchangelabs.com (2603:10b6:a02:80::34) by IA1PR12MB6388.namprd12.prod.outlook.com (2603:10b6:208:388::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6455.27; Tue, 6 Jun 2023 12:34:12 +0000 Received: from CO1NAM11FT081.eop-nam11.prod.protection.outlook.com (2603:10b6:a02:80:cafe::5b) by BYAPR01CA0021.outlook.office365.com (2603:10b6:a02:80::34) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6455.33 via Frontend Transport; Tue, 6 Jun 2023 12:34:12 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.118.233) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.118.233 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.118.233; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.118.233) by CO1NAM11FT081.mail.protection.outlook.com (10.13.174.80) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6455.23 via Frontend Transport; Tue, 6 Jun 2023 12:34:12 +0000 Received: from drhqmail202.nvidia.com (10.126.190.181) by mail.nvidia.com (10.127.129.6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.5; Tue, 6 Jun 2023 05:34:05 -0700 Received: from drhqmail201.nvidia.com (10.126.190.180) by drhqmail202.nvidia.com (10.126.190.181) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.37; Tue, 6 Jun 2023 05:34:04 -0700 Received: from NV-CL38DL3.nvidia.com (10.127.8.12) by mail.nvidia.com (10.126.190.180) with Microsoft SMTP Server id 15.2.986.37 via Frontend Transport; Tue, 6 Jun 2023 05:34:04 -0700 From: "Nickle Wang" To: CC: Abner Chang , Igor Kulchytskyy Subject: [edk2-redfish-client][PATCH v2 9/9] RedfishClientPkg/ComputerSystemDxe: Fix build error Date: Tue, 6 Jun 2023 20:34:03 +0800 Message-ID: <20230606123403.17953-1-nicklew@nvidia.com> X-Mailer: git-send-email 2.17.1 MIME-Version: 1.0 Return-Path: nicklew@nvidia.com X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CO1NAM11FT081:EE_|IA1PR12MB6388:EE_ X-MS-Office365-Filtering-Correlation-Id: 6c7b23ba-52f5-4157-ce0c-08db668a5511 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Em+S105IwdxlUoEfjEmIVgIFbfk0dz9EhEYDBfN4pIl6oOtNXHvt05NbK95qEQBMqH8v3kEaZ5Gt2lj+GSx9Fyz4BYXw9lrB+5MRwmZqrRajB4qHyRbHRb2hJlREY9u2iCWkeqFrmG3io/pyc0K703GKWVWzIZwuPl0HUSxdEwk2TnV1mcthjJWQHsz5sqGSZVOjmzdlpafQOTHLb8urYDOYVrNvGXEp2q4OcShfkoJQClFDzSsaIlsuCrMWCtpeoFd53WugWdZX4DHBwOVXhGXXP9CF/bzuEn5vxS3NWef1V80MFSt/yXLB4PxVaEUGg0TlBVBr1CoRvCj2sfj8zcZr8H5Ert+MKr2R19fVEyK7/nIEp1HSiZrhVoiqJ4vz7ozE5kikH7a0+nMpqGiYpmbDXGHpsdkOCfz9WBZvGD4P9vMbB8vNnxtrA4PlHI2L3eiKNtorYfDBk6zG+kdNrE/gtk82VU5598MixjOrLqPbKfbL0GSuy8RJLBpjqAced0hJoC9ZhndhhydyUMW2ok4iMsdinUWbd7z7RPIamZBilbzx5Y6MGRKrIXzODj0et4ubTxKghGO0TAm5miy8tK9jFLJ+aCzxx/ooV5pC4t3ujmRJIlJoNhxpYK7ig2EFykFlp4ewEGBGYpp1VUqNk3yDhLUeYzeTPKewQ3nqwUcYw4KpC698bd64qcmuSBS9ahqh2BxbPAcDwoz8TKuAln6UG3Uhv7Yow7TWv2Ig2iaY4E6IKRqNJ32xypuVYjTz X-Forefront-Antispam-Report: CIP:216.228.118.233;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:mail.nvidia.com;PTR:dc7edge2.nvidia.com;CAT:NONE;SFS:(13230028)(4636009)(346002)(136003)(39860400002)(396003)(376002)(451199021)(46966006)(36840700001)(40470700004)(40480700001)(186003)(54906003)(70586007)(478600001)(82740400003)(19627235002)(356005)(6916009)(8676002)(8936002)(70206006)(4326008)(41300700001)(316002)(2616005)(7696005)(426003)(336012)(36860700001)(83380400001)(47076005)(40460700003)(1076003)(26005)(7636003)(86362001)(5660300002)(2906002)(82310400005)(36756003);DIR:OUT;SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Jun 2023 12:34:12.0869 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 6c7b23ba-52f5-4157-ce0c-08db668a5511 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a;Ip=[216.228.118.233];Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: CO1NAM11FT081.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR12MB6388 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain - Fix "variable set but not used" error. - Fix missing "EFIAPI" error. - Fix typos. Signed-off-by: Nickle Wang Cc: Abner Chang Cc: Igor Kulchytskyy --- .../v1_5_0/Dxe/ComputerSystemDxe.c | 19 +++++++++++-------- 1 file changed, 11 insertions(+), 8 deletions(-) diff --git a/RedfishClientPkg/Features/ComputerSystem/v1_5_0/Dxe/ComputerSy= stemDxe.c b/RedfishClientPkg/Features/ComputerSystem/v1_5_0/Dxe/ComputerSys= temDxe.c index 49d065c9..91968dbe 100644 --- a/RedfishClientPkg/Features/ComputerSystem/v1_5_0/Dxe/ComputerSystemDxe= .c +++ b/RedfishClientPkg/Features/ComputerSystem/v1_5_0/Dxe/ComputerSystemDxe= .c @@ -2,6 +2,7 @@ Redfish feature driver implementation - ComputerSystem =20 (C) Copyright 2020-2022 Hewlett Packard Enterprise Development LP
+ Copyright (c) 2023, NVIDIA CORPORATION & AFFILIATES. All rights reserved= . =20 SPDX-License-Identifier: BSD-2-Clause-Patent =20 @@ -11,10 +12,10 @@ =20 extern REDFISH_RESOURCE_COMMON_PRIVATE *mRedfishResourcePrivate; =20 -EFI_HANDLE medfishResourceConfigProtocolHandle; +EFI_HANDLE mRedfishResourceConfigProtocolHandle; =20 /** - Provising redfish resource by given URI. + Provisioning redfish resource by given URI. =20 @param[in] This Pointer to EFI_HP_REDFISH_HII_PROTOCOL = instance. @param[in] Uri Target URI to create resource. @@ -26,6 +27,7 @@ EFI_HANDLE medfishResourceConfigProtocolHandle; =20 **/ EFI_STATUS +EFIAPI RedfishResourceProvisioningResource ( IN EDKII_REDFISH_RESOURCE_CONFIG_PROTOCOL *This, IN EFI_STRING Uri, @@ -87,6 +89,7 @@ RedfishResourceProvisioningResource ( =20 **/ EFI_STATUS +EFIAPI RedfishResourceConsumeResource ( IN EDKII_REDFISH_RESOURCE_CONFIG_PROTOCOL *This, IN EFI_STRING Uri @@ -178,19 +181,16 @@ RedfishResourceConsumeResource ( =20 **/ EFI_STATUS +EFIAPI RedfishResourceGetInfo ( IN EDKII_REDFISH_RESOURCE_CONFIG_PROTOCOL *This, OUT REDFISH_SCHEMA_INFO *Info ) { - REDFISH_RESOURCE_COMMON_PRIVATE *Private; - if ((This =3D=3D NULL) || (Info =3D=3D NULL)) { return EFI_INVALID_PARAMETER; } =20 - Private =3D REDFISH_RESOURCE_COMMON_PRIVATE_DATA_FROM_RESOURCE_PROTOCOL = (This); - AsciiStrCpyS (Info->Schema, REDFISH_SCHEMA_STRING_SIZE, RESOURCE_SCHEMA)= ; AsciiStrCpyS (Info->Major, REDFISH_SCHEMA_VERSION_SIZE, RESOURCE_SCHEMA_= MAJOR); AsciiStrCpyS (Info->Minor, REDFISH_SCHEMA_VERSION_SIZE, RESOURCE_SCHEMA_= MINOR); @@ -210,6 +210,7 @@ RedfishResourceGetInfo ( =20 **/ EFI_STATUS +EFIAPI RedfishResourceUpdate ( IN EDKII_REDFISH_RESOURCE_CONFIG_PROTOCOL *This, IN EFI_STRING Uri @@ -279,6 +280,7 @@ RedfishResourceUpdate ( =20 **/ EFI_STATUS +EFIAPI RedfishResourceCheck ( IN EDKII_REDFISH_RESOURCE_CONFIG_PROTOCOL *This, IN EFI_STRING Uri @@ -349,6 +351,7 @@ RedfishResourceCheck ( =20 **/ EFI_STATUS +EFIAPI RedfishResourceIdentify ( IN EDKII_REDFISH_RESOURCE_CONFIG_PROTOCOL *This, IN EFI_STRING Uri @@ -423,7 +426,7 @@ EDKII_REDFISH_RESOURCE_CONFIG_PROTOCOL mRedfishResourc= eConfig =3D { handler. =20 @param[in] This Pointer to EDKII_REDFISH_CONFIG_HA= NDLER_PROTOCOL instance. - @param[in] RedfishConfigServiceInfo Redfish service informaion. + @param[in] RedfishConfigServiceInfo Redfish service information. =20 @retval EFI_SUCCESS The handler has been initialized su= ccessfully. @retval EFI_DEVICE_ERROR Failed to create or configure the R= EST EX protocol instance. @@ -613,7 +616,7 @@ RedfishResourceEntryPoint ( return EFI_ALREADY_STARTED; } =20 - medfishResourceConfigProtocolHandle =3D ImageHandle; + mRedfishResourceConfigProtocolHandle =3D ImageHandle; =20 mRedfishResourcePrivate =3D AllocateZeroPool (sizeof (REDFISH_RESOURCE_C= OMMON_PRIVATE)); CopyMem (&mRedfishResourcePrivate->ConfigHandler, &mRedfishConfigHandler= , sizeof (EDKII_REDFISH_CONFIG_HANDLER_PROTOCOL)); --=20 2.17.1