[PATCH v1 0/3] OvmfPkg/Bhyve: enable bus enumeration

[PATCH v1 0/3] OvmfPkg/Bhyve: enable bus enumeration

[Corvin Köhne]

CI: https://github.com/tianocore/edk2/pull/4543

Corvin Köhne (3):
  Revert "OvmfPkg/Bhyve: consume PciHostBridgeLibScan"
  Revert "OvmfPkg/Bhyve: remove IncompatiblePciDeviceSupport DXE driver"
  OvmfPkg/BhyvePkg: enable bus enumeration

 OvmfPkg/Bhyve/BhyveX64.dsc | 4 ++--
 OvmfPkg/Bhyve/BhyveX64.fdf | 1 +
 2 files changed, 3 insertions(+), 2 deletions(-)

-- 
2.41.0

[PATCH v1 1/3] Revert "OvmfPkg/Bhyve: consume PciHostBridgeLibScan"

[Corvin Köhne]

We like to enable bus enumartion for bhyve. Therefore, this patch needs
to be reverted.

This reverts commit c2f24ba3218ae91a8d5a1a31c31dad3417850d0c.

Signed-off-by: Corvin Köhne <corvink@FreeBSD.org>
Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
Cc: Jiewen Yao <jiewen.yao@intel.com>
Cc: Jordan Justen <jordan.l.justen@intel.com>
Cc: Gerd Hoffmann <kraxel@redhat.com>
Cc: Rebecca Cran <rebecca@bsdio.com>
Cc: Peter Grehan <grehan@freebsd.org>
---
 OvmfPkg/Bhyve/BhyveX64.dsc | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/OvmfPkg/Bhyve/BhyveX64.dsc b/OvmfPkg/Bhyve/BhyveX64.dsc
index 7b974706f958..0f1fe2e2f18a 100644
--- a/OvmfPkg/Bhyve/BhyveX64.dsc
+++ b/OvmfPkg/Bhyve/BhyveX64.dsc
@@ -641,7 +641,7 @@ [Components]
   OvmfPkg/PciHotPlugInitDxe/PciHotPlugInit.inf
   MdeModulePkg/Bus/Pci/PciHostBridgeDxe/PciHostBridgeDxe.inf {
     <LibraryClasses>
-      PciHostBridgeLib|OvmfPkg/Library/PciHostBridgeLibScan/PciHostBridgeLibScan.inf
+      PciHostBridgeLib|OvmfPkg/Library/PciHostBridgeLib/PciHostBridgeLib.inf
       PciHostBridgeUtilityLib|OvmfPkg/Library/PciHostBridgeUtilityLib/PciHostBridgeUtilityLib.inf
       NULL|OvmfPkg/Library/PlatformHasIoMmuLib/PlatformHasIoMmuLib.inf
   }
-- 
2.41.0

[PATCH v1 2/3] Revert "OvmfPkg/Bhyve: remove IncompatiblePciDeviceSupport DXE driver"

[Corvin Köhne]

We like to enable bus enumeration for bhyve. Therefore, this patch needs
to be reverted.

This reverts commit 8c8f886f27556f2fb6e8b502d32aa9ccee930acc.

Signed-off-by: Corvin Köhne <corvink@FreeBSD.org>
Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
Cc: Jiewen Yao <jiewen.yao@intel.com>
Cc: Jordan Justen <jordan.l.justen@intel.com>
Cc: Gerd Hoffmann <kraxel@redhat.com>
Cc: Rebecca Cran <rebecca@bsdio.com>
Cc: Peter Grehan <grehan@freebsd.org>
---
 OvmfPkg/Bhyve/BhyveX64.dsc | 1 +
 OvmfPkg/Bhyve/BhyveX64.fdf | 1 +
 2 files changed, 2 insertions(+)

diff --git a/OvmfPkg/Bhyve/BhyveX64.dsc b/OvmfPkg/Bhyve/BhyveX64.dsc
index 0f1fe2e2f18a..e5167daa20a7 100644
--- a/OvmfPkg/Bhyve/BhyveX64.dsc
+++ b/OvmfPkg/Bhyve/BhyveX64.dsc
@@ -638,6 +638,7 @@ [Components]
   UefiCpuPkg/CpuIo2Dxe/CpuIo2Dxe.inf
   UefiCpuPkg/CpuDxe/CpuDxe.inf
   PcAtChipsetPkg/HpetTimerDxe/HpetTimerDxe.inf
+  OvmfPkg/IncompatiblePciDeviceSupportDxe/IncompatiblePciDeviceSupport.inf
   OvmfPkg/PciHotPlugInitDxe/PciHotPlugInit.inf
   MdeModulePkg/Bus/Pci/PciHostBridgeDxe/PciHostBridgeDxe.inf {
     <LibraryClasses>
diff --git a/OvmfPkg/Bhyve/BhyveX64.fdf b/OvmfPkg/Bhyve/BhyveX64.fdf
index 3f6270c048cc..a8f346f10cf5 100644
--- a/OvmfPkg/Bhyve/BhyveX64.fdf
+++ b/OvmfPkg/Bhyve/BhyveX64.fdf
@@ -205,6 +205,7 @@ [FV.DXEFV]
 INF  UefiCpuPkg/CpuIo2Dxe/CpuIo2Dxe.inf
 INF  UefiCpuPkg/CpuDxe/CpuDxe.inf
 INF  PcAtChipsetPkg/HpetTimerDxe/HpetTimerDxe.inf
+INF  OvmfPkg/IncompatiblePciDeviceSupportDxe/IncompatiblePciDeviceSupport.inf
 INF  OvmfPkg/PciHotPlugInitDxe/PciHotPlugInit.inf
 INF  MdeModulePkg/Bus/Pci/PciHostBridgeDxe/PciHostBridgeDxe.inf
 INF  MdeModulePkg/Bus/Pci/PciBusDxe/PciBusDxe.inf
-- 
2.41.0

[PATCH v1 3/3] OvmfPkg/BhyvePkg: enable bus enumeration

[Corvin Köhne]

bhyve supports adding a ROM to PCI devices. It was added to support GPU
passthrough of dedicated AMD GPUs. At the moment, this ROM file is
mostly useless as it's not shadowed and executed by firmware. Change
that by enabling bus enumeration.

Signed-off-by: Corvin Köhne <corvink@FreeBSD.org>
Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
Cc: Jiewen Yao <jiewen.yao@intel.com>
Cc: Jordan Justen <jordan.l.justen@intel.com>
Cc: Gerd Hoffmann <kraxel@redhat.com>
Cc: Rebecca Cran <rebecca@bsdio.com>
Cc: Peter Grehan <grehan@freebsd.org>
---
 OvmfPkg/Bhyve/BhyveX64.dsc | 1 -
 1 file changed, 1 deletion(-)

diff --git a/OvmfPkg/Bhyve/BhyveX64.dsc b/OvmfPkg/Bhyve/BhyveX64.dsc
index e5167daa20a7..df7508d7c36d 100644
--- a/OvmfPkg/Bhyve/BhyveX64.dsc
+++ b/OvmfPkg/Bhyve/BhyveX64.dsc
@@ -427,7 +427,6 @@ [PcdsFeatureFlag]
 !endif
 
 [PcdsFixedAtBuild]
-  gEfiMdeModulePkgTokenSpaceGuid.PcdPciDisableBusEnumeration|TRUE
   gEfiMdeModulePkgTokenSpaceGuid.PcdStatusCodeUseSerial|FALSE
   gEfiMdeModulePkgTokenSpaceGuid.PcdStatusCodeUseMemory|TRUE
   gEfiMdeModulePkgTokenSpaceGuid.PcdStatusCodeMemorySize|1
-- 
2.41.0

Re: [PATCH v1 3/3] OvmfPkg/BhyvePkg: enable bus enumeration

[Corvin Köhne]

[-- Attachment #1: Type: text/plain, Size: 1323 bytes --]

On Mon, 2023-06-12 at 11:20 +0200, Corvin Köhne wrote:
> bhyve supports adding a ROM to PCI devices. It was added to support
> GPU
> passthrough of dedicated AMD GPUs. At the moment, this ROM file is
> mostly useless as it's not shadowed and executed by firmware. Change
> that by enabling bus enumeration.
> 
> Signed-off-by: Corvin Köhne <corvink@FreeBSD.org>
> Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
> Cc: Jiewen Yao <jiewen.yao@intel.com>
> Cc: Jordan Justen <jordan.l.justen@intel.com>
> Cc: Gerd Hoffmann <kraxel@redhat.com>
> Cc: Rebecca Cran <rebecca@bsdio.com>
> Cc: Peter Grehan <grehan@freebsd.org>
> ---
>  OvmfPkg/Bhyve/BhyveX64.dsc | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/OvmfPkg/Bhyve/BhyveX64.dsc b/OvmfPkg/Bhyve/BhyveX64.dsc
> index e5167daa20a7..df7508d7c36d 100644
> --- a/OvmfPkg/Bhyve/BhyveX64.dsc
> +++ b/OvmfPkg/Bhyve/BhyveX64.dsc
> @@ -427,7 +427,6 @@ [PcdsFeatureFlag]
>  !endif
>  
>  [PcdsFixedAtBuild]
> -  gEfiMdeModulePkgTokenSpaceGuid.PcdPciDisableBusEnumeration|TRUE
>    gEfiMdeModulePkgTokenSpaceGuid.PcdStatusCodeUseSerial|FALSE
>    gEfiMdeModulePkgTokenSpaceGuid.PcdStatusCodeUseMemory|TRUE
>    gEfiMdeModulePkgTokenSpaceGuid.PcdStatusCodeMemorySize|1

Hi,

any comments on this?


-- 
Kind regards,
Corvin

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

Re: [PATCH v1 3/3] OvmfPkg/BhyvePkg: enable bus enumeration

[Peter Grehan]

On 7/3/23 9:34 PM, Corvin Köhne wrote:
> On Mon, 2023-06-12 at 11:20 +0200, Corvin Köhne wrote:
>> bhyve supports adding a ROM to PCI devices. It was added to support
>> GPU
>> passthrough of dedicated AMD GPUs. At the moment, this ROM file is
>> mostly useless as it's not shadowed and executed by firmware. Change
>> that by enabling bus enumeration.
>>
>> Signed-off-by: Corvin Köhne <corvink@FreeBSD.org>
...
> any comments on this?

Acked-by: Peter Grehan <grehan@freebsd.org>

later,

Peter.