From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx2.freebsd.org (mx2.freebsd.org [96.47.72.81]) by mx.groups.io with SMTP id smtpd.web11.7120.1687180384558713439 for ; Mon, 19 Jun 2023 06:13:04 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="body hash did not verify" header.i=@freebsd.org header.s=dkim header.b=LAZmb5gz; spf=pass (domain: freebsd.org, ip: 96.47.72.81, mailfrom: corvink@freebsd.org) Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits)) (Client CN "mx1.freebsd.org", Issuer "R3" (verified OK)) by mx2.freebsd.org (Postfix) with ESMTPS id 4Ql9Db6q0dz3LW3; Mon, 19 Jun 2023 13:13:03 +0000 (UTC) (envelope-from corvink@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Ql9Db62zBz3v9L; Mon, 19 Jun 2023 13:13:03 +0000 (UTC) (envelope-from corvink@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1687180383; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=vdbsYCYB2BWk+9P3cjNg77tHRAh8NgRXF/ih40T0T3g=; b=LAZmb5gzlzcc3k7IsUdEez7/xYmwc8+goY/6NGqUZSAs1NpplpWpVSkAl1C8RerpSMknA9 lKVbTG5fMbzumgKzKeivyVhqtLlXtAB6LSeXdYN1HHVepnCkjQL7O83geOUESvrjWa27nu nO6Y9ZTbzfv7vc+5/r3wzzGAGIFcnzOKAEEK4aEj2YNy63ZuPLIJ1TMV/NqBwq8E+ic7R+ yuxZcT6Qs8zc4cfd4DcEnAOlpV+jovEBjbTK39ueHOP8mB0aFyBNiBymKjrI/vhU9uQuik scihc4P6Wzaa2rMbY2eZYHHIT06A5pb9RicTLqbDOAu2S1WqvWvp/fTGAgHETw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1687180383; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=vdbsYCYB2BWk+9P3cjNg77tHRAh8NgRXF/ih40T0T3g=; b=J/Lf01D+vex8t82OQJ/8x/1djDpMXdV2Q8FRKrnTPzvEIsc06gizSnZh5iQ/EjdXxU/OFk JxQ47z8MPLZeXUaRY+R2p+clj2oY/IrDDFOvESfeXzLjHJ9uoHA1pC8zcQhl/QlO9cQ5EB mTMQWmw14I5W2u/ETVCuJcWXgp7K3q1B6qY2KHaH98BerTlV99z00viorIdYLQlD7gLpX/ 2W39x2NA9lIc/wZDQuJNXyk0/3Q3oHK4dMD371i9n+b9Fqn9vn6tv7r8D9Mj5Te1KaTorw h3sDFJhMqNrt+64o/TY3L2B7+XtVpNHvSOmSCjVjSxgxEAhdWV+9NHEN7F16dQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1687180383; a=rsa-sha256; cv=none; b=Xk5WlnLXl1b7mYAoaJOiueDhUwrsJXJyjMkkEsSpUXrhWWn7uXhz96qGT9iTV71RnDrrUU Q8B6D+9Ig0j60CjDuTfq1496FCvF6PJZXCB3XMbL8xMVzdIIxpYakvwyvxgT6TR8fxVq42 MG+DDdWdaUcqcuz/5Tw8jMzJV5n+3bTcLZWAXB6jtp8G0dOAWb6tz6avIA3QS3nk3tPUJ4 8YDUcOzWULglmunkU6xUETZeMI7vMSWUTDvGnf6Z0wWzGM18MKDxvag+ZGnfBiKe4hfhRH yW4wdGGE9cyPpEB4VXFrNCZRUfhFRFdYWCdBeS85mV2CH5HZP8wk+g+VAUwBkg== Received: from corvink-nb.fritz.box (unknown [IPv6:2001:9e8:da5e:c500:c216:138:c907:f83b]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: corvink) by smtp.freebsd.org (Postfix) with ESMTPSA id 4Ql9DZ5HcTzVB9; Mon, 19 Jun 2023 13:13:02 +0000 (UTC) (envelope-from corvink@FreeBSD.org) From: =?UTF-8?B?Q29ydmluIEvDtmhuZQ==?= To: devel@edk2.groups.io Cc: Ard Biesheuvel , Gerd Hoffmann , Jiewen Yao , Jordan Justen , Leif Lindholm , Peter Grehan , Rebecca Cran , Sami Mujawar Subject: [PATCH v2 1/6] OvmfPkg/Library: fix definition of GetAcpiRsdpFromMemory Date: Mon, 19 Jun 2023 15:12:23 +0200 Message-ID: <20230619131255.364358-2-corvink@FreeBSD.org> X-Mailer: git-send-email 2.41.0 In-Reply-To: <20230619131255.364358-1-corvink@FreeBSD.org> References: <20230619131255.364358-1-corvink@FreeBSD.org> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable The definition and declaration of GetAcpiRsdpFromMemory doesn't match. We don't get a compile error yet because UINTN is the same as UINT64 on 64bit machines. As the function works on memory addresses, UINTN is the correct type of the input parameters. Signed-off-by: Corvin K=C3=B6hne Cc: Ard Biesheuvel Cc: Gerd Hoffmann Cc: Jiewen Yao Cc: Jordan Justen Cc: Leif Lindholm Cc: Peter Grehan Cc: Rebecca Cran Cc: Sami Mujawar --- OvmfPkg/Include/Library/AcpiPlatformLib.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/OvmfPkg/Include/Library/AcpiPlatformLib.h b/OvmfPkg/Include/= Library/AcpiPlatformLib.h index 73a170636032..78d5010e91d5 100644 --- a/OvmfPkg/Include/Library/AcpiPlatformLib.h +++ b/OvmfPkg/Include/Library/AcpiPlatformLib.h @@ -20,8 +20,8 @@ EFI_STATUS EFIAPI GetAcpiRsdpFromMemory ( - IN UINT64 StartAddress, - IN UINT64 EndAddress, + IN UINTN StartAddress, + IN UINTN EndAddress, OUT EFI_ACPI_2_0_ROOT_SYSTEM_DESCRIPTION_POINTER **RsdpPtr ); =20 --=20 2.41.0