From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx2.freebsd.org (mx2.freebsd.org [96.47.72.81]) by mx.groups.io with SMTP id smtpd.web11.9456.1687265659710715045 for ; Tue, 20 Jun 2023 05:54:19 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="body hash did not verify" header.i=@freebsd.org header.s=dkim header.b=SD6j8APa; spf=pass (domain: freebsd.org, ip: 96.47.72.81, mailfrom: corvink@freebsd.org) Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits)) (Client CN "mx1.freebsd.org", Issuer "R3" (verified OK)) by mx2.freebsd.org (Postfix) with ESMTPS id 4QlmmW0Td2z3ZR7; Tue, 20 Jun 2023 12:54:19 +0000 (UTC) (envelope-from corvink@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4QlmmV6k9tz4T0M; Tue, 20 Jun 2023 12:54:18 +0000 (UTC) (envelope-from corvink@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1687265658; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=IP0ij2KhX5/0/OBcFGQJigh1kp2B1mNHyfmoafhpvjo=; b=SD6j8APazOqmDAqnB2u7+oYNEB/sa5kl6wq3tnW5x3FnoGBQcDHz+PIPuDUdNg7s1dnA1H 843Wi+lktFM7ehmHSpYMC8NZ91dtZQoiRNavLhFMCeGGb+mJOVFnFhSv35z0k+VwfSf7Ym QvM7ca/HZhhV/Do5iuYwFd6jWZepxAlxfNr1Gr6NAjIX2ZqytZ36iXGKNCQw/Oo7x6mfp+ WEpWtJd14VbdOOMZDlRb06ZFcStVuEgTL4FLeEPOE7/55gFIbCTWzevnfKK+Qulkpv/F71 Ukd/HpVejSG5xJjlnL9w/1iWxSzRjzPyDoexMUkea2iSnzYBQGmb0YnVCMRISg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1687265658; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=IP0ij2KhX5/0/OBcFGQJigh1kp2B1mNHyfmoafhpvjo=; b=cWlPElvMfpuE1uOHQKe4t4Dj06aGVluHUug5pKoauzVwNsct3zJM00YnkH+/LkO/nMM/i/ Qu2UGQWqFiDLiO2S66MC0FWfZ5qBDHw40m7aDkTPTRCdFFxYA8gT7NEHV9DVaJ/Ul9Ajf8 VRzEPdsS7bwyUefRBfBR33aS5epYDpPgpbsEL9CtChKKIfVLprT80xdUmCjzn3iJZ2U3cG pLEs48D3AdCcHhiGekC1b6OkEH+ESU7eKibgWO0q14yzVKbLhp4U01zSAsckKYv+4Qdzsr fXMKMCnLqdQBBsEzmPXj5xdXxhGs63ZoXypxaDLBVmFzaL82t+eFsit9NHVaMA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1687265658; a=rsa-sha256; cv=none; b=YDFVz/km3XAhRjTOgntTU+dQ1CBGpyLiqzKgCcNWUs1V+iALwCp8B4Onz5EqxqOsoQXizL gPP3aMdq+AiUWZy5uhLSJZ/1REdHqEgmrRpXFfzRQQ0Q3swfCofweUeYfZue1Gmi5eW5Zd 2LWG7jKPTQ2Tzkj3yyf/IpOfKEORxTYMzE7wOk6m7S6mjLP1dtDNku4tQ78/XNo5Gvah2E XgPBBz/DivUw8eL8uBcj9LYknw+cQKpezLxjM//wvbc0OMcBHw1vET5+48BrMAut7HU7lx 64GSTf5tqH/F7rDiLA6Xyam1oE1UIHNtyFKKHA4iqOMMh+Ox9wMxfQhcb1LACA== Received: from corvink-nb.beckhoff.com (unknown [IPv6:2001:9e8:da45:9200:c724:a25a:dc54:e67e]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: corvink) by smtp.freebsd.org (Postfix) with ESMTPSA id 4QlmmT5wRjzyy3; Tue, 20 Jun 2023 12:54:17 +0000 (UTC) (envelope-from corvink@FreeBSD.org) From: =?UTF-8?B?Q29ydmluIEvDtmhuZQ==?= To: devel@edk2.groups.io Cc: Gerd Hoffmann , Ard Biesheuvel , Jiewen Yao , Jordan Justen , Leif Lindholm , Peter Grehan , Rebecca Cran , Sami Mujawar Subject: [PATCH v3 1/6] OvmfPkg/Library: fix definition of GetAcpiRsdpFromMemory Date: Tue, 20 Jun 2023 14:53:35 +0200 Message-ID: <20230620125407.516697-2-corvink@FreeBSD.org> X-Mailer: git-send-email 2.41.0 In-Reply-To: <20230620125407.516697-1-corvink@FreeBSD.org> References: <20230620125407.516697-1-corvink@FreeBSD.org> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable The definition and declaration of GetAcpiRsdpFromMemory doesn't match. We don't get a compile error yet because UINTN is the same as UINT64 on 64bit machines. As the function works on memory addresses, UINTN is the correct type of the input parameters. Signed-off-by: Corvin K=C3=B6hne Tested-by: Gerd Hoffmann Acked-by: Gerd Hoffmann Cc: Ard Biesheuvel Cc: Jiewen Yao Cc: Jordan Justen Cc: Leif Lindholm Cc: Peter Grehan Cc: Rebecca Cran Cc: Sami Mujawar --- OvmfPkg/Include/Library/AcpiPlatformLib.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/OvmfPkg/Include/Library/AcpiPlatformLib.h b/OvmfPkg/Include/= Library/AcpiPlatformLib.h index 73a170636032..78d5010e91d5 100644 --- a/OvmfPkg/Include/Library/AcpiPlatformLib.h +++ b/OvmfPkg/Include/Library/AcpiPlatformLib.h @@ -20,8 +20,8 @@ EFI_STATUS EFIAPI GetAcpiRsdpFromMemory ( - IN UINT64 StartAddress, - IN UINT64 EndAddress, + IN UINTN StartAddress, + IN UINTN EndAddress, OUT EFI_ACPI_2_0_ROOT_SYSTEM_DESCRIPTION_POINTER **RsdpPtr ); =20 --=20 2.41.0