From: "Corvin Köhne" <corvink@FreeBSD.org>
To: devel@edk2.groups.io
Cc: Gerd Hoffmann <kraxel@redhat.com>,
Peter Grehan <grehan@freebsd.org>,
Ard Biesheuvel <ardb+tianocore@kernel.org>,
Jiewen Yao <jiewen.yao@intel.com>,
Jordan Justen <jordan.l.justen@intel.com>,
Leif Lindholm <quic_llindhol@quicinc.com>,
Rebecca Cran <rebecca@bsdio.com>,
Sami Mujawar <sami.mujawar@arm.com>
Subject: [PATCH v4 1/6] OvmfPkg/Library: fix definition of GetAcpiRsdpFromMemory
Date: Wed, 21 Jun 2023 09:31:11 +0200 [thread overview]
Message-ID: <20230621073141.149094-2-corvink@FreeBSD.org> (raw)
In-Reply-To: <20230621073141.149094-1-corvink@FreeBSD.org>
The definition and declaration of GetAcpiRsdpFromMemory doesn't match.
We don't get a compile error yet because UINTN is the same as UINT64 on
64bit machines. As the function works on memory addresses, UINTN is the
correct type of the input parameters.
Signed-off-by: Corvin Köhne <corvink@FreeBSD.org>
Tested-by: Gerd Hoffmann <kraxel@redhat.com>
Acked-by: Gerd Hoffmann <kraxel@redhat.com>
Acked-by: Peter Grehan <grehan@freebsd.org>
Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
Cc: Jiewen Yao <jiewen.yao@intel.com>
Cc: Jordan Justen <jordan.l.justen@intel.com>
Cc: Leif Lindholm <quic_llindhol@quicinc.com>
Cc: Rebecca Cran <rebecca@bsdio.com>
Cc: Sami Mujawar <sami.mujawar@arm.com>
---
OvmfPkg/Include/Library/AcpiPlatformLib.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/OvmfPkg/Include/Library/AcpiPlatformLib.h b/OvmfPkg/Include/Library/AcpiPlatformLib.h
index 73a170636032..78d5010e91d5 100644
--- a/OvmfPkg/Include/Library/AcpiPlatformLib.h
+++ b/OvmfPkg/Include/Library/AcpiPlatformLib.h
@@ -20,8 +20,8 @@
EFI_STATUS
EFIAPI
GetAcpiRsdpFromMemory (
- IN UINT64 StartAddress,
- IN UINT64 EndAddress,
+ IN UINTN StartAddress,
+ IN UINTN EndAddress,
OUT EFI_ACPI_2_0_ROOT_SYSTEM_DESCRIPTION_POINTER **RsdpPtr
);
--
2.41.0
next prev parent reply other threads:[~2023-06-21 7:31 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-21 7:31 [PATCH v4 0/6] OvmfPkg/Bhyve: install Acpi tables by FwCfg Corvin Köhne
2023-06-21 7:31 ` Corvin Köhne [this message]
2023-06-21 7:31 ` [PATCH v4 2/6] OvmfPkg: avoid including AcpiPlatformLib twice Corvin Köhne
2023-06-21 7:31 ` [PATCH v4 3/6] OvmfPkg: move PciEncoding into AcpiPlatformLib Corvin Köhne
2023-06-21 7:31 ` [PATCH v4 4/6] OvmfPkg: move BootScript " Corvin Köhne
2023-06-21 7:31 ` [PATCH v4 5/6] OvmfPkg: move QemuFwCfgAcpi " Corvin Köhne
2023-06-21 7:31 ` [PATCH v4 6/6] OvmfPkg/Bhyve: install Acpi tables provided by FwCfg Corvin Köhne
2023-06-23 17:38 ` [edk2-devel] [PATCH v4 0/6] OvmfPkg/Bhyve: install Acpi tables " Ard Biesheuvel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230621073141.149094-2-corvink@FreeBSD.org \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox