From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx2.freebsd.org (mx2.freebsd.org [96.47.72.81]) by mx.groups.io with SMTP id smtpd.web10.5593.1687332711037583466 for ; Wed, 21 Jun 2023 00:31:51 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="body hash did not verify" header.i=@freebsd.org header.s=dkim header.b=DzsZ7A0e; spf=pass (domain: freebsd.org, ip: 96.47.72.81, mailfrom: corvink@freebsd.org) Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits)) (Client CN "mx1.freebsd.org", Issuer "R3" (verified OK)) by mx2.freebsd.org (Postfix) with ESMTPS id 4QmFYy33CNz3d76; Wed, 21 Jun 2023 07:31:50 +0000 (UTC) (envelope-from corvink@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4QmFYy2H7Cz3sNc; Wed, 21 Jun 2023 07:31:50 +0000 (UTC) (envelope-from corvink@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1687332710; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=h/U1LTHDvpLAQa7s2S6sWuqI7AV47PQx35oX83qZ/WQ=; b=DzsZ7A0eAuN7mtmYb5p86odXT46F8XCoMlYvtywL+nIAbUNz2qlKJPnYJOsdN6DcNb9gsB irY4ddmWVNq6wq5adbXxFnhsG6PDR1SnY5TySeidNiEwGqS2qJL/yn2iXMd5haCdU8XQm2 iTvJ8fc41zawTX1JZxztr/3yrxi6PnkxD9/whRVEARps1fsDvB5Zc4SqIVi/KyUezVXAjH rkGjOCaz3dkfAEk4fnPjsNXtiHrouE30+QOhpQqPs1gULfUHNx5ThCYfpW2DoTUp0s1oCx HZpN0+Tmup4Vn7UELjjN8VKA/dVqHoiKTKRsvgzcUgfkRr1+2kAlaMYb6Otsxg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1687332710; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=h/U1LTHDvpLAQa7s2S6sWuqI7AV47PQx35oX83qZ/WQ=; b=bJH8elzdWgRPeHHN/xk2SpDpScLa4IyvLgmBckW8GYQXzmU+EeYAftmCqwidotAADu88Dv Up+cdBgPD7vUaq/CG8C562TMNNi5C8fN0HyrMd1ydo0oEVUuISOAZ0aOPwtJ0q+zC6K6n0 PA38Dyaq5klg8tdVtrfYTRqT8sI2HzszmlhLxndzE/beBnxr7GVwpTyYYS0w1Rx9XK/mFS t823g4T3LxYzFu847Ld/JXSx5XyNhyjUnlcickzL7kGtZD77VJ+oF4Fu8iFbu64zdB/NT0 pPBo/5qoncLy2Hfpkd3QC3C44JfgJmYNL2nH84DfopryLDHdhP+coP5jwhEUSQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1687332710; a=rsa-sha256; cv=none; b=Zbbo962iguX9WMplb131o2zTgNtpMGqv/fEclvw01tlp6r7NVNHci735k2G4M6CcestHDG iHAPxFpjrKL6ww5ixLjtmMrc7pzCO5FfZ9twj7XTVQSTuHoHPzl7VxHZD+xOzY2/qshJpo N7oEbNq4dqLmc0RYGyoqWSm4u+b3iAGY/KHlpcjvPY9ncUndMXoWqw2F1HMjD7/7fosDo5 64nNg1YVApu7spOFTr56X2Fz9ghNP+RygbKTgMzckf12WWb/5eTrgTgRzT284TiZnZ6M/O pjqDWJ34kkyfat0so3K3j3sZGI4Ydd79K4ywndsARSp9IFPl6rXhxWimM5nppQ== Received: from corvink-nb.beckhoff.com (unknown [IPv6:2001:9e8:da6d:2500:f78a:5460:c2c3:5780]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: corvink) by smtp.freebsd.org (Postfix) with ESMTPSA id 4QmFYx1P6BzNS4; Wed, 21 Jun 2023 07:31:49 +0000 (UTC) (envelope-from corvink@FreeBSD.org) From: =?UTF-8?B?Q29ydmluIEvDtmhuZQ==?= To: devel@edk2.groups.io Cc: Gerd Hoffmann , Peter Grehan , Ard Biesheuvel , Jiewen Yao , Jordan Justen , Leif Lindholm , Rebecca Cran , Sami Mujawar Subject: [PATCH v4 1/6] OvmfPkg/Library: fix definition of GetAcpiRsdpFromMemory Date: Wed, 21 Jun 2023 09:31:11 +0200 Message-ID: <20230621073141.149094-2-corvink@FreeBSD.org> X-Mailer: git-send-email 2.41.0 In-Reply-To: <20230621073141.149094-1-corvink@FreeBSD.org> References: <20230621073141.149094-1-corvink@FreeBSD.org> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable The definition and declaration of GetAcpiRsdpFromMemory doesn't match. We don't get a compile error yet because UINTN is the same as UINT64 on 64bit machines. As the function works on memory addresses, UINTN is the correct type of the input parameters. Signed-off-by: Corvin K=C3=B6hne Tested-by: Gerd Hoffmann Acked-by: Gerd Hoffmann Acked-by: Peter Grehan Cc: Ard Biesheuvel Cc: Jiewen Yao Cc: Jordan Justen Cc: Leif Lindholm Cc: Rebecca Cran Cc: Sami Mujawar --- OvmfPkg/Include/Library/AcpiPlatformLib.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/OvmfPkg/Include/Library/AcpiPlatformLib.h b/OvmfPkg/Include/= Library/AcpiPlatformLib.h index 73a170636032..78d5010e91d5 100644 --- a/OvmfPkg/Include/Library/AcpiPlatformLib.h +++ b/OvmfPkg/Include/Library/AcpiPlatformLib.h @@ -20,8 +20,8 @@ EFI_STATUS EFIAPI GetAcpiRsdpFromMemory ( - IN UINT64 StartAddress, - IN UINT64 EndAddress, + IN UINTN StartAddress, + IN UINTN EndAddress, OUT EFI_ACPI_2_0_ROOT_SYSTEM_DESCRIPTION_POINTER **RsdpPtr ); =20 --=20 2.41.0