public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
* [Patch V2] [edk2-staging] BaseTools/FMMT: C FMMT match new version machine defines
@ 2023-06-21 14:23 Yuwei Chen
  0 siblings, 0 replies; only message in thread
From: Yuwei Chen @ 2023-06-21 14:23 UTC (permalink / raw)
  To: devel; +Cc: Rebecca Cran, Liming Gao, Bob Feng

BaseTools have switch from EFI_IMAGE_MACHINE_*
to IMAGE_FILE_MACHINE_*. Thus, match the FCE & FMMT
tool in edk2-staging repo with the new version define.

Cc: Rebecca Cran <rebecca@bsdio.com>
Cc: Liming Gao <gaoliming@byosoft.com.cn>
Cc: Bob Feng <bob.c.feng@intel.com>
Signed-off-by: Yuwei Chen <yuwei.chen@intel.com>
---
 BaseTools/Source/C/FMMT/Rebase.c | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

Update V2 for correct conditional checking.
diff --git a/BaseTools/Source/C/FMMT/Rebase.c b/BaseTools/Source/C/FMMT/Rebase.c
index d32217d18c..ba1429d73a 100644
--- a/BaseTools/Source/C/FMMT/Rebase.c
+++ b/BaseTools/Source/C/FMMT/Rebase.c
@@ -159,8 +159,8 @@ EFI_NOT_FOUND           No compressed sections could be found.
       return Status;
     }
 
-    //if ((ImageContext.Machine == EFI_IMAGE_MACHINE_ARMT) ||
-    //  (ImageContext.Machine == EFI_IMAGE_MACHINE_AARCH64)) {
+    //if ((ImageContext.Machine == IMAGE_FILE_MACHINE_ARMT) ||
+    //  (ImageContext.Machine == IMAGE_FILE_MACHINE_AARCH64)) {
     //  mArm = TRUE;
     //}
 
@@ -435,8 +435,8 @@ EFI_NOT_FOUND           No compressed sections could be found.
       return Status;
     }
 
-    //if ((ImageContext.Machine == EFI_IMAGE_MACHINE_ARMT) ||
-    //  (ImageContext.Machine == EFI_IMAGE_MACHINE_AARCH64)) {
+    //if ((ImageContext.Machine == IMAGE_FILE_MACHINE_ARMT) ||
+    //  (ImageContext.Machine == IMAGE_FILE_MACHINE_AARCH64)) {
     //  mArm = TRUE;
     //}
 
@@ -835,8 +835,8 @@ Returns:
   //
   // Verify machine type is supported
   //
-  if ((*MachineType != EFI_IMAGE_MACHINE_IA32) && (*MachineType != EFI_IMAGE_MACHINE_X64) && (*MachineType != EFI_IMAGE_MACHINE_EBC) &&
-      (*MachineType != EFI_IMAGE_MACHINE_ARMT) && (*MachineType != EFI_IMAGE_MACHINE_AARCH64)) {
+  if ((*MachineType != IMAGE_FILE_MACHINE_I386) && (*MachineType != IMAGE_FILE_MACHINE_X64) && (*MachineType != IMAGE_FILE_MACHINE_EBC) &&
+      (*MachineType != IMAGE_FILE_MACHINE_ARMTHUMB_MIXED) && (*MachineType != IMAGE_FILE_MACHINE_ARM64 )) {
     Error (NULL, 0, 3000, "Invalid", "Unrecognized machine type in the PE32 file.");
     return EFI_UNSUPPORTED;
   }
-- 
2.27.0.windows.1


^ permalink raw reply related	[flat|nested] only message in thread

only message in thread, other threads:[~2023-06-21 14:24 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-06-21 14:23 [Patch V2] [edk2-staging] BaseTools/FMMT: C FMMT match new version machine defines Yuwei Chen

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox