[PATCH v1 00/24] Update Edk2-pytools to latest versions

[PATCH v1 00/24] Update Edk2-pytools to latest versions

[Joey Vagedes]

Updates Edk2-pytools to the latest versions, which introduces a new Policy
for detecting which packages must be built given a set of changes. This policy
is used when a library class instance INF is changed. When this occurs, it will
review the PrEval:DscPath provided in the CI YAML file and determine if the
package uses the library instance or not. If it does, it will build and test
the package.

Due to these changes, each package must now include an entry in it's CI YAML
file (PrEval:DscPath). If the package does not provide this entry, this policy
will be skipped, which could lead to a library instance breaking packages outside
of it's parent package.

Cc: Abner Chang <abner.chang@amd.com>
Cc: Alexei Fedorov <Alexei.Fedorov@arm.com>
Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
Cc: Ashraf Ali S <ashraf.ali.s@intel.com>
Cc: Chasel Chiu <chasel.chiu@intel.com>
Cc: Chen Gang C <gang.c.chen@intel.com>
Cc: Daniel Schaefer <git@danielschaefer.me>
Cc: Duggapu Chinni B <chinni.b.duggapu@intel.com>
Cc: Eric Dong <eric.dong@intel.com>
Cc: Gerd Hoffmann <kraxel@redhat.com>
Cc: Guo Dong <guo.dong@intel.com>
Cc: Guomin Jiang <guomin.jiang@intel.com>
Cc: Hao A Wu <hao.a.wu@intel.com>
Cc: Igor Kulchytskyy <igork@ami.com>
Cc: James Lu <james.lu@intel.com>
Cc: Jian J Wang <jian.j.wang@intel.com>
Cc: Jiewen Yao <jiewen.yao@intel.com>
Cc: Leif Lindholm <quic_llindhol@quicinc.com>
Cc: Liming Gao <gaoliming@byosoft.com.cn>
Cc: Maciej Rabeda <maciej.rabeda@linux.intel.com>
Cc: Michael D Kinney <michael.d.kinney@intel.com>
Cc: Michael Kubacki <mikuback@linux.microsoft.com>
Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
Cc: Nickle Wang <nicklew@nvidia.com>
Cc: Pierre Gondois <pierre.gondois@arm.com>
Cc: Rahul Kumar <rahul1.kumar@intel.com>
Cc: Ray Han Lim Ng <ray.han.lim.ng@intel.com>
Cc: Ray Ni <ray.ni@intel.com>
Cc: Sami Mujawar <sami.mujawar@arm.com>
Cc: Sean Brogan <sean.brogan@microsoft.com>
Cc: Sean Rhodes <sean@starlabs.systems>
Cc: Siyuan Fu <siyuan.fu@intel.com>
Cc: Star Zeng <star.zeng@intel.com>
Cc: Susovan Mohapatra <susovan.mohapatra@intel.com>
Cc: Ted Kuo <ted.kuo@intel.com>
Cc: Wei6 Xu <wei6.xu@intel.com>
Cc: Xiaoyu Lu <xiaoyu1.lu@intel.com>
Cc: Yi Li <yi1.li@intel.com>
Cc: Zhichao Gao <zhichao.gao@intel.com>
Cc: Zhiguang Liu <zhiguang.liu@intel.com>

Joey Vagedes (24):
  Edk2: edk2-pytools: Update to latest versions
  UnitTestFrameworkPkg: CI: Add PrEval entry
  UefiPayloadPkg: CI: Add PrEval entry
  ArmPkg: CI: Add PrEval entry
  UefiCpuPkg: CI: Add PrEval entry
  ArmPlatformPkg: CI: Add PrEval entry
  CryptoPkg: CI: Add PrEval entry
  DynamicTablesPkg: CI: Add PrEval entry
  EmbeddedPkg: CI: Add PrEval entry
  FatPkg: CI: Add PrEval entry
  FmpDevicePkg: CI: Add PrEval entry
  IntelFsp2Pkg: CI: Add PrEval entry
  CryptoPkg: CI: Add PrEval entry
  SourceLevelDebugPkg: CI: Add PrEval entry
  SignedCapsulePkg: CI: Add PrEval entry
  ShellPkg: CI: Add PrEval entry
  SecurityPkg: CI: Add PrEval entry
  RedfishPkg: CI: Add PrEval entry
  PrmPkg: CI: Add PrEval entry
  PcAtChipsetPkg: CI: Add PrEval entry
  NetworkPkg: CI: Add PrEval entry
  MdePkg: CI: Add PrEval entry
  MdeModulePkg: CI: Add PrEval entry
  IntelFsp2WrapperPkg: CI: Add PrEval entry

 ArmPkg/ArmPkg.ci.yaml                             | 3 +++
 ArmPlatformPkg/ArmPlatformPkg.ci.yaml             | 3 +++
 CryptoPkg/CryptoPkg.ci.yaml                       | 3 +++
 DynamicTablesPkg/DynamicTablesPkg.ci.yaml         | 3 +++
 EmbeddedPkg/EmbeddedPkg.ci.yaml                   | 3 +++
 FatPkg/FatPkg.ci.yaml                             | 3 +++
 FmpDevicePkg/FmpDevicePkg.ci.yaml                 | 3 +++
 IntelFsp2Pkg/IntelFsp2Pkg.ci.yaml                 | 3 +++
 IntelFsp2WrapperPkg/IntelFsp2WrapperPkg.ci.yaml   | 3 +++
 MdeModulePkg/MdeModulePkg.ci.yaml                 | 3 +++
 MdePkg/MdePkg.ci.yaml                             | 3 +++
 NetworkPkg/NetworkPkg.ci.yaml                     | 3 +++
 PcAtChipsetPkg/PcAtChipsetPkg.ci.yaml             | 3 +++
 PrmPkg/PrmPkg.ci.yaml                             | 3 +++
 RedfishPkg/RedfishPkg.ci.yaml                     | 3 +++
 SecurityPkg/SecurityPkg.ci.yaml                   | 3 +++
 ShellPkg/ShellPkg.ci.yaml                         | 3 +++
 SignedCapsulePkg/SignedCapsulePkg.ci.yaml         | 3 +++
 SourceLevelDebugPkg/SourceLevelDebugPkg.ci.yaml   | 3 +++
 StandaloneMmPkg/StandaloneMmPkg.ci.yaml           | 3 +++
 UefiCpuPkg/UefiCpuPkg.ci.yaml                     | 3 +++
 UefiPayloadPkg/UefiPayloadPkg.ci.yaml             | 3 +++
 UnitTestFrameworkPkg/UnitTestFrameworkPkg.ci.yaml | 3 +++
 pip-requirements.txt                              | 4 ++--
 24 files changed, 71 insertions(+), 2 deletions(-)

-- 
2.41.0.windows.1

[PATCH v1 01/24] Edk2: edk2-pytools: Update to latest versions

[Joey Vagedes]

Update to the latest versions of edk2-pytool-extensions and
edk2-pytool-library. This introduces a new policy to stuart_pr_eval
which, when a change in an INF occurs, will mark any associated DSC
that uses this INF to be built during CI.

Cc: Sean Brogan <sean.brogan@microsoft.com>
Cc: Michael Kubacki <mikuback@linux.microsoft.com>
Cc: Michael D Kinney <michael.d.kinney@intel.com>
Cc: Liming Gao <gaoliming@byosoft.com.cn>
Signed-off-by: Joey Vagedes <joeyvagedes@gmail.com>
---
 pip-requirements.txt | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/pip-requirements.txt b/pip-requirements.txt
index c221576bef3a..ed7e430f1572 100644
--- a/pip-requirements.txt
+++ b/pip-requirements.txt
@@ -12,8 +12,8 @@
 # https://www.python.org/dev/peps/pep-0440/#version-specifiers
 ##
 
-edk2-pytool-library==0.14.1
-edk2-pytool-extensions~=0.23.2
+edk2-pytool-library==0.15.3
+edk2-pytool-extensions~=0.23.6
 edk2-basetools==0.1.48
 antlr4-python3-runtime==4.7.1
 lcov-cobertura==2.0.2
-- 
2.41.0.windows.1

[PATCH v1 02/24] UnitTestFrameworkPkg: CI: Add PrEval entry

[Joey Vagedes]

Adds a PrEval entry to the package's ci.yaml file which is used to
verify if the package uses a particular library instance when that
library instance file (INF) is updated.

When a library instance file (INF) is updated, PrEval will review each
package's DSC as described in the ci.yaml file to determine if the
package uses said library instance. If the package does use the library
instance, it will be built and tested to ensure the package is not
broken from the change.

Cc: Michael D Kinney <michael.d.kinney@intel.com>
Cc: Michael Kubacki <mikuback@linux.microsoft.com>
Cc: Sean Brogan <sean.brogan@microsoft.com>
Signed-off-by: Joey Vagedes <joeyvagedes@gmail.com>
---
 UnitTestFrameworkPkg/UnitTestFrameworkPkg.ci.yaml | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/UnitTestFrameworkPkg/UnitTestFrameworkPkg.ci.yaml b/UnitTestFrameworkPkg/UnitTestFrameworkPkg.ci.yaml
index be839d1af0a7..40a396dd9f71 100644
--- a/UnitTestFrameworkPkg/UnitTestFrameworkPkg.ci.yaml
+++ b/UnitTestFrameworkPkg/UnitTestFrameworkPkg.ci.yaml
@@ -5,6 +5,9 @@
 # SPDX-License-Identifier: BSD-2-Clause-Patent
 ##
 {
+    "PrEval": {
+        "DscPath": "UnitTestFrameworkPkg.dsc",
+    },
     ## options defined .pytool/Plugin/LicenseCheck
     "LicenseCheck": {
         "IgnoreFiles": []
-- 
2.41.0.windows.1

[PATCH v1 03/24] UefiPayloadPkg: CI: Add PrEval entry

[Joey Vagedes]

Adds a PrEval entry to the package's ci.yaml file which is used to
verify if the package uses a particular library instance when that
library instance file (INF) is updated.

When a library instance file (INF) is updated, PrEval will review each
package's DSC as described in the ci.yaml file to determine if the
package uses said library instance. If the package does use the library
instance, it will be built and tested to ensure the package is not
broken from the change.

Cc: Guo Dong <guo.dong@intel.com>
Cc: Sean Rhodes <sean@starlabs.systems>
Cc: James Lu <james.lu@intel.com>
Signed-off-by: Joey Vagedes <joeyvagedes@gmail.com>
---
 UefiPayloadPkg/UefiPayloadPkg.ci.yaml | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/UefiPayloadPkg/UefiPayloadPkg.ci.yaml b/UefiPayloadPkg/UefiPayloadPkg.ci.yaml
index 278f271c3671..50229da451fa 100644
--- a/UefiPayloadPkg/UefiPayloadPkg.ci.yaml
+++ b/UefiPayloadPkg/UefiPayloadPkg.ci.yaml
@@ -5,6 +5,9 @@
 # SPDX-License-Identifier: BSD-2-Clause-Patent
 ##
 {
+    "PrEval": {
+        "DscPath": "UefiPayloadPkg.dsc",
+    },
     ## options defined .pytool/Plugin/LicenseCheck
     "LicenseCheck": {
         "IgnoreFiles": []
-- 
2.41.0.windows.1

[PATCH v1 04/24] ArmPkg: CI: Add PrEval entry

[Joey Vagedes]

Adds a PrEval entry to the package's ci.yaml file which is used to
verify if the package uses a particular library instance when that
library instance file (INF) is updated.

When a library instance file (INF) is updated, PrEval will review each
package's DSC as described in the ci.yaml file to determine if the
package uses said library instance. If the package does use the library
instance, it will be built and tested to ensure the package is not
broken from the change.

Cc: Leif Lindholm <quic_llindhol@quicinc.com>
Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
Cc: Sami Mujawar <sami.mujawar@arm.com>
Signed-off-by: Joey Vagedes <joeyvagedes@gmail.com>
---
 ArmPkg/ArmPkg.ci.yaml | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/ArmPkg/ArmPkg.ci.yaml b/ArmPkg/ArmPkg.ci.yaml
index d31248161189..b65efa7b3ece 100644
--- a/ArmPkg/ArmPkg.ci.yaml
+++ b/ArmPkg/ArmPkg.ci.yaml
@@ -5,6 +5,9 @@
 # SPDX-License-Identifier: BSD-2-Clause-Patent
 ##
 {
+    "PrEval": {
+        "DscPath": "ArmPkg.dsc",
+    },
     ## options defined .pytool/Plugin/LicenseCheck
     "LicenseCheck": {
         "IgnoreFiles": []
-- 
2.41.0.windows.1

[PATCH v1 05/24] UefiCpuPkg: CI: Add PrEval entry

[Joey Vagedes]

Adds a PrEval entry to the package's ci.yaml file which is used to
verify if the package uses a particular library instance when that
library instance file (INF) is updated.

When a library instance file (INF) is updated, PrEval will review each
package's DSC as described in the ci.yaml file to determine if the
package uses said library instance. If the package does use the library
instance, it will be built and tested to ensure the package is not
broken from the change.

Cc: Eric Dong <eric.dong@intel.com>
Cc: Ray Ni <ray.ni@intel.com>
Cc: Rahul Kumar <rahul1.kumar@intel.com>
Cc: Gerd Hoffmann <kraxel@redhat.com>
Signed-off-by: Joey Vagedes <joeyvagedes@gmail.com>
---
 UefiCpuPkg/UefiCpuPkg.ci.yaml | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/UefiCpuPkg/UefiCpuPkg.ci.yaml b/UefiCpuPkg/UefiCpuPkg.ci.yaml
index c2280aedf5ce..80a043f339c1 100644
--- a/UefiCpuPkg/UefiCpuPkg.ci.yaml
+++ b/UefiCpuPkg/UefiCpuPkg.ci.yaml
@@ -6,6 +6,9 @@
 # SPDX-License-Identifier: BSD-2-Clause-Patent
 ##
 {
+    "PrEval": {
+        "DscPath": "UefiCpuPkg.dsc",
+    },
     "LicenseCheck": {
         "IgnoreFiles": []
     },
-- 
2.41.0.windows.1

[PATCH v1 06/24] ArmPlatformPkg: CI: Add PrEval entry

[Joey Vagedes]

Adds a PrEval entry to the package's ci.yaml file which is used to
verify if the package uses a particular library instance when that
library instance file (INF) is updated.

When a library instance file (INF) is updated, PrEval will review each
package's DSC as described in the ci.yaml file to determine if the
package uses said library instance. If the package does use the library
instance, it will be built and tested to ensure the package is not
broken from the change.

Cc: Leif Lindholm <quic_llindhol@quicinc.com>
Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
Signed-off-by: Joey Vagedes <joeyvagedes@gmail.com>
---
 ArmPlatformPkg/ArmPlatformPkg.ci.yaml | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/ArmPlatformPkg/ArmPlatformPkg.ci.yaml b/ArmPlatformPkg/ArmPlatformPkg.ci.yaml
index 03632e74df73..9c384a3febad 100644
--- a/ArmPlatformPkg/ArmPlatformPkg.ci.yaml
+++ b/ArmPlatformPkg/ArmPlatformPkg.ci.yaml
@@ -5,6 +5,9 @@
 # SPDX-License-Identifier: BSD-2-Clause-Patent
 ##
 {
+    "PrEval": {
+        "DscPath": "ArmPlatformPkg.dsc",
+    },
     ## options defined .pytool/Plugin/LicenseCheck
     "LicenseCheck": {
         "IgnoreFiles": []
-- 
2.41.0.windows.1

[PATCH v1 07/24] CryptoPkg: CI: Add PrEval entry

[Joey Vagedes]

Adds a PrEval entry to the package's ci.yaml file which is used to
verify if the package uses a particular library instance when that
library instance file (INF) is updated.

When a library instance file (INF) is updated, PrEval will review each
package's DSC as described in the ci.yaml file to determine if the
package uses said library instance. If the package does use the library
instance, it will be built and tested to ensure the package is not
broken from the change.

Cc: Jiewen Yao <jiewen.yao@intel.com>
Cc: Yi Li <yi1.li@intel.com>
Cc: Xiaoyu Lu <xiaoyu1.lu@intel.com>
Cc: Guomin Jiang <guomin.jiang@intel.com>
Signed-off-by: Joey Vagedes <joeyvagedes@gmail.com>
---
 CryptoPkg/CryptoPkg.ci.yaml | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/CryptoPkg/CryptoPkg.ci.yaml b/CryptoPkg/CryptoPkg.ci.yaml
index 47f29759676d..4cec206477bc 100644
--- a/CryptoPkg/CryptoPkg.ci.yaml
+++ b/CryptoPkg/CryptoPkg.ci.yaml
@@ -6,6 +6,9 @@
 # SPDX-License-Identifier: BSD-2-Clause-Patent
 ##
 {
+    "PrEval": {
+        "DscPath": "CryptoPkg.dsc",
+    },
     "LicenseCheck": {
         "IgnoreFiles": [
             # These directories contain auto-generated OpenSSL content
-- 
2.41.0.windows.1

[PATCH v1 08/24] DynamicTablesPkg: CI: Add PrEval entry

[Joey Vagedes]

Adds a PrEval entry to the package's ci.yaml file which is used to
verify if the package uses a particular library instance when that
library instance file (INF) is updated.

When a library instance file (INF) is updated, PrEval will review each
package's DSC as described in the ci.yaml file to determine if the
package uses said library instance. If the package does use the library
instance, it will be built and tested to ensure the package is not
broken from the change.

Cc: Sami Mujawar <Sami.Mujawar@arm.com>
Cc: Alexei Fedorov <Alexei.Fedorov@arm.com>
Cc: Pierre Gondois <pierre.gondois@arm.com>
Signed-off-by: Joey Vagedes <joeyvagedes@gmail.com>
---
 DynamicTablesPkg/DynamicTablesPkg.ci.yaml | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/DynamicTablesPkg/DynamicTablesPkg.ci.yaml b/DynamicTablesPkg/DynamicTablesPkg.ci.yaml
index 5addf8626841..f37842f65246 100644
--- a/DynamicTablesPkg/DynamicTablesPkg.ci.yaml
+++ b/DynamicTablesPkg/DynamicTablesPkg.ci.yaml
@@ -5,6 +5,9 @@
 # SPDX-License-Identifier: BSD-2-Clause-Patent
 ##
 {
+    "PrEval": {
+        "DscPath": "DynamicTablesPkg.dsc",
+    },
     "EccCheck": {
         ## Exception sample looks like below:
         ## "ExceptionList": [
-- 
2.41.0.windows.1

[PATCH v1 09/24] EmbeddedPkg: CI: Add PrEval entry

[Joey Vagedes]

Adds a PrEval entry to the package's ci.yaml file which is used to
verify if the package uses a particular library instance when that
library instance file (INF) is updated.

When a library instance file (INF) is updated, PrEval will review each
package's DSC as described in the ci.yaml file to determine if the
package uses said library instance. If the package does use the library
instance, it will be built and tested to ensure the package is not
broken from the change.

Cc: Leif Lindholm <quic_llindhol@quicinc.com>
Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
Cc: Abner Chang <abner.chang@amd.com>
Cc: Daniel Schaefer <git@danielschaefer.me>
Signed-off-by: Joey Vagedes <joeyvagedes@gmail.com>
---
 EmbeddedPkg/EmbeddedPkg.ci.yaml | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/EmbeddedPkg/EmbeddedPkg.ci.yaml b/EmbeddedPkg/EmbeddedPkg.ci.yaml
index 21f30108a29f..96a60a6f8b4d 100644
--- a/EmbeddedPkg/EmbeddedPkg.ci.yaml
+++ b/EmbeddedPkg/EmbeddedPkg.ci.yaml
@@ -6,6 +6,9 @@
 # SPDX-License-Identifier: BSD-2-Clause-Patent
 ##
 {
+    "PrEval": {
+        "DscPath": "EmbeddedPkg.dsc",
+    },
     ## options defined .pytool/Plugin/LicenseCheck
     "LicenseCheck": {
         "IgnoreFiles": []
-- 
2.41.0.windows.1

[PATCH v1 10/24] FatPkg: CI: Add PrEval entry

[Joey Vagedes]

Adds a PrEval entry to the package's ci.yaml file which is used to
verify if the package uses a particular library instance when that
library instance file (INF) is updated.

When a library instance file (INF) is updated, PrEval will review each
package's DSC as described in the ci.yaml file to determine if the
package uses said library instance. If the package does use the library
instance, it will be built and tested to ensure the package is not
broken from the change.

Cc: Ray Ni <ray.ni@intel.com>
Signed-off-by: Joey Vagedes <joeyvagedes@gmail.com>
---
 FatPkg/FatPkg.ci.yaml | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/FatPkg/FatPkg.ci.yaml b/FatPkg/FatPkg.ci.yaml
index fe95f481b50c..afc29f7baa74 100644
--- a/FatPkg/FatPkg.ci.yaml
+++ b/FatPkg/FatPkg.ci.yaml
@@ -6,6 +6,9 @@
 # SPDX-License-Identifier: BSD-2-Clause-Patent
 ##
 {
+    "PrEval": {
+        "DscPath": "FatPkg.dsc",
+    },
     "LicenseCheck": {
         "IgnoreFiles": []
     },
-- 
2.41.0.windows.1

[PATCH v1 11/24] FmpDevicePkg: CI: Add PrEval entry

[Joey Vagedes]

Adds a PrEval entry to the package's ci.yaml file which is used to
verify if the package uses a particular library instance when that
library instance file (INF) is updated.

When a library instance file (INF) is updated, PrEval will review each
package's DSC as described in the ci.yaml file to determine if the
package uses said library instance. If the package does use the library
instance, it will be built and tested to ensure the package is not
broken from the change.

Cc: Liming Gao <gaoliming@byosoft.com.cn>
Cc: Michael D Kinney <michael.d.kinney@intel.com>
Cc: Guomin Jiang <guomin.jiang@intel.com>
Cc: Wei6 Xu <wei6.xu@intel.com>
Signed-off-by: Joey Vagedes <joeyvagedes@gmail.com>
---
 FmpDevicePkg/FmpDevicePkg.ci.yaml | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/FmpDevicePkg/FmpDevicePkg.ci.yaml b/FmpDevicePkg/FmpDevicePkg.ci.yaml
index 1b3e2187356d..1e687a53fa8f 100644
--- a/FmpDevicePkg/FmpDevicePkg.ci.yaml
+++ b/FmpDevicePkg/FmpDevicePkg.ci.yaml
@@ -6,6 +6,9 @@
 # SPDX-License-Identifier: BSD-2-Clause-Patent
 ##
 {
+    "PrEval": {
+        "DscPath": "FmpDevicePkg.dsc",
+    },
     "LicenseCheck": {
         "IgnoreFiles": []
     },
-- 
2.41.0.windows.1

[PATCH v1 12/24] IntelFsp2Pkg: CI: Add PrEval entry

[Joey Vagedes]

Adds a PrEval entry to the package's ci.yaml file which is used to
verify if the package uses a particular library instance when that
library instance file (INF) is updated.

When a library instance file (INF) is updated, PrEval will review each
package's DSC as described in the ci.yaml file to determine if the
package uses said library instance. If the package does use the library
instance, it will be built and tested to ensure the package is not
broken from the change.

Cc: Chasel Chiu <chasel.chiu@intel.com>
Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
Cc: Duggapu Chinni B <chinni.b.duggapu@intel.com>
Cc: Ray Han Lim Ng <ray.han.lim.ng@intel.com>
Cc: Star Zeng <star.zeng@intel.com>
Cc: Ted Kuo <ted.kuo@intel.com>
Cc: Ashraf Ali S <ashraf.ali.s@intel.com>
Cc: Susovan Mohapatra <susovan.mohapatra@intel.com>
Signed-off-by: Joey Vagedes <joeyvagedes@gmail.com>
---
 IntelFsp2Pkg/IntelFsp2Pkg.ci.yaml | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/IntelFsp2Pkg/IntelFsp2Pkg.ci.yaml b/IntelFsp2Pkg/IntelFsp2Pkg.ci.yaml
index 95d18cfcde1f..bd6f4cc961b0 100644
--- a/IntelFsp2Pkg/IntelFsp2Pkg.ci.yaml
+++ b/IntelFsp2Pkg/IntelFsp2Pkg.ci.yaml
@@ -6,6 +6,9 @@
 # SPDX-License-Identifier: BSD-2-Clause-Patent
 ##
 {
+    "PrEval": {
+        "DscPath": "IntelFsp2Pkg.dsc",
+    },
     ## options defined .pytool/Plugin/LicenseCheck
     "LicenseCheck": {
         "IgnoreFiles": []
-- 
2.41.0.windows.1

[PATCH v1 13/24] CryptoPkg: CI: Add PrEval entry

[Joey Vagedes]

Adds a PrEval entry to the package's ci.yaml file which is used to
verify if the package uses a particular library instance when that
library instance file (INF) is updated.

When a library instance file (INF) is updated, PrEval will review each
package's DSC as described in the ci.yaml file to determine if the
package uses said library instance. If the package does use the library
instance, it will be built and tested to ensure the package is not
broken from the change.

Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
Cc: Sami Mujawar <sami.mujawar@arm.com>
Cc: Ray Ni <ray.ni@intel.com>
Signed-off-by: Joey Vagedes <joeyvagedes@gmail.com>
---
 StandaloneMmPkg/StandaloneMmPkg.ci.yaml | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/StandaloneMmPkg/StandaloneMmPkg.ci.yaml b/StandaloneMmPkg/StandaloneMmPkg.ci.yaml
index 4777532a7ede..f23f5f2c4db2 100644
--- a/StandaloneMmPkg/StandaloneMmPkg.ci.yaml
+++ b/StandaloneMmPkg/StandaloneMmPkg.ci.yaml
@@ -5,6 +5,9 @@
 #  SPDX-License-Identifier: BSD-2-Clause-Patent
 ##
 {
+    "PrEval": {
+        "DscPath": "StandaloneMmPkg.dsc",
+    },
     "EccCheck": {
         ## Exception sample looks like below:
         ## "ExceptionList": [
-- 
2.41.0.windows.1

[PATCH v1 14/24] SourceLevelDebugPkg: CI: Add PrEval entry

[Joey Vagedes]

Adds a PrEval entry to the package's ci.yaml file which is used to
verify if the package uses a particular library instance when that
library instance file (INF) is updated.

When a library instance file (INF) is updated, PrEval will review each
package's DSC as described in the ci.yaml file to determine if the
package uses said library instance. If the package does use the library
instance, it will be built and tested to ensure the package is not
broken from the change.

Cc: Hao A Wu <hao.a.wu@intel.com>
Signed-off-by: Joey Vagedes <joeyvagedes@gmail.com>
---
 SourceLevelDebugPkg/SourceLevelDebugPkg.ci.yaml | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/SourceLevelDebugPkg/SourceLevelDebugPkg.ci.yaml b/SourceLevelDebugPkg/SourceLevelDebugPkg.ci.yaml
index 8887a6d10bc5..0ddf60cd434c 100644
--- a/SourceLevelDebugPkg/SourceLevelDebugPkg.ci.yaml
+++ b/SourceLevelDebugPkg/SourceLevelDebugPkg.ci.yaml
@@ -6,6 +6,9 @@
 # SPDX-License-Identifier: BSD-2-Clause-Patent
 ##
 {
+    "PrEval": {
+        "DscPath": "SourceLevelDebugPkg.dsc",
+    },
     ## options defined .pytool/Plugin/LicenseCheck
     "LicenseCheck": {
         "IgnoreFiles": []
-- 
2.41.0.windows.1

[PATCH v1 15/24] SignedCapsulePkg: CI: Add PrEval entry

[Joey Vagedes]

Adds a PrEval entry to the package's ci.yaml file which is used to
verify if the package uses a particular library instance when that
library instance file (INF) is updated.

When a library instance file (INF) is updated, PrEval will review each
package's DSC as described in the ci.yaml file to determine if the
package uses said library instance. If the package does use the library
instance, it will be built and tested to ensure the package is not
broken from the change.

Cc: Hao A Wu <hao.a.wu@intel.com>
Signed-off-by: Joey Vagedes <joeyvagedes@gmail.com>
---
 SignedCapsulePkg/SignedCapsulePkg.ci.yaml | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/SignedCapsulePkg/SignedCapsulePkg.ci.yaml b/SignedCapsulePkg/SignedCapsulePkg.ci.yaml
index 5f48613bd79f..e25218f95987 100644
--- a/SignedCapsulePkg/SignedCapsulePkg.ci.yaml
+++ b/SignedCapsulePkg/SignedCapsulePkg.ci.yaml
@@ -6,6 +6,9 @@
 # SPDX-License-Identifier: BSD-2-Clause-Patent
 ##
 {
+    "PrEval": {
+        "DscPath": "SignedCapsulePkg.dsc",
+    },
     ## options defined .pytool/Plugin/LicenseCheck
     "LicenseCheck": {
         "IgnoreFiles": []
-- 
2.41.0.windows.1

[PATCH v1 16/24] ShellPkg: CI: Add PrEval entry

[Joey Vagedes]

Adds a PrEval entry to the package's ci.yaml file which is used to
verify if the package uses a particular library instance when that
library instance file (INF) is updated.

When a library instance file (INF) is updated, PrEval will review each
package's DSC as described in the ci.yaml file to determine if the
package uses said library instance. If the package does use the library
instance, it will be built and tested to ensure the package is not
broken from the change.

Cc: Zhichao Gao <zhichao.gao@intel.com>
Signed-off-by: Joey Vagedes <joeyvagedes@gmail.com>
---
 ShellPkg/ShellPkg.ci.yaml | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/ShellPkg/ShellPkg.ci.yaml b/ShellPkg/ShellPkg.ci.yaml
index e741402459e5..93b1940b590e 100644
--- a/ShellPkg/ShellPkg.ci.yaml
+++ b/ShellPkg/ShellPkg.ci.yaml
@@ -6,6 +6,9 @@
 # SPDX-License-Identifier: BSD-2-Clause-Patent
 ##
 {
+    "PrEval": {
+        "DscPath": "ShellPkg.dsc"
+    },
     "LicenseCheck": {
         "IgnoreFiles": []
     },
-- 
2.41.0.windows.1

[PATCH v1 17/24] SecurityPkg: CI: Add PrEval entry

[Joey Vagedes]

Adds a PrEval entry to the package's ci.yaml file which is used to
verify if the package uses a particular library instance when that
library instance file (INF) is updated.

When a library instance file (INF) is updated, PrEval will review each
package's DSC as described in the ci.yaml file to determine if the
package uses said library instance. If the package does use the library
instance, it will be built and tested to ensure the package is not
broken from the change.

Cc: Jiewen Yao <jiewen.yao@intel.com>
Cc: Jian J Wang <jian.j.wang@intel.com>
Signed-off-by: Joey Vagedes <joeyvagedes@gmail.com>
---
 SecurityPkg/SecurityPkg.ci.yaml | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/SecurityPkg/SecurityPkg.ci.yaml b/SecurityPkg/SecurityPkg.ci.yaml
index 2138b0a5e21b..0924e5082a57 100644
--- a/SecurityPkg/SecurityPkg.ci.yaml
+++ b/SecurityPkg/SecurityPkg.ci.yaml
@@ -6,6 +6,9 @@
 # SPDX-License-Identifier: BSD-2-Clause-Patent
 ##
 {
+    "PrEval": {
+        "DscPath": "SecurityPkg.dsc",
+    },
     "LicenseCheck": {
         "IgnoreFiles": []
     },
-- 
2.41.0.windows.1

[PATCH v1 18/24] RedfishPkg: CI: Add PrEval entry

[Joey Vagedes]

Adds a PrEval entry to the package's ci.yaml file which is used to
verify if the package uses a particular library instance when that
library instance file (INF) is updated.

When a library instance file (INF) is updated, PrEval will review each
package's DSC as described in the ci.yaml file to determine if the
package uses said library instance. If the package does use the library
instance, it will be built and tested to ensure the package is not
broken from the change.

Cc: Abner Chang <abner.chang@amd.com>
Cc: Nickle Wang <nicklew@nvidia.com>
Cc: Igor Kulchytskyy <igork@ami.com>
Signed-off-by: Joey Vagedes <joeyvagedes@gmail.com>
---
 RedfishPkg/RedfishPkg.ci.yaml | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/RedfishPkg/RedfishPkg.ci.yaml b/RedfishPkg/RedfishPkg.ci.yaml
index 96133f8c288d..69b6bf39f5ce 100644
--- a/RedfishPkg/RedfishPkg.ci.yaml
+++ b/RedfishPkg/RedfishPkg.ci.yaml
@@ -5,6 +5,9 @@
 # SPDX-License-Identifier: BSD-2-Clause-Patent
 ##
 {
+    "PrEval": {
+        "DscPath": "RedfishPkg.dsc",
+    },
     "LicenseCheck": {
         "IgnoreFiles": []
     },
-- 
2.41.0.windows.1

[PATCH v1 19/24] PrmPkg: CI: Add PrEval entry

[Joey Vagedes]

Adds a PrEval entry to the package's ci.yaml file which is used to
verify if the package uses a particular library instance when that
library instance file (INF) is updated.

When a library instance file (INF) is updated, PrEval will review each
package's DSC as described in the ci.yaml file to determine if the
package uses said library instance. If the package does use the library
instance, it will be built and tested to ensure the package is not
broken from the change.

Cc: Michael Kubacki <mikuback@linux.microsoft.com>
Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
Signed-off-by: Joey Vagedes <joeyvagedes@gmail.com>
---
 PrmPkg/PrmPkg.ci.yaml | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/PrmPkg/PrmPkg.ci.yaml b/PrmPkg/PrmPkg.ci.yaml
index 2d4d12815d6b..b4b5aad67fbd 100644
--- a/PrmPkg/PrmPkg.ci.yaml
+++ b/PrmPkg/PrmPkg.ci.yaml
@@ -5,6 +5,9 @@
 # SPDX-License-Identifier: BSD-2-Clause-Patent
 ##
 {
+    "PrEval": {
+        "DscPath": "PrmPkg.dsc",
+    },
     ## options defined .pytool/Plugin/LicenseCheck
     "LicenseCheck": {
         "IgnoreFiles": []
-- 
2.41.0.windows.1

[PATCH v1 20/24] PcAtChipsetPkg: CI: Add PrEval entry

[Joey Vagedes]

Adds a PrEval entry to the package's ci.yaml file which is used to
verify if the package uses a particular library instance when that
library instance file (INF) is updated.

When a library instance file (INF) is updated, PrEval will review each
package's DSC as described in the ci.yaml file to determine if the
package uses said library instance. If the package does use the library
instance, it will be built and tested to ensure the package is not
broken from the change.

Cc: Ray Ni <ray.ni@intel.com>
Signed-off-by: Joey Vagedes <joeyvagedes@gmail.com>
---
 PcAtChipsetPkg/PcAtChipsetPkg.ci.yaml | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/PcAtChipsetPkg/PcAtChipsetPkg.ci.yaml b/PcAtChipsetPkg/PcAtChipsetPkg.ci.yaml
index 61f3fd7b5074..278bb43969a4 100644
--- a/PcAtChipsetPkg/PcAtChipsetPkg.ci.yaml
+++ b/PcAtChipsetPkg/PcAtChipsetPkg.ci.yaml
@@ -6,6 +6,9 @@
 # SPDX-License-Identifier: BSD-2-Clause-Patent
 ##
 {
+    "PrEval": {
+        "DscPath": "PcAtChipsetPkg.dsc",
+    },
     ## options defined .pytool/Plugin/LicenseCheck
     "LicenseCheck": {
         "IgnoreFiles": []
-- 
2.41.0.windows.1

[PATCH v1 21/24] NetworkPkg: CI: Add PrEval entry

[Joey Vagedes]

Adds a PrEval entry to the package's ci.yaml file which is used to
verify if the package uses a particular library instance when that
library instance file (INF) is updated.

When a library instance file (INF) is updated, PrEval will review each
package's DSC as described in the ci.yaml file to determine if the
package uses said library instance. If the package does use the library
instance, it will be built and tested to ensure the package is not
broken from the change.

Cc: Maciej Rabeda <maciej.rabeda@linux.intel.com>
Cc: Siyuan Fu <siyuan.fu@intel.com>
Signed-off-by: Joey Vagedes <joeyvagedes@gmail.com>
---
 NetworkPkg/NetworkPkg.ci.yaml | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/NetworkPkg/NetworkPkg.ci.yaml b/NetworkPkg/NetworkPkg.ci.yaml
index 07dc7abd6938..c24d581ce553 100644
--- a/NetworkPkg/NetworkPkg.ci.yaml
+++ b/NetworkPkg/NetworkPkg.ci.yaml
@@ -7,6 +7,9 @@
 # SPDX-License-Identifier: BSD-2-Clause-Patent
 ##
 {
+    "PrEval": {
+        "DscPath": "NetworkPkg.dsc",
+    },
     "LicenseCheck": {
         "IgnoreFiles": []
     },
-- 
2.41.0.windows.1

[PATCH v1 22/24] MdePkg: CI: Add PrEval entry

[Joey Vagedes]

Adds a PrEval entry to the package's ci.yaml file which is used to
verify if the package uses a particular library instance when that
library instance file (INF) is updated.

When a library instance file (INF) is updated, PrEval will review each
package's DSC as described in the ci.yaml file to determine if the
package uses said library instance. If the package does use the library
instance, it will be built and tested to ensure the package is not
broken from the change.

Cc: Michael D Kinney <michael.d.kinney@intel.com>
Cc: Liming Gao <gaoliming@byosoft.com.cn>
Cc: Zhiguang Liu <zhiguang.liu@intel.com>
Signed-off-by: Joey Vagedes <joeyvagedes@gmail.com>
---
 MdePkg/MdePkg.ci.yaml | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/MdePkg/MdePkg.ci.yaml b/MdePkg/MdePkg.ci.yaml
index f024b48685ef..8d9c63b0e535 100644
--- a/MdePkg/MdePkg.ci.yaml
+++ b/MdePkg/MdePkg.ci.yaml
@@ -8,6 +8,9 @@
 # SPDX-License-Identifier: BSD-2-Clause-Patent
 ##
 {
+    "PrEval": {
+        "DscPath": "MdePkg.dsc",
+    },
     ## options defined .pytool/Plugin/LicenseCheck
     "LicenseCheck": {
         "IgnoreFiles": [
-- 
2.41.0.windows.1

[PATCH v1 23/24] MdeModulePkg: CI: Add PrEval entry

[Joey Vagedes]

Adds a PrEval entry to the package's ci.yaml file which is used to
verify if the package uses a particular library instance when that
library instance file (INF) is updated.

When a library instance file (INF) is updated, PrEval will review each
package's DSC as described in the ci.yaml file to determine if the
package uses said library instance. If the package does use the library
instance, it will be built and tested to ensure the package is not
broken from the change.

Cc: Jian J Wang <jian.j.wang@intel.com>
Cc: Liming Gao <gaoliming@byosoft.com.cn>
Signed-off-by: Joey Vagedes <joeyvagedes@gmail.com>
---
 MdeModulePkg/MdeModulePkg.ci.yaml | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/MdeModulePkg/MdeModulePkg.ci.yaml b/MdeModulePkg/MdeModulePkg.ci.yaml
index f69989087b4c..669f54e33c0d 100644
--- a/MdeModulePkg/MdeModulePkg.ci.yaml
+++ b/MdeModulePkg/MdeModulePkg.ci.yaml
@@ -7,6 +7,9 @@
 # SPDX-License-Identifier: BSD-2-Clause-Patent
 ##
 {
+    "PrEval": {
+        "DscPath": "MdeModulePkg.dsc",
+    },
     ## options defined .pytool/Plugin/LicenseCheck
     "LicenseCheck": {
         "IgnoreFiles": []
-- 
2.41.0.windows.1

[PATCH v1 24/24] IntelFsp2WrapperPkg: CI: Add PrEval entry

[Joey Vagedes]

Adds a PrEval entry to the package's ci.yaml file which is used to
verify if the package uses a particular library instance when that
library instance file (INF) is updated.

When a library instance file (INF) is updated, PrEval will review each
package's DSC as described in the ci.yaml file to determine if the
package uses said library instance. If the package does use the library
instance, it will be built and tested to ensure the package is not
broken from the change.

Cc: Chasel Chiu <chasel.chiu@intel.com>
Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
Cc: Duggapu Chinni B <chinni.b.duggapu@intel.com>
Cc: Chen Gang C <gang.c.chen@intel.com>
Cc: Star Zeng <star.zeng@intel.com>
Cc: Ted Kuo <ted.kuo@intel.com>
Cc: Ashraf Ali S <ashraf.ali.s@intel.com>
Cc: Susovan Mohapatra <susovan.mohapatra@intel.com>
Signed-off-by: Joey Vagedes <joeyvagedes@gmail.com>
---
 IntelFsp2WrapperPkg/IntelFsp2WrapperPkg.ci.yaml | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/IntelFsp2WrapperPkg/IntelFsp2WrapperPkg.ci.yaml b/IntelFsp2WrapperPkg/IntelFsp2WrapperPkg.ci.yaml
index 45cb5a7d6f32..2d32bc65b415 100644
--- a/IntelFsp2WrapperPkg/IntelFsp2WrapperPkg.ci.yaml
+++ b/IntelFsp2WrapperPkg/IntelFsp2WrapperPkg.ci.yaml
@@ -6,6 +6,9 @@
 # SPDX-License-Identifier: BSD-2-Clause-Patent
 ##
 {
+    "PrEval": {
+        "DscPath": "IntelFsp2WrapperPkg.dsc",
+    },
     ## options defined .pytool/Plugin/LicenseCheck
     "LicenseCheck": {
         "IgnoreFiles": []
-- 
2.41.0.windows.1

回复: [PATCH v1 00/24] Update Edk2-pytools to latest versions

[gaoliming]

Joey:
  So, this change is required for all package YAML. If yes, can PrEval be
auto set to the package dsc if only one DSC is in Package directory?

Thanks
Liming
> -----邮件原件-----
> 发件人: Joey Vagedes <joey.vagedes@gmail.com>
> 发送时间: 2023年6月27日 5:34
> 收件人: devel@edk2.groups.io
> 抄送: Abner Chang <abner.chang@amd.com>; Alexei Fedorov
> <Alexei.Fedorov@arm.com>; Ard Biesheuvel <ardb+tianocore@kernel.org>;
> Ashraf Ali S <ashraf.ali.s@intel.com>; Chasel Chiu
<chasel.chiu@intel.com>;
> Chen Gang C <gang.c.chen@intel.com>; Daniel Schaefer
> <git@danielschaefer.me>; Duggapu Chinni B <chinni.b.duggapu@intel.com>;
> Eric Dong <eric.dong@intel.com>; Gerd Hoffmann <kraxel@redhat.com>; Guo
> Dong <guo.dong@intel.com>; Guomin Jiang <guomin.jiang@intel.com>; Hao
> A Wu <hao.a.wu@intel.com>; Igor Kulchytskyy <igork@ami.com>; James Lu
> <james.lu@intel.com>; Jian J Wang <jian.j.wang@intel.com>; Jiewen Yao
> <jiewen.yao@intel.com>; Leif Lindholm <quic_llindhol@quicinc.com>; Liming
> Gao <gaoliming@byosoft.com.cn>; Maciej Rabeda
> <maciej.rabeda@linux.intel.com>; Michael D Kinney
> <michael.d.kinney@intel.com>; Michael Kubacki
> <mikuback@linux.microsoft.com>; Nate DeSimone
> <nathaniel.l.desimone@intel.com>; Nickle Wang <nicklew@nvidia.com>;
> Pierre Gondois <pierre.gondois@arm.com>; Rahul Kumar
> <rahul1.kumar@intel.com>; Ray Han Lim Ng <ray.han.lim.ng@intel.com>;
> Ray Ni <ray.ni@intel.com>; Sami Mujawar <sami.mujawar@arm.com>; Sean
> Brogan <sean.brogan@microsoft.com>; Sean Rhodes
> <sean@starlabs.systems>; Siyuan Fu <siyuan.fu@intel.com>; Star Zeng
> <star.zeng@intel.com>; Susovan Mohapatra
> <susovan.mohapatra@intel.com>; Ted Kuo <ted.kuo@intel.com>; Wei6 Xu
> <wei6.xu@intel.com>; Xiaoyu Lu <xiaoyu1.lu@intel.com>; Yi Li
> <yi1.li@intel.com>; Zhichao Gao <zhichao.gao@intel.com>; Zhiguang Liu
> <zhiguang.liu@intel.com>
> 主题: [PATCH v1 00/24] Update Edk2-pytools to latest versions
> 
> Updates Edk2-pytools to the latest versions, which introduces a new Policy
> for detecting which packages must be built given a set of changes. This
policy
> is used when a library class instance INF is changed. When this occurs, it
will
> review the PrEval:DscPath provided in the CI YAML file and determine if
the
> package uses the library instance or not. If it does, it will build and
test
> the package.
> 
> Due to these changes, each package must now include an entry in it's CI
> YAML
> file (PrEval:DscPath). If the package does not provide this entry, this
policy
> will be skipped, which could lead to a library instance breaking packages
> outside
> of it's parent package.
> 
> Cc: Abner Chang <abner.chang@amd.com>
> Cc: Alexei Fedorov <Alexei.Fedorov@arm.com>
> Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
> Cc: Ashraf Ali S <ashraf.ali.s@intel.com>
> Cc: Chasel Chiu <chasel.chiu@intel.com>
> Cc: Chen Gang C <gang.c.chen@intel.com>
> Cc: Daniel Schaefer <git@danielschaefer.me>
> Cc: Duggapu Chinni B <chinni.b.duggapu@intel.com>
> Cc: Eric Dong <eric.dong@intel.com>
> Cc: Gerd Hoffmann <kraxel@redhat.com>
> Cc: Guo Dong <guo.dong@intel.com>
> Cc: Guomin Jiang <guomin.jiang@intel.com>
> Cc: Hao A Wu <hao.a.wu@intel.com>
> Cc: Igor Kulchytskyy <igork@ami.com>
> Cc: James Lu <james.lu@intel.com>
> Cc: Jian J Wang <jian.j.wang@intel.com>
> Cc: Jiewen Yao <jiewen.yao@intel.com>
> Cc: Leif Lindholm <quic_llindhol@quicinc.com>
> Cc: Liming Gao <gaoliming@byosoft.com.cn>
> Cc: Maciej Rabeda <maciej.rabeda@linux.intel.com>
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> Cc: Michael Kubacki <mikuback@linux.microsoft.com>
> Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
> Cc: Nickle Wang <nicklew@nvidia.com>
> Cc: Pierre Gondois <pierre.gondois@arm.com>
> Cc: Rahul Kumar <rahul1.kumar@intel.com>
> Cc: Ray Han Lim Ng <ray.han.lim.ng@intel.com>
> Cc: Ray Ni <ray.ni@intel.com>
> Cc: Sami Mujawar <sami.mujawar@arm.com>
> Cc: Sean Brogan <sean.brogan@microsoft.com>
> Cc: Sean Rhodes <sean@starlabs.systems>
> Cc: Siyuan Fu <siyuan.fu@intel.com>
> Cc: Star Zeng <star.zeng@intel.com>
> Cc: Susovan Mohapatra <susovan.mohapatra@intel.com>
> Cc: Ted Kuo <ted.kuo@intel.com>
> Cc: Wei6 Xu <wei6.xu@intel.com>
> Cc: Xiaoyu Lu <xiaoyu1.lu@intel.com>
> Cc: Yi Li <yi1.li@intel.com>
> Cc: Zhichao Gao <zhichao.gao@intel.com>
> Cc: Zhiguang Liu <zhiguang.liu@intel.com>
> 
> Joey Vagedes (24):
>   Edk2: edk2-pytools: Update to latest versions
>   UnitTestFrameworkPkg: CI: Add PrEval entry
>   UefiPayloadPkg: CI: Add PrEval entry
>   ArmPkg: CI: Add PrEval entry
>   UefiCpuPkg: CI: Add PrEval entry
>   ArmPlatformPkg: CI: Add PrEval entry
>   CryptoPkg: CI: Add PrEval entry
>   DynamicTablesPkg: CI: Add PrEval entry
>   EmbeddedPkg: CI: Add PrEval entry
>   FatPkg: CI: Add PrEval entry
>   FmpDevicePkg: CI: Add PrEval entry
>   IntelFsp2Pkg: CI: Add PrEval entry
>   CryptoPkg: CI: Add PrEval entry
>   SourceLevelDebugPkg: CI: Add PrEval entry
>   SignedCapsulePkg: CI: Add PrEval entry
>   ShellPkg: CI: Add PrEval entry
>   SecurityPkg: CI: Add PrEval entry
>   RedfishPkg: CI: Add PrEval entry
>   PrmPkg: CI: Add PrEval entry
>   PcAtChipsetPkg: CI: Add PrEval entry
>   NetworkPkg: CI: Add PrEval entry
>   MdePkg: CI: Add PrEval entry
>   MdeModulePkg: CI: Add PrEval entry
>   IntelFsp2WrapperPkg: CI: Add PrEval entry
> 
>  ArmPkg/ArmPkg.ci.yaml                             | 3 +++
>  ArmPlatformPkg/ArmPlatformPkg.ci.yaml             | 3 +++
>  CryptoPkg/CryptoPkg.ci.yaml                       | 3 +++
>  DynamicTablesPkg/DynamicTablesPkg.ci.yaml         | 3 +++
>  EmbeddedPkg/EmbeddedPkg.ci.yaml                   | 3 +++
>  FatPkg/FatPkg.ci.yaml                             | 3 +++
>  FmpDevicePkg/FmpDevicePkg.ci.yaml                 | 3 +++
>  IntelFsp2Pkg/IntelFsp2Pkg.ci.yaml                 | 3 +++
>  IntelFsp2WrapperPkg/IntelFsp2WrapperPkg.ci.yaml   | 3 +++
>  MdeModulePkg/MdeModulePkg.ci.yaml                 | 3 +++
>  MdePkg/MdePkg.ci.yaml                             | 3 +++
>  NetworkPkg/NetworkPkg.ci.yaml                     | 3 +++
>  PcAtChipsetPkg/PcAtChipsetPkg.ci.yaml             | 3 +++
>  PrmPkg/PrmPkg.ci.yaml                             | 3 +++
>  RedfishPkg/RedfishPkg.ci.yaml                     | 3 +++
>  SecurityPkg/SecurityPkg.ci.yaml                   | 3 +++
>  ShellPkg/ShellPkg.ci.yaml                         | 3 +++
>  SignedCapsulePkg/SignedCapsulePkg.ci.yaml         | 3 +++
>  SourceLevelDebugPkg/SourceLevelDebugPkg.ci.yaml   | 3 +++
>  StandaloneMmPkg/StandaloneMmPkg.ci.yaml           | 3 +++
>  UefiCpuPkg/UefiCpuPkg.ci.yaml                     | 3 +++
>  UefiPayloadPkg/UefiPayloadPkg.ci.yaml             | 3 +++
>  UnitTestFrameworkPkg/UnitTestFrameworkPkg.ci.yaml | 3 +++
>  pip-requirements.txt                              | 4 ++--
>  24 files changed, 71 insertions(+), 2 deletions(-)
> 
> --
> 2.41.0.windows.1

Re: [PATCH v1 00/24] Update Edk2-pytools to latest versions

[Joey Vagedes]

[-- Attachment #1: Type: text/plain, Size: 8747 bytes --]

Yes this change is currently required to enable Policy 5 for a given
package. I'm tempted to move this patch series to individual patch series
so that I can merge individual changes as they are approved in a package.

We could try and set the dsc automatically as you suggested. It would be
preferred to trying to get this patch series pushed through on almost all
packages in edk2 :). However there are some issues I don't think we can
easily work around:

1. There exist very few packages that only have one dsc in them (for
various reasons, one of which is that most packages have a dsc for
testing... but others such as the ArmVirtPkg have many in general)
2. The target of this Policy is to catch changes in an INF and build all
packages that use the INF via the compiler plugin, however not all packages
utilize the compiler plugin (such as EmulatorPkg). Using  EmulatorPkg  as
an example, if Policy 5 catches that its dsc uses the changed INF, then CI
will pointlessly run for  EmulatorPkg. It is pointless because
EmulatorPkg's dsc will not be compiled, so even if there is a break in the
INF interface, it will not be caught for  EmulatorPkg, but all other CI
will run on an unchanged package, wasting time.
3. It can cause unexpected behavior for the package developer

Let me know your thoughts!
Joey


On Mon, Jun 26, 2023 at 6:00 PM gaoliming <gaoliming@byosoft.com.cn> wrote:

> Joey:
>   So, this change is required for all package YAML. If yes, can PrEval be
> auto set to the package dsc if only one DSC is in Package directory?
>
> Thanks
> Liming
> > -----邮件原件-----
> > 发件人: Joey Vagedes <joey.vagedes@gmail.com>
> > 发送时间: 2023年6月27日 5:34
> > 收件人: devel@edk2.groups.io
> > 抄送: Abner Chang <abner.chang@amd.com>; Alexei Fedorov
> > <Alexei.Fedorov@arm.com>; Ard Biesheuvel <ardb+tianocore@kernel.org>;
> > Ashraf Ali S <ashraf.ali.s@intel.com>; Chasel Chiu
> <chasel.chiu@intel.com>;
> > Chen Gang C <gang.c.chen@intel.com>; Daniel Schaefer
> > <git@danielschaefer.me>; Duggapu Chinni B <chinni.b.duggapu@intel.com>;
> > Eric Dong <eric.dong@intel.com>; Gerd Hoffmann <kraxel@redhat.com>; Guo
> > Dong <guo.dong@intel.com>; Guomin Jiang <guomin.jiang@intel.com>; Hao
> > A Wu <hao.a.wu@intel.com>; Igor Kulchytskyy <igork@ami.com>; James Lu
> > <james.lu@intel.com>; Jian J Wang <jian.j.wang@intel.com>; Jiewen Yao
> > <jiewen.yao@intel.com>; Leif Lindholm <quic_llindhol@quicinc.com>;
> Liming
> > Gao <gaoliming@byosoft.com.cn>; Maciej Rabeda
> > <maciej.rabeda@linux.intel.com>; Michael D Kinney
> > <michael.d.kinney@intel.com>; Michael Kubacki
> > <mikuback@linux.microsoft.com>; Nate DeSimone
> > <nathaniel.l.desimone@intel.com>; Nickle Wang <nicklew@nvidia.com>;
> > Pierre Gondois <pierre.gondois@arm.com>; Rahul Kumar
> > <rahul1.kumar@intel.com>; Ray Han Lim Ng <ray.han.lim.ng@intel.com>;
> > Ray Ni <ray.ni@intel.com>; Sami Mujawar <sami.mujawar@arm.com>; Sean
> > Brogan <sean.brogan@microsoft.com>; Sean Rhodes
> > <sean@starlabs.systems>; Siyuan Fu <siyuan.fu@intel.com>; Star Zeng
> > <star.zeng@intel.com>; Susovan Mohapatra
> > <susovan.mohapatra@intel.com>; Ted Kuo <ted.kuo@intel.com>; Wei6 Xu
> > <wei6.xu@intel.com>; Xiaoyu Lu <xiaoyu1.lu@intel.com>; Yi Li
> > <yi1.li@intel.com>; Zhichao Gao <zhichao.gao@intel.com>; Zhiguang Liu
> > <zhiguang.liu@intel.com>
> > 主题: [PATCH v1 00/24] Update Edk2-pytools to latest versions
> >
> > Updates Edk2-pytools to the latest versions, which introduces a new
> Policy
> > for detecting which packages must be built given a set of changes. This
> policy
> > is used when a library class instance INF is changed. When this occurs,
> it
> will
> > review the PrEval:DscPath provided in the CI YAML file and determine if
> the
> > package uses the library instance or not. If it does, it will build and
> test
> > the package.
> >
> > Due to these changes, each package must now include an entry in it's CI
> > YAML
> > file (PrEval:DscPath). If the package does not provide this entry, this
> policy
> > will be skipped, which could lead to a library instance breaking packages
> > outside
> > of it's parent package.
> >
> > Cc: Abner Chang <abner.chang@amd.com>
> > Cc: Alexei Fedorov <Alexei.Fedorov@arm.com>
> > Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
> > Cc: Ashraf Ali S <ashraf.ali.s@intel.com>
> > Cc: Chasel Chiu <chasel.chiu@intel.com>
> > Cc: Chen Gang C <gang.c.chen@intel.com>
> > Cc: Daniel Schaefer <git@danielschaefer.me>
> > Cc: Duggapu Chinni B <chinni.b.duggapu@intel.com>
> > Cc: Eric Dong <eric.dong@intel.com>
> > Cc: Gerd Hoffmann <kraxel@redhat.com>
> > Cc: Guo Dong <guo.dong@intel.com>
> > Cc: Guomin Jiang <guomin.jiang@intel.com>
> > Cc: Hao A Wu <hao.a.wu@intel.com>
> > Cc: Igor Kulchytskyy <igork@ami.com>
> > Cc: James Lu <james.lu@intel.com>
> > Cc: Jian J Wang <jian.j.wang@intel.com>
> > Cc: Jiewen Yao <jiewen.yao@intel.com>
> > Cc: Leif Lindholm <quic_llindhol@quicinc.com>
> > Cc: Liming Gao <gaoliming@byosoft.com.cn>
> > Cc: Maciej Rabeda <maciej.rabeda@linux.intel.com>
> > Cc: Michael D Kinney <michael.d.kinney@intel.com>
> > Cc: Michael Kubacki <mikuback@linux.microsoft.com>
> > Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
> > Cc: Nickle Wang <nicklew@nvidia.com>
> > Cc: Pierre Gondois <pierre.gondois@arm.com>
> > Cc: Rahul Kumar <rahul1.kumar@intel.com>
> > Cc: Ray Han Lim Ng <ray.han.lim.ng@intel.com>
> > Cc: Ray Ni <ray.ni@intel.com>
> > Cc: Sami Mujawar <sami.mujawar@arm.com>
> > Cc: Sean Brogan <sean.brogan@microsoft.com>
> > Cc: Sean Rhodes <sean@starlabs.systems>
> > Cc: Siyuan Fu <siyuan.fu@intel.com>
> > Cc: Star Zeng <star.zeng@intel.com>
> > Cc: Susovan Mohapatra <susovan.mohapatra@intel.com>
> > Cc: Ted Kuo <ted.kuo@intel.com>
> > Cc: Wei6 Xu <wei6.xu@intel.com>
> > Cc: Xiaoyu Lu <xiaoyu1.lu@intel.com>
> > Cc: Yi Li <yi1.li@intel.com>
> > Cc: Zhichao Gao <zhichao.gao@intel.com>
> > Cc: Zhiguang Liu <zhiguang.liu@intel.com>
> >
> > Joey Vagedes (24):
> >   Edk2: edk2-pytools: Update to latest versions
> >   UnitTestFrameworkPkg: CI: Add PrEval entry
> >   UefiPayloadPkg: CI: Add PrEval entry
> >   ArmPkg: CI: Add PrEval entry
> >   UefiCpuPkg: CI: Add PrEval entry
> >   ArmPlatformPkg: CI: Add PrEval entry
> >   CryptoPkg: CI: Add PrEval entry
> >   DynamicTablesPkg: CI: Add PrEval entry
> >   EmbeddedPkg: CI: Add PrEval entry
> >   FatPkg: CI: Add PrEval entry
> >   FmpDevicePkg: CI: Add PrEval entry
> >   IntelFsp2Pkg: CI: Add PrEval entry
> >   CryptoPkg: CI: Add PrEval entry
> >   SourceLevelDebugPkg: CI: Add PrEval entry
> >   SignedCapsulePkg: CI: Add PrEval entry
> >   ShellPkg: CI: Add PrEval entry
> >   SecurityPkg: CI: Add PrEval entry
> >   RedfishPkg: CI: Add PrEval entry
> >   PrmPkg: CI: Add PrEval entry
> >   PcAtChipsetPkg: CI: Add PrEval entry
> >   NetworkPkg: CI: Add PrEval entry
> >   MdePkg: CI: Add PrEval entry
> >   MdeModulePkg: CI: Add PrEval entry
> >   IntelFsp2WrapperPkg: CI: Add PrEval entry
> >
> >  ArmPkg/ArmPkg.ci.yaml                             | 3 +++
> >  ArmPlatformPkg/ArmPlatformPkg.ci.yaml             | 3 +++
> >  CryptoPkg/CryptoPkg.ci.yaml                       | 3 +++
> >  DynamicTablesPkg/DynamicTablesPkg.ci.yaml         | 3 +++
> >  EmbeddedPkg/EmbeddedPkg.ci.yaml                   | 3 +++
> >  FatPkg/FatPkg.ci.yaml                             | 3 +++
> >  FmpDevicePkg/FmpDevicePkg.ci.yaml                 | 3 +++
> >  IntelFsp2Pkg/IntelFsp2Pkg.ci.yaml                 | 3 +++
> >  IntelFsp2WrapperPkg/IntelFsp2WrapperPkg.ci.yaml   | 3 +++
> >  MdeModulePkg/MdeModulePkg.ci.yaml                 | 3 +++
> >  MdePkg/MdePkg.ci.yaml                             | 3 +++
> >  NetworkPkg/NetworkPkg.ci.yaml                     | 3 +++
> >  PcAtChipsetPkg/PcAtChipsetPkg.ci.yaml             | 3 +++
> >  PrmPkg/PrmPkg.ci.yaml                             | 3 +++
> >  RedfishPkg/RedfishPkg.ci.yaml                     | 3 +++
> >  SecurityPkg/SecurityPkg.ci.yaml                   | 3 +++
> >  ShellPkg/ShellPkg.ci.yaml                         | 3 +++
> >  SignedCapsulePkg/SignedCapsulePkg.ci.yaml         | 3 +++
> >  SourceLevelDebugPkg/SourceLevelDebugPkg.ci.yaml   | 3 +++
> >  StandaloneMmPkg/StandaloneMmPkg.ci.yaml           | 3 +++
> >  UefiCpuPkg/UefiCpuPkg.ci.yaml                     | 3 +++
> >  UefiPayloadPkg/UefiPayloadPkg.ci.yaml             | 3 +++
> >  UnitTestFrameworkPkg/UnitTestFrameworkPkg.ci.yaml | 3 +++
> >  pip-requirements.txt                              | 4 ++--
> >  24 files changed, 71 insertions(+), 2 deletions(-)
> >
> > --
> > 2.41.0.windows.1
>
>
>
>

[-- Attachment #2: Type: text/html, Size: 15394 bytes --]

Re: [PATCH v1 09/24] EmbeddedPkg: CI: Add PrEval entry

[Chang, Abner]

[AMD Official Use Only - General]

Reviewed-by: Abner Chang <abner.chang@amd.com>

> -----Original Message-----
> From: Joey Vagedes <joey.vagedes@gmail.com>
> Sent: Tuesday, June 27, 2023 5:34 AM
> To: devel@edk2.groups.io
> Cc: Leif Lindholm <quic_llindhol@quicinc.com>; Ard Biesheuvel
> <ardb+tianocore@kernel.org>; Chang, Abner <Abner.Chang@amd.com>;
> Daniel Schaefer <git@danielschaefer.me>
> Subject: [PATCH v1 09/24] EmbeddedPkg: CI: Add PrEval entry
>
> Caution: This message originated from an External Source. Use proper caution
> when opening attachments, clicking links, or responding.
>
>
> Adds a PrEval entry to the package's ci.yaml file which is used to
> verify if the package uses a particular library instance when that
> library instance file (INF) is updated.
>
> When a library instance file (INF) is updated, PrEval will review each
> package's DSC as described in the ci.yaml file to determine if the
> package uses said library instance. If the package does use the library
> instance, it will be built and tested to ensure the package is not
> broken from the change.
>
> Cc: Leif Lindholm <quic_llindhol@quicinc.com>
> Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
> Cc: Abner Chang <abner.chang@amd.com>
> Cc: Daniel Schaefer <git@danielschaefer.me>
> Signed-off-by: Joey Vagedes <joeyvagedes@gmail.com>
> ---
>  EmbeddedPkg/EmbeddedPkg.ci.yaml | 3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/EmbeddedPkg/EmbeddedPkg.ci.yaml
> b/EmbeddedPkg/EmbeddedPkg.ci.yaml
> index 21f30108a29f..96a60a6f8b4d 100644
> --- a/EmbeddedPkg/EmbeddedPkg.ci.yaml
> +++ b/EmbeddedPkg/EmbeddedPkg.ci.yaml
> @@ -6,6 +6,9 @@
>  # SPDX-License-Identifier: BSD-2-Clause-Patent
>
>  ##
>
>  {
>
> +    "PrEval": {
>
> +        "DscPath": "EmbeddedPkg.dsc",
>
> +    },
>
>      ## options defined .pytool/Plugin/LicenseCheck
>
>      "LicenseCheck": {
>
>          "IgnoreFiles": []
>
> --
> 2.41.0.windows.1

Re: [PATCH v1 18/24] RedfishPkg: CI: Add PrEval entry

[Chang, Abner]

[AMD Official Use Only - General]

Reviewed-by: Abner Chang <abner.chang@amd.com>

> -----Original Message-----
> From: Joey Vagedes <joey.vagedes@gmail.com>
> Sent: Tuesday, June 27, 2023 5:34 AM
> To: devel@edk2.groups.io
> Cc: Chang, Abner <Abner.Chang@amd.com>; Nickle Wang
> <nicklew@nvidia.com>; Igor Kulchytskyy <igork@ami.com>
> Subject: [PATCH v1 18/24] RedfishPkg: CI: Add PrEval entry
>
> Caution: This message originated from an External Source. Use proper caution
> when opening attachments, clicking links, or responding.
>
>
> Adds a PrEval entry to the package's ci.yaml file which is used to
> verify if the package uses a particular library instance when that
> library instance file (INF) is updated.
>
> When a library instance file (INF) is updated, PrEval will review each
> package's DSC as described in the ci.yaml file to determine if the
> package uses said library instance. If the package does use the library
> instance, it will be built and tested to ensure the package is not
> broken from the change.
>
> Cc: Abner Chang <abner.chang@amd.com>
> Cc: Nickle Wang <nicklew@nvidia.com>
> Cc: Igor Kulchytskyy <igork@ami.com>
> Signed-off-by: Joey Vagedes <joeyvagedes@gmail.com>
> ---
>  RedfishPkg/RedfishPkg.ci.yaml | 3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/RedfishPkg/RedfishPkg.ci.yaml b/RedfishPkg/RedfishPkg.ci.yaml
> index 96133f8c288d..69b6bf39f5ce 100644
> --- a/RedfishPkg/RedfishPkg.ci.yaml
> +++ b/RedfishPkg/RedfishPkg.ci.yaml
> @@ -5,6 +5,9 @@
>  # SPDX-License-Identifier: BSD-2-Clause-Patent
>
>  ##
>
>  {
>
> +    "PrEval": {
>
> +        "DscPath": "RedfishPkg.dsc",
>
> +    },
>
>      "LicenseCheck": {
>
>          "IgnoreFiles": []
>
>      },
>
> --
> 2.41.0.windows.1

Re: [edk2-devel] 回复: [PATCH v1 00/24] Update Edk2-pytools to latest versions

[Sean]

Liming,


In general, due to feedback on this list we have tried to require 
explicit opt-in for all the stuart based validation tools.  So could 
that be done yes, but it goes against our current consistent approach of 
requiring opt-in and then would put the burden on a platform/package 
owner to opt-out if they didn't want this new functionality.


Thanks

Sean



On 6/26/2023 5:59 PM, gaoliming via groups.io wrote:
> Joey:
>    So, this change is required for all package YAML. If yes, can PrEval be
> auto set to the package dsc if only one DSC is in Package directory?

回复: [edk2-devel] 回复: [PATCH v1 00/24] Update Edk2-pytools to latest versions

[gaoliming]

Sean and Joey:
  Thanks for your detail information. Now, I understand the rule that require explicit opt-in for all the stuart based validation tools. I have no more comments for this patch set. 

Thanks
Liming
> -----邮件原件-----
> 发件人: devel@edk2.groups.io <devel@edk2.groups.io> 代表 Sean
> 发送时间: 2023年6月30日 2:01
> 收件人: devel@edk2.groups.io; gaoliming@byosoft.com.cn; 'Joey Vagedes'
> <joey.vagedes@gmail.com>
> 抄送: 'Abner Chang' <abner.chang@amd.com>; 'Alexei Fedorov'
> <Alexei.Fedorov@arm.com>; 'Ard Biesheuvel' <ardb+tianocore@kernel.org>;
> 'Ashraf Ali S' <ashraf.ali.s@intel.com>; 'Chasel Chiu' <chasel.chiu@intel.com>;
> 'Chen Gang C' <gang.c.chen@intel.com>; 'Daniel Schaefer'
> <git@danielschaefer.me>; 'Duggapu Chinni B' <chinni.b.duggapu@intel.com>;
> 'Eric Dong' <eric.dong@intel.com>; 'Gerd Hoffmann' <kraxel@redhat.com>;
> 'Guo Dong' <guo.dong@intel.com>; 'Guomin Jiang' <guomin.jiang@intel.com>;
> 'Hao A Wu' <hao.a.wu@intel.com>; 'Igor Kulchytskyy' <igork@ami.com>;
> 'James Lu' <james.lu@intel.com>; 'Jian J Wang' <jian.j.wang@intel.com>;
> 'Jiewen Yao' <jiewen.yao@intel.com>; 'Leif Lindholm'
> <quic_llindhol@quicinc.com>; 'Maciej Rabeda'
> <maciej.rabeda@linux.intel.com>; 'Michael D Kinney'
> <michael.d.kinney@intel.com>; 'Michael Kubacki'
> <mikuback@linux.microsoft.com>; 'Nate DeSimone'
> <nathaniel.l.desimone@intel.com>; 'Nickle Wang' <nicklew@nvidia.com>;
> 'Pierre Gondois' <pierre.gondois@arm.com>; 'Rahul Kumar'
> <rahul1.kumar@intel.com>; 'Ray Han Lim Ng' <ray.han.lim.ng@intel.com>;
> 'Ray Ni' <ray.ni@intel.com>; 'Sami Mujawar' <sami.mujawar@arm.com>;
> 'Sean Brogan' <sean.brogan@microsoft.com>; 'Sean Rhodes'
> <sean@starlabs.systems>; 'Siyuan Fu' <siyuan.fu@intel.com>; 'Star Zeng'
> <star.zeng@intel.com>; 'Susovan Mohapatra'
> <susovan.mohapatra@intel.com>; 'Ted Kuo' <ted.kuo@intel.com>; 'Wei6 Xu'
> <wei6.xu@intel.com>; 'Xiaoyu Lu' <xiaoyu1.lu@intel.com>; 'Yi Li'
> <yi1.li@intel.com>; 'Zhichao Gao' <zhichao.gao@intel.com>; 'Zhiguang Liu'
> <zhiguang.liu@intel.com>
> 主题: Re: [edk2-devel] 回复: [PATCH v1 00/24] Update Edk2-pytools to latest
> versions
> 
> Liming,
> 
> 
> In general, due to feedback on this list we have tried to require
> explicit opt-in for all the stuart based validation tools.  So could
> that be done yes, but it goes against our current consistent approach of
> requiring opt-in and then would put the burden on a platform/package
> owner to opt-out if they didn't want this new functionality.
> 
> 
> Thanks
> 
> Sean
> 
> 
> 
> On 6/26/2023 5:59 PM, gaoliming via groups.io wrote:
> > Joey:
> >    So, this change is required for all package YAML. If yes, can PrEval be
> > auto set to the package dsc if only one DSC is in Package directory?
> 
> 
> 
> 

Re: [PATCH v1 01/24] Edk2: edk2-pytools: Update to latest versions

[Michael Kubacki]

Reviewed-by: Michael Kubacki <michael.kubacki@microsoft.com>

On 6/26/2023 5:34 PM, Joey Vagedes wrote:
> Update to the latest versions of edk2-pytool-extensions and
> edk2-pytool-library. This introduces a new policy to stuart_pr_eval
> which, when a change in an INF occurs, will mark any associated DSC
> that uses this INF to be built during CI.
> 
> Cc: Sean Brogan <sean.brogan@microsoft.com>
> Cc: Michael Kubacki <mikuback@linux.microsoft.com>
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> Cc: Liming Gao <gaoliming@byosoft.com.cn>
> Signed-off-by: Joey Vagedes <joeyvagedes@gmail.com>
> ---
>   pip-requirements.txt | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/pip-requirements.txt b/pip-requirements.txt
> index c221576bef3a..ed7e430f1572 100644
> --- a/pip-requirements.txt
> +++ b/pip-requirements.txt
> @@ -12,8 +12,8 @@
>   # https://www.python.org/dev/peps/pep-0440/#version-specifiers
> 
>   ##
> 
>   
> 
> -edk2-pytool-library==0.14.1
> 
> -edk2-pytool-extensions~=0.23.2
> 
> +edk2-pytool-library==0.15.3
> 
> +edk2-pytool-extensions~=0.23.6
> 
>   edk2-basetools==0.1.48
> 
>   antlr4-python3-runtime==4.7.1
> 
>   lcov-cobertura==2.0.2
> 

Re: [edk2-devel] [PATCH v1 02/24] UnitTestFrameworkPkg: CI: Add PrEval entry

[Michael Kubacki]

Reviewed-by: Michael Kubacki <michael.kubacki@microsoft.com>

On 6/26/2023 5:34 PM, Joey Vagedes wrote:
> Adds a PrEval entry to the package's ci.yaml file which is used to
> verify if the package uses a particular library instance when that
> library instance file (INF) is updated.
> 
> When a library instance file (INF) is updated, PrEval will review each
> package's DSC as described in the ci.yaml file to determine if the
> package uses said library instance. If the package does use the library
> instance, it will be built and tested to ensure the package is not
> broken from the change.
> 
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> Cc: Michael Kubacki <mikuback@linux.microsoft.com>
> Cc: Sean Brogan <sean.brogan@microsoft.com>
> Signed-off-by: Joey Vagedes <joeyvagedes@gmail.com>
> ---
>   UnitTestFrameworkPkg/UnitTestFrameworkPkg.ci.yaml | 3 +++
>   1 file changed, 3 insertions(+)
> 
> diff --git a/UnitTestFrameworkPkg/UnitTestFrameworkPkg.ci.yaml b/UnitTestFrameworkPkg/UnitTestFrameworkPkg.ci.yaml
> index be839d1af0a7..40a396dd9f71 100644
> --- a/UnitTestFrameworkPkg/UnitTestFrameworkPkg.ci.yaml
> +++ b/UnitTestFrameworkPkg/UnitTestFrameworkPkg.ci.yaml
> @@ -5,6 +5,9 @@
>   # SPDX-License-Identifier: BSD-2-Clause-Patent
> 
>   ##
> 
>   {
> 
> +    "PrEval": {
> 
> +        "DscPath": "UnitTestFrameworkPkg.dsc",
> 
> +    },
> 
>       ## options defined .pytool/Plugin/LicenseCheck
> 
>       "LicenseCheck": {
> 
>           "IgnoreFiles": []
> 

Re: [edk2-devel] [PATCH v1 19/24] PrmPkg: CI: Add PrEval entry

[Michael Kubacki]

Reviewed-by: Michael Kubacki <michael.kubacki@microsoft.com>

On 6/26/2023 5:34 PM, Joey Vagedes wrote:
> Adds a PrEval entry to the package's ci.yaml file which is used to
> verify if the package uses a particular library instance when that
> library instance file (INF) is updated.
> 
> When a library instance file (INF) is updated, PrEval will review each
> package's DSC as described in the ci.yaml file to determine if the
> package uses said library instance. If the package does use the library
> instance, it will be built and tested to ensure the package is not
> broken from the change.
> 
> Cc: Michael Kubacki <mikuback@linux.microsoft.com>
> Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
> Signed-off-by: Joey Vagedes <joeyvagedes@gmail.com>
> ---
>   PrmPkg/PrmPkg.ci.yaml | 3 +++
>   1 file changed, 3 insertions(+)
> 
> diff --git a/PrmPkg/PrmPkg.ci.yaml b/PrmPkg/PrmPkg.ci.yaml
> index 2d4d12815d6b..b4b5aad67fbd 100644
> --- a/PrmPkg/PrmPkg.ci.yaml
> +++ b/PrmPkg/PrmPkg.ci.yaml
> @@ -5,6 +5,9 @@
>   # SPDX-License-Identifier: BSD-2-Clause-Patent
> 
>   ##
> 
>   {
> 
> +    "PrEval": {
> 
> +        "DscPath": "PrmPkg.dsc",
> 
> +    },
> 
>       ## options defined .pytool/Plugin/LicenseCheck
> 
>       "LicenseCheck": {
> 
>           "IgnoreFiles": []
> 

Re: [PATCH v1 00/24] Update Edk2-pytools to latest versions

[Joey Vagedes]

[-- Attachment #1: Type: text/plain, Size: 5567 bytes --]

Hello everyone,

Just following up on this patch series; looking for reviews from each
package owner. Just to reiterate, this patch series enables a new policy
for detecting which packages should be built for any given PR / Patch on
github. The policy is used when an INF is changed. It requires that any
package consuming that inf (generally a library instance) be built and
tested. I'm happy to help answer any questions!

Thanks,
Joey

On Mon, Jun 26, 2023 at 2:34 PM Joey Vagedes <joey.vagedes@gmail.com> wrote:

> Updates Edk2-pytools to the latest versions, which introduces a new Policy
> for detecting which packages must be built given a set of changes. This
> policy
> is used when a library class instance INF is changed. When this occurs, it
> will
> review the PrEval:DscPath provided in the CI YAML file and determine if the
> package uses the library instance or not. If it does, it will build and
> test
> the package.
>
> Due to these changes, each package must now include an entry in it's CI
> YAML
> file (PrEval:DscPath). If the package does not provide this entry, this
> policy
> will be skipped, which could lead to a library instance breaking packages
> outside
> of it's parent package.
>
> Cc: Abner Chang <abner.chang@amd.com>
> Cc: Alexei Fedorov <Alexei.Fedorov@arm.com>
> Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
> Cc: Ashraf Ali S <ashraf.ali.s@intel.com>
> Cc: Chasel Chiu <chasel.chiu@intel.com>
> Cc: Chen Gang C <gang.c.chen@intel.com>
> Cc: Daniel Schaefer <git@danielschaefer.me>
> Cc: Duggapu Chinni B <chinni.b.duggapu@intel.com>
> Cc: Eric Dong <eric.dong@intel.com>
> Cc: Gerd Hoffmann <kraxel@redhat.com>
> Cc: Guo Dong <guo.dong@intel.com>
> Cc: Guomin Jiang <guomin.jiang@intel.com>
> Cc: Hao A Wu <hao.a.wu@intel.com>
> Cc: Igor Kulchytskyy <igork@ami.com>
> Cc: James Lu <james.lu@intel.com>
> Cc: Jian J Wang <jian.j.wang@intel.com>
> Cc: Jiewen Yao <jiewen.yao@intel.com>
> Cc: Leif Lindholm <quic_llindhol@quicinc.com>
> Cc: Liming Gao <gaoliming@byosoft.com.cn>
> Cc: Maciej Rabeda <maciej.rabeda@linux.intel.com>
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> Cc: Michael Kubacki <mikuback@linux.microsoft.com>
> Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
> Cc: Nickle Wang <nicklew@nvidia.com>
> Cc: Pierre Gondois <pierre.gondois@arm.com>
> Cc: Rahul Kumar <rahul1.kumar@intel.com>
> Cc: Ray Han Lim Ng <ray.han.lim.ng@intel.com>
> Cc: Ray Ni <ray.ni@intel.com>
> Cc: Sami Mujawar <sami.mujawar@arm.com>
> Cc: Sean Brogan <sean.brogan@microsoft.com>
> Cc: Sean Rhodes <sean@starlabs.systems>
> Cc: Siyuan Fu <siyuan.fu@intel.com>
> Cc: Star Zeng <star.zeng@intel.com>
> Cc: Susovan Mohapatra <susovan.mohapatra@intel.com>
> Cc: Ted Kuo <ted.kuo@intel.com>
> Cc: Wei6 Xu <wei6.xu@intel.com>
> Cc: Xiaoyu Lu <xiaoyu1.lu@intel.com>
> Cc: Yi Li <yi1.li@intel.com>
> Cc: Zhichao Gao <zhichao.gao@intel.com>
> Cc: Zhiguang Liu <zhiguang.liu@intel.com>
>
> Joey Vagedes (24):
>   Edk2: edk2-pytools: Update to latest versions
>   UnitTestFrameworkPkg: CI: Add PrEval entry
>   UefiPayloadPkg: CI: Add PrEval entry
>   ArmPkg: CI: Add PrEval entry
>   UefiCpuPkg: CI: Add PrEval entry
>   ArmPlatformPkg: CI: Add PrEval entry
>   CryptoPkg: CI: Add PrEval entry
>   DynamicTablesPkg: CI: Add PrEval entry
>   EmbeddedPkg: CI: Add PrEval entry
>   FatPkg: CI: Add PrEval entry
>   FmpDevicePkg: CI: Add PrEval entry
>   IntelFsp2Pkg: CI: Add PrEval entry
>   CryptoPkg: CI: Add PrEval entry
>   SourceLevelDebugPkg: CI: Add PrEval entry
>   SignedCapsulePkg: CI: Add PrEval entry
>   ShellPkg: CI: Add PrEval entry
>   SecurityPkg: CI: Add PrEval entry
>   RedfishPkg: CI: Add PrEval entry
>   PrmPkg: CI: Add PrEval entry
>   PcAtChipsetPkg: CI: Add PrEval entry
>   NetworkPkg: CI: Add PrEval entry
>   MdePkg: CI: Add PrEval entry
>   MdeModulePkg: CI: Add PrEval entry
>   IntelFsp2WrapperPkg: CI: Add PrEval entry
>
>  ArmPkg/ArmPkg.ci.yaml                             | 3 +++
>  ArmPlatformPkg/ArmPlatformPkg.ci.yaml             | 3 +++
>  CryptoPkg/CryptoPkg.ci.yaml                       | 3 +++
>  DynamicTablesPkg/DynamicTablesPkg.ci.yaml         | 3 +++
>  EmbeddedPkg/EmbeddedPkg.ci.yaml                   | 3 +++
>  FatPkg/FatPkg.ci.yaml                             | 3 +++
>  FmpDevicePkg/FmpDevicePkg.ci.yaml                 | 3 +++
>  IntelFsp2Pkg/IntelFsp2Pkg.ci.yaml                 | 3 +++
>  IntelFsp2WrapperPkg/IntelFsp2WrapperPkg.ci.yaml   | 3 +++
>  MdeModulePkg/MdeModulePkg.ci.yaml                 | 3 +++
>  MdePkg/MdePkg.ci.yaml                             | 3 +++
>  NetworkPkg/NetworkPkg.ci.yaml                     | 3 +++
>  PcAtChipsetPkg/PcAtChipsetPkg.ci.yaml             | 3 +++
>  PrmPkg/PrmPkg.ci.yaml                             | 3 +++
>  RedfishPkg/RedfishPkg.ci.yaml                     | 3 +++
>  SecurityPkg/SecurityPkg.ci.yaml                   | 3 +++
>  ShellPkg/ShellPkg.ci.yaml                         | 3 +++
>  SignedCapsulePkg/SignedCapsulePkg.ci.yaml         | 3 +++
>  SourceLevelDebugPkg/SourceLevelDebugPkg.ci.yaml   | 3 +++
>  StandaloneMmPkg/StandaloneMmPkg.ci.yaml           | 3 +++
>  UefiCpuPkg/UefiCpuPkg.ci.yaml                     | 3 +++
>  UefiPayloadPkg/UefiPayloadPkg.ci.yaml             | 3 +++
>  UnitTestFrameworkPkg/UnitTestFrameworkPkg.ci.yaml | 3 +++
>  pip-requirements.txt                              | 4 ++--
>  24 files changed, 71 insertions(+), 2 deletions(-)
>
> --
> 2.41.0.windows.1
>
>

[-- Attachment #2: Type: text/html, Size: 8932 bytes --]

Re: [PATCH v1 08/24] DynamicTablesPkg: CI: Add PrEval entry

[Sami Mujawar]

Hi Joey,

Thank you for this patch.

Reviewed-by: Sami Mujawar <sami.mujawar@arm.com>

Regards,

Sami Mujawar

On 26/06/2023, 22:35, "Joey Vagedes" <joey.vagedes@gmail.com <mailto:joey.vagedes@gmail.com>> wrote:


Adds a PrEval entry to the package's ci.yaml file which is used to
verify if the package uses a particular library instance when that
library instance file (INF) is updated.


When a library instance file (INF) is updated, PrEval will review each
package's DSC as described in the ci.yaml file to determine if the
package uses said library instance. If the package does use the library
instance, it will be built and tested to ensure the package is not
broken from the change.


Cc: Sami Mujawar <Sami.Mujawar@arm.com <mailto:Sami.Mujawar@arm.com>>
Cc: Alexei Fedorov <Alexei.Fedorov@arm.com <mailto:Alexei.Fedorov@arm.com>>
Cc: Pierre Gondois <pierre.gondois@arm.com <mailto:pierre.gondois@arm.com>>
Signed-off-by: Joey Vagedes <joeyvagedes@gmail.com <mailto:joeyvagedes@gmail.com>>
---
DynamicTablesPkg/DynamicTablesPkg.ci.yaml | 3 +++
1 file changed, 3 insertions(+)


diff --git a/DynamicTablesPkg/DynamicTablesPkg.ci.yaml b/DynamicTablesPkg/DynamicTablesPkg.ci.yaml
index 5addf8626841..f37842f65246 100644
--- a/DynamicTablesPkg/DynamicTablesPkg.ci.yaml
+++ b/DynamicTablesPkg/DynamicTablesPkg.ci.yaml
@@ -5,6 +5,9 @@
# SPDX-License-Identifier: BSD-2-Clause-Patent


##


{


+ "PrEval": {


+ "DscPath": "DynamicTablesPkg.dsc",


+ },


"EccCheck": {


## Exception sample looks like below:


## "ExceptionList": [


-- 
2.41.0.windows.1

Re: [edk2-devel] [PATCH v1 00/24] Update Edk2-pytools to latest versions

[Joey Vagedes via groups.io]

[-- Attachment #1: Type: text/plain, Size: 7093 bytes --]

Hello everyone, I'm still looking for reviews for this change. Please
remember this has no effect on the package itself, rather it adds
additional helps to ensure your package is tested when necessary. The
particular situation this change now catches is when a library instance
(INF) from outside your package changes and your package consumes that
library instance. When this situation occurs, your package will also be
built as a part of CI, ensuring other package changes don't break your
package in a build breaking way.

I still need reviews from the following packages:
- UefiPayloadPkg
- ArmPkg
- UefiCpuPkg
- ArmPlatformPkg
- CryptoPkg
- FatPkg
- FmpDevicePkg
- IntelFsp2Pkg
- CryptoPkg
- SourceLevelDebugPkg
- SignedCapsulePkg
- ShellPkg
- SecurityPkg
- PcAtChipsetPkg
- NetworkPkg
- MdePkg
- MdeModulePkg
- IntelFsp2WrapperPkg

Thank you to those that have already reviewed!

Thanks,
Joey

On Thu, Jul 6, 2023 at 8:22 AM Joey Vagedes <joey.vagedes@gmail.com> wrote:

> Hello everyone,
>
> Just following up on this patch series; looking for reviews from each
> package owner. Just to reiterate, this patch series enables a new policy
> for detecting which packages should be built for any given PR / Patch on
> github. The policy is used when an INF is changed. It requires that any
> package consuming that inf (generally a library instance) be built and
> tested. I'm happy to help answer any questions!
>
> Thanks,
> Joey
>
> On Mon, Jun 26, 2023 at 2:34 PM Joey Vagedes <joey.vagedes@gmail.com>
> wrote:
>
>> Updates Edk2-pytools to the latest versions, which introduces a new Policy
>> for detecting which packages must be built given a set of changes. This
>> policy
>> is used when a library class instance INF is changed. When this occurs,
>> it will
>> review the PrEval:DscPath provided in the CI YAML file and determine if
>> the
>> package uses the library instance or not. If it does, it will build and
>> test
>> the package.
>>
>> Due to these changes, each package must now include an entry in it's CI
>> YAML
>> file (PrEval:DscPath). If the package does not provide this entry, this
>> policy
>> will be skipped, which could lead to a library instance breaking packages
>> outside
>> of it's parent package.
>>
>> Cc: Abner Chang <abner.chang@amd.com>
>> Cc: Alexei Fedorov <Alexei.Fedorov@arm.com>
>> Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
>> Cc: Ashraf Ali S <ashraf.ali.s@intel.com>
>> Cc: Chasel Chiu <chasel.chiu@intel.com>
>> Cc: Chen Gang C <gang.c.chen@intel.com>
>> Cc: Daniel Schaefer <git@danielschaefer.me>
>> Cc: Duggapu Chinni B <chinni.b.duggapu@intel.com>
>> Cc: Eric Dong <eric.dong@intel.com>
>> Cc: Gerd Hoffmann <kraxel@redhat.com>
>> Cc: Guo Dong <guo.dong@intel.com>
>> Cc: Guomin Jiang <guomin.jiang@intel.com>
>> Cc: Hao A Wu <hao.a.wu@intel.com>
>> Cc: Igor Kulchytskyy <igork@ami.com>
>> Cc: James Lu <james.lu@intel.com>
>> Cc: Jian J Wang <jian.j.wang@intel.com>
>> Cc: Jiewen Yao <jiewen.yao@intel.com>
>> Cc: Leif Lindholm <quic_llindhol@quicinc.com>
>> Cc: Liming Gao <gaoliming@byosoft.com.cn>
>> Cc: Maciej Rabeda <maciej.rabeda@linux.intel.com>
>> Cc: Michael D Kinney <michael.d.kinney@intel.com>
>> Cc: Michael Kubacki <mikuback@linux.microsoft.com>
>> Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
>> Cc: Nickle Wang <nicklew@nvidia.com>
>> Cc: Pierre Gondois <pierre.gondois@arm.com>
>> Cc: Rahul Kumar <rahul1.kumar@intel.com>
>> Cc: Ray Han Lim Ng <ray.han.lim.ng@intel.com>
>> Cc: Ray Ni <ray.ni@intel.com>
>> Cc: Sami Mujawar <sami.mujawar@arm.com>
>> Cc: Sean Brogan <sean.brogan@microsoft.com>
>> Cc: Sean Rhodes <sean@starlabs.systems>
>> Cc: Siyuan Fu <siyuan.fu@intel.com>
>> Cc: Star Zeng <star.zeng@intel.com>
>> Cc: Susovan Mohapatra <susovan.mohapatra@intel.com>
>> Cc: Ted Kuo <ted.kuo@intel.com>
>> Cc: Wei6 Xu <wei6.xu@intel.com>
>> Cc: Xiaoyu Lu <xiaoyu1.lu@intel.com>
>> Cc: Yi Li <yi1.li@intel.com>
>> Cc: Zhichao Gao <zhichao.gao@intel.com>
>> Cc: Zhiguang Liu <zhiguang.liu@intel.com>
>>
>> Joey Vagedes (24):
>>   Edk2: edk2-pytools: Update to latest versions
>>   UnitTestFrameworkPkg: CI: Add PrEval entry
>>   UefiPayloadPkg: CI: Add PrEval entry
>>   ArmPkg: CI: Add PrEval entry
>>   UefiCpuPkg: CI: Add PrEval entry
>>   ArmPlatformPkg: CI: Add PrEval entry
>>   CryptoPkg: CI: Add PrEval entry
>>   DynamicTablesPkg: CI: Add PrEval entry
>>   EmbeddedPkg: CI: Add PrEval entry
>>   FatPkg: CI: Add PrEval entry
>>   FmpDevicePkg: CI: Add PrEval entry
>>   IntelFsp2Pkg: CI: Add PrEval entry
>>   CryptoPkg: CI: Add PrEval entry
>>   SourceLevelDebugPkg: CI: Add PrEval entry
>>   SignedCapsulePkg: CI: Add PrEval entry
>>   ShellPkg: CI: Add PrEval entry
>>   SecurityPkg: CI: Add PrEval entry
>>   RedfishPkg: CI: Add PrEval entry
>>   PrmPkg: CI: Add PrEval entry
>>   PcAtChipsetPkg: CI: Add PrEval entry
>>   NetworkPkg: CI: Add PrEval entry
>>   MdePkg: CI: Add PrEval entry
>>   MdeModulePkg: CI: Add PrEval entry
>>   IntelFsp2WrapperPkg: CI: Add PrEval entry
>>
>>  ArmPkg/ArmPkg.ci.yaml                             | 3 +++
>>  ArmPlatformPkg/ArmPlatformPkg.ci.yaml             | 3 +++
>>  CryptoPkg/CryptoPkg.ci.yaml                       | 3 +++
>>  DynamicTablesPkg/DynamicTablesPkg.ci.yaml         | 3 +++
>>  EmbeddedPkg/EmbeddedPkg.ci.yaml                   | 3 +++
>>  FatPkg/FatPkg.ci.yaml                             | 3 +++
>>  FmpDevicePkg/FmpDevicePkg.ci.yaml                 | 3 +++
>>  IntelFsp2Pkg/IntelFsp2Pkg.ci.yaml                 | 3 +++
>>  IntelFsp2WrapperPkg/IntelFsp2WrapperPkg.ci.yaml   | 3 +++
>>  MdeModulePkg/MdeModulePkg.ci.yaml                 | 3 +++
>>  MdePkg/MdePkg.ci.yaml                             | 3 +++
>>  NetworkPkg/NetworkPkg.ci.yaml                     | 3 +++
>>  PcAtChipsetPkg/PcAtChipsetPkg.ci.yaml             | 3 +++
>>  PrmPkg/PrmPkg.ci.yaml                             | 3 +++
>>  RedfishPkg/RedfishPkg.ci.yaml                     | 3 +++
>>  SecurityPkg/SecurityPkg.ci.yaml                   | 3 +++
>>  ShellPkg/ShellPkg.ci.yaml                         | 3 +++
>>  SignedCapsulePkg/SignedCapsulePkg.ci.yaml         | 3 +++
>>  SourceLevelDebugPkg/SourceLevelDebugPkg.ci.yaml   | 3 +++
>>  StandaloneMmPkg/StandaloneMmPkg.ci.yaml           | 3 +++
>>  UefiCpuPkg/UefiCpuPkg.ci.yaml                     | 3 +++
>>  UefiPayloadPkg/UefiPayloadPkg.ci.yaml             | 3 +++
>>  UnitTestFrameworkPkg/UnitTestFrameworkPkg.ci.yaml | 3 +++
>>  pip-requirements.txt                              | 4 ++--
>>  24 files changed, 71 insertions(+), 2 deletions(-)
>>
>> --
>> 2.41.0.windows.1
>>
>>


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#107430): https://edk2.groups.io/g/devel/message/107430
Mute This Topic: https://groups.io/mt/99798032/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-



[-- Attachment #2: Type: text/html, Size: 11334 bytes --]

[edk2-devel] 回复: [PATCH v1 00/24] Update Edk2-pytools to latest versions

[gaoliming via groups.io]

[-- Attachment #1: Type: text/plain, Size: 9943 bytes --]

Joey:

 For MdePkg, MdeModulePkg, FmpDevicePkg,  Reviewed-by: Liming Gao <gaoliming@byosoft.com.cn>

 

Thanks

Liming

发件人: Joey Vagedes <joey.vagedes@gmail.com> 
发送时间: 2023年8月2日 0:17
收件人: devel@edk2.groups.io
抄送: Alexei Fedorov <Alexei.Fedorov@arm.com>; Ard Biesheuvel <ardb+tianocore@kernel.org>; Ashraf Ali S <ashraf.ali.s@intel.com>; Chasel Chiu <chasel.chiu@intel.com>; Chen Gang C <gang.c.chen@intel.com>; Daniel Schaefer <git@danielschaefer.me>; Duggapu Chinni B <chinni.b.duggapu@intel.com>; Eric Dong <eric.dong@intel.com>; Gerd Hoffmann <kraxel@redhat.com>; Guo Dong <guo.dong@intel.com>; Guomin Jiang <guomin.jiang@intel.com>; Hao A Wu <hao.a.wu@intel.com>; Igor Kulchytskyy <igork@ami.com>; James Lu <james.lu@intel.com>; Jian J Wang <jian.j.wang@intel.com>; Jiewen Yao <jiewen.yao@intel.com>; Leif Lindholm <quic_llindhol@quicinc.com>; Liming Gao <gaoliming@byosoft.com.cn>; Maciej Rabeda <maciej.rabeda@linux.intel.com>; Michael D Kinney <michael.d.kinney@intel.com>; Michael Kubacki <mikuback@linux.microsoft.com>; Nate DeSimone <nathaniel.l.desimone@intel.com>; Nickle Wang <nicklew@nvidia.com>; Pierre Gondois <pierre.gondois@arm.com>; Rahul Kumar <rahul1.kumar@intel.com>; Ray Han Lim Ng <ray.han.lim.ng@intel.com>; Ray Ni <ray.ni@intel.com>; Sami Mujawar <sami.mujawar@arm.com>; Sean Brogan <sean.brogan@microsoft.com>; Sean Rhodes <sean@starlabs.systems>; Siyuan Fu <siyuan.fu@intel.com>; Star Zeng <star.zeng@intel.com>; Susovan Mohapatra <susovan.mohapatra@intel.com>; Ted Kuo <ted.kuo@intel.com>; Wei6 Xu <wei6.xu@intel.com>; Xiaoyu Lu <xiaoyu1.lu@intel.com>; Yi Li <yi1.li@intel.com>; Zhichao Gao <zhichao.gao@intel.com>; Zhiguang Liu <zhiguang.liu@intel.com>
主题: Re: [PATCH v1 00/24] Update Edk2-pytools to latest versions

 

Hello everyone, I'm still looking for reviews for this change. Please remember this has no effect on the package itself, rather it adds additional helps to ensure your package is tested when necessary. The particular situation this change now catches is when a library instance (INF) from outside your package changes and your package consumes that library instance. When this situation occurs, your package will also be built as a part of CI, ensuring other package changes don't break your package in a build breaking way.

 

I still need reviews from the following packages:
- UefiPayloadPkg

- ArmPkg

- UefiCpuPkg

- ArmPlatformPkg

- CryptoPkg

- FatPkg

- FmpDevicePkg

- IntelFsp2Pkg

- CryptoPkg

- SourceLevelDebugPkg

- SignedCapsulePkg

- ShellPkg

- SecurityPkg

- PcAtChipsetPkg

- NetworkPkg

- MdePkg

- MdeModulePkg

- IntelFsp2WrapperPkg

 

Thank you to those that have already reviewed!

 

Thanks,

Joey

 

On Thu, Jul 6, 2023 at 8:22 AM Joey Vagedes <joey.vagedes@gmail.com <mailto:joey.vagedes@gmail.com> > wrote:

Hello everyone,

 

Just following up on this patch series; looking for reviews from each package owner. Just to reiterate, this patch series enables a new policy for detecting which packages should be built for any given PR / Patch on github. The policy is used when an INF is changed. It requires that any package consuming that inf (generally a library instance) be built and tested. I'm happy to help answer any questions!

 

Thanks,

Joey

 

On Mon, Jun 26, 2023 at 2:34 PM Joey Vagedes <joey.vagedes@gmail.com <mailto:joey.vagedes@gmail.com> > wrote:

Updates Edk2-pytools to the latest versions, which introduces a new Policy
for detecting which packages must be built given a set of changes. This policy
is used when a library class instance INF is changed. When this occurs, it will
review the PrEval:DscPath provided in the CI YAML file and determine if the
package uses the library instance or not. If it does, it will build and test
the package.

Due to these changes, each package must now include an entry in it's CI YAML
file (PrEval:DscPath). If the package does not provide this entry, this policy
will be skipped, which could lead to a library instance breaking packages outside
of it's parent package.

Cc: Abner Chang <abner.chang@amd.com <mailto:abner.chang@amd.com> >
Cc: Alexei Fedorov <Alexei.Fedorov@arm.com <mailto:Alexei.Fedorov@arm.com> >
Cc: Ard Biesheuvel <ardb+tianocore@kernel.org <mailto:ardb%2Btianocore@kernel.org> >
Cc: Ashraf Ali S <ashraf.ali.s@intel.com <mailto:ashraf.ali.s@intel.com> >
Cc: Chasel Chiu <chasel.chiu@intel.com <mailto:chasel.chiu@intel.com> >
Cc: Chen Gang C <gang.c.chen@intel.com <mailto:gang.c.chen@intel.com> >
Cc: Daniel Schaefer <git@danielschaefer.me <mailto:git@danielschaefer.me> >
Cc: Duggapu Chinni B <chinni.b.duggapu@intel.com <mailto:chinni.b.duggapu@intel.com> >
Cc: Eric Dong <eric.dong@intel.com <mailto:eric.dong@intel.com> >
Cc: Gerd Hoffmann <kraxel@redhat.com <mailto:kraxel@redhat.com> >
Cc: Guo Dong <guo.dong@intel.com <mailto:guo.dong@intel.com> >
Cc: Guomin Jiang <guomin.jiang@intel.com <mailto:guomin.jiang@intel.com> >
Cc: Hao A Wu <hao.a.wu@intel.com <mailto:hao.a.wu@intel.com> >
Cc: Igor Kulchytskyy <igork@ami.com <mailto:igork@ami.com> >
Cc: James Lu <james.lu@intel.com <mailto:james.lu@intel.com> >
Cc: Jian J Wang <jian.j.wang@intel.com <mailto:jian.j.wang@intel.com> >
Cc: Jiewen Yao <jiewen.yao@intel.com <mailto:jiewen.yao@intel.com> >
Cc: Leif Lindholm <quic_llindhol@quicinc.com <mailto:quic_llindhol@quicinc.com> >
Cc: Liming Gao <gaoliming@byosoft.com.cn <mailto:gaoliming@byosoft.com.cn> >
Cc: Maciej Rabeda <maciej.rabeda@linux.intel.com <mailto:maciej.rabeda@linux.intel.com> >
Cc: Michael D Kinney <michael.d.kinney@intel.com <mailto:michael.d.kinney@intel.com> >
Cc: Michael Kubacki <mikuback@linux.microsoft.com <mailto:mikuback@linux.microsoft.com> >
Cc: Nate DeSimone <nathaniel.l.desimone@intel.com <mailto:nathaniel.l.desimone@intel.com> >
Cc: Nickle Wang <nicklew@nvidia.com <mailto:nicklew@nvidia.com> >
Cc: Pierre Gondois <pierre.gondois@arm.com <mailto:pierre.gondois@arm.com> >
Cc: Rahul Kumar <rahul1.kumar@intel.com <mailto:rahul1.kumar@intel.com> >
Cc: Ray Han Lim Ng <ray.han.lim.ng@intel.com <mailto:ray.han.lim.ng@intel.com> >
Cc: Ray Ni <ray.ni@intel.com <mailto:ray.ni@intel.com> >
Cc: Sami Mujawar <sami.mujawar@arm.com <mailto:sami.mujawar@arm.com> >
Cc: Sean Brogan <sean.brogan@microsoft.com <mailto:sean.brogan@microsoft.com> >
Cc: Sean Rhodes <sean@starlabs.systems <mailto:sean@starlabs.systems> >
Cc: Siyuan Fu <siyuan.fu@intel.com <mailto:siyuan.fu@intel.com> >
Cc: Star Zeng <star.zeng@intel.com <mailto:star.zeng@intel.com> >
Cc: Susovan Mohapatra <susovan.mohapatra@intel.com <mailto:susovan.mohapatra@intel.com> >
Cc: Ted Kuo <ted.kuo@intel.com <mailto:ted.kuo@intel.com> >
Cc: Wei6 Xu <wei6.xu@intel.com <mailto:wei6.xu@intel.com> >
Cc: Xiaoyu Lu <xiaoyu1.lu@intel.com <mailto:xiaoyu1.lu@intel.com> >
Cc: Yi Li <yi1.li@intel.com <mailto:yi1.li@intel.com> >
Cc: Zhichao Gao <zhichao.gao@intel.com <mailto:zhichao.gao@intel.com> >
Cc: Zhiguang Liu <zhiguang.liu@intel.com <mailto:zhiguang.liu@intel.com> >

Joey Vagedes (24):
  Edk2: edk2-pytools: Update to latest versions
  UnitTestFrameworkPkg: CI: Add PrEval entry
  UefiPayloadPkg: CI: Add PrEval entry
  ArmPkg: CI: Add PrEval entry
  UefiCpuPkg: CI: Add PrEval entry
  ArmPlatformPkg: CI: Add PrEval entry
  CryptoPkg: CI: Add PrEval entry
  DynamicTablesPkg: CI: Add PrEval entry
  EmbeddedPkg: CI: Add PrEval entry
  FatPkg: CI: Add PrEval entry
  FmpDevicePkg: CI: Add PrEval entry
  IntelFsp2Pkg: CI: Add PrEval entry
  CryptoPkg: CI: Add PrEval entry
  SourceLevelDebugPkg: CI: Add PrEval entry
  SignedCapsulePkg: CI: Add PrEval entry
  ShellPkg: CI: Add PrEval entry
  SecurityPkg: CI: Add PrEval entry
  RedfishPkg: CI: Add PrEval entry
  PrmPkg: CI: Add PrEval entry
  PcAtChipsetPkg: CI: Add PrEval entry
  NetworkPkg: CI: Add PrEval entry
  MdePkg: CI: Add PrEval entry
  MdeModulePkg: CI: Add PrEval entry
  IntelFsp2WrapperPkg: CI: Add PrEval entry

 ArmPkg/ArmPkg.ci.yaml                             | 3 +++
 ArmPlatformPkg/ArmPlatformPkg.ci.yaml             | 3 +++
 CryptoPkg/CryptoPkg.ci.yaml                       | 3 +++
 DynamicTablesPkg/DynamicTablesPkg.ci.yaml         | 3 +++
 EmbeddedPkg/EmbeddedPkg.ci.yaml                   | 3 +++
 FatPkg/FatPkg.ci.yaml                             | 3 +++
 FmpDevicePkg/FmpDevicePkg.ci.yaml                 | 3 +++
 IntelFsp2Pkg/IntelFsp2Pkg.ci.yaml                 | 3 +++
 IntelFsp2WrapperPkg/IntelFsp2WrapperPkg.ci.yaml   | 3 +++
 MdeModulePkg/MdeModulePkg.ci.yaml                 | 3 +++
 MdePkg/MdePkg.ci.yaml                             | 3 +++
 NetworkPkg/NetworkPkg.ci.yaml                     | 3 +++
 PcAtChipsetPkg/PcAtChipsetPkg.ci.yaml             | 3 +++
 PrmPkg/PrmPkg.ci.yaml                             | 3 +++
 RedfishPkg/RedfishPkg.ci.yaml                     | 3 +++
 SecurityPkg/SecurityPkg.ci.yaml                   | 3 +++
 ShellPkg/ShellPkg.ci.yaml                         | 3 +++
 SignedCapsulePkg/SignedCapsulePkg.ci.yaml         | 3 +++
 SourceLevelDebugPkg/SourceLevelDebugPkg.ci.yaml   | 3 +++
 StandaloneMmPkg/StandaloneMmPkg.ci.yaml           | 3 +++
 UefiCpuPkg/UefiCpuPkg.ci.yaml                     | 3 +++
 UefiPayloadPkg/UefiPayloadPkg.ci.yaml             | 3 +++
 UnitTestFrameworkPkg/UnitTestFrameworkPkg.ci.yaml | 3 +++
 pip-requirements.txt                              | 4 ++--
 24 files changed, 71 insertions(+), 2 deletions(-)

-- 
2.41.0.windows.1



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#107440): https://edk2.groups.io/g/devel/message/107440
Mute This Topic: https://groups.io/mt/100498733/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-



[-- Attachment #2: Type: text/html, Size: 19478 bytes --]

Re: [edk2-devel] [PATCH v1 07/24] CryptoPkg: CI: Add PrEval entry

[Li, Yi]

Looks good to me.
Reviewed-by: Yi Li <yi1.li@intel.com>

-----Original Message-----
From: Joey Vagedes <joey.vagedes@gmail.com> 
Sent: Tuesday, June 27, 2023 5:34 AM
To: devel@edk2.groups.io
Cc: Yao, Jiewen <jiewen.yao@intel.com>; Li, Yi1 <yi1.li@intel.com>; Lu, Xiaoyu1 <xiaoyu1.lu@intel.com>; Jiang, Guomin <guomin.jiang@intel.com>
Subject: [PATCH v1 07/24] CryptoPkg: CI: Add PrEval entry

Adds a PrEval entry to the package's ci.yaml file which is used to verify if the package uses a particular library instance when that library instance file (INF) is updated.

When a library instance file (INF) is updated, PrEval will review each package's DSC as described in the ci.yaml file to determine if the package uses said library instance. If the package does use the library instance, it will be built and tested to ensure the package is not broken from the change.

Cc: Jiewen Yao <jiewen.yao@intel.com>
Cc: Yi Li <yi1.li@intel.com>
Cc: Xiaoyu Lu <xiaoyu1.lu@intel.com>
Cc: Guomin Jiang <guomin.jiang@intel.com>
Signed-off-by: Joey Vagedes <joeyvagedes@gmail.com>
---
 CryptoPkg/CryptoPkg.ci.yaml | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/CryptoPkg/CryptoPkg.ci.yaml b/CryptoPkg/CryptoPkg.ci.yaml index 47f29759676d..4cec206477bc 100644
--- a/CryptoPkg/CryptoPkg.ci.yaml
+++ b/CryptoPkg/CryptoPkg.ci.yaml
@@ -6,6 +6,9 @@
 # SPDX-License-Identifier: BSD-2-Clause-Patent ## {+    "PrEval": {+        "DscPath": "CryptoPkg.dsc",+    },     "LicenseCheck": {         "IgnoreFiles": [             # These directories contain auto-generated OpenSSL content-- 
2.41.0.windows.1



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#107445): https://edk2.groups.io/g/devel/message/107445
Mute This Topic: https://groups.io/mt/99798040/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH v1 12/24] IntelFsp2Pkg: CI: Add PrEval entry

[Nate DeSimone]

Reviewed-by: Nate DeSimone <nathaniel.l.desimone@intel.com>

> -----Original Message-----
> From: Joey Vagedes <joey.vagedes@gmail.com>
> Sent: Monday, June 26, 2023 2:34 PM
> To: devel@edk2.groups.io
> Cc: Chiu, Chasel <chasel.chiu@intel.com>; Desimone, Nathaniel L
> <nathaniel.l.desimone@intel.com>; Duggapu, Chinni B
> <chinni.b.duggapu@intel.com>; Ng, Ray Han Lim <ray.han.lim.ng@intel.com>;
> Zeng, Star <star.zeng@intel.com>; Kuo, Ted <ted.kuo@intel.com>; S, Ashraf
> Ali <ashraf.ali.s@intel.com>; Mohapatra, Susovan
> <susovan.mohapatra@intel.com>
> Subject: [PATCH v1 12/24] IntelFsp2Pkg: CI: Add PrEval entry
> 
> Adds a PrEval entry to the package's ci.yaml file which is used to
> verify if the package uses a particular library instance when that
> library instance file (INF) is updated.
> 
> When a library instance file (INF) is updated, PrEval will review each
> package's DSC as described in the ci.yaml file to determine if the
> package uses said library instance. If the package does use the library
> instance, it will be built and tested to ensure the package is not
> broken from the change.
> 
> Cc: Chasel Chiu <chasel.chiu@intel.com>
> Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
> Cc: Duggapu Chinni B <chinni.b.duggapu@intel.com>
> Cc: Ray Han Lim Ng <ray.han.lim.ng@intel.com>
> Cc: Star Zeng <star.zeng@intel.com>
> Cc: Ted Kuo <ted.kuo@intel.com>
> Cc: Ashraf Ali S <ashraf.ali.s@intel.com>
> Cc: Susovan Mohapatra <susovan.mohapatra@intel.com>
> Signed-off-by: Joey Vagedes <joeyvagedes@gmail.com>
> ---
>  IntelFsp2Pkg/IntelFsp2Pkg.ci.yaml | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/IntelFsp2Pkg/IntelFsp2Pkg.ci.yaml
> b/IntelFsp2Pkg/IntelFsp2Pkg.ci.yaml
> index 95d18cfcde1f..bd6f4cc961b0 100644
> --- a/IntelFsp2Pkg/IntelFsp2Pkg.ci.yaml
> +++ b/IntelFsp2Pkg/IntelFsp2Pkg.ci.yaml
> @@ -6,6 +6,9 @@
>  # SPDX-License-Identifier: BSD-2-Clause-Patent
>  ##
>  {
> +    "PrEval": {
> +        "DscPath": "IntelFsp2Pkg.dsc",
> +    },
>      ## options defined .pytool/Plugin/LicenseCheck
>      "LicenseCheck": {
>          "IgnoreFiles": []
> --
> 2.41.0.windows.1



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#107622): https://edk2.groups.io/g/devel/message/107622
Mute This Topic: https://groups.io/mt/99798045/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH v1 19/24] PrmPkg: CI: Add PrEval entry

[Nate DeSimone]

Reviewed-by: Nate DeSimone <nathaniel.l.desimone@intel.com>

> -----Original Message-----
> From: Joey Vagedes <joey.vagedes@gmail.com>
> Sent: Monday, June 26, 2023 2:34 PM
> To: devel@edk2.groups.io
> Cc: Michael Kubacki <mikuback@linux.microsoft.com>; Desimone, Nathaniel L
> <nathaniel.l.desimone@intel.com>
> Subject: [PATCH v1 19/24] PrmPkg: CI: Add PrEval entry
> 
> Adds a PrEval entry to the package's ci.yaml file which is used to
> verify if the package uses a particular library instance when that
> library instance file (INF) is updated.
> 
> When a library instance file (INF) is updated, PrEval will review each
> package's DSC as described in the ci.yaml file to determine if the
> package uses said library instance. If the package does use the library
> instance, it will be built and tested to ensure the package is not
> broken from the change.
> 
> Cc: Michael Kubacki <mikuback@linux.microsoft.com>
> Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
> Signed-off-by: Joey Vagedes <joeyvagedes@gmail.com>
> ---
>  PrmPkg/PrmPkg.ci.yaml | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/PrmPkg/PrmPkg.ci.yaml b/PrmPkg/PrmPkg.ci.yaml
> index 2d4d12815d6b..b4b5aad67fbd 100644
> --- a/PrmPkg/PrmPkg.ci.yaml
> +++ b/PrmPkg/PrmPkg.ci.yaml
> @@ -5,6 +5,9 @@
>  # SPDX-License-Identifier: BSD-2-Clause-Patent
>  ##
>  {
> +    "PrEval": {
> +        "DscPath": "PrmPkg.dsc",
> +    },
>      ## options defined .pytool/Plugin/LicenseCheck
>      "LicenseCheck": {
>          "IgnoreFiles": []
> --
> 2.41.0.windows.1



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#107623): https://edk2.groups.io/g/devel/message/107623
Mute This Topic: https://groups.io/mt/99798053/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH v1 24/24] IntelFsp2WrapperPkg: CI: Add PrEval entry

[Nate DeSimone]

Reviewed-by: Nate DeSimone <nathaniel.l.desimone@intel.com>

> -----Original Message-----
> From: Joey Vagedes <joey.vagedes@gmail.com>
> Sent: Monday, June 26, 2023 2:35 PM
> To: devel@edk2.groups.io
> Cc: Chiu, Chasel <chasel.chiu@intel.com>; Desimone, Nathaniel L
> <nathaniel.l.desimone@intel.com>; Duggapu, Chinni B
> <chinni.b.duggapu@intel.com>; Chen, Gang C <gang.c.chen@intel.com>;
> Zeng, Star <star.zeng@intel.com>; Kuo, Ted <ted.kuo@intel.com>; S, Ashraf
> Ali <ashraf.ali.s@intel.com>; Mohapatra, Susovan
> <susovan.mohapatra@intel.com>
> Subject: [PATCH v1 24/24] IntelFsp2WrapperPkg: CI: Add PrEval entry
> 
> Adds a PrEval entry to the package's ci.yaml file which is used to
> verify if the package uses a particular library instance when that
> library instance file (INF) is updated.
> 
> When a library instance file (INF) is updated, PrEval will review each
> package's DSC as described in the ci.yaml file to determine if the
> package uses said library instance. If the package does use the library
> instance, it will be built and tested to ensure the package is not
> broken from the change.
> 
> Cc: Chasel Chiu <chasel.chiu@intel.com>
> Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
> Cc: Duggapu Chinni B <chinni.b.duggapu@intel.com>
> Cc: Chen Gang C <gang.c.chen@intel.com>
> Cc: Star Zeng <star.zeng@intel.com>
> Cc: Ted Kuo <ted.kuo@intel.com>
> Cc: Ashraf Ali S <ashraf.ali.s@intel.com>
> Cc: Susovan Mohapatra <susovan.mohapatra@intel.com>
> Signed-off-by: Joey Vagedes <joeyvagedes@gmail.com>
> ---
>  IntelFsp2WrapperPkg/IntelFsp2WrapperPkg.ci.yaml | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/IntelFsp2WrapperPkg/IntelFsp2WrapperPkg.ci.yaml
> b/IntelFsp2WrapperPkg/IntelFsp2WrapperPkg.ci.yaml
> index 45cb5a7d6f32..2d32bc65b415 100644
> --- a/IntelFsp2WrapperPkg/IntelFsp2WrapperPkg.ci.yaml
> +++ b/IntelFsp2WrapperPkg/IntelFsp2WrapperPkg.ci.yaml
> @@ -6,6 +6,9 @@
>  # SPDX-License-Identifier: BSD-2-Clause-Patent
>  ##
>  {
> +    "PrEval": {
> +        "DscPath": "IntelFsp2WrapperPkg.dsc",
> +    },
>      ## options defined .pytool/Plugin/LicenseCheck
>      "LicenseCheck": {
>          "IgnoreFiles": []
> --
> 2.41.0.windows.1



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#107624): https://edk2.groups.io/g/devel/message/107624
Mute This Topic: https://groups.io/mt/99798062/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH v1 00/24] Update Edk2-pytools to latest versions

[Joey Vagedes via groups.io]

[-- Attachment #1: Type: text/plain, Size: 7842 bytes --]

Hello everyone, Almost done! Following up on this patch series. I still
need reviews for the following packages:

Please see comments above as to why this will not affect the package,
except to ensure it is tested if another package changes a library INF your
package uses.

UefiPayloadPkg
ArmPkg
UefiCpuPkg
ArmPlatformPkg
CryptoPkg
FatPkg
SourceLevelDebugPkg
SignedCapsulePkg
ShellPkg
SecurityPkgPcAtChipsetPkg
NetworkPkg

Thanks,
Joey


On Tue, Aug 1, 2023 at 9:16 AM Joey Vagedes <joey.vagedes@gmail.com> wrote:

> Hello everyone, I'm still looking for reviews for this change. Please
> remember this has no effect on the package itself, rather it adds
> additional helps to ensure your package is tested when necessary. The
> particular situation this change now catches is when a library instance
> (INF) from outside your package changes and your package consumes that
> library instance. When this situation occurs, your package will also be
> built as a part of CI, ensuring other package changes don't break your
> package in a build breaking way.
>
> I still need reviews from the following packages:
> - UefiPayloadPkg
> - ArmPkg
> - UefiCpuPkg
> - ArmPlatformPkg
> - CryptoPkg
> - FatPkg
> - FmpDevicePkg
> - IntelFsp2Pkg
> - CryptoPkg
> - SourceLevelDebugPkg
> - SignedCapsulePkg
> - ShellPkg
> - SecurityPkg
> - PcAtChipsetPkg
> - NetworkPkg
> - MdePkg
> - MdeModulePkg
> - IntelFsp2WrapperPkg
>
> Thank you to those that have already reviewed!
>
> Thanks,
> Joey
>
> On Thu, Jul 6, 2023 at 8:22 AM Joey Vagedes <joey.vagedes@gmail.com>
> wrote:
>
>> Hello everyone,
>>
>> Just following up on this patch series; looking for reviews from each
>> package owner. Just to reiterate, this patch series enables a new policy
>> for detecting which packages should be built for any given PR / Patch on
>> github. The policy is used when an INF is changed. It requires that any
>> package consuming that inf (generally a library instance) be built and
>> tested. I'm happy to help answer any questions!
>>
>> Thanks,
>> Joey
>>
>> On Mon, Jun 26, 2023 at 2:34 PM Joey Vagedes <joey.vagedes@gmail.com>
>> wrote:
>>
>>> Updates Edk2-pytools to the latest versions, which introduces a new
>>> Policy
>>> for detecting which packages must be built given a set of changes. This
>>> policy
>>> is used when a library class instance INF is changed. When this occurs,
>>> it will
>>> review the PrEval:DscPath provided in the CI YAML file and determine if
>>> the
>>> package uses the library instance or not. If it does, it will build and
>>> test
>>> the package.
>>>
>>> Due to these changes, each package must now include an entry in it's CI
>>> YAML
>>> file (PrEval:DscPath). If the package does not provide this entry, this
>>> policy
>>> will be skipped, which could lead to a library instance breaking
>>> packages outside
>>> of it's parent package.
>>>
>>> Cc: Abner Chang <abner.chang@amd.com>
>>> Cc: Alexei Fedorov <Alexei.Fedorov@arm.com>
>>> Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
>>> Cc: Ashraf Ali S <ashraf.ali.s@intel.com>
>>> Cc: Chasel Chiu <chasel.chiu@intel.com>
>>> Cc: Chen Gang C <gang.c.chen@intel.com>
>>> Cc: Daniel Schaefer <git@danielschaefer.me>
>>> Cc: Duggapu Chinni B <chinni.b.duggapu@intel.com>
>>> Cc: Eric Dong <eric.dong@intel.com>
>>> Cc: Gerd Hoffmann <kraxel@redhat.com>
>>> Cc: Guo Dong <guo.dong@intel.com>
>>> Cc: Guomin Jiang <guomin.jiang@intel.com>
>>> Cc: Hao A Wu <hao.a.wu@intel.com>
>>> Cc: Igor Kulchytskyy <igork@ami.com>
>>> Cc: James Lu <james.lu@intel.com>
>>> Cc: Jian J Wang <jian.j.wang@intel.com>
>>> Cc: Jiewen Yao <jiewen.yao@intel.com>
>>> Cc: Leif Lindholm <quic_llindhol@quicinc.com>
>>> Cc: Liming Gao <gaoliming@byosoft.com.cn>
>>> Cc: Maciej Rabeda <maciej.rabeda@linux.intel.com>
>>> Cc: Michael D Kinney <michael.d.kinney@intel.com>
>>> Cc: Michael Kubacki <mikuback@linux.microsoft.com>
>>> Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
>>> Cc: Nickle Wang <nicklew@nvidia.com>
>>> Cc: Pierre Gondois <pierre.gondois@arm.com>
>>> Cc: Rahul Kumar <rahul1.kumar@intel.com>
>>> Cc: Ray Han Lim Ng <ray.han.lim.ng@intel.com>
>>> Cc: Ray Ni <ray.ni@intel.com>
>>> Cc: Sami Mujawar <sami.mujawar@arm.com>
>>> Cc: Sean Brogan <sean.brogan@microsoft.com>
>>> Cc: Sean Rhodes <sean@starlabs.systems>
>>> Cc: Siyuan Fu <siyuan.fu@intel.com>
>>> Cc: Star Zeng <star.zeng@intel.com>
>>> Cc: Susovan Mohapatra <susovan.mohapatra@intel.com>
>>> Cc: Ted Kuo <ted.kuo@intel.com>
>>> Cc: Wei6 Xu <wei6.xu@intel.com>
>>> Cc: Xiaoyu Lu <xiaoyu1.lu@intel.com>
>>> Cc: Yi Li <yi1.li@intel.com>
>>> Cc: Zhichao Gao <zhichao.gao@intel.com>
>>> Cc: Zhiguang Liu <zhiguang.liu@intel.com>
>>>
>>> Joey Vagedes (24):
>>>   Edk2: edk2-pytools: Update to latest versions
>>>   UnitTestFrameworkPkg: CI: Add PrEval entry
>>>   UefiPayloadPkg: CI: Add PrEval entry
>>>   ArmPkg: CI: Add PrEval entry
>>>   UefiCpuPkg: CI: Add PrEval entry
>>>   ArmPlatformPkg: CI: Add PrEval entry
>>>   CryptoPkg: CI: Add PrEval entry
>>>   DynamicTablesPkg: CI: Add PrEval entry
>>>   EmbeddedPkg: CI: Add PrEval entry
>>>   FatPkg: CI: Add PrEval entry
>>>   FmpDevicePkg: CI: Add PrEval entry
>>>   IntelFsp2Pkg: CI: Add PrEval entry
>>>   CryptoPkg: CI: Add PrEval entry
>>>   SourceLevelDebugPkg: CI: Add PrEval entry
>>>   SignedCapsulePkg: CI: Add PrEval entry
>>>   ShellPkg: CI: Add PrEval entry
>>>   SecurityPkg: CI: Add PrEval entry
>>>   RedfishPkg: CI: Add PrEval entry
>>>   PrmPkg: CI: Add PrEval entry
>>>   PcAtChipsetPkg: CI: Add PrEval entry
>>>   NetworkPkg: CI: Add PrEval entry
>>>   MdePkg: CI: Add PrEval entry
>>>   MdeModulePkg: CI: Add PrEval entry
>>>   IntelFsp2WrapperPkg: CI: Add PrEval entry
>>>
>>>  ArmPkg/ArmPkg.ci.yaml                             | 3 +++
>>>  ArmPlatformPkg/ArmPlatformPkg.ci.yaml             | 3 +++
>>>  CryptoPkg/CryptoPkg.ci.yaml                       | 3 +++
>>>  DynamicTablesPkg/DynamicTablesPkg.ci.yaml         | 3 +++
>>>  EmbeddedPkg/EmbeddedPkg.ci.yaml                   | 3 +++
>>>  FatPkg/FatPkg.ci.yaml                             | 3 +++
>>>  FmpDevicePkg/FmpDevicePkg.ci.yaml                 | 3 +++
>>>  IntelFsp2Pkg/IntelFsp2Pkg.ci.yaml                 | 3 +++
>>>  IntelFsp2WrapperPkg/IntelFsp2WrapperPkg.ci.yaml   | 3 +++
>>>  MdeModulePkg/MdeModulePkg.ci.yaml                 | 3 +++
>>>  MdePkg/MdePkg.ci.yaml                             | 3 +++
>>>  NetworkPkg/NetworkPkg.ci.yaml                     | 3 +++
>>>  PcAtChipsetPkg/PcAtChipsetPkg.ci.yaml             | 3 +++
>>>  PrmPkg/PrmPkg.ci.yaml                             | 3 +++
>>>  RedfishPkg/RedfishPkg.ci.yaml                     | 3 +++
>>>  SecurityPkg/SecurityPkg.ci.yaml                   | 3 +++
>>>  ShellPkg/ShellPkg.ci.yaml                         | 3 +++
>>>  SignedCapsulePkg/SignedCapsulePkg.ci.yaml         | 3 +++
>>>  SourceLevelDebugPkg/SourceLevelDebugPkg.ci.yaml   | 3 +++
>>>  StandaloneMmPkg/StandaloneMmPkg.ci.yaml           | 3 +++
>>>  UefiCpuPkg/UefiCpuPkg.ci.yaml                     | 3 +++
>>>  UefiPayloadPkg/UefiPayloadPkg.ci.yaml             | 3 +++
>>>  UnitTestFrameworkPkg/UnitTestFrameworkPkg.ci.yaml | 3 +++
>>>  pip-requirements.txt                              | 4 ++--
>>>  24 files changed, 71 insertions(+), 2 deletions(-)
>>>
>>> --
>>> 2.41.0.windows.1
>>>
>>>


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#107985): https://edk2.groups.io/g/devel/message/107985
Mute This Topic: https://groups.io/mt/99798032/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-



[-- Attachment #2: Type: text/html, Size: 12425 bytes --]

Re: [edk2-devel] [PATCH v1 00/24] Update Edk2-pytools to latest versions

[Joey Vagedes via groups.io]

[-- Attachment #1: Type: text/plain, Size: 8965 bytes --]

Last call for any package maintainers that wish to opt their package into
this additional CI check, which serves to ensure your package is not broken
due to library interfaces changes in other packages. I will give this a few
more days then will work to merge only the current approvals I have on
record and close out bugzilla 4489
<https://bugzilla.tianocore.org/show_bug.cgi?id=4489>.

Below are the following packages without approvals. If package maintainers
do not opt in now, they can put up their own patch series to add this
additional check into their package at a later date.

Packages without approval / review on record:
UefiPayloadPkg
ArmPkg
UefiCpuPkg
ArmPlatformPkg
CryptoPkg
FatPkg
SourceLevelDebugPkg
SignedCapsulePkg
ShellPkg
SecurityPkgPcAtChipsetPkg
NetworkPkg

Thanks,
Joey

On Wed, Aug 23, 2023 at 10:14 AM Joey Vagedes <joey.vagedes@gmail.com>
wrote:

> Hello everyone, Almost done! Following up on this patch series. I still
> need reviews for the following packages:
>
> Please see comments above as to why this will not affect the package,
> except to ensure it is tested if another package changes a library INF your
> package uses.
>
> UefiPayloadPkg
> ArmPkg
> UefiCpuPkg
> ArmPlatformPkg
> CryptoPkg
> FatPkg
> SourceLevelDebugPkg
> SignedCapsulePkg
> ShellPkg
> SecurityPkgPcAtChipsetPkg
> NetworkPkg
>
> Thanks,
> Joey
>
>
> On Tue, Aug 1, 2023 at 9:16 AM Joey Vagedes <joey.vagedes@gmail.com>
> wrote:
>
>> Hello everyone, I'm still looking for reviews for this change. Please
>> remember this has no effect on the package itself, rather it adds
>> additional helps to ensure your package is tested when necessary. The
>> particular situation this change now catches is when a library instance
>> (INF) from outside your package changes and your package consumes that
>> library instance. When this situation occurs, your package will also be
>> built as a part of CI, ensuring other package changes don't break your
>> package in a build breaking way.
>>
>> I still need reviews from the following packages:
>> - UefiPayloadPkg
>> - ArmPkg
>> - UefiCpuPkg
>> - ArmPlatformPkg
>> - CryptoPkg
>> - FatPkg
>> - FmpDevicePkg
>> - IntelFsp2Pkg
>> - CryptoPkg
>> - SourceLevelDebugPkg
>> - SignedCapsulePkg
>> - ShellPkg
>> - SecurityPkg
>> - PcAtChipsetPkg
>> - NetworkPkg
>> - MdePkg
>> - MdeModulePkg
>> - IntelFsp2WrapperPkg
>>
>> Thank you to those that have already reviewed!
>>
>> Thanks,
>> Joey
>>
>> On Thu, Jul 6, 2023 at 8:22 AM Joey Vagedes <joey.vagedes@gmail.com>
>> wrote:
>>
>>> Hello everyone,
>>>
>>> Just following up on this patch series; looking for reviews from each
>>> package owner. Just to reiterate, this patch series enables a new policy
>>> for detecting which packages should be built for any given PR / Patch on
>>> github. The policy is used when an INF is changed. It requires that any
>>> package consuming that inf (generally a library instance) be built and
>>> tested. I'm happy to help answer any questions!
>>>
>>> Thanks,
>>> Joey
>>>
>>> On Mon, Jun 26, 2023 at 2:34 PM Joey Vagedes <joey.vagedes@gmail.com>
>>> wrote:
>>>
>>>> Updates Edk2-pytools to the latest versions, which introduces a new
>>>> Policy
>>>> for detecting which packages must be built given a set of changes. This
>>>> policy
>>>> is used when a library class instance INF is changed. When this occurs,
>>>> it will
>>>> review the PrEval:DscPath provided in the CI YAML file and determine if
>>>> the
>>>> package uses the library instance or not. If it does, it will build and
>>>> test
>>>> the package.
>>>>
>>>> Due to these changes, each package must now include an entry in it's CI
>>>> YAML
>>>> file (PrEval:DscPath). If the package does not provide this entry, this
>>>> policy
>>>> will be skipped, which could lead to a library instance breaking
>>>> packages outside
>>>> of it's parent package.
>>>>
>>>> Cc: Abner Chang <abner.chang@amd.com>
>>>> Cc: Alexei Fedorov <Alexei.Fedorov@arm.com>
>>>> Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
>>>> Cc: Ashraf Ali S <ashraf.ali.s@intel.com>
>>>> Cc: Chasel Chiu <chasel.chiu@intel.com>
>>>> Cc: Chen Gang C <gang.c.chen@intel.com>
>>>> Cc: Daniel Schaefer <git@danielschaefer.me>
>>>> Cc: Duggapu Chinni B <chinni.b.duggapu@intel.com>
>>>> Cc: Eric Dong <eric.dong@intel.com>
>>>> Cc: Gerd Hoffmann <kraxel@redhat.com>
>>>> Cc: Guo Dong <guo.dong@intel.com>
>>>> Cc: Guomin Jiang <guomin.jiang@intel.com>
>>>> Cc: Hao A Wu <hao.a.wu@intel.com>
>>>> Cc: Igor Kulchytskyy <igork@ami.com>
>>>> Cc: James Lu <james.lu@intel.com>
>>>> Cc: Jian J Wang <jian.j.wang@intel.com>
>>>> Cc: Jiewen Yao <jiewen.yao@intel.com>
>>>> Cc: Leif Lindholm <quic_llindhol@quicinc.com>
>>>> Cc: Liming Gao <gaoliming@byosoft.com.cn>
>>>> Cc: Maciej Rabeda <maciej.rabeda@linux.intel.com>
>>>> Cc: Michael D Kinney <michael.d.kinney@intel.com>
>>>> Cc: Michael Kubacki <mikuback@linux.microsoft.com>
>>>> Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
>>>> Cc: Nickle Wang <nicklew@nvidia.com>
>>>> Cc: Pierre Gondois <pierre.gondois@arm.com>
>>>> Cc: Rahul Kumar <rahul1.kumar@intel.com>
>>>> Cc: Ray Han Lim Ng <ray.han.lim.ng@intel.com>
>>>> Cc: Ray Ni <ray.ni@intel.com>
>>>> Cc: Sami Mujawar <sami.mujawar@arm.com>
>>>> Cc: Sean Brogan <sean.brogan@microsoft.com>
>>>> Cc: Sean Rhodes <sean@starlabs.systems>
>>>> Cc: Siyuan Fu <siyuan.fu@intel.com>
>>>> Cc: Star Zeng <star.zeng@intel.com>
>>>> Cc: Susovan Mohapatra <susovan.mohapatra@intel.com>
>>>> Cc: Ted Kuo <ted.kuo@intel.com>
>>>> Cc: Wei6 Xu <wei6.xu@intel.com>
>>>> Cc: Xiaoyu Lu <xiaoyu1.lu@intel.com>
>>>> Cc: Yi Li <yi1.li@intel.com>
>>>> Cc: Zhichao Gao <zhichao.gao@intel.com>
>>>> Cc: Zhiguang Liu <zhiguang.liu@intel.com>
>>>>
>>>> Joey Vagedes (24):
>>>>   Edk2: edk2-pytools: Update to latest versions
>>>>   UnitTestFrameworkPkg: CI: Add PrEval entry
>>>>   UefiPayloadPkg: CI: Add PrEval entry
>>>>   ArmPkg: CI: Add PrEval entry
>>>>   UefiCpuPkg: CI: Add PrEval entry
>>>>   ArmPlatformPkg: CI: Add PrEval entry
>>>>   CryptoPkg: CI: Add PrEval entry
>>>>   DynamicTablesPkg: CI: Add PrEval entry
>>>>   EmbeddedPkg: CI: Add PrEval entry
>>>>   FatPkg: CI: Add PrEval entry
>>>>   FmpDevicePkg: CI: Add PrEval entry
>>>>   IntelFsp2Pkg: CI: Add PrEval entry
>>>>   CryptoPkg: CI: Add PrEval entry
>>>>   SourceLevelDebugPkg: CI: Add PrEval entry
>>>>   SignedCapsulePkg: CI: Add PrEval entry
>>>>   ShellPkg: CI: Add PrEval entry
>>>>   SecurityPkg: CI: Add PrEval entry
>>>>   RedfishPkg: CI: Add PrEval entry
>>>>   PrmPkg: CI: Add PrEval entry
>>>>   PcAtChipsetPkg: CI: Add PrEval entry
>>>>   NetworkPkg: CI: Add PrEval entry
>>>>   MdePkg: CI: Add PrEval entry
>>>>   MdeModulePkg: CI: Add PrEval entry
>>>>   IntelFsp2WrapperPkg: CI: Add PrEval entry
>>>>
>>>>  ArmPkg/ArmPkg.ci.yaml                             | 3 +++
>>>>  ArmPlatformPkg/ArmPlatformPkg.ci.yaml             | 3 +++
>>>>  CryptoPkg/CryptoPkg.ci.yaml                       | 3 +++
>>>>  DynamicTablesPkg/DynamicTablesPkg.ci.yaml         | 3 +++
>>>>  EmbeddedPkg/EmbeddedPkg.ci.yaml                   | 3 +++
>>>>  FatPkg/FatPkg.ci.yaml                             | 3 +++
>>>>  FmpDevicePkg/FmpDevicePkg.ci.yaml                 | 3 +++
>>>>  IntelFsp2Pkg/IntelFsp2Pkg.ci.yaml                 | 3 +++
>>>>  IntelFsp2WrapperPkg/IntelFsp2WrapperPkg.ci.yaml   | 3 +++
>>>>  MdeModulePkg/MdeModulePkg.ci.yaml                 | 3 +++
>>>>  MdePkg/MdePkg.ci.yaml                             | 3 +++
>>>>  NetworkPkg/NetworkPkg.ci.yaml                     | 3 +++
>>>>  PcAtChipsetPkg/PcAtChipsetPkg.ci.yaml             | 3 +++
>>>>  PrmPkg/PrmPkg.ci.yaml                             | 3 +++
>>>>  RedfishPkg/RedfishPkg.ci.yaml                     | 3 +++
>>>>  SecurityPkg/SecurityPkg.ci.yaml                   | 3 +++
>>>>  ShellPkg/ShellPkg.ci.yaml                         | 3 +++
>>>>  SignedCapsulePkg/SignedCapsulePkg.ci.yaml         | 3 +++
>>>>  SourceLevelDebugPkg/SourceLevelDebugPkg.ci.yaml   | 3 +++
>>>>  StandaloneMmPkg/StandaloneMmPkg.ci.yaml           | 3 +++
>>>>  UefiCpuPkg/UefiCpuPkg.ci.yaml                     | 3 +++
>>>>  UefiPayloadPkg/UefiPayloadPkg.ci.yaml             | 3 +++
>>>>  UnitTestFrameworkPkg/UnitTestFrameworkPkg.ci.yaml | 3 +++
>>>>  pip-requirements.txt                              | 4 ++--
>>>>  24 files changed, 71 insertions(+), 2 deletions(-)
>>>>
>>>> --
>>>> 2.41.0.windows.1
>>>>
>>>>


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#109266): https://edk2.groups.io/g/devel/message/109266
Mute This Topic: https://groups.io/mt/99798032/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-



[-- Attachment #2: Type: text/html, Size: 13796 bytes --]

Re: [edk2-devel] [PATCH v1 07/24] CryptoPkg: CI: Add PrEval entry

[Li, Yi]

Joey:

I already give feedback for CryptoPkg part.

Seems there are two Crypto patch 07/24 and 13/24, but actually 13 is StandaloneMmPkg changes. Please check.
[PATCH v1 13/24] CryptoPkg: CI: Add PrEval entry 

-----Original Message-----
From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Li, Yi
Sent: Wednesday, August 2, 2023 12:42 PM
To: Joey Vagedes <joey.vagedes@gmail.com>; devel@edk2.groups.io
Cc: Yao, Jiewen <jiewen.yao@intel.com>; Lu, Xiaoyu1 <xiaoyu1.lu@intel.com>; Jiang, Guomin <guomin.jiang@intel.com>
Subject: Re: [edk2-devel] [PATCH v1 07/24] CryptoPkg: CI: Add PrEval entry


Looks good to me.
Reviewed-by: Yi Li <yi1.li@intel.com>

-----Original Message-----
From: Joey Vagedes <joey.vagedes@gmail.com> 
Sent: Tuesday, June 27, 2023 5:34 AM
To: devel@edk2.groups.io
Cc: Yao, Jiewen <jiewen.yao@intel.com>; Li, Yi1 <yi1.li@intel.com>; Lu, Xiaoyu1 <xiaoyu1.lu@intel.com>; Jiang, Guomin <guomin.jiang@intel.com>
Subject: [PATCH v1 07/24] CryptoPkg: CI: Add PrEval entry

Adds a PrEval entry to the package's ci.yaml file which is used to verify if the package uses a particular library instance when that library instance file (INF) is updated.

When a library instance file (INF) is updated, PrEval will review each package's DSC as described in the ci.yaml file to determine if the package uses said library instance. If the package does use the library instance, it will be built and tested to ensure the package is not broken from the change.

Cc: Jiewen Yao <jiewen.yao@intel.com>
Cc: Yi Li <yi1.li@intel.com>
Cc: Xiaoyu Lu <xiaoyu1.lu@intel.com>
Cc: Guomin Jiang <guomin.jiang@intel.com>
Signed-off-by: Joey Vagedes <joeyvagedes@gmail.com>
---
 CryptoPkg/CryptoPkg.ci.yaml | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/CryptoPkg/CryptoPkg.ci.yaml b/CryptoPkg/CryptoPkg.ci.yaml index 47f29759676d..4cec206477bc 100644
--- a/CryptoPkg/CryptoPkg.ci.yaml
+++ b/CryptoPkg/CryptoPkg.ci.yaml
@@ -6,6 +6,9 @@
 # SPDX-License-Identifier: BSD-2-Clause-Patent ## {+    "PrEval": {+        "DscPath": "CryptoPkg.dsc",+    },     "LicenseCheck": {         "IgnoreFiles": [             # These directories contain auto-generated OpenSSL content-- 
2.41.0.windows.1








-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#109377): https://edk2.groups.io/g/devel/message/109377
Mute This Topic: https://groups.io/mt/99798040/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH v1 07/24] CryptoPkg: CI: Add PrEval entry

[Joey Vagedes via groups.io]

[-- Attachment #1: Type: text/plain, Size: 2864 bytes --]

Thank you for catching this! I will correct it.

Thanks,
Joey

On Fri, Oct 6, 2023 at 8:07 PM Li, Yi1 <yi1.li@intel.com> wrote:

> Joey:
>
> I already give feedback for CryptoPkg part.
>
> Seems there are two Crypto patch 07/24 and 13/24, but actually 13 is
> StandaloneMmPkg changes. Please check.
> [PATCH v1 13/24] CryptoPkg: CI: Add PrEval entry
>
> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Li, Yi
> Sent: Wednesday, August 2, 2023 12:42 PM
> To: Joey Vagedes <joey.vagedes@gmail.com>; devel@edk2.groups.io
> Cc: Yao, Jiewen <jiewen.yao@intel.com>; Lu, Xiaoyu1 <xiaoyu1.lu@intel.com>;
> Jiang, Guomin <guomin.jiang@intel.com>
> Subject: Re: [edk2-devel] [PATCH v1 07/24] CryptoPkg: CI: Add PrEval entry
>
>
> Looks good to me.
> Reviewed-by: Yi Li <yi1.li@intel.com>
>
> -----Original Message-----
> From: Joey Vagedes <joey.vagedes@gmail.com>
> Sent: Tuesday, June 27, 2023 5:34 AM
> To: devel@edk2.groups.io
> Cc: Yao, Jiewen <jiewen.yao@intel.com>; Li, Yi1 <yi1.li@intel.com>; Lu,
> Xiaoyu1 <xiaoyu1.lu@intel.com>; Jiang, Guomin <guomin.jiang@intel.com>
> Subject: [PATCH v1 07/24] CryptoPkg: CI: Add PrEval entry
>
> Adds a PrEval entry to the package's ci.yaml file which is used to verify
> if the package uses a particular library instance when that library
> instance file (INF) is updated.
>
> When a library instance file (INF) is updated, PrEval will review each
> package's DSC as described in the ci.yaml file to determine if the package
> uses said library instance. If the package does use the library instance,
> it will be built and tested to ensure the package is not broken from the
> change.
>
> Cc: Jiewen Yao <jiewen.yao@intel.com>
> Cc: Yi Li <yi1.li@intel.com>
> Cc: Xiaoyu Lu <xiaoyu1.lu@intel.com>
> Cc: Guomin Jiang <guomin.jiang@intel.com>
> Signed-off-by: Joey Vagedes <joeyvagedes@gmail.com>
> ---
>  CryptoPkg/CryptoPkg.ci.yaml | 3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/CryptoPkg/CryptoPkg.ci.yaml b/CryptoPkg/CryptoPkg.ci.yaml
> index 47f29759676d..4cec206477bc 100644
> --- a/CryptoPkg/CryptoPkg.ci.yaml
> +++ b/CryptoPkg/CryptoPkg.ci.yaml
> @@ -6,6 +6,9 @@
>  # SPDX-License-Identifier: BSD-2-Clause-Patent ## {+    "PrEval": {+
>   "DscPath": "CryptoPkg.dsc",+    },     "LicenseCheck": {
>  "IgnoreFiles": [             # These directories contain auto-generated
> OpenSSL content--
> 2.41.0.windows.1
>
>
>
> 
>
>
>


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#109462): https://edk2.groups.io/g/devel/message/109462
Mute This Topic: https://groups.io/mt/99798040/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-



[-- Attachment #2: Type: text/html, Size: 4948 bytes --]

Re: [edk2-devel] [PATCH v1 13/24] StandaloneMmPkg: CI: Add PrEval entry

[Joey Vagedes via groups.io]

[-- Attachment #1: Type: text/plain, Size: 2543 bytes --]

Hello All,

Due to a Subject Line mistake, this particular patch was labeled as a
CryptoPkg change. I'm resending this out to the package maintainers with
the correct package (StandaloneMmPkg).

Please review this change to your package's ci.yaml file ~ This change will
ensure your package is properly tested if another package changes an INF
that your package depends on to build, making sure it is not broken from
another's change. If you wish for this to be merged into your package,
please review.

If not, I will be re-sending this patch series out with only the package's
I have reviews on, to get it merged so that we can update edk2-pytools
further. You will always be able to add this yourself at a later date if
you wish.

Thanks,
Joey


On Mon, Jun 26, 2023 at 2:35 PM Joey Vagedes <joey.vagedes@gmail.com> wrote:

> Adds a PrEval entry to the package's ci.yaml file which is used to
> verify if the package uses a particular library instance when that
> library instance file (INF) is updated.
>
> When a library instance file (INF) is updated, PrEval will review each
> package's DSC as described in the ci.yaml file to determine if the
> package uses said library instance. If the package does use the library
> instance, it will be built and tested to ensure the package is not
> broken from the change.
>
> Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
> Cc: Sami Mujawar <sami.mujawar@arm.com>
> Cc: Ray Ni <ray.ni@intel.com>
> Signed-off-by: Joey Vagedes <joeyvagedes@gmail.com>
> ---
>  StandaloneMmPkg/StandaloneMmPkg.ci.yaml | 3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/StandaloneMmPkg/StandaloneMmPkg.ci.yaml
> b/StandaloneMmPkg/StandaloneMmPkg.ci.yaml
> index 4777532a7ede..f23f5f2c4db2 100644
> --- a/StandaloneMmPkg/StandaloneMmPkg.ci.yaml
> +++ b/StandaloneMmPkg/StandaloneMmPkg.ci.yaml
> @@ -5,6 +5,9 @@
>  #  SPDX-License-Identifier: BSD-2-Clause-Patent
>  ##
>  {
> +    "PrEval": {
> +        "DscPath": "StandaloneMmPkg.dsc",
> +    },
>      "EccCheck": {
>          ## Exception sample looks like below:
>          ## "ExceptionList": [
> --
> 2.41.0.windows.1
>
>


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#109463): https://edk2.groups.io/g/devel/message/109463
Mute This Topic: https://groups.io/mt/101856788/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-



[-- Attachment #2: Type: text/html, Size: 3775 bytes --]

Re: [edk2-devel] [PATCH v1 13/24] StandaloneMmPkg: CI: Add PrEval entry

[Ard Biesheuvel]

On Mon, 9 Oct 2023 at 18:49, Joey Vagedes <joey.vagedes@gmail.com> wrote:
>
> Hello All,
>
> Due to a Subject Line mistake, this particular patch was labeled as a CryptoPkg change. I'm resending this out to the package maintainers with the correct package (StandaloneMmPkg).
>
> Please review this change to your package's ci.yaml file ~ This change will ensure your package is properly tested if another package changes an INF that your package depends on to build, making sure it is not broken from another's change. If you wish for this to be merged into your package, please review.
>
> If not, I will be re-sending this patch series out with only the package's I have reviews on, to get it merged so that we can update edk2-pytools further. You will always be able to add this yourself at a later date if you wish.
>
> Thanks,
> Joey
>
>
> On Mon, Jun 26, 2023 at 2:35 PM Joey Vagedes <joey.vagedes@gmail.com> wrote:
>>
>> Adds a PrEval entry to the package's ci.yaml file which is used to
>> verify if the package uses a particular library instance when that
>> library instance file (INF) is updated.
>>
>> When a library instance file (INF) is updated, PrEval will review each
>> package's DSC as described in the ci.yaml file to determine if the
>> package uses said library instance. If the package does use the library
>> instance, it will be built and tested to ensure the package is not
>> broken from the change.
>>
>> Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
>> Cc: Sami Mujawar <sami.mujawar@arm.com>
>> Cc: Ray Ni <ray.ni@intel.com>
>> Signed-off-by: Joey Vagedes <joeyvagedes@gmail.com>
>> ---
>>  StandaloneMmPkg/StandaloneMmPkg.ci.yaml | 3 +++
>>  1 file changed, 3 insertions(+)
>>

Fine with me

Acked-by: Ard Biesheuvel <ardb@kernel.org>

>> diff --git a/StandaloneMmPkg/StandaloneMmPkg.ci.yaml b/StandaloneMmPkg/StandaloneMmPkg.ci.yaml
>> index 4777532a7ede..f23f5f2c4db2 100644
>> --- a/StandaloneMmPkg/StandaloneMmPkg.ci.yaml
>> +++ b/StandaloneMmPkg/StandaloneMmPkg.ci.yaml
>> @@ -5,6 +5,9 @@
>>  #  SPDX-License-Identifier: BSD-2-Clause-Patent
>>  ##
>>  {
>> +    "PrEval": {
>> +        "DscPath": "StandaloneMmPkg.dsc",
>> +    },
>>      "EccCheck": {
>>          ## Exception sample looks like below:
>>          ## "ExceptionList": [
>> --
>> 2.41.0.windows.1
>>


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#109476): https://edk2.groups.io/g/devel/message/109476
Mute This Topic: https://groups.io/mt/101856788/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-