From: "Yuwei Chen" <yuwei.chen@intel.com>
To: devel@edk2.groups.io
Cc: Rebecca Cran <rebecca@bsdio.com>,
Liming Gao <gaoliming@byosoft.com.cn>,
Bob Feng <bob.c.feng@intel.com>
Subject: [Patch V3] [edk2-staging] BaseTools/FMMT: C FMMT match new version machine defines
Date: Tue, 27 Jun 2023 10:53:30 +0800 [thread overview]
Message-ID: <20230627025330.1579-1-yuwei.chen@intel.com> (raw)
BaseTools have switch from EFI_IMAGE_MACHINE_*
to IMAGE_FILE_MACHINE_*. Thus, match the FCE & FMMT
tool in edk2-staging repo with the new version define.
Cc: Rebecca Cran <rebecca@bsdio.com>
Cc: Liming Gao <gaoliming@byosoft.com.cn>
Cc: Bob Feng <bob.c.feng@intel.com>
Signed-off-by: Yuwei Chen <yuwei.chen@intel.com>
---
V3 modify the patch with the correct define
BaseTools/Source/C/FMMT/Rebase.c | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/BaseTools/Source/C/FMMT/Rebase.c b/BaseTools/Source/C/FMMT/Rebase.c
index d32217d18c..20f8e5a3fc 100644
--- a/BaseTools/Source/C/FMMT/Rebase.c
+++ b/BaseTools/Source/C/FMMT/Rebase.c
@@ -159,8 +159,8 @@ EFI_NOT_FOUND No compressed sections could be found.
return Status;
}
- //if ((ImageContext.Machine == EFI_IMAGE_MACHINE_ARMT) ||
- // (ImageContext.Machine == EFI_IMAGE_MACHINE_AARCH64)) {
+ //if ((ImageContext.Machine == IMAGE_FILE_MACHINE_ARMTHUMB_MIXED) ||
+ // (ImageContext.Machine == IMAGE_FILE_MACHINE_ARM64)) {
// mArm = TRUE;
//}
@@ -435,8 +435,8 @@ EFI_NOT_FOUND No compressed sections could be found.
return Status;
}
- //if ((ImageContext.Machine == EFI_IMAGE_MACHINE_ARMT) ||
- // (ImageContext.Machine == EFI_IMAGE_MACHINE_AARCH64)) {
+ //if ((ImageContext.Machine == IMAGE_FILE_MACHINE_ARMTHUMB_MIXED) ||
+ // (ImageContext.Machine == IMAGE_FILE_MACHINE_ARM64)) {
// mArm = TRUE;
//}
@@ -835,8 +835,8 @@ Returns:
//
// Verify machine type is supported
//
- if ((*MachineType != EFI_IMAGE_MACHINE_IA32) && (*MachineType != EFI_IMAGE_MACHINE_X64) && (*MachineType != EFI_IMAGE_MACHINE_EBC) &&
- (*MachineType != EFI_IMAGE_MACHINE_ARMT) && (*MachineType != EFI_IMAGE_MACHINE_AARCH64)) {
+ if ((*MachineType != IMAGE_FILE_MACHINE_I386) && (*MachineType != IMAGE_FILE_MACHINE_X64) && (*MachineType != IMAGE_FILE_MACHINE_EBC) &&
+ (*MachineType != IMAGE_FILE_MACHINE_ARMTHUMB_MIXED) && (*MachineType != IMAGE_FILE_MACHINE_ARM64)) {
Error (NULL, 0, 3000, "Invalid", "Unrecognized machine type in the PE32 file.");
return EFI_UNSUPPORTED;
}
--
2.27.0.windows.1
next reply other threads:[~2023-06-27 2:53 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-27 2:53 Yuwei Chen [this message]
2023-06-27 6:14 ` 回复: [Patch V3] [edk2-staging] BaseTools/FMMT: C FMMT match new version machine defines gaoliming
2023-07-04 7:51 ` Yuwei Chen
2023-07-10 1:51 ` 回复: [edk2-devel] " gaoliming
2023-07-10 1:59 ` Yuwei Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230627025330.1579-1-yuwei.chen@intel.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox