* [PATCH] OvmfPkg/VirtioSerialDxe: Remove noisy debug print on supported() call
@ 2023-06-27 11:17 Ard Biesheuvel
2023-06-27 13:27 ` Gerd Hoffmann
0 siblings, 1 reply; 2+ messages in thread
From: Ard Biesheuvel @ 2023-06-27 11:17 UTC (permalink / raw)
To: devel; +Cc: kraxel, Ard Biesheuvel
The UEFI driver model invokes the supported() method on every driver
every time a connection attempt is made on any handle, and so doing an
unconditional DEBUG() print inside this method produced a lot of noise.
So let's drop this DEBUG() call from the VirtioSerial driver's
Supported() method.
Signed-off-by: Ard Biesheuvel <ardb@kernel.org>
---
OvmfPkg/VirtioSerialDxe/VirtioSerial.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/OvmfPkg/VirtioSerialDxe/VirtioSerial.c b/OvmfPkg/VirtioSerialDxe/VirtioSerial.c
index df545c080e9d9212..fd34ad75a9a079ce 100644
--- a/OvmfPkg/VirtioSerialDxe/VirtioSerial.c
+++ b/OvmfPkg/VirtioSerialDxe/VirtioSerial.c
@@ -510,8 +510,6 @@ VirtioSerialDriverBindingSupported (
Status = EFI_UNSUPPORTED;
}
- DEBUG ((DEBUG_INFO, "%a:%d: subsystem %d -> %r\n", __func__, __LINE__, VirtIo->SubSystemDeviceId, Status));
-
//
// We needed VirtIo access only transitorily, to see whether we support the
// device or not.
--
2.39.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] OvmfPkg/VirtioSerialDxe: Remove noisy debug print on supported() call
2023-06-27 11:17 [PATCH] OvmfPkg/VirtioSerialDxe: Remove noisy debug print on supported() call Ard Biesheuvel
@ 2023-06-27 13:27 ` Gerd Hoffmann
0 siblings, 0 replies; 2+ messages in thread
From: Gerd Hoffmann @ 2023-06-27 13:27 UTC (permalink / raw)
To: Ard Biesheuvel; +Cc: devel
On Tue, Jun 27, 2023 at 01:17:16PM +0200, Ard Biesheuvel wrote:
> The UEFI driver model invokes the supported() method on every driver
> every time a connection attempt is made on any handle, and so doing an
> unconditional DEBUG() print inside this method produced a lot of noise.
>
> So let's drop this DEBUG() call from the VirtioSerial driver's
> Supported() method.
>
> Signed-off-by: Ard Biesheuvel <ardb@kernel.org>
Acked-by: Gerd Hoffmann <kraxel@redhat.com>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-06-27 13:27 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-06-27 11:17 [PATCH] OvmfPkg/VirtioSerialDxe: Remove noisy debug print on supported() call Ard Biesheuvel
2023-06-27 13:27 ` Gerd Hoffmann
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox