From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (NAM10-BN7-obe.outbound.protection.outlook.com [40.107.92.70]) by mx.groups.io with SMTP id smtpd.web11.32235.1688390432397035967 for ; Mon, 03 Jul 2023 06:20:32 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="body hash did not verify" header.i=@nvidia.com header.s=selector2 header.b=aCnOBaJF; spf=permerror, err=parse error for token &{10 18 %{i}._ip.%{h}._ehlo.%{d}._spf.vali.email}: invalid domain name (domain: nvidia.com, ip: 40.107.92.70, mailfrom: nicklew@nvidia.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Sg1q6zG7nZQAsKfHLC2/S7rVOLVsLd3NiaUfEC4u1/n+jdfMyqS4SWEdGEqmqwwVgspN2m3kba1SNtYNiv0XHBgBu7b47kWfOHyRL/XxwZtxxpiWFpRDSY5hhnOI06v2mFjxTWwBgNErPcficJ/bKd5womUPHejvsFqqPmOIRA43qGHzpmsdbDws3M7pGkUg2DP6S7hB6OunxWNPe6Db8pfJBwcrBfaDJtZjj+gJpz1sWpROcd1tjvvQc2cMvEOE81Ag5YGw67Z9iHTOvHJPWHsYNP7qgdGYhKmSH4IUEQa0KvPe0NeiFqlKHgq17ZwNfMiwJnrydmFl6jo4yd8j7w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=UNwAgK1PerUYt3LYa8B5IwtxJMeKG1O6agbXHq8Zdhk=; b=i2THsXQ99jGj+EuvkKBrPM85rdAjTgyyA+T/Mg2J5x2NPyiil4Itk1oIVlWhES7tcHKpHsYuVeG/jiWQPY69uxmrerfW61mCtflFcWaP1tH0qHPdpQvia4nKxNxVp8cn/sMX+RjQyz46aNI8nqvsQzecvidI+YmVrmfKSpVsc1N+RO9nRCC7YvYWLX33S07TpfTeKJ97/K0K/8U6ctAFlawZXSQZUOQ4cBad8/s41RqTrZQHFo256Ga6Gr/4MSYzhMzsd8bvMEZJUH8luh3qP5vkx3BKNhK/X7fPYirr8L5qpVGpr22VtAFjqd3jPEU/AbQrDNPVlYWseHAcE4E/yQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.161) smtp.rcpttodomain=edk2.groups.io smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=UNwAgK1PerUYt3LYa8B5IwtxJMeKG1O6agbXHq8Zdhk=; b=aCnOBaJFSzAUWsV6knJxqJWkMzemnHDWEpyV1/tpFMtt8tjNsYWkdytuNSsYBXTvyXl/E1lHQrnCUYIjRam092BX0P0GBvIEZohC6k3NnK4d1jjC4SCwMH3CVa/JgNV8dWab3ATn2haShEH40KkScroiRGz5SJzGU2pWHo+82BKWBJWvxBHvVYv0SoYCp13mCTBW3Z2MXa4xL0VEDSlVZO0TP4yKlgjM38pSaxfqCzGifCpNTRzKNfjiGgjwPM3GE7667LgoTjxVa69QYlvuzJINw7s9PUTMkrV6t8n95FlqhfthBa8e3vaCjUYWTSpexSgtd+rBCAKi3eoBcrYfLA== Received: from MW4PR03CA0064.namprd03.prod.outlook.com (2603:10b6:303:b6::9) by LV3PR12MB9439.namprd12.prod.outlook.com (2603:10b6:408:20e::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6565.8; Mon, 3 Jul 2023 13:20:30 +0000 Received: from CO1NAM11FT008.eop-nam11.prod.protection.outlook.com (2603:10b6:303:b6:cafe::b9) by MW4PR03CA0064.outlook.office365.com (2603:10b6:303:b6::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6544.30 via Frontend Transport; Mon, 3 Jul 2023 13:20:29 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.161) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.161 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.161; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.161) by CO1NAM11FT008.mail.protection.outlook.com (10.13.175.191) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6521.44 via Frontend Transport; Mon, 3 Jul 2023 13:20:29 +0000 Received: from rnnvmail202.nvidia.com (10.129.68.7) by mail.nvidia.com (10.129.200.67) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.5; Mon, 3 Jul 2023 06:20:18 -0700 Received: from rnnvmail203.nvidia.com (10.129.68.9) by rnnvmail202.nvidia.com (10.129.68.7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.37; Mon, 3 Jul 2023 06:20:18 -0700 Received: from NV-CL38DL3.nvidia.com (10.127.8.14) by mail.nvidia.com (10.129.68.9) with Microsoft SMTP Server id 15.2.986.37 via Frontend Transport; Mon, 3 Jul 2023 06:20:17 -0700 From: "Nickle Wang" To: CC: Abner Chang , Igor Kulchytskyy , "Nick Ramirez" Subject: [PATCH 1/3] RedfishPkg/RedfishRestExDxe: fix CPU exception in RedfishRestExDxe Date: Mon, 3 Jul 2023 21:20:16 +0800 Message-ID: <20230703132016.7097-1-nicklew@nvidia.com> X-Mailer: git-send-email 2.17.1 MIME-Version: 1.0 Return-Path: nicklew@nvidia.com X-NV-OnPremToCloud: ExternallySecured X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CO1NAM11FT008:EE_|LV3PR12MB9439:EE_ X-MS-Office365-Filtering-Correlation-Id: ac9dffb0-d7ab-4e5f-7c77-08db7bc845ca X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Lrxy1Ii6ns+qPym2fo9QjI/pAv/M1PiR2b7As2dHICMYeUQuK9ZxmzPzqaH/566TxitM9BieFXXqjcIVoKADR8wkG52y5OKucCrKYNhTMjchCVKdZOclgCntzREZKA5M8J4yNt9vpD5d+Rj576daXV0rP6Z9z05YPBkLKANaZj1Nhm9jJPNL45UEBduZ/DKlZZrpRJUgqHZwrvGxc4mSQ2UoTv2QFPEDLNLutRp8h5W69GVktFkdHiufWTFiSvjzMY62RJwif0ytOZDBnt3a/09c/UJFFORNcwQybHqCXFJYucq9D8Um1YZusewWdedKAWn1aOlsaWcW1uEB5Mcrw18GfuIl8tWBNRduIw2N0WQ2PHjf9QWVe+4VL7r37sTuRmIACvGwiEwx34Vq6wubMkEsZ19DvModwTIDbIoMq+Y49KLij7HnZKj/0/PZupJAzCnZgm3YGXerb9wZH9VaoiUNUzljoEKYNwb9XhGyRobvfyK7n4qW4wEw8XviC8ZFvl8WOVgjNEJ6ZRgCn7ni2/x6GxwXKywBcM9gDq4YCTGSkgEgGCGi6wHqCtWZI163RokSPusxJN5Ji5agTZTi980vP2xdl4GLSgncqE0T1C//s6Ng+E2ezdJJZt+QChsjOOhnOiKUrKMPpV0d02Zqht8iE1J7EG4eHEngGDAOmVZXRaQcXeSmpy7FM4bBS5eIe2HDJqlgQG0HcjeZAXTpQRutjWVtWh5Ymhg+QRphhmhNEIbwgn/e9BZAmTu3vW10 X-Forefront-Antispam-Report: CIP:216.228.117.161;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:mail.nvidia.com;PTR:dc6edge2.nvidia.com;CAT:NONE;SFS:(13230028)(6029001)(4636009)(136003)(396003)(346002)(39860400002)(376002)(451199021)(46966006)(36840700001)(40470700004)(6916009)(4326008)(70206006)(316002)(2906002)(478600001)(36756003)(70586007)(8936002)(8676002)(5660300002)(40460700003)(336012)(41300700001)(40480700001)(36860700001)(54906003)(86362001)(82310400005)(7696005)(1076003)(26005)(186003)(47076005)(426003)(82740400003)(7636003)(2616005)(83380400001)(107886003)(356005);DIR:OUT;SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Jul 2023 13:20:29.6068 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: ac9dffb0-d7ab-4e5f-7c77-08db7bc845ca X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a;Ip=[216.228.117.161];Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: CO1NAM11FT008.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: LV3PR12MB9439 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain RedfishRestExDxe driver failed to uninstall service binding protocol when driver binding stop is called. Application drivers may still use RedfishRestExDxe after it is disconnected in system. Signed-off-by: Nickle Wang Cc: Abner Chang Cc: Igor Kulchytskyy Cc: Nick Ramirez --- RedfishPkg/RedfishRestExDxe/RedfishRestExDriver.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/RedfishPkg/RedfishRestExDxe/RedfishRestExDriver.c b/RedfishPkg= /RedfishRestExDxe/RedfishRestExDriver.c index ad65ae213ae0..7036aed42683 100644 --- a/RedfishPkg/RedfishRestExDxe/RedfishRestExDriver.c +++ b/RedfishPkg/RedfishRestExDxe/RedfishRestExDriver.c @@ -3,6 +3,7 @@ =20 Copyright (c) 2019, Intel Corporation. All rights reserved.
(C) Copyright 2020 Hewlett Packard Enterprise Development LP
+ Copyright (c) 2023, NVIDIA CORPORATION & AFFILIATES. All rights reserved= . =20 SPDX-License-Identifier: BSD-2-Clause-Patent =20 @@ -57,6 +58,7 @@ RestExDestroyChildEntryInHandleBuffer ( ChildHandleBuffer =3D ((RESTEX_DESTROY_CHILD_IN_HANDLE_BUF_CONTEXT *)Con= text)->ChildHandleBuffer; =20 if (!NetIsInHandleBuffer (Instance->ChildHandle, NumberOfChildren, Child= HandleBuffer)) { + RemoveEntryList (&Instance->Link); return EFI_SUCCESS; } =20 @@ -563,7 +565,7 @@ RedfishRestExDriverBindingStop ( ); } =20 - if ((NumberOfChildren =3D=3D 0) && IsListEmpty (&RestExSb->RestExChildre= nList)) { + if (IsListEmpty (&RestExSb->RestExChildrenList)) { gBS->UninstallProtocolInterface ( NicHandle, &gEfiRestExServiceBindingProtocolGuid, --=20 2.17.1